Skip to content

Finish Homepage - #41

Merged
na933950 merged 3 commits into
mainfrom
vi-homepage
Aug 28, 2024
Merged

Finish Homepage#41
na933950 merged 3 commits into
mainfrom
vi-homepage

Conversation

@ViWilde

@ViWildeViWilde commented Aug 27, 2024

Copy link
Copy Markdown
Collaborator

Issue Number

Closes#15.

Type of Change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Details

  • Added recruitment timeline, "our community" slider, and past clients/alumni bragging components.
  • Edited the navbar, commented out the buttons for "Research" and "External Events" since those pages don't yet exist, and made the Editorials button just link directly to our Medium.
  • Added a Join Us page (holdover from previous PR)

Screenshots

2024-08-24_17-14_1
A shot of the (slightly excessively zoomed-out) Join Us page

2024-08-27_10-58
Home page

Update: With images (the row does scroll to show all images)
2024-08-27_13-39

How Has This Been Tested?

Eyeballing it

Checklist

  • Code is formatted in line with the style guidelines
  • Every function has a JSDoc that is up-to-date with my changes
  • I have added tests for the new behaviour, and they pass

Questions

@ViWilde
ViWilde requested a review from na933950August 27, 2024 18:04
@ViWilde
ViWilde requested review from milja14 and niyosasAugust 27, 2024 20:42

@na933950na933950 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for quick dev

@na933950
na933950 merged commit 221f0e8 into mainAug 28, 2024
@na933950
na933950 deleted the vi-homepage branch August 28, 2024 01:39
@ViWildeViWilde mentioned this pull request Aug 28, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Develop Homepage

2 participants

@ViWilde@na933950