Skip to content

95 Added devision by height resolution in Raman extinction error calculations#95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HavardStridBuholdt wants to merge 1 commit into
base:main
Choose a base branch
from
Open

95 Added devision by height resolution in Raman extinction error calculations #95

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions ppcpy/retrievals/raman.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -328,6 +328,7 @@ def raman_ext(
- 2021-05-31: First edition by Zhenping
- 2025-01-05: AI supported translation
- 2026-02-04: Cleaned by Buholdt
- 2026-08-25: Added devision by height resolution in error calculations

.. TODO::
- moving_smooth_varied_win function is not yet implemented.
Expand DownExpand Up@@ -371,11 +372,11 @@ def raman_ext(
ratio_MC = np.log(temp_MC)

if method == 'movingslope' or method == 'moving':
deriv_ratio_MC = movingslope_variedWin(ratio_MC, window_size)
# TODO divide by
deriv_ratio_MC = movingslope_variedWin(ratio_MC, window_size) / \
np.concatenate([[height[1] - height[0]], np.diff(height)])
elif method == 'smoothing' or method == 'smooth':
deriv_ratio_MC = moving_smooth_varied_win(ratio_MC, window_size)
# TODO divide by
deriv_ratio_MC = moving_smooth_varied_win(ratio_MC, window_size) / \
np.concatenate([[height[1] - height[0]], np.diff(height)])
elif method == 'chi2':
deriv_ratio_MC = moving_linfit_varied_win(height, ratio_MC, window_size)

Expand Down