Fix: normalize Windows path spellings before plan-file containment check - #228

Open
houhou8 wants to merge 1 commit into
PolyArch:mainfrom
houhou8:fix/windows-msys-path-normalization
Open

Fix: normalize Windows path spellings before plan-file containment check#228
houhou8 wants to merge 1 commit into
PolyArch:mainfrom
houhou8:fix/windows-msys-path-normalization

Conversation

@houhou8

@houhou8houhou8 commented Jul 15, 2026

Copy link
Copy Markdown

Problem

On MSYS/MinGW/Cygwin, the same directory can have multiple textual representations, and the two sides of the plan-file containment check may come from sources that use different forms:

git rev-parse --show-toplevel -> C:/Users/name/project
CLAUDE_PROJECT_DIR from Claude Code -> C:\Users\name\project
bash cd ... && pwd -> /c/Users/name/project

setup-rlcr-loop.sh compares these paths as strings. When the project root and plan path use different representations, affected Windows Git Bash users hit a hard failure at loop start even though the plan file is inside the project:

Error: Plan file must be within project directory

The existing canonicalization does not solve this mismatch because MSYS realpath preserves whichever path representation it is given rather than folding drive-letter and MSYS forms together.

Fix

Add to_posix_path() to hooks/lib/project-root.sh.

The helper converts drive-letter and backslash paths to the MSYS/Cygwin POSIX form using cygpath -u, with a pure-Bash fallback for Windows shells where cygpath is unavailable.

Apply it consistently to:

  • CLAUDE_PROJECT_DIR
  • the output of git rev-parse --show-toplevel
  • the resolved plan path

This ensures that every path involved in the containment comparison uses the same representation. Arbitrary drive letters are supported, and paths containing spaces are preserved.

The helper is a no-op outside Windows environments, so a valid POSIX filename containing a backslash is not rewritten.

Also restrict the python3 fallback in canonicalize_path() and canonicalize_path_prefix() to non-Windows shells. A native Windows Python interpreter can interpret an MSYS path such as /c/x as a different drive-relative path:

/c/x -> C:\c\x

This silently produces an incorrect path. MSYS environments provide realpath, so disabling this fallback on Windows does not remove required functionality.

Testing

Add tests/test-path-normalization.sh covering:

  • drive-letter and MSYS representations of the same directory
  • backslash paths
  • arbitrary drive letters
  • project paths containing spaces
  • non-Windows no-op behavior
  • rejection of a plan genuinely outside the project
  • rejection of prefix-sibling paths such as project-evil

End-to-end verification confirms that the fixed branch starts the RLCR loop successfully without manually exporting CLAUDE_PROJECT_DIR, while the current main branch fails with the incorrect containment error.

@houhou8
Normalize Windows path spellings before containment checks
15fa348
On MSYS/MinGW/Cygwin one directory has two textual spellings, and the two
sides of the plan-file containment check came from sources that disagree:
git rev-parse --show-toplevel -> C:/Users/name/project
CLAUDE_PROJECT_DIR (from Claude Code) -> C:\Users\name\project
bash cd .. && pwd -> /c/Users/name/project
setup-rlcr-loop.sh compares these as strings, so the check never matched and
every Windows Git Bash user hit a hard failure at loop start:
Error: Plan file must be within project directory
Canonicalization did not help: MSYS realpath preserves whichever spelling it
is handed rather than folding the two together.
Add to_posix_path() in hooks/lib/project-root.sh, which folds drive-letter
and backslash spellings to the POSIX form via cygpath, with a pure-bash
fallback for Windows shells lacking it. Apply it to CLAUDE_PROJECT_DIR, to
the git toplevel output, and to the resolved plan path, so every path
crossing a comparison speaks one dialect. Any drive letter is supported and
paths containing spaces are preserved.
The helper is a no-op off Windows, guarded by a shell check, so a POSIX
filename legitimately containing a backslash is not rewritten.
Also gate the python3 fallback in canonicalize_path/canonicalize_path_prefix
to non-Windows shells. A native Windows interpreter reads /c/x as
drive-relative and answers C:\c\x -- a different directory -- so on Windows
it silently produced a wrong path. MSYS always ships realpath, so nothing is
lost.
Add tests/test-path-normalization.sh covering both spellings of one
directory, arbitrary drive letters, spaces, POSIX no-op behavior, and that a
plan genuinely outside the project (including a prefix-sibling directory) is
still rejected.
chatgpt-codex-connector[bot]
chatgpt-codex-connectorBot reviewed Jul 15, 2026
View reviewed changes

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:15fa348aff

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadhooks/lib/project-root.sh
# exports CLAUDE_PROJECT_DIR as `F:\Project\Public`, and git prints
# `F:/Project/Public`. Normalize before canonicalizing so the result is
# comparable with paths built from `pwd`.
root="$(to_posix_path "$root")"

@chatgpt-codex-connectorchatgpt-codex-connectorBotJul 15, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Normalize remaining realpath comparisons too

On MSYS/MinGW this switches PROJECT_ROOT to /c/..., but the methodology-analysis read guard still compares raw realpath "$FILE_PATH" against raw realpath "$PROJECT_ROOT"/$PROJECT_ROOT in hooks/loop-read-validator.sh lines 91 and 154-158. When Claude supplies a drive-letter path such as C:/repo/src/x during methodology analysis, MSYS realpath preserves that spelling while PROJECT_ROOT is now /c/repo, so neither prefix check matches and project files are allowed to be read despite that phase's project-read block. Please run those remaining realpath outputs through the same normalization before comparing.

Useful? React with 👍 / 👎.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chatgpt-codex-connectorchatgpt-codex-connector[bot]chatgpt-codex-connector[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@houhou8
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Fix: normalize Windows path spellings before plan-file containment check - #228
Open
houhou8 wants to merge 1 commit into
PolyArch:mainfrom 
houhou8:fix/windows-msys-path-normalization
Open
Fix: normalize Windows path spellings before plan-file containment check#228
houhou8 wants to merge 1 commit into
PolyArch:mainfrom 
houhou8:fix/windows-msys-path-normalization
Conversation
@houhou8
@houhou8houhou8
commented
Jul 15, 2026

Copy link


Copy Markdown

Problem
On MSYS/MinGW/Cygwin, the same directory can have multiple textual representations, and the two sides of the plan-file containment check may come from sources that use different forms:
git rev-parse --show-toplevel -> C:/Users/name/project
CLAUDE_PROJECT_DIR from Claude Code -> C:\Users\name\project
bash cd ... && pwd -> /c/Users/name/project

setup-rlcr-loop.sh compares these paths as strings. When the project root and plan path use different representations, affected Windows Git Bash users hit a hard failure at loop start even though the plan file is inside the project:
Error: Plan file must be within project directory

The existing canonicalization does not solve this mismatch because MSYS realpath preserves whichever path representation it is given rather than folding drive-letter and MSYS forms together.
Fix
Add to_posix_path() to hooks/lib/project-root.sh.
The helper converts drive-letter and backslash paths to the MSYS/Cygwin POSIX form using cygpath -u, with a pure-Bash fallback for Windows shells where cygpath is unavailable.
Apply it consistently to:
  • CLAUDE_PROJECT_DIR
  • the output of git rev-parse --show-toplevel
  • the resolved plan path
This ensures that every path involved in the containment comparison uses the same representation. Arbitrary drive letters are supported, and paths containing spaces are preserved.
The helper is a no-op outside Windows environments, so a valid POSIX filename containing a backslash is not rewritten.
Also restrict the python3 fallback in canonicalize_path() and canonicalize_path_prefix() to non-Windows shells. A native Windows Python interpreter can interpret an MSYS path such as /c/x as a different drive-relative path:
/c/x -> C:\c\x

This silently produces an incorrect path. MSYS environments provide realpath, so disabling this fallback on Windows does not remove required functionality.
Testing
Add tests/test-path-normalization.sh covering:
  • drive-letter and MSYS representations of the same directory
  • backslash paths
  • arbitrary drive letters
  • project paths containing spaces
  • non-Windows no-op behavior
  • rejection of a plan genuinely outside the project
  • rejection of prefix-sibling paths such as project-evil
End-to-end verification confirms that the fixed branch starts the RLCR loop successfully without manually exporting CLAUDE_PROJECT_DIR, while the current main branch fails with the incorrect containment error.
@houhou8
Normalize Windows path spellings before containment checks
15fa348
On MSYS/MinGW/Cygwin one directory has two textual spellings, and the two
sides of the plan-file containment check came from sources that disagree:
git rev-parse --show-toplevel -> C:/Users/name/project
CLAUDE_PROJECT_DIR (from Claude Code) -> C:\Users\name\project
bash cd .. && pwd -> /c/Users/name/project
setup-rlcr-loop.sh compares these as strings, so the check never matched and
every Windows Git Bash user hit a hard failure at loop start:
Error: Plan file must be within project directory
Canonicalization did not help: MSYS realpath preserves whichever spelling it
is handed rather than folding the two together.
Add to_posix_path() in hooks/lib/project-root.sh, which folds drive-letter
and backslash spellings to the POSIX form via cygpath, with a pure-bash
fallback for Windows shells lacking it. Apply it to CLAUDE_PROJECT_DIR, to
the git toplevel output, and to the resolved plan path, so every path
crossing a comparison speaks one dialect. Any drive letter is supported and
paths containing spaces are preserved.
The helper is a no-op off Windows, guarded by a shell check, so a POSIX
filename legitimately containing a backslash is not rewritten.
Also gate the python3 fallback in canonicalize_path/canonicalize_path_prefix
to non-Windows shells. A native Windows interpreter reads /c/x as
drive-relative and answers C:\c\x -- a different directory -- so on Windows
it silently produced a wrong path. MSYS always ships realpath, so nothing is
lost.
Add tests/test-path-normalization.sh covering both spellings of one
directory, arbitrary drive letters, spaces, POSIX no-op behavior, and that a
plan genuinely outside the project (including a prefix-sibling directory) is
still rejected.
chatgpt-codex-connector[bot]
chatgpt-codex-connectorBot
reviewed
Jul 15, 2026
View reviewed changes
@chatgpt-codex-connectorchatgpt-codex-connectorBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:15fa348aff
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment threadhooks/lib/project-root.sh
 # exports CLAUDE_PROJECT_DIR as `F:\Project\Public`, and git prints
 # `F:/Project/Public`. Normalize before canonicalizing so the result is
 # comparable with paths built from `pwd`.
 root="$(to_posix_path "$root")"
@chatgpt-codex-connectorchatgpt-codex-connectorBotJul 15, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Normalize remaining realpath comparisons too
On MSYS/MinGW this switches PROJECT_ROOT to /c/..., but the methodology-analysis read guard still compares raw realpath "$FILE_PATH" against raw realpath "$PROJECT_ROOT"/$PROJECT_ROOT in hooks/loop-read-validator.sh lines 91 and 154-158. When Claude supplies a drive-letter path such as C:/repo/src/x during methodology analysis, MSYS realpath preserves that spelling while PROJECT_ROOT is now /c/repo, so neither prefix check matches and project files are allowed to be read despite that phase's project-read block. Please run those remaining realpath outputs through the same normalization before comparing.
Useful? React with 👍 / 👎.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@chatgpt-codex-connectorchatgpt-codex-connector[bot]chatgpt-codex-connector[bot] left review comments

At least 1 approving review is required to merge this pull request.


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@houhou8

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Fix: normalize Windows path spellings before plan-file containment check - #228
Open
houhou8 wants to merge 1 commit into
PolyArch:mainfrom 
houhou8:fix/windows-msys-path-normalization
Open
Fix: normalize Windows path spellings before plan-file containment check#228
houhou8 wants to merge 1 commit into
PolyArch:mainfrom 
houhou8:fix/windows-msys-path-normalization
Conversation
@houhou8
@houhou8houhou8
commented
Jul 15, 2026

Copy link


Copy Markdown

Problem
On MSYS/MinGW/Cygwin, the same directory can have multiple textual representations, and the two sides of the plan-file containment check may come from sources that use different forms:
git rev-parse --show-toplevel -> C:/Users/name/project
CLAUDE_PROJECT_DIR from Claude Code -> C:\Users\name\project
bash cd ... && pwd -> /c/Users/name/project

setup-rlcr-loop.sh compares these paths as strings. When the project root and plan path use different representations, affected Windows Git Bash users hit a hard failure at loop start even though the plan file is inside the project:
Error: Plan file must be within project directory

The existing canonicalization does not solve this mismatch because MSYS realpath preserves whichever path representation it is given rather than folding drive-letter and MSYS forms together.
Fix
Add to_posix_path() to hooks/lib/project-root.sh.
The helper converts drive-letter and backslash paths to the MSYS/Cygwin POSIX form using cygpath -u, with a pure-Bash fallback for Windows shells where cygpath is unavailable.
Apply it consistently to:
  • CLAUDE_PROJECT_DIR
  • the output of git rev-parse --show-toplevel
  • the resolved plan path
This ensures that every path involved in the containment comparison uses the same representation. Arbitrary drive letters are supported, and paths containing spaces are preserved.
The helper is a no-op outside Windows environments, so a valid POSIX filename containing a backslash is not rewritten.
Also restrict the python3 fallback in canonicalize_path() and canonicalize_path_prefix() to non-Windows shells. A native Windows Python interpreter can interpret an MSYS path such as /c/x as a different drive-relative path:
/c/x -> C:\c\x

This silently produces an incorrect path. MSYS environments provide realpath, so disabling this fallback on Windows does not remove required functionality.
Testing
Add tests/test-path-normalization.sh covering:
  • drive-letter and MSYS representations of the same directory
  • backslash paths
  • arbitrary drive letters
  • project paths containing spaces
  • non-Windows no-op behavior
  • rejection of a plan genuinely outside the project
  • rejection of prefix-sibling paths such as project-evil
End-to-end verification confirms that the fixed branch starts the RLCR loop successfully without manually exporting CLAUDE_PROJECT_DIR, while the current main branch fails with the incorrect containment error.
@houhou8
Normalize Windows path spellings before containment checks
15fa348
On MSYS/MinGW/Cygwin one directory has two textual spellings, and the two
sides of the plan-file containment check came from sources that disagree:
git rev-parse --show-toplevel -> C:/Users/name/project
CLAUDE_PROJECT_DIR (from Claude Code) -> C:\Users\name\project
bash cd .. && pwd -> /c/Users/name/project
setup-rlcr-loop.sh compares these as strings, so the check never matched and
every Windows Git Bash user hit a hard failure at loop start:
Error: Plan file must be within project directory
Canonicalization did not help: MSYS realpath preserves whichever spelling it
is handed rather than folding the two together.
Add to_posix_path() in hooks/lib/project-root.sh, which folds drive-letter
and backslash spellings to the POSIX form via cygpath, with a pure-bash
fallback for Windows shells lacking it. Apply it to CLAUDE_PROJECT_DIR, to
the git toplevel output, and to the resolved plan path, so every path
crossing a comparison speaks one dialect. Any drive letter is supported and
paths containing spaces are preserved.
The helper is a no-op off Windows, guarded by a shell check, so a POSIX
filename legitimately containing a backslash is not rewritten.
Also gate the python3 fallback in canonicalize_path/canonicalize_path_prefix
to non-Windows shells. A native Windows interpreter reads /c/x as
drive-relative and answers C:\c\x -- a different directory -- so on Windows
it silently produced a wrong path. MSYS always ships realpath, so nothing is
lost.
Add tests/test-path-normalization.sh covering both spellings of one
directory, arbitrary drive letters, spaces, POSIX no-op behavior, and that a
plan genuinely outside the project (including a prefix-sibling directory) is
still rejected.
chatgpt-codex-connector[bot]
chatgpt-codex-connectorBot
reviewed
Jul 15, 2026
View reviewed changes
@chatgpt-codex-connectorchatgpt-codex-connectorBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:15fa348aff
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment threadhooks/lib/project-root.sh
 # exports CLAUDE_PROJECT_DIR as `F:\Project\Public`, and git prints
 # `F:/Project/Public`. Normalize before canonicalizing so the result is
 # comparable with paths built from `pwd`.
 root="$(to_posix_path "$root")"
@chatgpt-codex-connectorchatgpt-codex-connectorBotJul 15, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Normalize remaining realpath comparisons too
On MSYS/MinGW this switches PROJECT_ROOT to /c/..., but the methodology-analysis read guard still compares raw realpath "$FILE_PATH" against raw realpath "$PROJECT_ROOT"/$PROJECT_ROOT in hooks/loop-read-validator.sh lines 91 and 154-158. When Claude supplies a drive-letter path such as C:/repo/src/x during methodology analysis, MSYS realpath preserves that spelling while PROJECT_ROOT is now /c/repo, so neither prefix check matches and project files are allowed to be read despite that phase's project-read block. Please run those remaining realpath outputs through the same normalization before comparing.
Useful? React with 👍 / 👎.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@chatgpt-codex-connectorchatgpt-codex-connector[bot]chatgpt-codex-connector[bot] left review comments

At least 1 approving review is required to merge this pull request.


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@houhou8

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Fix: normalize Windows path spellings before plan-file containment check - #228
Open
houhou8 wants to merge 1 commit into
PolyArch:mainfrom 
houhou8:fix/windows-msys-path-normalization
Open
Fix: normalize Windows path spellings before plan-file containment check#228
houhou8 wants to merge 1 commit into
PolyArch:mainfrom 
houhou8:fix/windows-msys-path-normalization
Conversation
@houhou8
@houhou8houhou8
commented
Jul 15, 2026

Copy link


Copy Markdown

Problem
On MSYS/MinGW/Cygwin, the same directory can have multiple textual representations, and the two sides of the plan-file containment check may come from sources that use different forms:
git rev-parse --show-toplevel -> C:/Users/name/project
CLAUDE_PROJECT_DIR from Claude Code -> C:\Users\name\project
bash cd ... && pwd -> /c/Users/name/project

setup-rlcr-loop.sh compares these paths as strings. When the project root and plan path use different representations, affected Windows Git Bash users hit a hard failure at loop start even though the plan file is inside the project:
Error: Plan file must be within project directory

The existing canonicalization does not solve this mismatch because MSYS realpath preserves whichever path representation it is given rather than folding drive-letter and MSYS forms together.
Fix
Add to_posix_path() to hooks/lib/project-root.sh.
The helper converts drive-letter and backslash paths to the MSYS/Cygwin POSIX form using cygpath -u, with a pure-Bash fallback for Windows shells where cygpath is unavailable.
Apply it consistently to:
  • CLAUDE_PROJECT_DIR
  • the output of git rev-parse --show-toplevel
  • the resolved plan path
This ensures that every path involved in the containment comparison uses the same representation. Arbitrary drive letters are supported, and paths containing spaces are preserved.
The helper is a no-op outside Windows environments, so a valid POSIX filename containing a backslash is not rewritten.
Also restrict the python3 fallback in canonicalize_path() and canonicalize_path_prefix() to non-Windows shells. A native Windows Python interpreter can interpret an MSYS path such as /c/x as a different drive-relative path:
/c/x -> C:\c\x

This silently produces an incorrect path. MSYS environments provide realpath, so disabling this fallback on Windows does not remove required functionality.
Testing
Add tests/test-path-normalization.sh covering:
  • drive-letter and MSYS representations of the same directory
  • backslash paths
  • arbitrary drive letters
  • project paths containing spaces
  • non-Windows no-op behavior
  • rejection of a plan genuinely outside the project
  • rejection of prefix-sibling paths such as project-evil
End-to-end verification confirms that the fixed branch starts the RLCR loop successfully without manually exporting CLAUDE_PROJECT_DIR, while the current main branch fails with the incorrect containment error.
@houhou8
Normalize Windows path spellings before containment checks
15fa348
On MSYS/MinGW/Cygwin one directory has two textual spellings, and the two
sides of the plan-file containment check came from sources that disagree:
git rev-parse --show-toplevel -> C:/Users/name/project
CLAUDE_PROJECT_DIR (from Claude Code) -> C:\Users\name\project
bash cd .. && pwd -> /c/Users/name/project
setup-rlcr-loop.sh compares these as strings, so the check never matched and
every Windows Git Bash user hit a hard failure at loop start:
Error: Plan file must be within project directory
Canonicalization did not help: MSYS realpath preserves whichever spelling it
is handed rather than folding the two together.
Add to_posix_path() in hooks/lib/project-root.sh, which folds drive-letter
and backslash spellings to the POSIX form via cygpath, with a pure-bash
fallback for Windows shells lacking it. Apply it to CLAUDE_PROJECT_DIR, to
the git toplevel output, and to the resolved plan path, so every path
crossing a comparison speaks one dialect. Any drive letter is supported and
paths containing spaces are preserved.
The helper is a no-op off Windows, guarded by a shell check, so a POSIX
filename legitimately containing a backslash is not rewritten.
Also gate the python3 fallback in canonicalize_path/canonicalize_path_prefix
to non-Windows shells. A native Windows interpreter reads /c/x as
drive-relative and answers C:\c\x -- a different directory -- so on Windows
it silently produced a wrong path. MSYS always ships realpath, so nothing is
lost.
Add tests/test-path-normalization.sh covering both spellings of one
directory, arbitrary drive letters, spaces, POSIX no-op behavior, and that a
plan genuinely outside the project (including a prefix-sibling directory) is
still rejected.
chatgpt-codex-connector[bot]
chatgpt-codex-connectorBot
reviewed
Jul 15, 2026
View reviewed changes
@chatgpt-codex-connectorchatgpt-codex-connectorBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:15fa348aff
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment threadhooks/lib/project-root.sh
 # exports CLAUDE_PROJECT_DIR as `F:\Project\Public`, and git prints
 # `F:/Project/Public`. Normalize before canonicalizing so the result is
 # comparable with paths built from `pwd`.
 root="$(to_posix_path "$root")"
@chatgpt-codex-connectorchatgpt-codex-connectorBotJul 15, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Normalize remaining realpath comparisons too
On MSYS/MinGW this switches PROJECT_ROOT to /c/..., but the methodology-analysis read guard still compares raw realpath "$FILE_PATH" against raw realpath "$PROJECT_ROOT"/$PROJECT_ROOT in hooks/loop-read-validator.sh lines 91 and 154-158. When Claude supplies a drive-letter path such as C:/repo/src/x during methodology analysis, MSYS realpath preserves that spelling while PROJECT_ROOT is now /c/repo, so neither prefix check matches and project files are allowed to be read despite that phase's project-read block. Please run those remaining realpath outputs through the same normalization before comparing.
Useful? React with 👍 / 👎.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@chatgpt-codex-connectorchatgpt-codex-connector[bot]chatgpt-codex-connector[bot] left review comments

At least 1 approving review is required to merge this pull request.


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@houhou8

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Fix: normalize Windows path spellings before plan-file containment check - #228
Open
houhou8 wants to merge 1 commit into
PolyArch:mainfrom 
houhou8:fix/windows-msys-path-normalization
Open
Fix: normalize Windows path spellings before plan-file containment check#228
houhou8 wants to merge 1 commit into
PolyArch:mainfrom 
houhou8:fix/windows-msys-path-normalization
Conversation
@houhou8
@houhou8houhou8
commented
Jul 15, 2026

Copy link


Copy Markdown

Problem
On MSYS/MinGW/Cygwin, the same directory can have multiple textual representations, and the two sides of the plan-file containment check may come from sources that use different forms:
git rev-parse --show-toplevel -> C:/Users/name/project
CLAUDE_PROJECT_DIR from Claude Code -> C:\Users\name\project
bash cd ... && pwd -> /c/Users/name/project

setup-rlcr-loop.sh compares these paths as strings. When the project root and plan path use different representations, affected Windows Git Bash users hit a hard failure at loop start even though the plan file is inside the project:
Error: Plan file must be within project directory

The existing canonicalization does not solve this mismatch because MSYS realpath preserves whichever path representation it is given rather than folding drive-letter and MSYS forms together.
Fix
Add to_posix_path() to hooks/lib/project-root.sh.
The helper converts drive-letter and backslash paths to the MSYS/Cygwin POSIX form using cygpath -u, with a pure-Bash fallback for Windows shells where cygpath is unavailable.
Apply it consistently to:
  • CLAUDE_PROJECT_DIR
  • the output of git rev-parse --show-toplevel
  • the resolved plan path
This ensures that every path involved in the containment comparison uses the same representation. Arbitrary drive letters are supported, and paths containing spaces are preserved.
The helper is a no-op outside Windows environments, so a valid POSIX filename containing a backslash is not rewritten.
Also restrict the python3 fallback in canonicalize_path() and canonicalize_path_prefix() to non-Windows shells. A native Windows Python interpreter can interpret an MSYS path such as /c/x as a different drive-relative path:
/c/x -> C:\c\x

This silently produces an incorrect path. MSYS environments provide realpath, so disabling this fallback on Windows does not remove required functionality.
Testing
Add tests/test-path-normalization.sh covering:
  • drive-letter and MSYS representations of the same directory
  • backslash paths
  • arbitrary drive letters
  • project paths containing spaces
  • non-Windows no-op behavior
  • rejection of a plan genuinely outside the project
  • rejection of prefix-sibling paths such as project-evil
End-to-end verification confirms that the fixed branch starts the RLCR loop successfully without manually exporting CLAUDE_PROJECT_DIR, while the current main branch fails with the incorrect containment error.
@houhou8
Normalize Windows path spellings before containment checks
15fa348
On MSYS/MinGW/Cygwin one directory has two textual spellings, and the two
sides of the plan-file containment check came from sources that disagree:
git rev-parse --show-toplevel -> C:/Users/name/project
CLAUDE_PROJECT_DIR (from Claude Code) -> C:\Users\name\project
bash cd .. && pwd -> /c/Users/name/project
setup-rlcr-loop.sh compares these as strings, so the check never matched and
every Windows Git Bash user hit a hard failure at loop start:
Error: Plan file must be within project directory
Canonicalization did not help: MSYS realpath preserves whichever spelling it
is handed rather than folding the two together.
Add to_posix_path() in hooks/lib/project-root.sh, which folds drive-letter
and backslash spellings to the POSIX form via cygpath, with a pure-bash
fallback for Windows shells lacking it. Apply it to CLAUDE_PROJECT_DIR, to
the git toplevel output, and to the resolved plan path, so every path
crossing a comparison speaks one dialect. Any drive letter is supported and
paths containing spaces are preserved.
The helper is a no-op off Windows, guarded by a shell check, so a POSIX
filename legitimately containing a backslash is not rewritten.
Also gate the python3 fallback in canonicalize_path/canonicalize_path_prefix
to non-Windows shells. A native Windows interpreter reads /c/x as
drive-relative and answers C:\c\x -- a different directory -- so on Windows
it silently produced a wrong path. MSYS always ships realpath, so nothing is
lost.
Add tests/test-path-normalization.sh covering both spellings of one
directory, arbitrary drive letters, spaces, POSIX no-op behavior, and that a
plan genuinely outside the project (including a prefix-sibling directory) is
still rejected.
chatgpt-codex-connector[bot]
chatgpt-codex-connectorBot
reviewed
Jul 15, 2026
View reviewed changes
@chatgpt-codex-connectorchatgpt-codex-connectorBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:15fa348aff
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment threadhooks/lib/project-root.sh
 # exports CLAUDE_PROJECT_DIR as `F:\Project\Public`, and git prints
 # `F:/Project/Public`. Normalize before canonicalizing so the result is
 # comparable with paths built from `pwd`.
 root="$(to_posix_path "$root")"
@chatgpt-codex-connectorchatgpt-codex-connectorBotJul 15, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Normalize remaining realpath comparisons too
On MSYS/MinGW this switches PROJECT_ROOT to /c/..., but the methodology-analysis read guard still compares raw realpath "$FILE_PATH" against raw realpath "$PROJECT_ROOT"/$PROJECT_ROOT in hooks/loop-read-validator.sh lines 91 and 154-158. When Claude supplies a drive-letter path such as C:/repo/src/x during methodology analysis, MSYS realpath preserves that spelling while PROJECT_ROOT is now /c/repo, so neither prefix check matches and project files are allowed to be read despite that phase's project-read block. Please run those remaining realpath outputs through the same normalization before comparing.
Useful? React with 👍 / 👎.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@chatgpt-codex-connectorchatgpt-codex-connector[bot]chatgpt-codex-connector[bot] left review comments

At least 1 approving review is required to merge this pull request.


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@houhou8

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Fix: normalize Windows path spellings before plan-file containment check - #228
Open
houhou8 wants to merge 1 commit into
PolyArch:mainfrom 
houhou8:fix/windows-msys-path-normalization
Open
Fix: normalize Windows path spellings before plan-file containment check#228
houhou8 wants to merge 1 commit into
PolyArch:mainfrom 
houhou8:fix/windows-msys-path-normalization
Conversation
@houhou8
@houhou8houhou8
commented
Jul 15, 2026

Copy link


Copy Markdown

Problem
On MSYS/MinGW/Cygwin, the same directory can have multiple textual representations, and the two sides of the plan-file containment check may come from sources that use different forms:
git rev-parse --show-toplevel -> C:/Users/name/project
CLAUDE_PROJECT_DIR from Claude Code -> C:\Users\name\project
bash cd ... && pwd -> /c/Users/name/project

setup-rlcr-loop.sh compares these paths as strings. When the project root and plan path use different representations, affected Windows Git Bash users hit a hard failure at loop start even though the plan file is inside the project:
Error: Plan file must be within project directory

The existing canonicalization does not solve this mismatch because MSYS realpath preserves whichever path representation it is given rather than folding drive-letter and MSYS forms together.
Fix
Add to_posix_path() to hooks/lib/project-root.sh.
The helper converts drive-letter and backslash paths to the MSYS/Cygwin POSIX form using cygpath -u, with a pure-Bash fallback for Windows shells where cygpath is unavailable.
Apply it consistently to:
  • CLAUDE_PROJECT_DIR
  • the output of git rev-parse --show-toplevel
  • the resolved plan path
This ensures that every path involved in the containment comparison uses the same representation. Arbitrary drive letters are supported, and paths containing spaces are preserved.
The helper is a no-op outside Windows environments, so a valid POSIX filename containing a backslash is not rewritten.
Also restrict the python3 fallback in canonicalize_path() and canonicalize_path_prefix() to non-Windows shells. A native Windows Python interpreter can interpret an MSYS path such as /c/x as a different drive-relative path:
/c/x -> C:\c\x

This silently produces an incorrect path. MSYS environments provide realpath, so disabling this fallback on Windows does not remove required functionality.
Testing
Add tests/test-path-normalization.sh covering:
  • drive-letter and MSYS representations of the same directory
  • backslash paths
  • arbitrary drive letters
  • project paths containing spaces
  • non-Windows no-op behavior
  • rejection of a plan genuinely outside the project
  • rejection of prefix-sibling paths such as project-evil
End-to-end verification confirms that the fixed branch starts the RLCR loop successfully without manually exporting CLAUDE_PROJECT_DIR, while the current main branch fails with the incorrect containment error.
@houhou8
Normalize Windows path spellings before containment checks
15fa348
On MSYS/MinGW/Cygwin one directory has two textual spellings, and the two
sides of the plan-file containment check came from sources that disagree:
git rev-parse --show-toplevel -> C:/Users/name/project
CLAUDE_PROJECT_DIR (from Claude Code) -> C:\Users\name\project
bash cd .. && pwd -> /c/Users/name/project
setup-rlcr-loop.sh compares these as strings, so the check never matched and
every Windows Git Bash user hit a hard failure at loop start:
Error: Plan file must be within project directory
Canonicalization did not help: MSYS realpath preserves whichever spelling it
is handed rather than folding the two together.
Add to_posix_path() in hooks/lib/project-root.sh, which folds drive-letter
and backslash spellings to the POSIX form via cygpath, with a pure-bash
fallback for Windows shells lacking it. Apply it to CLAUDE_PROJECT_DIR, to
the git toplevel output, and to the resolved plan path, so every path
crossing a comparison speaks one dialect. Any drive letter is supported and
paths containing spaces are preserved.
The helper is a no-op off Windows, guarded by a shell check, so a POSIX
filename legitimately containing a backslash is not rewritten.
Also gate the python3 fallback in canonicalize_path/canonicalize_path_prefix
to non-Windows shells. A native Windows interpreter reads /c/x as
drive-relative and answers C:\c\x -- a different directory -- so on Windows
it silently produced a wrong path. MSYS always ships realpath, so nothing is
lost.
Add tests/test-path-normalization.sh covering both spellings of one
directory, arbitrary drive letters, spaces, POSIX no-op behavior, and that a
plan genuinely outside the project (including a prefix-sibling directory) is
still rejected.
chatgpt-codex-connector[bot]
chatgpt-codex-connectorBot
reviewed
Jul 15, 2026
View reviewed changes
@chatgpt-codex-connectorchatgpt-codex-connectorBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:15fa348aff
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment threadhooks/lib/project-root.sh
 # exports CLAUDE_PROJECT_DIR as `F:\Project\Public`, and git prints
 # `F:/Project/Public`. Normalize before canonicalizing so the result is
 # comparable with paths built from `pwd`.
 root="$(to_posix_path "$root")"
@chatgpt-codex-connectorchatgpt-codex-connectorBotJul 15, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Normalize remaining realpath comparisons too
On MSYS/MinGW this switches PROJECT_ROOT to /c/..., but the methodology-analysis read guard still compares raw realpath "$FILE_PATH" against raw realpath "$PROJECT_ROOT"/$PROJECT_ROOT in hooks/loop-read-validator.sh lines 91 and 154-158. When Claude supplies a drive-letter path such as C:/repo/src/x during methodology analysis, MSYS realpath preserves that spelling while PROJECT_ROOT is now /c/repo, so neither prefix check matches and project files are allowed to be read despite that phase's project-read block. Please run those remaining realpath outputs through the same normalization before comparing.
Useful? React with 👍 / 👎.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@chatgpt-codex-connectorchatgpt-codex-connector[bot]chatgpt-codex-connector[bot] left review comments

At least 1 approving review is required to merge this pull request.


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@houhou8

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Fix: normalize Windows path spellings before plan-file containment check - #228
Open
houhou8 wants to merge 1 commit into
PolyArch:mainfrom 
houhou8:fix/windows-msys-path-normalization
Open
Fix: normalize Windows path spellings before plan-file containment check#228
houhou8 wants to merge 1 commit into
PolyArch:mainfrom 
houhou8:fix/windows-msys-path-normalization
Conversation
@houhou8
@houhou8houhou8
commented
Jul 15, 2026

Copy link


Copy Markdown

Problem
On MSYS/MinGW/Cygwin, the same directory can have multiple textual representations, and the two sides of the plan-file containment check may come from sources that use different forms:
git rev-parse --show-toplevel -> C:/Users/name/project
CLAUDE_PROJECT_DIR from Claude Code -> C:\Users\name\project
bash cd ... && pwd -> /c/Users/name/project

setup-rlcr-loop.sh compares these paths as strings. When the project root and plan path use different representations, affected Windows Git Bash users hit a hard failure at loop start even though the plan file is inside the project:
Error: Plan file must be within project directory

The existing canonicalization does not solve this mismatch because MSYS realpath preserves whichever path representation it is given rather than folding drive-letter and MSYS forms together.
Fix
Add to_posix_path() to hooks/lib/project-root.sh.
The helper converts drive-letter and backslash paths to the MSYS/Cygwin POSIX form using cygpath -u, with a pure-Bash fallback for Windows shells where cygpath is unavailable.
Apply it consistently to:
  • CLAUDE_PROJECT_DIR
  • the output of git rev-parse --show-toplevel
  • the resolved plan path
This ensures that every path involved in the containment comparison uses the same representation. Arbitrary drive letters are supported, and paths containing spaces are preserved.
The helper is a no-op outside Windows environments, so a valid POSIX filename containing a backslash is not rewritten.
Also restrict the python3 fallback in canonicalize_path() and canonicalize_path_prefix() to non-Windows shells. A native Windows Python interpreter can interpret an MSYS path such as /c/x as a different drive-relative path:
/c/x -> C:\c\x

This silently produces an incorrect path. MSYS environments provide realpath, so disabling this fallback on Windows does not remove required functionality.
Testing
Add tests/test-path-normalization.sh covering:
  • drive-letter and MSYS representations of the same directory
  • backslash paths
  • arbitrary drive letters
  • project paths containing spaces
  • non-Windows no-op behavior
  • rejection of a plan genuinely outside the project
  • rejection of prefix-sibling paths such as project-evil
End-to-end verification confirms that the fixed branch starts the RLCR loop successfully without manually exporting CLAUDE_PROJECT_DIR, while the current main branch fails with the incorrect containment error.
@houhou8
Normalize Windows path spellings before containment checks
15fa348
On MSYS/MinGW/Cygwin one directory has two textual spellings, and the two
sides of the plan-file containment check came from sources that disagree:
git rev-parse --show-toplevel -> C:/Users/name/project
CLAUDE_PROJECT_DIR (from Claude Code) -> C:\Users\name\project
bash cd .. && pwd -> /c/Users/name/project
setup-rlcr-loop.sh compares these as strings, so the check never matched and
every Windows Git Bash user hit a hard failure at loop start:
Error: Plan file must be within project directory
Canonicalization did not help: MSYS realpath preserves whichever spelling it
is handed rather than folding the two together.
Add to_posix_path() in hooks/lib/project-root.sh, which folds drive-letter
and backslash spellings to the POSIX form via cygpath, with a pure-bash
fallback for Windows shells lacking it. Apply it to CLAUDE_PROJECT_DIR, to
the git toplevel output, and to the resolved plan path, so every path
crossing a comparison speaks one dialect. Any drive letter is supported and
paths containing spaces are preserved.
The helper is a no-op off Windows, guarded by a shell check, so a POSIX
filename legitimately containing a backslash is not rewritten.
Also gate the python3 fallback in canonicalize_path/canonicalize_path_prefix
to non-Windows shells. A native Windows interpreter reads /c/x as
drive-relative and answers C:\c\x -- a different directory -- so on Windows
it silently produced a wrong path. MSYS always ships realpath, so nothing is
lost.
Add tests/test-path-normalization.sh covering both spellings of one
directory, arbitrary drive letters, spaces, POSIX no-op behavior, and that a
plan genuinely outside the project (including a prefix-sibling directory) is
still rejected.
chatgpt-codex-connector[bot]
chatgpt-codex-connectorBot
reviewed
Jul 15, 2026
View reviewed changes
@chatgpt-codex-connectorchatgpt-codex-connectorBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:15fa348aff
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment threadhooks/lib/project-root.sh
 # exports CLAUDE_PROJECT_DIR as `F:\Project\Public`, and git prints
 # `F:/Project/Public`. Normalize before canonicalizing so the result is
 # comparable with paths built from `pwd`.
 root="$(to_posix_path "$root")"
@chatgpt-codex-connectorchatgpt-codex-connectorBotJul 15, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Normalize remaining realpath comparisons too
On MSYS/MinGW this switches PROJECT_ROOT to /c/..., but the methodology-analysis read guard still compares raw realpath "$FILE_PATH" against raw realpath "$PROJECT_ROOT"/$PROJECT_ROOT in hooks/loop-read-validator.sh lines 91 and 154-158. When Claude supplies a drive-letter path such as C:/repo/src/x during methodology analysis, MSYS realpath preserves that spelling while PROJECT_ROOT is now /c/repo, so neither prefix check matches and project files are allowed to be read despite that phase's project-read block. Please run those remaining realpath outputs through the same normalization before comparing.
Useful? React with 👍 / 👎.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@chatgpt-codex-connectorchatgpt-codex-connector[bot]chatgpt-codex-connector[bot] left review comments

At least 1 approving review is required to merge this pull request.


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@houhou8

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Fix: normalize Windows path spellings before plan-file containment check - #228
Open
houhou8 wants to merge 1 commit into
PolyArch:mainfrom 
houhou8:fix/windows-msys-path-normalization
Open
Fix: normalize Windows path spellings before plan-file containment check#228
houhou8 wants to merge 1 commit into
PolyArch:mainfrom 
houhou8:fix/windows-msys-path-normalization
Conversation
@houhou8
@houhou8houhou8
commented
Jul 15, 2026

Copy link


Copy Markdown

Problem
On MSYS/MinGW/Cygwin, the same directory can have multiple textual representations, and the two sides of the plan-file containment check may come from sources that use different forms:
git rev-parse --show-toplevel -> C:/Users/name/project
CLAUDE_PROJECT_DIR from Claude Code -> C:\Users\name\project
bash cd ... && pwd -> /c/Users/name/project

setup-rlcr-loop.sh compares these paths as strings. When the project root and plan path use different representations, affected Windows Git Bash users hit a hard failure at loop start even though the plan file is inside the project:
Error: Plan file must be within project directory

The existing canonicalization does not solve this mismatch because MSYS realpath preserves whichever path representation it is given rather than folding drive-letter and MSYS forms together.
Fix
Add to_posix_path() to hooks/lib/project-root.sh.
The helper converts drive-letter and backslash paths to the MSYS/Cygwin POSIX form using cygpath -u, with a pure-Bash fallback for Windows shells where cygpath is unavailable.
Apply it consistently to:
  • CLAUDE_PROJECT_DIR
  • the output of git rev-parse --show-toplevel
  • the resolved plan path
This ensures that every path involved in the containment comparison uses the same representation. Arbitrary drive letters are supported, and paths containing spaces are preserved.
The helper is a no-op outside Windows environments, so a valid POSIX filename containing a backslash is not rewritten.
Also restrict the python3 fallback in canonicalize_path() and canonicalize_path_prefix() to non-Windows shells. A native Windows Python interpreter can interpret an MSYS path such as /c/x as a different drive-relative path:
/c/x -> C:\c\x

This silently produces an incorrect path. MSYS environments provide realpath, so disabling this fallback on Windows does not remove required functionality.
Testing
Add tests/test-path-normalization.sh covering:
  • drive-letter and MSYS representations of the same directory
  • backslash paths
  • arbitrary drive letters
  • project paths containing spaces
  • non-Windows no-op behavior
  • rejection of a plan genuinely outside the project
  • rejection of prefix-sibling paths such as project-evil
End-to-end verification confirms that the fixed branch starts the RLCR loop successfully without manually exporting CLAUDE_PROJECT_DIR, while the current main branch fails with the incorrect containment error.
@houhou8
Normalize Windows path spellings before containment checks
15fa348
On MSYS/MinGW/Cygwin one directory has two textual spellings, and the two
sides of the plan-file containment check came from sources that disagree:
git rev-parse --show-toplevel -> C:/Users/name/project
CLAUDE_PROJECT_DIR (from Claude Code) -> C:\Users\name\project
bash cd .. && pwd -> /c/Users/name/project
setup-rlcr-loop.sh compares these as strings, so the check never matched and
every Windows Git Bash user hit a hard failure at loop start:
Error: Plan file must be within project directory
Canonicalization did not help: MSYS realpath preserves whichever spelling it
is handed rather than folding the two together.
Add to_posix_path() in hooks/lib/project-root.sh, which folds drive-letter
and backslash spellings to the POSIX form via cygpath, with a pure-bash
fallback for Windows shells lacking it. Apply it to CLAUDE_PROJECT_DIR, to
the git toplevel output, and to the resolved plan path, so every path
crossing a comparison speaks one dialect. Any drive letter is supported and
paths containing spaces are preserved.
The helper is a no-op off Windows, guarded by a shell check, so a POSIX
filename legitimately containing a backslash is not rewritten.
Also gate the python3 fallback in canonicalize_path/canonicalize_path_prefix
to non-Windows shells. A native Windows interpreter reads /c/x as
drive-relative and answers C:\c\x -- a different directory -- so on Windows
it silently produced a wrong path. MSYS always ships realpath, so nothing is
lost.
Add tests/test-path-normalization.sh covering both spellings of one
directory, arbitrary drive letters, spaces, POSIX no-op behavior, and that a
plan genuinely outside the project (including a prefix-sibling directory) is
still rejected.
chatgpt-codex-connector[bot]
chatgpt-codex-connectorBot
reviewed
Jul 15, 2026
View reviewed changes
@chatgpt-codex-connectorchatgpt-codex-connectorBot
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:15fa348aff
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment threadhooks/lib/project-root.sh
 # exports CLAUDE_PROJECT_DIR as `F:\Project\Public`, and git prints
 # `F:/Project/Public`. Normalize before canonicalizing so the result is
 # comparable with paths built from `pwd`.
 root="$(to_posix_path "$root")"
@chatgpt-codex-connectorchatgpt-codex-connectorBotJul 15, 2026

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Normalize remaining realpath comparisons too
On MSYS/MinGW this switches PROJECT_ROOT to /c/..., but the methodology-analysis read guard still compares raw realpath "$FILE_PATH" against raw realpath "$PROJECT_ROOT"/$PROJECT_ROOT in hooks/loop-read-validator.sh lines 91 and 154-158. When Claude supplies a drive-letter path such as C:/repo/src/x during methodology analysis, MSYS realpath preserves that spelling while PROJECT_ROOT is now /c/repo, so neither prefix check matches and project files are allowed to be read despite that phase's project-read block. Please run those remaining realpath outputs through the same normalization before comparing.
Useful? React with 👍 / 👎.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@chatgpt-codex-connectorchatgpt-codex-connector[bot]chatgpt-codex-connector[bot] left review comments

At least 1 approving review is required to merge this pull request.


Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

1 participant

@houhou8