') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); feat: accept 'max' reasoning effort for Codex models by Windy3f3f3f3f · Pull Request #229 · PolyArch/humanize · GitHub
Skip to content

feat: accept 'max' reasoning effort for Codex models - #229

Merged
zevorn merged 1 commit into
PolyArch:devfrom
Windy3f3f3f3f:support-max-reasoning-effort
Aug 28, 2026
Merged

feat: accept 'max' reasoning effort for Codex models#229
zevorn merged 1 commit into
PolyArch:devfrom
Windy3f3f3f3f:support-max-reasoning-effort

Conversation

@Windy3f3f3f3f

@Windy3f3f3f3fWindy3f3f3f3f commented Jul 17, 2026

Copy link
Copy Markdown

Motivation

Codex CLI >= 0.144.0 supports model_reasoning_effort=max (introduced alongside the GPT-5.6 model family, GA July 2026). Humanize currently rejects max at every validation site:

  • codex_effort: "max" in config.json is silently ignored with a warning (hooks/lib/loop-common.sh)
  • start-rlcr-loop --codex-model MODEL:max fails at setup (scripts/setup-rlcr-loop.sh)
  • the stop hook rejects max when re-reading loop state (hooks/loop-codex-stop-hook.sh)
  • map_effort errors on max (scripts/lib/model-router.sh)

So users on GPT-5.6 can't run RLCR reviews at the deepest reasoning tier even though their CLI supports it.

Changes

  • Add max to the four effort whitelists and the corresponding error messages
  • map_effort: downgrade max -> high for the claude provider, same as the existing xhigh mapping (the info log now interpolates the actual effort value)
  • docs/usage.md: update both codex_effort value lists
  • tests/test-unified-codex-config.sh: keep the replicated validation regexes in sync
  • tests/test-model-router.sh: add Test 21 (max passes through for codex) and Test 22 (max maps to high for claude)

Testing

  • tests/test-model-router.sh: new Tests 21/22 pass (Tests 11/13 fail only on my box because codex/claude exist in /usr/bin, which defeats the missing-binary simulation; unrelated to this change)
  • tests/test-unified-codex-config.sh, tests/test-config-merge.sh, tests/test-config-error-handling.sh: all pass
  • bash -n clean on all changed shell files
  • Verified end-to-end on a patched install: codex_effort: "max" in config is accepted without warning and ask-codex runs with model=gpt-5.6-sol effort=max

🤖 Generated with Claude Code

@Windy3f3f3f3f@claude
feat: accept 'max' reasoning effort for Codex models
450a351
Codex CLI >= 0.144.0 supports model_reasoning_effort=max (introduced
with the GPT-5.6 family). Humanize currently rejects it at every
validation site, so codex_effort=max in config.json is ignored with a
warning and start-rlcr-loop --codex-model MODEL:max fails at setup.
- Add max to the effort whitelists in loop-common.sh (config
validation), setup-rlcr-loop.sh (loop setup), loop-codex-stop-hook.sh
(state validation), and model-router.sh (map_effort)
- Map max -> high for the claude provider, same as xhigh
- Update error messages and docs/usage.md value lists
- Add map_effort test cases: max passthrough (codex), max -> high
(claude)
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@zevorn
zevorn merged commit fc0e0be into PolyArch:devAug 28, 2026
5 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Windy3f3f3f3f@zevorn