Skip to content
This repository was archived by the owner on Jun 2, 2026. It is now read-only.

fix(issuer): display dummy page for incompatible browsers - #12

Merged
RafaelVidaurre merged 3 commits into
developfrom
fix/incompatible-browsers
Oct 5, 2018
Merged

fix(issuer): display dummy page for incompatible browsers#12
RafaelVidaurre merged 3 commits into
developfrom
fix/incompatible-browsers

Conversation

@sajclarke

@sajclarkesajclarke commented Sep 21, 2018

Copy link
Copy Markdown
Contributor

display dummy page for incompatible browsers

@sajclarke
fix(issuer): display dummy page for incompatible browsers
f38ba17
display dummy page for incompatible browsers
RafaelVidaurre
RafaelVidaurre suggested changes Sep 21, 2018
View reviewed changes

@RafaelVidaurreRafaelVidaurre left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just readability changes ;p

Comment threadpackages/polymath-issuer/src/RouteLoader.js Outdated
@sajclarke
fix(issuer): improve readability
fb328a4
add constant for readability improvements
RafaelVidaurre
RafaelVidaurre previously approved these changes Sep 21, 2018
View reviewed changes
@GrsmtoGrsmto self-assigned this Sep 27, 2018
@serpixel

serpixel commented Oct 1, 2018•
edited
Loading

Copy link
Copy Markdown

Please bear in mind that browsers that are incompatible with react (e.g. IE) may not even process this far. We should have a snippet load up at the beginning.

@GrsmtoGrsmto mentioned this pull request Oct 2, 2018
Open
@RafaelVidaurre

RafaelVidaurre commented Oct 3, 2018

Copy link
Copy Markdown
Contributor

@josepmc maybe this is something we want to check before merging then

@RafaelVidaurre

RafaelVidaurre commented Oct 4, 2018

Copy link
Copy Markdown
Contributor

@josepmc I guess what you are saying would make sense for browser <= ie8, should we care about this?

@serpixel

serpixel commented Oct 4, 2018

Copy link
Copy Markdown

I think it'd be wise for us to avoid any possible mishaps by an external library and just insert any snippet before anything, that would cover us in any situation.

@Grsmto

Grsmto commented Oct 5, 2018

Copy link
Copy Markdown
Contributor

@RafaelVidaurre I think you can merge this. We have an issue already in place for what Josep suggested.

@RafaelVidaurre

RafaelVidaurre commented Oct 5, 2018

Copy link
Copy Markdown
Contributor

@Grsmto thanks, I'll do that then

@RafaelVidaurre
RafaelVidaurre merged commit f41ff22 into developOct 5, 2018
@RafaelVidaurre
RafaelVidaurre deleted the fix/incompatible-browsers branch October 5, 2018 13:39
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@RafaelVidaurreRafaelVidaurreRafaelVidaurre approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@GrsmtoGrsmto

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sajclarke@serpixel@RafaelVidaurre@Grsmto