Uh oh!
There was an error while loading. Please reload this page.
Percentage tm admin permission - #379
Merged
Merged
Conversation
maxsam4
suggested changes
Oct 25, 2018
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
satyamakgec
commented
Oct 25, 2018
Contributor
@kostind Mudit points out the concerns already. Nothing more. |
added 2 commits
October 25, 2018 10:07
maxsam4
reviewed
Oct 25, 2018
Uh oh!
There was an error while loading. Please reload this page.
maxsam4
approved these changes
Oct 25, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Make
changeHolderPercentagein PercentageTM a permissioned function (e.g. withPerm(ADMIN))What is the current behavior?
(You can also link to an open issue here)
What is the new behavior?
(Define and describe any new functionality. Clarify if this is a feature change)
Does this PR introduce a breaking change?
No
Any Other information: