Uh oh!
There was an error while loading. Please reload this page.
Reinvent lockup - #409
Conversation
satyamakgec
commented
Nov 15, 2018
Please do check with the issue #389 As per the test it is not present in the current code |
maxsam4
left a comment
There was a problem hiding this comment.
Consider adding a view getLockedToken function which will return sum of cirrently locked tokens of a user so that user can know how many tokens are still locked and how many can they transfer.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
maxsam4
commented
Nov 16, 2018
TIL that references to parameters of an external function are stored in the stack. |
satyamakgec
commented
Nov 20, 2018
@maxsam4 It is done with the review? If yes then @VictorVicente can use this same PR to create the CLI |
maxsam4
commented
Nov 20, 2018
Yeah. The function modifier thing was the last issue. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
satyamakgec
commented
Nov 30, 2018
@maxsam4@adamdossa could you please review it again because of the data structure changes |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.