Skip to content

Reinvent lockup - #409

Merged
VictorVicente merged 26 commits into
dev-2.1.0from
reinvent-lockup
Jan 9, 2019
Merged

Reinvent lockup#409
VictorVicente merged 26 commits into
dev-2.1.0from
reinvent-lockup

Conversation

@satyamakgec

@satyamakgecsatyamakgec commented Nov 13, 2018

Copy link
Copy Markdown
Contributor
  • Test suite

@satyamakgecsatyamakgec changed the title [WIP] Reinvent lockupReinvent lockupNov 14, 2018
@satyamakgec

Copy link
Copy Markdown
ContributorAuthor

Please do check with the issue #389 As per the test it is not present in the current code

This was referenced Nov 15, 2018

@maxsam4maxsam4 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a view getLockedToken function which will return sum of cirrently locked tokens of a user so that user can know how many tokens are still locked and how many can they transfer.

@maxsam4

Copy link
Copy Markdown
Contributor

TIL that references to parameters of an external function are stored in the stack.

@satyamakgec

Copy link
Copy Markdown
ContributorAuthor

@maxsam4 It is done with the review? If yes then @VictorVicente can use this same PR to create the CLI

@maxsam4

Copy link
Copy Markdown
Contributor

Yeah. The function modifier thing was the last issue.
Everything Looks good to me now.

@satyamakgec

Copy link
Copy Markdown
ContributorAuthor

@maxsam4@adamdossa could you please review it again because of the data structure changes

Comment threadcontracts/modules/TransferManager/LockUpTransferManager.sol Outdated
Comment threadcontracts/modules/TransferManager/LockUpTransferManager.sol Outdated
Comment threadcontracts/modules/TransferManager/LockUpTransferManager.sol Outdated
Comment threadcontracts/modules/TransferManager/LockUpTransferManager.sol Outdated
Comment threadcontracts/modules/TransferManager/LockUpTransferManager.sol Outdated
@coveralls

coveralls commented Jan 8, 2019

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.3%) to 96.042% when pulling 887860e on reinvent-lockup into 7e05021 on dev-2.1.0.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@satyamakgec@maxsam4@coveralls@adamdossa@VictorVicente@SatyamSB