Skip to content

Signed transfer manager fixed - #410

Closed
comeonbuddy wants to merge 23 commits into
dev-2.1.0from
signed-transfer-manager-fixed
Closed

Signed transfer manager fixed#410
comeonbuddy wants to merge 23 commits into
dev-2.1.0from
signed-transfer-manager-fixed

Conversation

@comeonbuddy

@comeonbuddycomeonbuddy commented Nov 13, 2018

Copy link
Copy Markdown
Contributor

Please check if the PR fulfills these requirements

  • [x ] The commit message follows our Submission guidelines
  • [x ] Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

fixed signed transfer manager and test filess

What is the current behavior?

current signed transfer manager was not working due to a pending issue we have double pre fix when signing messages because our version of web3 automatically adds one.

What is the new behavior?

fixed the issue so the test file work

Does this PR introduce a breaking change?

no

Any Other information:

@comeonbuddy
comeonbuddy changed the base branch from development-1.5.0 to dev-2.1.0November 13, 2018 15:28
adamdossa
adamdossa suggested changes Nov 14, 2018
View reviewed changes
Comment threadcontracts/modules/TransferManager/SignedTransferManager.sol
Comment threadcontracts/modules/TransferManager/SignedTransferManager.sol Outdated
Comment threadcontracts/modules/TransferManager/SignedTransferManager.sol Outdated
Comment threadcontracts/modules/TransferManager/SignedTransferManager.sol Outdated
Comment threadcontracts/modules/TransferManager/SignedTransferManager.sol Outdated
adamdossa
adamdossa suggested changes Nov 16, 2018
View reviewed changes
Comment threadcontracts/modules/TransferManager/SignedTransferManager.sol Outdated
Comment threadcontracts/modules/TransferManager/SignedTransferManager.sol
maxsam4
maxsam4 suggested changes Nov 16, 2018
View reviewed changes
Comment threadcontracts/modules/TransferManager/SignedTransferManager.sol Outdated
Comment threadcontracts/modules/TransferManager/SignedTransferManager.sol
Comment threadcontracts/modules/TransferManager/SignedTransferManager.sol
Comment threadtest/helpers/signData.js Outdated
Comment threadtest/y_signed_transfer_manager.js Outdated
Comment threadtest/y_signed_transfer_manager.js Outdated
comeonbuddyand others added 3 commits November 16, 2018 08:18
@comeonbuddy
updated logic in verify transfer function
07f1b8f
as requested by Adam D.
@maxsam4@comeonbuddy
Apply suggestions from code review
2abea31
gas saver
Co-Authored-By: comeonbuddy <comeonbuddy@gmail.com>
@comeonbuddy
added data length check
95c4b84
data input length can not be 0
maxsam4
maxsam4 reviewed Nov 16, 2018
View reviewed changes
Comment threadcontracts/modules/TransferManager/SignedTransferManager.sol Outdated
maxsam4
maxsam4 reviewed Nov 16, 2018
View reviewed changes
Comment threadcontracts/modules/TransferManager/SignedTransferManager.sol
@comeonbuddy
comeonbuddy changed the base branch from dev-2.1.0 to dev-3.0.0January 14, 2019 06:01
@comeonbuddy
comeonbuddy changed the base branch from dev-3.0.0 to dev-2.1.0January 14, 2019 07:00
@maxsam4

maxsam4 commented Jan 25, 2019

Copy link
Copy Markdown
Contributor

Closing in favor of #533

@maxsam4maxsam4 closed this Jan 25, 2019
@maxsam4
maxsam4 deleted the signed-transfer-manager-fixed branch April 9, 2019 07:07
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@adamdossaadamdossaadamdossa approved these changes
@maxsam4maxsam4maxsam4 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@comeonbuddy@maxsam4@adamdossa