Skip to content

MATM changes - #450

Merged
pabloruiz55 merged 34 commits into
dev-2.1.0from
remove-blocking-MATM
Jan 2, 2019
Merged

MATM changes#450
pabloruiz55 merged 34 commits into
dev-2.1.0from
remove-blocking-MATM

Conversation

@comeonbuddy

@comeonbuddycomeonbuddy commented Dec 3, 2018•
edited by VictorVicente
Loading

Copy link
Copy Markdown
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our Submission guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

  • Removed all the blocking related functions and events in MATM
  • Given a single address, anyone is able to see a list of all active approvals from/to that address
  • Improved MATM to allow allowances and expiryTimes to be changed for existing approvals.
  • As an issuer, you are able to add/revoke in batches (using a multi approach)
  • As an issuer, you are able to add a description to a manual approval.
  • Anyone is able to see a list of all active approvals

Does this PR introduce a breaking change?

Yes

Any Other information:

@comeonbuddy
comeonbuddy changed the base branch from master to dev-2.1.0December 3, 2018 11:06
@pabloruiz55pabloruiz55 changed the title Remove blocking matm[WIP] Remove blocking matmDec 3, 2018
@comeonbuddycomeonbuddy changed the title [WIP] Remove blocking matmRemove blocking matmDec 4, 2018
@comeonbuddycomeonbuddy changed the title Remove blocking matm[WIP] Remove blocking matmDec 4, 2018
satyamakgec
satyamakgec approved these changes Dec 4, 2018
View reviewed changes

@satyamakgecsatyamakgec left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are looking fine to me.
@comeonbuddy you don't need to remove /*solium-disable-next-line security/no-block-members*/ this from the code it only used for linting :)

@VictorVicenteVictorVicente changed the title [WIP] Remove blocking matmRemove blocking matmDec 8, 2018
maxsam4
maxsam4 suggested changes Dec 10, 2018
View reviewed changes

@maxsam4maxsam4 left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need to review logic. Only completed style review currently.

Comment threadcontracts/modules/TransferManager/ManualApprovalTransferManager.sol Outdated
Comment threadcontracts/modules/TransferManager/ManualApprovalTransferManager.sol Outdated
maxsam4
maxsam4 suggested changes Dec 11, 2018
View reviewed changes

@maxsam4maxsam4 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, Just some minor things that can be optimized.
Test cases need to be fixed/added.

Comment threadcontracts/modules/TransferManager/ManualApprovalTransferManager.sol Outdated
Comment threadcontracts/modules/TransferManager/ManualApprovalTransferManager.sol
Comment threadcontracts/modules/TransferManager/ManualApprovalTransferManager.sol
Comment threadcontracts/modules/TransferManager/ManualApprovalTransferManager.sol Outdated
maxsam4
maxsam4 suggested changes Dec 11, 2018
View reviewed changes
Comment threadcontracts/modules/TransferManager/ManualApprovalTransferManager.sol Outdated
@VictorVicenteVictorVicente changed the title Remove blocking matm[WIP] MATM changesDec 11, 2018
@VictorVicente

VictorVicente commented Dec 11, 2018

Copy link
Copy Markdown
Contributor

Edited title and description to include all new MATM changes

@VictorVicenteVictorVicente changed the title [WIP] MATM changesMATM changesDec 14, 2018
@coveralls

coveralls commented Dec 18, 2018•
edited
Loading

Copy link
Copy Markdown

Coverage Status

Coverage decreased (-0.3%) to 97.746% when pulling ad29c1b on remove-blocking-MATM into f2bd23a on dev-2.1.0.

@pabloruiz55
pabloruiz55 merged commit a0408c0 into dev-2.1.0Jan 2, 2019
@maxsam4
maxsam4 deleted the remove-blocking-MATM branch January 11, 2019 13:57
@knanjukutty-polymathknanjukutty-polymath mentioned this pull request Mar 28, 2024
Open
This was referenced Apr 17, 2024
Open
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@satyamakgecsatyamakgecsatyamakgec approved these changes
@maxsam4maxsam4maxsam4 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@comeonbuddy@VictorVicente@coveralls@maxsam4@satyamakgec@pabloruiz55@SatyamSB@shuffledex