Skip to content

add getRestrictedData() function in VRTM - #513

Merged
satyamakgec merged 22 commits into
dev-2.1.0from
getter-voltm
Jan 10, 2019
Merged

add getRestrictedData() function in VRTM#513
satyamakgec merged 22 commits into
dev-2.1.0from
getter-voltm

Conversation

@satyamakgec

@satyamakgecsatyamakgec commented Jan 8, 2019

Copy link
Copy Markdown
Contributor

No description provided.

@coveralls

coveralls commented Jan 8, 2019•
edited
Loading

Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.3%) to 96.32% when pulling 1b126c2 on getter-voltm into 70a460a on dev-2.1.0.

maxsam4
maxsam4 suggested changes Jan 8, 2019
View reviewed changes
Comment threadcontracts/modules/TransferManager/VolumeRestrictionTM.sol Outdated
Comment threadcontracts/modules/TransferManager/VolumeRestrictionTMStorage.sol Outdated
@satyamakgec

satyamakgec commented Jan 9, 2019

Copy link
Copy Markdown
ContributorAuthor

@VictorVicente please take a look at the getRestrictedAddress() function return values and confirm that you need the same data. I will remove the earlier one once you confirm that new one is according to the requirement.

@satyamakgec

satyamakgec commented Jan 10, 2019

Copy link
Copy Markdown
ContributorAuthor

@maxsam4 could you please review the latest changes.

adamdossa
adamdossa reviewed Jan 10, 2019
View reviewed changes
Comment threadcontracts/modules/TransferManager/VolumeRestrictionTM.sol Outdated
@adamdossaadamdossa changed the title add getRestrictedAddresses() function in VRTMadd getRestrictedData() function in VRTMJan 10, 2019
@satyamakgec
satyamakgec merged commit 962dc89 into dev-2.1.0Jan 10, 2019
@VictorVicente
VictorVicente deleted the getter-voltm branch January 11, 2019 13:59
@knanjukutty-polymathknanjukutty-polymath mentioned this pull request Feb 21, 2024
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@adamdossaadamdossaadamdossa left review comments
@maxsam4maxsam4maxsam4 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@satyamakgec@coveralls@adamdossa@maxsam4@SatyamSB@VictorVicente