Skip to content

Add weighted voting module - #578

Merged
satyamakgec merged 23 commits into
dev-3.0.0from
weighted-voting-module
Apr 10, 2019
Merged

Add weighted voting module#578
satyamakgec merged 23 commits into
dev-3.0.0from
weighted-voting-module

Conversation

@satyamakgec

Copy link
Copy Markdown
Contributor

No description provided.

@satyamakgecsatyamakgec mentioned this pull request Mar 4, 2019
3 tasks
@satyamakgecsatyamakgec changed the title add weighted voting module[WIP]: Add weighted voting moduleMar 4, 2019
@coveralls

coveralls commented Mar 4, 2019

Copy link
Copy Markdown

Coverage Status

Coverage remained the same at 95.134% when pulling 04fbdcc on weighted-voting-module into 47624d8 on dev-3.0.0.

@satyamakgecsatyamakgec changed the title [WIP]: Add weighted voting moduleAdd weighted voting moduleMar 6, 2019
Comment threadcontracts/modules/Experimental/Checkpoints/WeightedVoteCheckpoint.sol Outdated
Comment threadcontracts/modules/Experimental/Checkpoints/WeightedVoteCheckpoint.sol Outdated
Comment threadcontracts/modules/Experimental/Checkpoints/WeightedVoteCheckpoint.sol Outdated
Comment threadcontracts/modules/Experimental/Checkpoints/WeightedVoteCheckpoint.sol Outdated
Comment threadcontracts/modules/Experimental/Checkpoints/WeightedVoteCheckpoint.sol Outdated
@satyamakgec

Copy link
Copy Markdown
ContributorAuthor

Everything is fixed only one thing remains i.e proposalId starts from 0. I keep that as it is because if I start with it 0 then there is no way to restrict the user to vote again until unless I will use another storage variable to keep track of it. IMO it is best over introducing another variable to do it.

Comment threadcontracts/modules/Experimental/Checkpoints/WeightedVoteCheckpoint.sol Outdated
Comment threadtest/zc_weighted_vote_checkpoint.js
Comment threadcontracts/modules/Experimental/Checkpoints/WeightedVoteCheckpoint.sol Outdated
Comment threadcontracts/modules/Experimental/Checkpoints/WeightedVoteCheckpoint.sol Outdated
Comment threadcontracts/modules/Experimental/Checkpoints/WeightedVoteCheckpoint.sol Outdated
Comment threadcontracts/modules/Experimental/Checkpoints/WeightedVoteCheckpoint.sol Outdated
@satyamakgec
satyamakgec merged commit 5d87221 into dev-3.0.0Apr 10, 2019
@maxsam4
maxsam4 deleted the weighted-voting-module branch April 10, 2019 09:30
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@satyamakgec@coveralls@adamdossa@maxsam4@SatyamSB