develop is green again: a held driver and a verified pin - #752
Merged
Merged
Conversation
Two dependabot merges took develop red, and every branch cut from it inherited the failure. Nothing here is a code fix; both are decisions the automation is not allowed to make on its own. MONGOOSE 9.10 CANNOT TALK TO THE TEST DATABASE #749 moved mongoose from 9.9.5 to 9.10.0 as part of a patch-and-minor group. Mongoose 9.10 moves its bundled mongodb driver from ~7.5 to ~7.6, and the handshake 7.6 sends is rejected outright by the mongod that mongodb-memory-server runs: MongooseServerSelectionError: Missing required sub-document 'driver' in the client metadata document So it is not a test that broke, it is the connection. Every suite that opens a database failed at beforeAll. Reproduced locally by installing 9.10.1 against mongod 8.2.6 and watching the same error, then cleared by going back to 9.9.5. Held at ~9.9.5, which still takes patches, and dependabot is told the version range and the reason rather than being left to reopen the same pull request on Monday. The note says how to lift it: run the api suite against 9.10 or later, and if it connects, widen it back. THE CODEQL PIN WAS NOT APPROVED, AND THAT GUARD WORKED #750 bumped github/codeql-action/upload-sarif to v4.38.0. The workflow carries the new SHA; tests/scorecard-workflow.test.js carries the list of SHAs a person has actually checked, and nobody had checked this one, so it failed. That is the guard doing its job, not a stale test. Verified upstream before approving, the way the existing comment instructs: gh api repos/github/codeql-action/git/ref/tags/v4.38.0 -> annotated tag 4bd7200e1f146b1c937cae12d258b50f41a53cf8 gh api repos/github/codeql-action/git/tags/4bd7200e... -> commit b96794f015dfd88f77b49b1c93e0fa7110f94c63 which is the commit the workflow now pins. The comment records the commands and the trap: a signed release's refs/tags/vX points at a TAG OBJECT, so reading .object.sha off the ref approves the tag rather than the commit it names. API 10625 pass, desktop 2427 pass, both zero failures.
Contributor
|
Merged to Try it at https://develop.posnic.io, or run it yourself: git fetch origin develop && git checkout develop
npm install && npm --prefix api install
npm run dev # then http://localhost:3000When you have tested it, say what you did and what happened, and set Reporting that something is broken is as useful as fixing it. It is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
develophas been red since #749 merged, and every branch cut from it inheritsthe failure - which is why #745 came back red after its conflict was resolved.
Neither of these is a code fix. Both are decisions the automation is not allowed
to make on its own, and in one case the guard that stopped it was working
exactly as intended.
1. Mongoose 9.10 cannot talk to the test database
#749 moved mongoose
9.9.5→9.10.0inside a patch-and-minor group. Mongoose9.10 moves its bundled mongodb driver from
~7.5to~7.6, and the handshake7.6 sends is rejected outright by the mongod
mongodb-memory-serverruns:Line 39 is
await mongoose.connect(...). It is not a test that broke, it is theconnection - every suite that opens a database died in
beforeAll, which is whysix unrelated files failed at once and each took ~30s to give up.
Reproduced locally rather than guessed: installed 9.10.1 against mongod 8.2.6,
got the identical error, went back to 9.9.5, clean.
Held at
~9.9.5, which still accepts patches. Dependabot is told the range andthe reason, so it does not reopen the same pull request on Monday, and the note
says how to lift it: run the api suite against 9.10 or later, and if it connects,
widen back to a caret.
2. The codeql pin was never approved, and that guard worked
#750 bumped
github/codeql-action/upload-sarifto v4.38.0. The workflow carriesthe new SHA;
tests/scorecard-workflow.test.jscarries the SHAs a person hasactually verified, and nobody had verified this one.
That is the supply-chain guard doing its job. A bump arrives as a SHA plus a
trailing comment, and the comment is written by whoever opened the pull request,
not by the registry - so the test refuses to take the comment's word for it.
Verified upstream before approving, the way the existing comment instructs:
which is exactly the commit the workflow now pins, so the bump is genuine and is
approved here. The new comment records the commands and the trap worth
remembering: a signed release's
refs/tags/vXpoints at a tag object, soreading
.object.shaoff the ref approves the tag rather than the commit itnames.
Tests
API 10625 pass / 0 fail. Desktop 2427 pass / 0 fail.
Merge this first
It unblocks everything else. Once develop is green:
#745 and #747 both append to all seventeen language packs, so whichever goes
second needs a resolve; #744 and #746 touch no packs.