And drawing the channels screen does not depend on another namespace - #796
Merged
sridharkalaibala merged 1 commit intoSep 16, 2026
Merged
Conversation
salesChannels.load() called PosnicPro.settings.showSilenceRule(). The channels screen is lifted out and run on its own in tests/online-ordering-screen.test.js, where PosnicPro.settings does not exist, so load() threw on the reach across. Not only a harness problem. A load() that throws leaves Delivery Partners with no partners and Restaurant with no venues or charges - and collect() reads those same rows back out of the DOM, so the next Save would write the empty screen over the real ones. That is the shape of the channel settings split bug, arriving through a namespace instead of a tab id. So the helper moves onto the module whose screen the control is on, and its handler is bound beside the other channel-screen handlers.
Contributor
|
Merged to Try it at https://develop.posnic.io, or run it yourself: git fetch origin develop && git checkout develop
npm install && npm --prefix api install
npm run dev # then http://localhost:3000When you have tested it, say what you did and what happened, and set Reporting that something is broken is as useful as fixing it. It is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Develop's Desktop tests are red without this. #795 merged its first commit; this
was the second, and it did not travel. Two tests in
tests/online-ordering-screen.test.jsfail on develop right now.What broke
salesChannels.load()calledPosnicPro.settings.showSilenceRule(). The channelsscreen is lifted out and run on its own in that suite, where
PosnicPro.settingsdoesnot exist, so
load()threw on the reach across.Not only a harness problem. A
load()that throws leaves Delivery Partners with nopartners and Restaurant with no venues or charges - and
collect()reads those samerows back out of the DOM, so the next Save would write the empty screen over the real
ones. That is the shape of the channel-settings-split bug, arriving through a namespace
instead of a tab id.
The fix
The helper moves onto the module whose screen the control is actually on, and its
change handler is bound beside the other channel-screen handlers.
tests/online-ordering-screen.test.js21/21, and the settings, channel-roundtrip anddead-selector suites with it.