The kitchen files are packaged, or the installer cannot find them - #841
Merged
Merged
Conversation
The packaging check caught this on the promotion PR, which is exactly
where it is meant to: the three files added for the kitchen announcement
were required at runtime and absent from build.files.
src/order-alert.js requires src/kitchen-call.js
src/kot-manager.js requires src/kitchen-announce.js
src/main.js requires src/kitchen-announce.js
A packaged installer would have started and then failed with "Cannot find
module" on a customer machine, and nowhere else - not here, not in CI,
not on any machine running from source. That is the whole reason this
check exists, and the reason it runs before a release rather than after
one.
Found the night this was going to a client.
Contributor
|
Merged to Try it at https://develop.posnic.io, or run it yourself: git fetch origin develop && git checkout develop
npm install && npm --prefix api install
npm run dev # then http://localhost:3000When you have tested it, say what you did and what happened, and set Reporting that something is broken is as useful as fixing it. It is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is why POS#839 is failing Packaging checks. Merge this before the promotion.
The three files added for the kitchen announcement are required at runtime and were absent from
build.files:A packaged installer would have started and then failed with "Cannot find module" on a customer machine - and nowhere else. Not here, not in CI, not on any machine running from source. That is exactly what this check exists for, and why it runs before a release rather than after one.
After the fix:
Found on the night this was going to a client.