Skip to content

The ting and the voice are separate switches - #843

Merged
sridharkalaibala merged 2 commits into
developfrom
feat/the-ting-and-the-voice-are-separate
Sep 16, 2026
Merged

sridharkalaibala merged 2 commits into
developfrom
feat/the-ting-and-the-voice-are-separate

Conversation

@sridharkalaibala

Copy link
Copy Markdown
Contributor

"ting sound on/off read it on/off seperately?"

They are different things to a kitchen. The chime says a ticket landed and costs a second; the reading says what is on it and costs ten. A kitchen that knows to look at the printer wants the first and will come to resent the second. A kitchen whose printer is across the room wants both.

One switch would have made somebody choose between hearing nothing and hearing too much - and they would have chosen nothing. That is how an announcement feature ends up switched off in week two and blamed for not working.

posnic.kitchenCall.set({ ting: true })     // chime only
posnic.kitchenCall.set({ speak: true })    // and read it out
posnic.kitchenCall.get()                   // { ting, speak }

A value left out is left as it was, so turning the reading off does not silently take the chime with it.

Honoured before the payload is built, not in the page

A machine set to chime only is sent no words at all: nothing to ignore, nothing to go wrong in a speech engine, and nothing sitting in the payload that a later change could decide to speak.

A machine already set up keeps working

The single switch this replaces meant both. Somebody who turned it on yesterday must not fall silent because the setting grew a second half overnight - there is a test for exactly that.

✔ THE CHIME AND THE READING ARE SEPARATE SWITCHES
✔ a machine already set up in a kitchen does not fall silent
✔ a machine is SILENT until somebody says otherwise
✔ a settings file somebody broke by hand means silence, not noise

19 tests pass. Packaging gate green (51 modules), prettier clean.

Owner: "ting sound on/off read it on/off seperately?"

They are different things to a kitchen. The chime says a ticket has
landed and costs a second; the reading says what is on it and costs ten.
A kitchen that knows to look at the printer wants the first and will come
to resent the second, and a kitchen whose printer is across the room
wants both.

One switch would have made somebody choose between hearing nothing and
hearing too much, and they would have chosen nothing - which is how an
announcement feature ends up switched off in week two and blamed for not
working.

    posnic.kitchenCall.set({ ting: true })     chime only
    posnic.kitchenCall.set({ speak: true })    and read it out
    posnic.kitchenCall.get()                   { ting, speak }

A value left out is left as it was, so turning the reading off does not
silently take the chime with it.

HONOURED BEFORE THE PAYLOAD IS BUILT, not in the page. A machine set to
chime only is sent no words at all: nothing to ignore, nothing to go
wrong in a speech engine, and nothing sitting in the payload that a later
change could decide to speak.

A machine already set up with the single switch keeps both halves. It
meant both, and somebody who turned it on yesterday must not fall silent
because the setting grew a second half overnight.

Nineteen tests, including that one.
@sridharkalaibala
sridharkalaibala merged commit 8b5abea into develop Sep 16, 2026
9 checks passed
@github-actions github-actions Bot added the ready for QA Merged to develop and live on develop.posnic.io - anyone can test it label Sep 16, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Merged to develop. Anyone can test this - you do not need write access.

Try it at https://develop.posnic.io, or run it yourself:

git fetch origin develop && git checkout develop
npm install && npm --prefix api install
npm run dev   # then http://localhost:3000

When you have tested it, say what you did and what happened, and set
QA passed or QA failed. If you cannot set labels, just comment -
a maintainer will.

Reporting that something is broken is as useful as fixing it. It is
better found here than by a shopkeeper.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for QA Merged to develop and live on develop.posnic.io - anyone can test it

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant