The ting and the voice are separate switches - #843
Merged
sridharkalaibala merged 2 commits intoSep 16, 2026
Merged
Conversation
dev to main
Owner: "ting sound on/off read it on/off seperately?"
They are different things to a kitchen. The chime says a ticket has
landed and costs a second; the reading says what is on it and costs ten.
A kitchen that knows to look at the printer wants the first and will come
to resent the second, and a kitchen whose printer is across the room
wants both.
One switch would have made somebody choose between hearing nothing and
hearing too much, and they would have chosen nothing - which is how an
announcement feature ends up switched off in week two and blamed for not
working.
posnic.kitchenCall.set({ ting: true }) chime only
posnic.kitchenCall.set({ speak: true }) and read it out
posnic.kitchenCall.get() { ting, speak }
A value left out is left as it was, so turning the reading off does not
silently take the chime with it.
HONOURED BEFORE THE PAYLOAD IS BUILT, not in the page. A machine set to
chime only is sent no words at all: nothing to ignore, nothing to go
wrong in a speech engine, and nothing sitting in the payload that a later
change could decide to speak.
A machine already set up with the single switch keeps both halves. It
meant both, and somebody who turned it on yesterday must not fall silent
because the setting grew a second half overnight.
Nineteen tests, including that one.
Contributor
|
Merged to Try it at https://develop.posnic.io, or run it yourself: git fetch origin develop && git checkout develop
npm install && npm --prefix api install
npm run dev # then http://localhost:3000When you have tested it, say what you did and what happened, and set Reporting that something is broken is as useful as fixing it. It is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They are different things to a kitchen. The chime says a ticket landed and costs a second; the reading says what is on it and costs ten. A kitchen that knows to look at the printer wants the first and will come to resent the second. A kitchen whose printer is across the room wants both.
One switch would have made somebody choose between hearing nothing and hearing too much - and they would have chosen nothing. That is how an announcement feature ends up switched off in week two and blamed for not working.
A value left out is left as it was, so turning the reading off does not silently take the chime with it.
Honoured before the payload is built, not in the page
A machine set to chime only is sent no words at all: nothing to ignore, nothing to go wrong in a speech engine, and nothing sitting in the payload that a later change could decide to speak.
A machine already set up keeps working
The single switch this replaces meant both. Somebody who turned it on yesterday must not fall silent because the setting grew a second half overnight - there is a test for exactly that.
19 tests pass. Packaging gate green (51 modules), prettier clean.