A sync that existed on paper only - #851
Merged
Merged
Conversation
The waiter-call feature marked its collection synced the day it shipped. Nothing built the lane: the sync agent has none, the sync-gateway allows none, and no build since has carried one. A call from a table on the ordering page lands in the cloud and a till with its own database never sees it. The packaging guard compared the promise with the bundle and refused the build, which is what it is for. This records the truth: waitercalls is undecided, with what it will take to sync it written next to it. The classification test now names it among the undecided instead of the promised.
Merged
Contributor
|
Merged to Try it at https://develop.posnic.io, or run it yourself: git fetch origin develop && git checkout develop
npm install && npm --prefix api install
npm run dev # then http://localhost:3000When you have tested it, say what you did and what happened, and set Reporting that something is broken is as useful as fixing it. It is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
api/src/sync/collections.jsonpromisedwaitercallssyncs per branch. No lane was ever built: the sync agent'ssync-config.jsonhas none, the sync-gateway allows none, no Gateway branch has ever mentioned it. The packaging guard (scripts/prepare-sync-agent.js) compared the promise with the bundle and refused tonight's build, exactly as designed.This PR records the truth:
waitercallsmoves fromsyncedtoundecided, with its consequence and what syncing it will take written beside it. The classification test now prints it among the 21 undecided collections instead of hiding it among the promised.What this means for the feature
A table's call from the ordering page lands in the cloud tenant database. The till's request dock reads calls through the till's own API, so a shop running a desktop till never sees the call. That was already true; this PR does not change behaviour, it stops the build claiming otherwise.
To actually sync it (separate decision, Gateway repo + cloud deploy): a lane in the agent, the collection allowed by the sync-gateway, a check that rows carry
branch_idandlicense, and a tombstone on close.Tests
tests/sync-classification.test.js5/5.node scripts/prepare-sync-agent.js: "the agent syncs every collection the app promises (22)".