Promote develop to main: a publish that builds what it ships - #857
Merged
Merged
Conversation
frontend/public/ is gitignored build output, so whatever is on the packaging machine's disk when electron-builder runs is what goes into the exe. Every build variant guards that with a prebuild step that calls prepare:bundle, which runs the gulp build and then refuses to continue if the artifacts are older than the run. publish had no such step. One script out of eight, and it is the one that makes the installer customers receive. What that cost today: an exe carrying a current main process - the kitchen announcement, the tone, the preload bridge, all correct - and a dashboard bundle built before the renderer half of that feature existed. The main process sent posnic:kitchen-call to a page where nothing was listening, so the kitchen stayed silent. Every file was present on disk; one was simply older than the code that needed it. Nothing failed and nothing logged, and the feature looked shipped. The test asserts the rule rather than that one script, because the next variant somebody adds will be added the way the last one was.
…-ships A publish that builds what it ships
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two commits, and
mainneeds them before the installer is re-staged.The exe is built from
main.maincurrently still has:which is the line that shipped tonight's silent installer.
frontend/public/is gitignored build output, so that script packages whatever happens to be on the packaging machine's disk. Every other build variant runsprepare:bundlefirst, which rebuilds the frontend and refuses to continue if the artifacts are older than the run.So re-staging from
mainas it stands can reproduce the exact fault that made the kitchen silent: a current main process packaged with adashboard.jsolder than the code that needs it.Carries
A publish that builds what it ships(A publish that builds what it ships #856): the one-line fix, plustests/a-build-builds-what-it-ships.test.jswhich asserts the rule for every script that invokes electron-builder rather than for that one script, since the next variant will be added the way the last one was.After this
Re-stage with
npm run buildornpm run publish. Either is now correct, andprepare-frontendwill fail the build rather than ship a stale bundle.Do not squash. A squashed release PR conflicts with the next one.