Make the checker executable, as its shebang promises - #861
Merged
Merged
Conversation
Contributor
|
Merged to Try it at https://develop.posnic.io, or run it yourself: git fetch origin develop && git checkout develop
npm install && npm --prefix api install
npm run dev # then http://localhost:3000When you have tested it, say what you did and what happened, and set Reporting that something is broken is as useful as fixing it. It is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
developis red. #858 merged at its first head, before this one-line fix, soscripts/check-installed-app.jsis ondevelopas100644while carrying#!/usr/bin/env node.tests/executable-scripts.test.jspins that a committed script with a shebang is also executable, and it is right to: a shebang is a promise that the file can be run directly, and a file that cannot is a promise broken in the one situation where somebody is already debugging something else.This is
git update-index --chmod=+xand nothing else. Verified locally:For the record on how it got in: the fix existed and was pushed as
1edec3ab, but GitHub never triggered CI for that push and kept reporting the older head, so the PR was merged on the strength of a stale page. That is the third time today a merge has taken a head older than what was pushed, which is worth knowing when merging soon after a push.