The kitchen's speaker lives with the kitchen

[sridharkalaibala]

"this is about kitchen play right? not restaurant module?"

Right, and it took three goes to get this in the correct place.

1. Sale tab of Core Settings, beside the auto-focus switches, because those are device-local too
2. Print tab, because the kitchen ticket is printed
3. Hardware Manager, where it belongs

Per-device was the right instinct and the wrong page both times. A speaker is a device on one computer, like the cash drawer, the weighing scale and the kitchen screen. Hardware Manager is where those live, and it is the window somebody setting up the machine at the pass is already standing in.

So it is a 🔔 Kitchen Sound tab, immediately after 📺 Kitchen Screen:

  Ring a bell                      switch
  Read the order out               switch
  Bell when the order arrives      picker + Play
  Bell before each dish            picker + Play
  Voice                            picker + Play
  Test the sound                   button

Not the Multi KOT Print tab, which would have been the obvious guess. That one is hidden unless multi-KOT is enabled, and a setting that disappears depending on another setting is exactly how this feature spent its whole life switched off and unfindable.

Removed from the settings page, not left in both

Two homes drift apart and then a shop has two answers to one question. A comment stays behind on both files saying where it went and why, because the next person will wonder.

The hard-won part is carried over rather than re-learned: the switches are set before anything that can fail, and the pickers fill inside their own guard. On the settings page, filling the voice picker threw, the failure path hid the switches and the Test button, and left three empty pickers on screen.

A guard caught me

tests/settings-windows.test.js failed on this while I was writing it:

switchTab('sound') has no entry in tabMap. switchTab hides every panel before
showing the requested one, so an unmapped name blanks the window - which is
exactly what Receipt Printer did.

Clicking the new tab would have blanked the whole window. Somebody wrote that test after being bitten, and it caught the next person, which is the entire point of writing them that way.

Tests

tests/the-kitchen-switch-has-somewhere-to-live.test.js rewritten for the new home, 11 of them: the switches exist and are two rather than one, they show what the machine is set to, they are set before anything that can fail, the tab hides itself where there is no bridge, the Test button reaches the real announcer and says why when nothing happened, and the controls are really gone from the settings page rather than living in two places.

Zero assertion failures across the desktop suite.

[github-actions]

Merged to develop. Anyone can test this - you do not need write access.

Try it at https://develop.posnic.io, or run it yourself:

git fetch origin develop && git checkout develop
npm install && npm --prefix api install
npm run dev   # then http://localhost:3000

When you have tested it, say what you did and what happened, and set
QA passed or QA failed. If you cannot set labels, just comment -
a maintainer will.

Reporting that something is broken is as useful as fixing it. It is
better found here than by a shopkeeper.