Set the version to 1.2.30 - #131
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v1.2.29 shipped the network work. This is the one that carries the sold-out gesture to the handsets, which v1.2.29 correctly does not contain.
What the handsets get on top of 1.2.29
A waiter says it has run out. A long press on a dish takes it off the menu for the rest of today, and the same press puts it back. The kitchen tells the floor before it tells anybody with a keyboard, and until now a waiter who heard "no more fish" had to find whoever runs the till while three more tables ordered it.
The sheet names the dish, the button says what will happen rather than OK, and it says for how long: the till records the day rather than a stock level, so tomorrow starts clean without anybody remembering to undo it.
It had been written and unshipped because the handset half called
POSNIC.askRunOut(product)and that function did not exist, so the long press returned early and did nothing while the till endpoint sat live and uncalled. The sheet is now written and covered by 18 tests, verified failing with it removed.Verification
454 unit tests and 326 browser tests through the pre-commit hook.
After merging, tag
v1.2.30to build and publish the APK and IPA.