Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Aug 6, 2026. It is now read-only.
fix(code): fix truncated diff preview - #1235
Merged
Merged
Conversation
ContributorAuthor
This was referenced Mar 13, 2026
adboioforce-pushed
the
03-13-fix_code_fix_truncated_diff_preview
branch
4 times, most recently
from
March 13, 2026 22:02
97bc735 to
8cb44e0Compareadboio
marked this pull request as ready for review
March 13, 2026 22:05
charlesvien
approved these changes
Mar 14, 2026
Member
Merge activity
|
charlesvien
changed the base branch from
03-13-feat_code_improve_pasted_text_ux
to
graphite-base/1235March 14, 2026 19:27
charlesvienforce-pushed
the
03-13-fix_code_fix_truncated_diff_preview
branch
from
March 14, 2026 19:32
8cb44e0 to
e4e2ba6CompareUh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

problem
diff viewer is a little broken - mostly because sometimes the tool output is too large, causing the "diff preview content" to be something like this:
when this happens, 1) it looks bad, 2) the stats are computed incorrectly as
+0 -0, and 3) just means you can’t actually view the diffalso, the diff sometimes doesn't work if it's a delete-only, because we only check
newTextwhen rendering the diffchanges
EditToolViewto checkoldText || newTextto determine if there is a diff, instead of onlynewTexttoolInfoFromToolUseto build the diff by: