Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Aug 6, 2026. It is now read-only.
feat: Add fullscreen expand to plan preview - #1793
Merged
Merged
Conversation
MemberAuthor
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Apr 22, 2026
charlesvienforce-pushed
the
04-21-add_fullscreen_expand_to_plan_preview
branch
from
April 22, 2026 00:37
6cdea85 to
d0a4b67Comparecharlesvienforce-pushed
the
04-21-replace_email_cta_with_discord_link_in_readme
branch
from
April 22, 2026 00:41
bc525e6 to
20a7ee1Comparecharlesvienforce-pushed
the
04-21-add_fullscreen_expand_to_plan_preview
branch
2 times, most recently
from
April 22, 2026 00:47
d4fec55 to
f6b3492Comparecharlesvien
marked this pull request as ready for review
April 22, 2026 00:47
Contributor
Prompt To Fix All With AIThis is a comment left during a code review.
Path: apps/code/src/renderer/components/permissions/PlanContent.tsx
Line: 19-37
Comment:
**Scroll tracking breaks after mode toggle**
The scroll `useEffect` depends only on `[id]`, so when `isFullscreen` flips and `scrollRef.current` is re-bound to a different DOM node, the effect never re-runs. The listener stays on the stale (now detached) element: scroll events in the new mode go untracked, and `el.scrollTop = position` (position restoration) never fires for the newly mounted element. This directly breaks the PR's stated goal of preserving scroll position across mode toggles.
Add `isFullscreen` to the dependency array so the effect re-attaches to whichever element is currently active:
```suggestion useEffect(() => { const el = scrollRef.current; if (!el) return; const position = planScrollPosition.get(id); if (position !== undefined) { el.scrollTop = position; } const handleScroll = () => { planScrollPosition.set(id, el.scrollTop); }; el.addEventListener("scroll", handleScroll, { passive: true }); return () => { el.removeEventListener("scroll", handleScroll); }; }, [id, isFullscreen]);```
How can I resolve this? If you propose a fix, please make it concise.
---
This is a comment left during a code review.
Path: apps/code/src/renderer/components/permissions/PlanContent.tsx
Line: 72-75
Comment:
**Superfluous opacity transition**`transition: "opacity 150ms ease"` is set on the fullscreen overlay, but nothing in the code ever changes the element's `opacity`. The transition never fires, making this a no-op style property. Per simplicity rule #4, superfluous parts should be removed.
```suggestion <Box className="pointer-events-auto absolute inset-0 flex flex-col bg-gray-1" >```
How can I resolve this? If you propose a fix, please make it concise.Reviews (1): Last reviewed commit: "Add fullscreen expand to plan preview" | Re-trigger Greptile |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
charlesvienforce-pushed
the
04-21-add_fullscreen_expand_to_plan_preview
branch
from
April 22, 2026 01:37
774bd27 to
2c49b8aComparecharlesvienforce-pushed
the
04-21-replace_email_cta_with_discord_link_in_readme
branch
2 times, most recently
from
April 22, 2026 01:40
1c25914 to
1d1d68aComparecharlesvienforce-pushed
the
04-21-add_fullscreen_expand_to_plan_preview
branch
2 times, most recently
from
April 22, 2026 01:47
c41e432 to
e7f9eecComparecharlesvienforce-pushed
the
04-21-replace_email_cta_with_discord_link_in_readme
branch
from
April 22, 2026 01:47
1d1d68a to
960e351Comparecharlesvienforce-pushed
the
04-21-add_fullscreen_expand_to_plan_preview
branch
from
April 22, 2026 01:54
e7f9eec to
c1caeb1Comparecharlesvienforce-pushed
the
04-21-replace_email_cta_with_discord_link_in_readme
branch
from
April 22, 2026 01:54
960e351 to
355c40eComparecharlesvienforce-pushed
the
04-21-add_fullscreen_expand_to_plan_preview
branch
2 times, most recently
from
April 22, 2026 03:33
341d9ba to
f8c34d6Comparecharlesvienforce-pushed
the
04-21-replace_email_cta_with_discord_link_in_readme
branch
from
April 22, 2026 03:33
58add1c to
07d21c3Comparecharlesvienforce-pushed
the
04-21-add_fullscreen_expand_to_plan_preview
branch
from
April 22, 2026 03:55
f8c34d6 to
e951a1cComparecharlesvienforce-pushed
the
04-21-replace_email_cta_with_discord_link_in_readme
branch
2 times, most recently
from
April 22, 2026 05:11
665aa02 to
4ce9fb9Comparecharlesvienforce-pushed
the
04-21-add_fullscreen_expand_to_plan_preview
branch
from
April 22, 2026 05:11
e951a1c to
46afbffComparecharlesvienforce-pushed
the
04-21-replace_email_cta_with_discord_link_in_readme
branch
from
April 22, 2026 05:13
4ce9fb9 to
9ac73f9Comparecharlesvienforce-pushed
the
04-21-add_fullscreen_expand_to_plan_preview
branch
2 times, most recently
from
April 22, 2026 05:21
33ec432 to
2cd556eComparecharlesvienforce-pushed
the
04-21-add_fullscreen_expand_to_plan_preview
branch
from
April 22, 2026 05:43
482daea to
5805fdcComparecharlesvienforce-pushed
the
04-21-replace_email_cta_with_discord_link_in_readme
branch
from
April 22, 2026 05:43
62e41e9 to
117493aComparecharlesvienforce-pushed
the
04-21-add_fullscreen_expand_to_plan_preview
branch
from
April 22, 2026 08:03
5805fdc to
2c40ec6Comparecharlesvienforce-pushed
the
04-21-replace_email_cta_with_discord_link_in_readme
branch
from
April 22, 2026 08:03
117493a to
d8f6b3fComparejonathanlab
approved these changes
Apr 22, 2026
charlesvienforce-pushed
the
04-21-add_fullscreen_expand_to_plan_preview
branch
from
April 22, 2026 15:19
2c40ec6 to
3cef1dcComparecharlesvienforce-pushed
the
04-21-replace_email_cta_with_discord_link_in_readme
branch
from
April 22, 2026 15:23
caa2d1f to
54cf08cComparecharlesvienforce-pushed
the
04-21-add_fullscreen_expand_to_plan_preview
branch
from
April 22, 2026 15:23
3cef1dc to
5000b46Comparecharlesvienforce-pushed
the
04-21-replace_email_cta_with_discord_link_in_readme
branch
from
April 22, 2026 15:24
54cf08c to
84c86acComparecharlesvienforce-pushed
the
04-21-add_fullscreen_expand_to_plan_preview
branch
from
April 22, 2026 15:24
5000b46 to
1425b23Comparecharlesvienforce-pushed
the
04-21-replace_email_cta_with_discord_link_in_readme
branch
from
April 22, 2026 22:33
84c86ac to
00930cfComparecharlesvienforce-pushed
the
04-21-add_fullscreen_expand_to_plan_preview
branch
2 times, most recently
from
April 22, 2026 22:33
a00a5d1 to
e3a4882Comparecharlesvienforce-pushed
the
04-21-replace_email_cta_with_discord_link_in_readme
branch
2 times, most recently
from
April 23, 2026 00:33
7068bcf to
e72353aComparecharlesvienforce-pushed
the
04-21-add_fullscreen_expand_to_plan_preview
branch
from
April 23, 2026 00:33
e3a4882 to
b08c6ecComparecharlesvienforce-pushed
the
04-21-replace_email_cta_with_discord_link_in_readme
branch
from
April 23, 2026 01:27
e72353a to
02e7190Comparecharlesvienforce-pushed
the
04-21-add_fullscreen_expand_to_plan_preview
branch
from
April 23, 2026 01:27
b08c6ec to
578c274Comparecharlesvienforce-pushed
the
04-21-add_fullscreen_expand_to_plan_preview
branch
from
April 23, 2026 01:31
578c274 to
dc01db2CompareMemberAuthor
Merge activity
|
charlesvien
changed the base branch from
04-21-replace_email_cta_with_discord_link_in_readme
to
graphite-base/1793April 23, 2026 01:40
charlesvienforce-pushed
the
04-21-add_fullscreen_expand_to_plan_preview
branch
from
April 23, 2026 01:41
dc01db2 to
5a6cff4CompareUh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Problem
Plan previews are capped at 50vh, making long plans hard to read in full.
Closeshttps://github.com/PostHog/code/issues/1743
See below the screen of the inline plan preview (in blue) with the expand button on the top right of the plan and the expanded plan view (the first image).
Changes
How did you test this?
Manually