Uh oh!
There was an error while loading. Please reload this page.
feat(agent): Sync Claude ACP adapter with upstream v0.42.0 - #2513
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
What T-Rex did
ArtifactsVerbose output from 29 generated targeted tests
Existing model test suite output
Generated SDK-to-ACP conversion tests
Verbose output from 29 T-Rex-generated tests
Existing model test suites pass with no regressions
Prompt To Fix All With AIFix the following 3 code review issues. Work through them one at a time, proposing concise fixes.
---### Issue 1 of 3
packages/agent/src/adapters/claude/claude-agent.ts:1050-1074
**Use ACP session id**
These new updates are sent with `message.session_id`, but the client routes ACP notifications by the active ACP session id. In this adapter those ids can differ because the adapter creates its own ACP session id and the SDK message carries the Claude SDK session id. When a long-running tool emits progress, the update can be sent to a session the client is not rendering, so the visible tool call keeps looking stalled. The same applies to the rate-limit update.
### Issue 2 of 3
packages/agent/src/adapters/claude/conversion/sdk-to-acp.ts:795-797
**Route denial updates correctly**
This sends the permission-denied tool update to the SDK session id instead of the ACP session id from `context`. The original tool call is emitted under the ACP session, so when a permission rule denies the tool, the failure update can be dropped or routed elsewhere. The user then sees a tool call that never resolves instead of the permission-denied message.
### Issue 3 of 3
packages/agent/src/adapters/claude/claude-agent.ts:626-634
**Refresh skills baseline**
This mid-session command update refreshes the visible command list, but it skips the same skills-token baseline update done by `sendAvailableCommandsUpdate`. When skills or plugin commands are discovered during a session, the command list changes while the context breakdown keeps the old skills estimate. Later usage breakdown notifications can show stale skills context even though the session has the new commands.
Reviews (1): Last reviewed commit: "update claude adapter with upstream" | Re-trigger Greptile |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
8c6bc8d to
fec00b8Comparec7bf83f to
c505ae8Comparefec00b8 to
a51aca3Comparec505ae8 to
978596dCompareReact Doctor found no issues in the changed files. 🎉 Reviewed by React Doctor for commit |
a51aca3 to
da4b88aCompare978596d to
f71d76fCompareda4b88a to
043b491Comparef71d76f to
e3e9e87CompareUh oh!
There was an error while loading. Please reload this page.
043b491 to
dacc643Comparee3e9e87 to
576a55bComparedacc643 to
ae78cadCompareMerge activity
|
Uh oh!
There was an error while loading. Please reload this page.

Problem
Our fork of @anthropic-ai/claude-agent-acp lagged upstream by three releases (v0.39→v0.42), missing SDK fixes (Opus refusal handling, wedged-cancel hangs) and a breaking ACP SDK model-API removal.
Changes
How did you test this?
Manually
Automatic notifications