Uh oh!
There was an error while loading. Please reload this page.
Restore true 0.1.0 SQL; move default_version to 'stable' - #12
Conversation
sql/object_reference--0.1.0.sql had drifted from the actual PGXN-published 0.1.0 release: default_version was never bumped past 0.1.0 despite years of ongoing development, so pgxntool's build kept regenerating this "frozen" file from the current, ever-changing sql/object_reference.sql instead of it staying a true historical record. Verified against the real distribution downloaded from PGXN (pgxn download object_reference==0.1.0 --unstable) and restored its actual content. default_version is now 'stable', a non-numeric version alias -- supported since pgxntool 2.2.0 fixed extract_version_from_filename() to stop rejecting aliases like this (Postgres-Extensions/pgxntool#57). This avoids picking an arbitrary next semver number and lets the "current" version track ongoing development under a stable name instead. Verified end-to-end on PG12: `make`, `make install`, `make pgtle`, and CREATE EXTENSION ... CASCADE all work correctly with default_version = 'stable'; `make test` shows no new failures versus plain master (the only diffs are pre-existing, unrelated to this change: cat_tools deprecation-warning noise from a locally-built newer cat_tools, and a pre-existing gap where partitioned table/index aren't yet covered by the "all object types" test).
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
fd2bde6
into
Postgres-Extensions:masterUh oh!
There was an error while loading. Please reload this page.
Summary
sql/object_reference--0.1.0.sqlhad drifted from the actual PGXN-published 0.1.0 release, sincedefault_versionwas never bumped past 0.1.0 despite substantial ongoing development -- pgxntool's build kept regenerating this supposedly-frozen file from the currentsql/object_reference.sql. Downloaded the real 0.1.0 distribution from PGXN (pgxn download object_reference==0.1.0 --unstable) and restored its actual content as the true historical record.default_versionto'stable', a non-numeric version alias -- supported since pgxntool 2.2.0 fixedextract_version_from_filename()to stop rejecting aliases like this (pgtle.sh: extract_version_from_filename() rejects non-numeric version aliases like 'stable' pgxntool#57). Avoids picking an arbitrary next semver number for ongoing development.Test plan
sql/object_reference--0.1.0.sqlagainst the real PGXN 0.1.0 distributionmake,make install,make pgtleall work correctly withdefault_version = 'stable'CREATE EXTENSION object_reference CASCADEworks and reports versionstablein\dxmake teston PG12: no new failures vs. plainmaster-- remaining diffs are pre-existing and unrelated (cat_tools deprecation-warning noise from a locally-built newer cat_tools since PGXN's published cat_tools is stuck at a broken 0.2.1; a pre-existing gap where partitioned table/index aren't yet covered by the "all object types" test)