Uh oh!
There was an error while loading. Please reload this page.
Improved reliability of some tests - #4686
Merged
Dongbo Wang (daxian-dbw) merged 4 commits intoApr 17, 2025
Merged
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Dongbo Wang (daxian-dbw)
approved these changes
Apr 17, 2025
Steven Bucher (StevenBucher98)
self-requested a review
April 17, 2025 18:04
Steven Bucher (StevenBucher98)
approved these changes
Apr 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
TL;DR;
This pull request suggests an improvement to the
TestSetup()method to initialize some data members that are used in some tests that would otherwise fail.Summary
Some tests around history, prediction and suggestion – are failing on the local machine due to the
PSConsoleReadLine._historymember not being initialized.This member is initialized the first time the
PSConsoleReadLine.ReadLine()method is called, which happens in theTestmethod overloads.However, some tests perform actions between the
TestSetup()and theTest()methods. For instance, the following test fails because the_historymember is not initialized:List_RenderSuggestion_UpdatesWhileTyping:
PR Checklist
Microsoft Reviewers: Open in CodeFlow