Uh oh!
There was an error while loading. Please reload this page.
Fix custom key binding on Windows - #657
Merged
Merged
Conversation
Jason Shirk (lzybkr)
approved these changes
Mar 25, 2018
Staffan Gustafsson (powercode) pushed a commit
to powercode/PSReadLine
that referenced
this pull request
Apr 9, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix#580
Attempt to fix the custom key binding on Windows.
On Linux, the
Modifiersof theConsoleKeyInforead in fromConsole.ReadKey()sometimes is0, even though thectrlkey is pressed, for example, this happens forctrl+[,ctrl+],ctrl+hand more others.Therefore, this PR is only to fix the custom key binding on Windows.