Uh oh!
There was an error while loading. Please reload this page.
Enable IDE0005 (unneccessary using statements) as error - #1759
Merged
Conversation
Andy Jordan (andyleejordan)
requested a review
from Patrick Meinecke (SeeminglyScience)April 18, 2022 17:48
Andy Jordan (andyleejordan)
marked this pull request as draft
April 18, 2022 17:57
Andy Jordan (andyleejordan)
commented
Apr 18, 2022
MemberAuthor
Interesting...passed locally, looks like in other configs though I need to clean up some using statements! And disable a bunch of XML warnings I don't care about. Converted to draft. |
Andy Jordan (andyleejordan)force-pushed
the
andschwa/fix-ide0005
branch
2 times, most recently
from
April 20, 2022 20:14
5e991a4 to
d664e81CompareDue to a quirk in how `msbuild` runs rules, documentation generation must be enabled for this rule (and presumably others) to be respected.
Andy Jordan (andyleejordan)force-pushed
the
andschwa/fix-ide0005
branch
from
April 20, 2022 20:17
d664e81 to
bf8a482CompareAndy Jordan (andyleejordan)
marked this pull request as ready for review
April 20, 2022 20:28
Patrick Meinecke (SeeminglyScience)
approved these changes
Apr 20, 2022
Patrick Meinecke (SeeminglyScience)
left a comment
Collaborator
There was a problem hiding this comment.
Awesome :) LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to a quirk in how
msbuildruns rules, documentation generationmust be enabled for this rule (and presumably others) to be respected.
See dotnet/roslyn#22579.
Fixes#1479.