Skip to content

[WIP] Simplify inherited IDisposable logic due to Serilog - #2335

Draft
Andy Jordan (andyleejordan) with Copilot wants to merge 2 commits into
mainfrom
copilot/simplify-idisposable-logic
Draft

[WIP] Simplify inherited IDisposable logic due to Serilog#2335
Andy Jordan (andyleejordan) with Copilot wants to merge 2 commits into
mainfrom
copilot/simplify-idisposable-logic

Conversation

CopilotAI commented Aug 6, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor
  • Trace the inherited disposal chain and shutdown ownership
  • Remove no-op factory disposal and cascading IDisposable implementations
  • Add or adjust focused regression coverage if appropriate (no test added for removal-only API cleanup)
  • Build and run targeted tests (blocked by unavailable NuGet package downloads)
  • Review changes and run security validation

CopilotAI balanced review requested due to automatic review settings August 6, 2026 18:30
CopilotAI reviewed Aug 6, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

CopilotAI linked an issue Aug 6, 2026 that may be closed by this pull request
Simplify inherited IDisposable logic due to Serilog #1477
Open
@andyleejordan
Remove obsolete IDisposable chain
6ce4e84
Co-authored-by: andyleejordan <2226434+andyleejordan@users.noreply.github.com>
CopilotAI reviewed Aug 6, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

Comment threadsrc/PowerShellEditorServices.Hosting/EditorServicesLoader.cs
/// in a way that separates its dependencies from the calling context.
/// </summary>
public sealed class EditorServicesLoader : IDisposable
public sealed class EditorServicesLoader
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code reviewCopilot
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@andyleejordanAndy Jordan (andyleejordan)Awaiting requested review from andyleejordan

At least 1 approving review is required to merge this pull request.

Assignees

@andyleejordanAndy Jordan (andyleejordan)

Copilot code reviewCopilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Simplify inherited IDisposable logic due to Serilog

3 participants

@andyleejordan