Uh oh!
There was an error while loading. Please reload this page.
Add MRMediaRemoteRequestNowPlayingPlaybackQueueForPlayerSync - #4
Open
DimitarNestorov wants to merge 3 commits into
Open
Add MRMediaRemoteRequestNowPlayingPlaybackQueueForPlayerSync#4DimitarNestorov wants to merge 3 commits into
MRMediaRemoteRequestNowPlayingPlaybackQueueForPlayerSync#4DimitarNestorov wants to merge 3 commits into
Conversation
DimitarNestorovforce-pushed
the
request-now-playing-playback-queue-for-player
branch
from
December 29, 2022 18:25
2cf0217 to
1f1c90cCompare| if (@available(macOS 10.15, *)) { | ||
| XCTAssertTrue([((NSObject *)client).className isEqualToString:@"MRClient"]); | ||
| } else { | ||
| XCTAssertTrue([((NSObject *)client).className isEqualToString:@"_MRNowPlayingClientProtobuf"]); |
ContributorAuthor
There was a problem hiding this comment.
Confirm this on Mojave, High Sierra, and Sierra. Also figure out iOS, watchOS, and tvOS versions.
| #import <os/availability.h> | ||
| #import <PrivateProtocolBuffer/PrivateProtocolBuffer.h> | ||
| API_AVAILABLE(macos(10.15)) |
ContributorAuthor
There was a problem hiding this comment.
Figure out iOS, watchOS, and tvOS versions.
MRClient and modify _MRNowPlayingClientProtobufMRMediaRemoteRequestNowPlayingPlaybackQueueForPlayerSyncDimitarNestorovforce-pushed
the
request-now-playing-playback-queue-for-player
branch
from
December 30, 2022 00:49
90780da to
302fbf3Compare| XCTestExpectation *expectation = [self expectationWithDescription:@"MRMediaRemoteRequestNowPlayingPlaybackQueueForPlayerSync"]; | ||
| (*func)(nil, nil, dispatch_get_main_queue(), ^(id queue, NSError *error) { | ||
| XCTAssertNotNil(queue, @"`queue` is `nil` when calling `MRMediaRemoteRequestNowPlayingPlaybackQueueForPlayerSync`. Play some music for this test to pass."); | ||
| XCTAssertNil(error); |
DimitarNestorovforce-pushed
the
request-now-playing-playback-queue-for-player
branch
from
January 10, 2023 05:27
302fbf3 to
40d5403CompareDimitarNestorovforce-pushed
the
request-now-playing-playback-queue-for-player
branch
from
January 15, 2023 22:45
7f8eeef to
d231c7aCompare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.