Skip to content

Feat/get user by Id - #117

Merged
kaitoz11 merged 3 commits into
devfrom
feat/get-user-by-id
Jun 1, 2023
Merged

Feat/get user by Id#117
kaitoz11 merged 3 commits into
devfrom
feat/get-user-by-id

Conversation

@vzart

@vzartvzart commented May 30, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@vzartvzart added the enhancement New feature or request label May 30, 2023
@vzartvzart added this to the Iteration 2 milestone May 30, 2023
@vzart
vzart requested a review from StarryFolfMay 30, 2023 12:54
@vzartvzart self-assigned this May 30, 2023
@vzartvzart linked an issue May 30, 2023 that may be closed by this pull request
Get user by Id #118
Closed
StarryFolf
StarryFolf approved these changes Jun 1, 2023
View reviewed changes

@StarryFolfStarryFolf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kaitoz11
kaitoz11 suggested changes Jun 1, 2023
View reviewed changes

@kaitoz11kaitoz11 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

excuse me!

Comment threadsrc/Application/Users/Queries/GetUserById.cs Outdated
Comment threadtests/Application.Tests.Integration/Users/Queries/GetUserByIdTests.cs Outdated
kaitoz11
kaitoz11 approved these changes Jun 1, 2023
View reviewed changes

@kaitoz11kaitoz11 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kaitoz11
kaitoz11 merged commit 22aebca into devJun 1, 2023
@ChienNQuang
ChienNQuang deleted the feat/get-user-by-id branch July 3, 2023 05:05
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@kaitoz11kaitoz11kaitoz11 approved these changes
@StarryFolfStarryFolfStarryFolf approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@vzartvzart

Labels

enhancementNew feature or request

Projects

None yet

Milestone

Iteration 2

Development

Successfully merging this pull request may close these issues.

Get user by Id

4 participants

@vzart@kaitoz11@StarryFolf@ChienNQuang