FOUR-20912: Enhance Test Coverage for Screens Functionality Before Adding Cache

[rodriquelca]

…dding Cache

Issue & Reproduction Steps

As a developer I want to improve test coverage for tests/Feature/Screens/ScreenCompiledManagerTest.php test

Solution

• refactor get key test
• add exception tests
• add empty compile content test
• add clear assets when the directory does not exist

How to Test

run the next command s
// run the test php artisan test --filter=ScreenCompiledManagerTest // check coverage vendor/bin/phpunit --coverage-html coverage-report tests/Feature/Screens/ScreenCompiledManagerTest.php

Related Tickets & Packages

• https://processmaker.atlassian.net/browse/FOUR-20912

Code Review Checklist

• I have pulled this code locally and tested it on my instance, along with any associated packages.
• This code adheres to ProcessMaker Coding Guidelines.
• This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
• This solution fixes the bug reported in the original ticket.
• This solution does not alter the expected output of a component in a way that would break existing Processes.
• This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
• This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
• This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
• This ticket conforms to the PRD associated with this part of ProcessMaker.

[caleeli]

Add a negative test, when the storage fails. Something like:

/** @test */
public function it_handles_storage_limit_scenarios()
{
// Mock storage reaching its limit
Storage::shouldReceive('disk->put')
->andThrow(new \Illuminate\Contracts\Filesystem\FileNotFoundException());
$key = $this->manager->createKey('1', '1', 'en', '1', '1');
$this->expectException(\Exception::class);
$this->manager->storeCompiledContent($key, ['test' => 'content']);
}

[rodriquelca]

…dding Cache

Issue & Reproduction Steps

As a developer I want to improve test coverage for tests/Feature/Screens/ScreenCompiledManagerTest.php test

Solution

• refactor get key test
• add exception tests
• add empty compile content test
• add clear assets when the directory does not exist

How to Test

run the next command s
// run the test php artisan test --filter=ScreenCompiledManagerTest // check coverage vendor/bin/phpunit --coverage-html coverage-report tests/Feature/Screens/ScreenCompiledManagerTest.php

Related Tickets & Packages

• https://processmaker.atlassian.net/browse/FOUR-20912

Code Review Checklist

• I have pulled this code locally and tested it on my instance, along with any associated packages.
• This code adheres to ProcessMaker Coding Guidelines.
• This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
• This solution fixes the bug reported in the original ticket.
• This solution does not alter the expected output of a component in a way that would break existing Processes.
• This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
• This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
• This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
• This ticket conforms to the PRD associated with this part of ProcessMaker.

[caleeli]

Add a negative test, when the storage fails. Something like:

/** @test */
public function it_handles_storage_limit_scenarios()
{
// Mock storage reaching its limit
Storage::shouldReceive('disk->put')
->andThrow(new \Illuminate\Contracts\Filesystem\FileNotFoundException());
$key = $this->manager->createKey('1', '1', 'en', '1', '1');
$this->expectException(\Exception::class);
$this->manager->storeCompiledContent($key, ['test' => 'content']);
}

[rodriquelca]

…dding Cache

Issue & Reproduction Steps

As a developer I want to improve test coverage for tests/Feature/Screens/ScreenCompiledManagerTest.php test

Solution

• refactor get key test
• add exception tests
• add empty compile content test
• add clear assets when the directory does not exist

How to Test

run the next command s
// run the test php artisan test --filter=ScreenCompiledManagerTest // check coverage vendor/bin/phpunit --coverage-html coverage-report tests/Feature/Screens/ScreenCompiledManagerTest.php

Related Tickets & Packages

• https://processmaker.atlassian.net/browse/FOUR-20912

Code Review Checklist

• I have pulled this code locally and tested it on my instance, along with any associated packages.
• This code adheres to ProcessMaker Coding Guidelines.
• This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
• This solution fixes the bug reported in the original ticket.
• This solution does not alter the expected output of a component in a way that would break existing Processes.
• This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
• This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
• This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
• This ticket conforms to the PRD associated with this part of ProcessMaker.

[caleeli]

Add a negative test, when the storage fails. Something like:

/** @test */
public function it_handles_storage_limit_scenarios()
{
// Mock storage reaching its limit
Storage::shouldReceive('disk->put')
->andThrow(new \Illuminate\Contracts\Filesystem\FileNotFoundException());
$key = $this->manager->createKey('1', '1', 'en', '1', '1');
$this->expectException(\Exception::class);
$this->manager->storeCompiledContent($key, ['test' => 'content']);
}

[rodriquelca]

…dding Cache

Issue & Reproduction Steps

As a developer I want to improve test coverage for tests/Feature/Screens/ScreenCompiledManagerTest.php test

Solution

• refactor get key test
• add exception tests
• add empty compile content test
• add clear assets when the directory does not exist

How to Test

run the next command s
// run the test php artisan test --filter=ScreenCompiledManagerTest // check coverage vendor/bin/phpunit --coverage-html coverage-report tests/Feature/Screens/ScreenCompiledManagerTest.php

Related Tickets & Packages

• https://processmaker.atlassian.net/browse/FOUR-20912

Code Review Checklist

• I have pulled this code locally and tested it on my instance, along with any associated packages.
• This code adheres to ProcessMaker Coding Guidelines.
• This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
• This solution fixes the bug reported in the original ticket.
• This solution does not alter the expected output of a component in a way that would break existing Processes.
• This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
• This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
• This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
• This ticket conforms to the PRD associated with this part of ProcessMaker.

[caleeli]

Add a negative test, when the storage fails. Something like:

/** @test */
public function it_handles_storage_limit_scenarios()
{
// Mock storage reaching its limit
Storage::shouldReceive('disk->put')
->andThrow(new \Illuminate\Contracts\Filesystem\FileNotFoundException());
$key = $this->manager->createKey('1', '1', 'en', '1', '1');
$this->expectException(\Exception::class);
$this->manager->storeCompiledContent($key, ['test' => 'content']);
}

[rodriquelca]

…dding Cache

Issue & Reproduction Steps

As a developer I want to improve test coverage for tests/Feature/Screens/ScreenCompiledManagerTest.php test

Solution

• refactor get key test
• add exception tests
• add empty compile content test
• add clear assets when the directory does not exist

How to Test

run the next command s
// run the test php artisan test --filter=ScreenCompiledManagerTest // check coverage vendor/bin/phpunit --coverage-html coverage-report tests/Feature/Screens/ScreenCompiledManagerTest.php

Related Tickets & Packages

• https://processmaker.atlassian.net/browse/FOUR-20912

Code Review Checklist

• I have pulled this code locally and tested it on my instance, along with any associated packages.
• This code adheres to ProcessMaker Coding Guidelines.
• This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
• This solution fixes the bug reported in the original ticket.
• This solution does not alter the expected output of a component in a way that would break existing Processes.
• This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
• This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
• This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
• This ticket conforms to the PRD associated with this part of ProcessMaker.

[caleeli]

Add a negative test, when the storage fails. Something like:

/** @test */
public function it_handles_storage_limit_scenarios()
{
// Mock storage reaching its limit
Storage::shouldReceive('disk->put')
->andThrow(new \Illuminate\Contracts\Filesystem\FileNotFoundException());
$key = $this->manager->createKey('1', '1', 'en', '1', '1');
$this->expectException(\Exception::class);
$this->manager->storeCompiledContent($key, ['test' => 'content']);
}

[rodriquelca]

…dding Cache

Issue & Reproduction Steps

As a developer I want to improve test coverage for tests/Feature/Screens/ScreenCompiledManagerTest.php test

Solution

• refactor get key test
• add exception tests
• add empty compile content test
• add clear assets when the directory does not exist

How to Test

run the next command s
// run the test php artisan test --filter=ScreenCompiledManagerTest // check coverage vendor/bin/phpunit --coverage-html coverage-report tests/Feature/Screens/ScreenCompiledManagerTest.php

Related Tickets & Packages

• https://processmaker.atlassian.net/browse/FOUR-20912

Code Review Checklist

• I have pulled this code locally and tested it on my instance, along with any associated packages.
• This code adheres to ProcessMaker Coding Guidelines.
• This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
• This solution fixes the bug reported in the original ticket.
• This solution does not alter the expected output of a component in a way that would break existing Processes.
• This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
• This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
• This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
• This ticket conforms to the PRD associated with this part of ProcessMaker.

[caleeli]

Add a negative test, when the storage fails. Something like:

/** @test */
public function it_handles_storage_limit_scenarios()
{
// Mock storage reaching its limit
Storage::shouldReceive('disk->put')
->andThrow(new \Illuminate\Contracts\Filesystem\FileNotFoundException());
$key = $this->manager->createKey('1', '1', 'en', '1', '1');
$this->expectException(\Exception::class);
$this->manager->storeCompiledContent($key, ['test' => 'content']);
}

[rodriquelca]

…dding Cache

Issue & Reproduction Steps

As a developer I want to improve test coverage for tests/Feature/Screens/ScreenCompiledManagerTest.php test

Solution

• refactor get key test
• add exception tests
• add empty compile content test
• add clear assets when the directory does not exist

How to Test

run the next command s
// run the test php artisan test --filter=ScreenCompiledManagerTest // check coverage vendor/bin/phpunit --coverage-html coverage-report tests/Feature/Screens/ScreenCompiledManagerTest.php

Related Tickets & Packages

• https://processmaker.atlassian.net/browse/FOUR-20912

Code Review Checklist

• I have pulled this code locally and tested it on my instance, along with any associated packages.
• This code adheres to ProcessMaker Coding Guidelines.
• This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
• This solution fixes the bug reported in the original ticket.
• This solution does not alter the expected output of a component in a way that would break existing Processes.
• This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
• This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
• This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
• This ticket conforms to the PRD associated with this part of ProcessMaker.

[caleeli]

Add a negative test, when the storage fails. Something like:

/** @test */
public function it_handles_storage_limit_scenarios()
{
// Mock storage reaching its limit
Storage::shouldReceive('disk->put')
->andThrow(new \Illuminate\Contracts\Filesystem\FileNotFoundException());
$key = $this->manager->createKey('1', '1', 'en', '1', '1');
$this->expectException(\Exception::class);
$this->manager->storeCompiledContent($key, ['test' => 'content']);
}

[rodriquelca]

…dding Cache

Issue & Reproduction Steps

As a developer I want to improve test coverage for tests/Feature/Screens/ScreenCompiledManagerTest.php test

Solution

• refactor get key test
• add exception tests
• add empty compile content test
• add clear assets when the directory does not exist

How to Test

run the next command s
// run the test php artisan test --filter=ScreenCompiledManagerTest // check coverage vendor/bin/phpunit --coverage-html coverage-report tests/Feature/Screens/ScreenCompiledManagerTest.php

Related Tickets & Packages

• https://processmaker.atlassian.net/browse/FOUR-20912

Code Review Checklist

• I have pulled this code locally and tested it on my instance, along with any associated packages.
• This code adheres to ProcessMaker Coding Guidelines.
• This code includes a unit test or an E2E test that tests its functionality, or is covered by an existing test.
• This solution fixes the bug reported in the original ticket.
• This solution does not alter the expected output of a component in a way that would break existing Processes.
• This solution does not implement any breaking changes that would invalidate documentation or cause existing Processes to fail.
• This solution has been tested with enterprise packages that rely on its functionality and does not introduce bugs in those packages.
• This code does not duplicate functionality that already exists in the framework or in ProcessMaker.
• This ticket conforms to the PRD associated with this part of ProcessMaker.

[caleeli]

Add a negative test, when the storage fails. Something like:

/** @test */
public function it_handles_storage_limit_scenarios()
{
// Mock storage reaching its limit
Storage::shouldReceive('disk->put')
->andThrow(new \Illuminate\Contracts\Filesystem\FileNotFoundException());
$key = $this->manager->createKey('1', '1', 'en', '1', '1');
$this->expectException(\Exception::class);
$this->manager->storeCompiledContent($key, ['test' => 'content']);
}