FOUR-20281: [WINTER] Remove fades on tab switching#7824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryancooley merged 4 commits into from
Jan 23, 2025
Merged

FOUR-20281: [WINTER] Remove fades on tab switching #7824

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8573753
FOUR-20281 : S2: Remove fades
hjonathan Nov 25, 2024
7658dea
Merge remote-tracking branch 'origin/release-2024-fall' into feature/…
pmPaulis Dec 4, 2024
9688ae5
Merge pull request #7763 from ProcessMaker/feature/FOUR-20281
pmPaulis Dec 13, 2024
416e506
Merge remote-tracking branch 'origin/release-2025-winter' into epic/F…
pmPaulis Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions resources/views/admin/users/index.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,13 +33,13 @@

<div>
<div class="tab-content">
<div class="tab-pane fade show active" id="nav-users" role="tabpanel" aria-labelledby="nav-users-tab">
<div class="tab-pane show active" id="nav-users" role="tabpanel" aria-labelledby="nav-users-tab">
<div class="card card-body p-3 border-top-0">
@include('admin.users.list')
</div>
</div>

<div class="tab-pane fade show" id="nav-deleted-users" role="tabpanel" aria-labelledby="nav-deleted-users-tab">
<div class="tab-pane show" id="nav-deleted-users" role="tabpanel" aria-labelledby="nav-deleted-users-tab">
<div class="card card-body p-3 border-top-0">
@include('admin.users.deletedUsers')
</div>
Expand Down
12 changes: 6 additions & 6 deletions resources/views/components/categorized_resource.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
<div class="px-3 page-content" id="categorizedList" style="display:none">
@php
$firstTab = $secondTab = 'nav-item nav-link';
$firstContent = $secondContent = 'tab-pane fade show';
$firstContent = $secondContent = 'tab-pane show';

$catListWebRoute = str_replace('.edit', '.index', $catConfig->routes->editCategoryWeb);
$showCategoriesTab = $catListWebRoute === \Request::route()->getName() || $listConfig->countCategories === 0
Expand DownExpand Up@@ -127,7 +127,7 @@ class="nav-item nav-link"
</div>
@if(isset($templatesList))
@can('view-process-templates')
<div class="tab-pane fade" id="nav-templates" role="tabpanel" aria-labelledby="nav-templates-tab">
<div class="tab-pane" id="nav-templates" role="tabpanel" aria-labelledby="nav-templates-tab">
<div class="card card-body p-3 border-top-0">
{{ $templatesList }}
</div>
Expand All@@ -139,7 +139,7 @@ class="nav-item nav-link"
</div>
</div>
@isset($tabs[3])
<div class="tab-pane fade" id="nav-archived" role="tabpanel" aria-labelledby="nav-archived-tab">
<div class="tab-pane" id="nav-archived" role="tabpanel" aria-labelledby="nav-archived-tab">
<div class="card card-body p-3 border-top-0">
{{ $archivedList }}
</div>
Expand All@@ -156,13 +156,13 @@ class="{{$secondContent}}"
{{ $categoryList }}
</div>
</div>
<div class="tab-pane fade" id="nav-myTemplates" role="tabpanel" aria-labelledby="nav-myTemplates-tab">
<div class="tab-pane" id="nav-myTemplates" role="tabpanel" aria-labelledby="nav-myTemplates-tab">
<div class="card card-body p-3 border-top-0">
{{ $myTemplatesList }}
</div>
</div>
<div
class="tab-pane fade"
class="tab-pane"
id="nav-publicTemplates"
role="tabpanel"
aria-labelledby="nav-publicTemplates-tab"
Expand All@@ -178,7 +178,7 @@ class="tab-pane fade"
</div>
</div>
@isset($tabs[2])
<div class="tab-pane fade" id="nav-archived" role="tabpanel" aria-labelledby="nav-archived-tab">
<div class="tab-pane" id="nav-archived" role="tabpanel" aria-labelledby="nav-archived-tab">
<div class="card card-body p-3 border-top-0">
{{ $archivedList }}
</div>
Expand Down
6 changes: 3 additions & 3 deletions resources/views/processes/edit.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -46,7 +46,7 @@

{{-- Configuration --}}
<div
class="tab-pane fade show"
class="tab-pane show"
:class="{'active': activeTab === '' || activeTab === 'nav-config'}"
id="nav-config"
role="tabpanel"
Expand DownExpand Up@@ -375,7 +375,7 @@ class="invalid-feedback"
</div>

{{-- Notifications --}}
<div class="tab-pane fade show p-3" id="nav-notifications" role="tabpanel"
<div class="tab-pane show p-3" id="nav-notifications" role="tabpanel"
aria-labelledby="nav-notifications-tab">
<div class="form-group p-0">

Expand DownExpand Up@@ -530,7 +530,7 @@ class="custom-control-input">
{{-- Addons --}}
@isset($addons)
@foreach ($addons as $addon)
<div class="tab-pane fade show" id="{{$addon['id']}}" role="tabpanel"
<div class="tab-pane show" id="{{$addon['id']}}" role="tabpanel"
aria-labelledby="nav-notifications-tab">
{!! $addon['content'] !!}
</div>
Expand Down
4 changes: 2 additions & 2 deletions resources/views/processes/screens/edit.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,7 +38,7 @@

<div class="card card-body card-body-nav-tabs">
<div class="tab-content" id="nav-tabContent">
<div class="tab-pane fade show active" id="nav-config" role="tabpanel" aria-labelledby="nav-config-tab">
<div class="tab-pane show active" id="nav-config" role="tabpanel" aria-labelledby="nav-config-tab">
<required></required>
<div class="form-group">
{!! Form::label('title', __('Name') . '<small class="ml-1">*</small>', [], false) !!}
Expand DownExpand Up@@ -76,7 +76,7 @@
</div>
@isset($addons)
@foreach ($addons as $addon)
<div class="tab-pane fade show" id="{{$addon['id']}}" role="tabpanel" aria-labelledby="'nav-tab-'+ {{$addon['id']}}">
<div class="tab-pane show" id="{{$addon['id']}}" role="tabpanel" aria-labelledby="'nav-tab-'+ {{$addon['id']}}">
{!! $addon['content'] !!}
</div>
@endforeach
Expand Down
4 changes: 2 additions & 2 deletions resources/views/processes/scripts/edit.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -39,7 +39,7 @@

<div class="card card-body card-body-nav-tabs">
<div class="tab-content" id="nav-tabContent">
<div class="tab-pane fade show active" id="nav-config" role="tabpanel" aria-labelledby="nav-config-tab">
<div class="tab-pane show active" id="nav-config" role="tabpanel" aria-labelledby="nav-config-tab">
<required></required>
<div class="form-group">
{!! Form::label('title', __('Name') . '<small class="ml-1">*</small>', [], false) !!}
Expand DownExpand Up@@ -130,7 +130,7 @@
</div>
@isset($addons)
@foreach ($addons as $addon)
<div class="tab-pane fade show" id="{{$addon['id']}}" role="tabpanel" aria-labelledby="'nav-tab-'+ {{$addon['id']}}">
<div class="tab-pane show" id="{{$addon['id']}}" role="tabpanel" aria-labelledby="'nav-tab-'+ {{$addon['id']}}">
{!! $addon['content'] !!}
</div>
@endforeach
Expand Down
4 changes: 2 additions & 2 deletions resources/views/processes/signals/edit.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,7 +33,7 @@

<div class="tab-content" id="nav-tabContent">

<div class="card card-body border-top-0 tab-pane p-3 fade show active" id="nav-detail" role="tabpanel" aria-labelledby="nav-detail-tab">
<div class="card card-body border-top-0 tab-pane p-3 show active" id="nav-detail" role="tabpanel" aria-labelledby="nav-detail-tab">
<div class="modal-body">
<required></required>
<div class="form-group">
Expand DownExpand Up@@ -68,7 +68,7 @@
</div>
@endif
</div>
<div class="card card-body border-top-0 tab-pane p-3 fade" id="nav-catch" role="tabpanel" aria-labelledby="nav-catch-tab">
<div class="card card-body border-top-0 tab-pane p-3" id="nav-catch" role="tabpanel" aria-labelledby="nav-catch-tab">
<catch-listing ref="catchList" :filter="filter" items="{{json_encode($signal['processes'])}}" />
</div>

Expand Down
2 changes: 1 addition & 1 deletion resources/views/requests/index.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -52,7 +52,7 @@ function() use ($title) { return [__($title), null]; }
</counter-card-group>

<div class="tab-content" id="requests-tabContent">
<div class="tab-pane fade show active" id="inbox" role="tabpanel" aria-labelledby="inbox-tab">
<div class="tab-pane show active" id="inbox" role="tabpanel" aria-labelledby="inbox-tab">

<div class="card card-body requests-list-body">
<div id="search-bar" class="search advanced-search mb-2">
Expand Down
18 changes: 9 additions & 9 deletions resources/views/requests/show.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -109,7 +109,7 @@
role="tabpanel" aria-labelledby="errors-tab">
<request-errors :errors="errorLogs"></request-errors>
</div>
<div class="tab-pane fade show card card-body border-top-0 p-0" :class="{ active: activePending }"
<div class="tab-pane show card card-body border-top-0 p-0" :class="{ active: activePending }"
id="pending" role="tabpanel" aria-labelledby="pending-tab">
<request-detail ref="pending" :process-request-id="requestId" status="ACTIVE"
:is-process-manager="{{ $isProcessManager ? 'true' : 'false' }}"
Expand DownExpand Up@@ -187,20 +187,20 @@ class="tab-pane card card-body border-top-0 p-3">
</div>
@endcan
@endif
<div class="tab-pane fade card card-body border-top-0 p-0" id="completed" role="tabpanel"
<div class="tab-pane card card-body border-top-0 p-0" id="completed" role="tabpanel"
aria-labelledby="completed-tab">
<request-detail ref="completed" :process-request-id="requestId" status="CLOSED"
:is-admin="{{ Auth::user()->is_administrator ? 'true' : 'false' }}">
</request-detail>
</div>

<template v-for="{ tab, component } in packages">
<div class="tab-pane fade card card-body border-top-0 p-0" :id="tab.target" role="tabpanel">
<div class="tab-pane card card-body border-top-0 p-0" :id="tab.target" role="tabpanel">
<component :is="component" :process-request-id="requestId"></component>
</div>
</template>

<div class="tab-pane fade card card-body border-top-0 p-3" id="files" role="tabpanel"
<div class="tab-pane card card-body border-top-0 p-3" id="files" role="tabpanel"
aria-labelledby="files-tab">
<div class="card">
<div>
Expand DownExpand Up@@ -228,12 +228,12 @@ class="tab-pane card card-body border-top-0 p-3">
</div>
</div>
</div>
<div class="tab-pane fade card card-body border-top-0 p-0" id="forms" role="tabpanel"
<div class="tab-pane card card-body border-top-0 p-0" id="forms" role="tabpanel"
aria-labelledby="forms-tab" v-show="canViewPrint">
<request-screens :id="requestId" :information="dataSummary" ref="forms">
</request-screens>
</div>
<div v-if="activeTab === 'overview'" class="tab-pane fade p-0" id="overview" role="tabpanel"
<div v-if="activeTab === 'overview'" class="tab-pane p-0" id="overview" role="tabpanel"
aria-labelledby="overview-tab">
<div class="card" style="border-top: none !important;">
<div class="card-body">
Expand DownExpand Up@@ -267,7 +267,7 @@ class="tab-pane card card-body border-top-0 p-3">

@isset($addons)
@foreach ($addons as $addon)
<div class="tab-pane fade show" id="{{ $addon['id'] }}" role="tabpanel"
<div class="tab-pane show" id="{{ $addon['id'] }}" role="tabpanel"
aria-labelledby="{{ $addon['id'] }}">
{!! $addon['content'] !!}
</div>
Expand DownExpand Up@@ -326,7 +326,7 @@ class="tab-pane card card-body border-top-0 p-3">
<div
v-if="showInfo"
id="details"
v-bind:class="{ 'tab-pane':true, fade: true, show: showInfo, active: showInfo }"
v-bind:class="{ 'tab-pane':true, show: showInfo, active: showInfo }"
role="tabpanel"
aria-labelledby="details-tab"
>
Expand DownExpand Up@@ -453,7 +453,7 @@ class="btn btn-outline-info btn-block"
<div
v-if="!showInfo"
id="comments"
v-bind:class="{ 'tab-pane':true, fade: true, show: !showInfo, active: !showInfo }"
v-bind:class="{ 'tab-pane':true, show: !showInfo, active: !showInfo }"
role="tabpanel"
aria-labelledby="comments-tab"
>
Expand Down
4 changes: 2 additions & 2 deletions resources/views/requests/showMobile.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -83,7 +83,7 @@ class="tab-content"
>
<div
id="tasks"
class="tab-pane fade show card card-body border-top-0 p-3 active"
class="tab-pane show card card-body border-top-0 p-3 active"
role="tabpanel"
aria-labelledby="tasks-tab"
>
Expand All@@ -110,7 +110,7 @@ class="tab-pane card card-body border-top-0 p-3"

<div
id="files"
class="tab-pane fade card card-body border-top-0 p-3"
class="tab-pane card card-body border-top-0 p-3"
role="tabpanel"
aria-labelledby="files-tab"
>
Expand Down
4 changes: 2 additions & 2 deletions resources/views/tasks/edit.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -164,7 +164,7 @@ class="card border-0"
<div
v-if="showInfo"
id="details"
v-bind:class="{ 'tab-pane':true, fade: true, show: showInfo, active: showInfo }"
v-bind:class="{ 'tab-pane':true, show: showInfo, active: showInfo }"
role="tabpanel"
aria-labelledby="details-tab">
<div class="ml-md-3 mt-3 mt-md-0">
Expand DownExpand Up@@ -313,7 +313,7 @@ class="d-inline-flex pull-left align-items-center"
<div
v-if="!showInfo"
id="comments"
v-bind:class="{ 'tab-pane':true, fade: true, show: !showInfo, active: !showInfo }"
v-bind:class="{ 'tab-pane':true, show: !showInfo, active: !showInfo }"
role="tabpanel"
aria-labelledby="comments-tab">
<div class="ml-md-3 mt-md-0 mt-3 collapse-content">
Expand Down
2 changes: 1 addition & 1 deletion resources/views/tasks/index.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -77,7 +77,7 @@ class="nav-link task-nav-link"
</ul>

<div class="tab-content" id="task-tabContent">
<div class="tab-pane fade show active" id="inbox" role="tabpanel" aria-labelledby="inbox-tab">
<div class="tab-pane show active" id="inbox" role="tabpanel" aria-labelledby="inbox-tab">
<div class="card card-body task-list-body">
<div id="search-bar" class="search advanced-search mb-2">
<div class="d-flex">
Expand Down
4 changes: 2 additions & 2 deletions resources/views/templates/configure.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -36,7 +36,7 @@
</nav>
<div class="card card-body card-body-nav-tabs">
<div class="tab-content" id="nav-tabContent">
<div class="tab-pane fade show active" id="nav-config" role="tabpanel"
<div class="tab-pane show active" id="nav-config" role="tabpanel"
aria-labelledby="nav-config-tab">
<required></required>
@if ($type === 'process')
Expand All@@ -59,7 +59,7 @@
</div>
@isset($addons)
@foreach ($addons as $addon)
<div class="tab-pane fade show" id="{{$addon['id']}}" role="tabpanel"
<div class="tab-pane show" id="{{$addon['id']}}" role="tabpanel"
aria-labelledby="nav-notifications-tab">
{!! $addon['content'] !!}
</div>
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all \u003cpre\u003e\u003ccode\u003e blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks"); } } catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); } })(); (function(){ try { var __m = "github.com"; var __re = new RegExp('^' + "github\\.com" + '
Skip to content

FOUR-20281: [WINTER] Remove fades on tab switching#7824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryancooley merged 4 commits into from
Jan 23, 2025
Merged

FOUR-20281: [WINTER] Remove fades on tab switching #7824

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8573753
FOUR-20281 : S2: Remove fades
hjonathan Nov 25, 2024
7658dea
Merge remote-tracking branch 'origin/release-2024-fall' into feature/…
pmPaulis Dec 4, 2024
9688ae5
Merge pull request #7763 from ProcessMaker/feature/FOUR-20281
pmPaulis Dec 13, 2024
416e506
Merge remote-tracking branch 'origin/release-2025-winter' into epic/F…
pmPaulis Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions resources/views/admin/users/index.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,13 +33,13 @@

<div>
<div class="tab-content">
<div class="tab-pane fade show active" id="nav-users" role="tabpanel" aria-labelledby="nav-users-tab">
<div class="tab-pane show active" id="nav-users" role="tabpanel" aria-labelledby="nav-users-tab">
<div class="card card-body p-3 border-top-0">
@include('admin.users.list')
</div>
</div>

<div class="tab-pane fade show" id="nav-deleted-users" role="tabpanel" aria-labelledby="nav-deleted-users-tab">
<div class="tab-pane show" id="nav-deleted-users" role="tabpanel" aria-labelledby="nav-deleted-users-tab">
<div class="card card-body p-3 border-top-0">
@include('admin.users.deletedUsers')
</div>
Expand Down
12 changes: 6 additions & 6 deletions resources/views/components/categorized_resource.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
<div class="px-3 page-content" id="categorizedList" style="display:none">
@php
$firstTab = $secondTab = 'nav-item nav-link';
$firstContent = $secondContent = 'tab-pane fade show';
$firstContent = $secondContent = 'tab-pane show';

$catListWebRoute = str_replace('.edit', '.index', $catConfig->routes->editCategoryWeb);
$showCategoriesTab = $catListWebRoute === \Request::route()->getName() || $listConfig->countCategories === 0
Expand DownExpand Up@@ -127,7 +127,7 @@ class="nav-item nav-link"
</div>
@if(isset($templatesList))
@can('view-process-templates')
<div class="tab-pane fade" id="nav-templates" role="tabpanel" aria-labelledby="nav-templates-tab">
<div class="tab-pane" id="nav-templates" role="tabpanel" aria-labelledby="nav-templates-tab">
<div class="card card-body p-3 border-top-0">
{{ $templatesList }}
</div>
Expand All@@ -139,7 +139,7 @@ class="nav-item nav-link"
</div>
</div>
@isset($tabs[3])
<div class="tab-pane fade" id="nav-archived" role="tabpanel" aria-labelledby="nav-archived-tab">
<div class="tab-pane" id="nav-archived" role="tabpanel" aria-labelledby="nav-archived-tab">
<div class="card card-body p-3 border-top-0">
{{ $archivedList }}
</div>
Expand All@@ -156,13 +156,13 @@ class="{{$secondContent}}"
{{ $categoryList }}
</div>
</div>
<div class="tab-pane fade" id="nav-myTemplates" role="tabpanel" aria-labelledby="nav-myTemplates-tab">
<div class="tab-pane" id="nav-myTemplates" role="tabpanel" aria-labelledby="nav-myTemplates-tab">
<div class="card card-body p-3 border-top-0">
{{ $myTemplatesList }}
</div>
</div>
<div
class="tab-pane fade"
class="tab-pane"
id="nav-publicTemplates"
role="tabpanel"
aria-labelledby="nav-publicTemplates-tab"
Expand All@@ -178,7 +178,7 @@ class="tab-pane fade"
</div>
</div>
@isset($tabs[2])
<div class="tab-pane fade" id="nav-archived" role="tabpanel" aria-labelledby="nav-archived-tab">
<div class="tab-pane" id="nav-archived" role="tabpanel" aria-labelledby="nav-archived-tab">
<div class="card card-body p-3 border-top-0">
{{ $archivedList }}
</div>
Expand Down
6 changes: 3 additions & 3 deletions resources/views/processes/edit.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -46,7 +46,7 @@

{{-- Configuration --}}
<div
class="tab-pane fade show"
class="tab-pane show"
:class="{'active': activeTab === '' || activeTab === 'nav-config'}"
id="nav-config"
role="tabpanel"
Expand DownExpand Up@@ -375,7 +375,7 @@ class="invalid-feedback"
</div>

{{-- Notifications --}}
<div class="tab-pane fade show p-3" id="nav-notifications" role="tabpanel"
<div class="tab-pane show p-3" id="nav-notifications" role="tabpanel"
aria-labelledby="nav-notifications-tab">
<div class="form-group p-0">

Expand DownExpand Up@@ -530,7 +530,7 @@ class="custom-control-input">
{{-- Addons --}}
@isset($addons)
@foreach ($addons as $addon)
<div class="tab-pane fade show" id="{{$addon['id']}}" role="tabpanel"
<div class="tab-pane show" id="{{$addon['id']}}" role="tabpanel"
aria-labelledby="nav-notifications-tab">
{!! $addon['content'] !!}
</div>
Expand Down
4 changes: 2 additions & 2 deletions resources/views/processes/screens/edit.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,7 +38,7 @@

<div class="card card-body card-body-nav-tabs">
<div class="tab-content" id="nav-tabContent">
<div class="tab-pane fade show active" id="nav-config" role="tabpanel" aria-labelledby="nav-config-tab">
<div class="tab-pane show active" id="nav-config" role="tabpanel" aria-labelledby="nav-config-tab">
<required></required>
<div class="form-group">
{!! Form::label('title', __('Name') . '<small class="ml-1">*</small>', [], false) !!}
Expand DownExpand Up@@ -76,7 +76,7 @@
</div>
@isset($addons)
@foreach ($addons as $addon)
<div class="tab-pane fade show" id="{{$addon['id']}}" role="tabpanel" aria-labelledby="'nav-tab-'+ {{$addon['id']}}">
<div class="tab-pane show" id="{{$addon['id']}}" role="tabpanel" aria-labelledby="'nav-tab-'+ {{$addon['id']}}">
{!! $addon['content'] !!}
</div>
@endforeach
Expand Down
4 changes: 2 additions & 2 deletions resources/views/processes/scripts/edit.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -39,7 +39,7 @@

<div class="card card-body card-body-nav-tabs">
<div class="tab-content" id="nav-tabContent">
<div class="tab-pane fade show active" id="nav-config" role="tabpanel" aria-labelledby="nav-config-tab">
<div class="tab-pane show active" id="nav-config" role="tabpanel" aria-labelledby="nav-config-tab">
<required></required>
<div class="form-group">
{!! Form::label('title', __('Name') . '<small class="ml-1">*</small>', [], false) !!}
Expand DownExpand Up@@ -130,7 +130,7 @@
</div>
@isset($addons)
@foreach ($addons as $addon)
<div class="tab-pane fade show" id="{{$addon['id']}}" role="tabpanel" aria-labelledby="'nav-tab-'+ {{$addon['id']}}">
<div class="tab-pane show" id="{{$addon['id']}}" role="tabpanel" aria-labelledby="'nav-tab-'+ {{$addon['id']}}">
{!! $addon['content'] !!}
</div>
@endforeach
Expand Down
4 changes: 2 additions & 2 deletions resources/views/processes/signals/edit.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,7 +33,7 @@

<div class="tab-content" id="nav-tabContent">

<div class="card card-body border-top-0 tab-pane p-3 fade show active" id="nav-detail" role="tabpanel" aria-labelledby="nav-detail-tab">
<div class="card card-body border-top-0 tab-pane p-3 show active" id="nav-detail" role="tabpanel" aria-labelledby="nav-detail-tab">
<div class="modal-body">
<required></required>
<div class="form-group">
Expand DownExpand Up@@ -68,7 +68,7 @@
</div>
@endif
</div>
<div class="card card-body border-top-0 tab-pane p-3 fade" id="nav-catch" role="tabpanel" aria-labelledby="nav-catch-tab">
<div class="card card-body border-top-0 tab-pane p-3" id="nav-catch" role="tabpanel" aria-labelledby="nav-catch-tab">
<catch-listing ref="catchList" :filter="filter" items="{{json_encode($signal['processes'])}}" />
</div>

Expand Down
2 changes: 1 addition & 1 deletion resources/views/requests/index.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -52,7 +52,7 @@ function() use ($title) { return [__($title), null]; }
</counter-card-group>

<div class="tab-content" id="requests-tabContent">
<div class="tab-pane fade show active" id="inbox" role="tabpanel" aria-labelledby="inbox-tab">
<div class="tab-pane show active" id="inbox" role="tabpanel" aria-labelledby="inbox-tab">

<div class="card card-body requests-list-body">
<div id="search-bar" class="search advanced-search mb-2">
Expand Down
18 changes: 9 additions & 9 deletions resources/views/requests/show.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -109,7 +109,7 @@
role="tabpanel" aria-labelledby="errors-tab">
<request-errors :errors="errorLogs"></request-errors>
</div>
<div class="tab-pane fade show card card-body border-top-0 p-0" :class="{ active: activePending }"
<div class="tab-pane show card card-body border-top-0 p-0" :class="{ active: activePending }"
id="pending" role="tabpanel" aria-labelledby="pending-tab">
<request-detail ref="pending" :process-request-id="requestId" status="ACTIVE"
:is-process-manager="{{ $isProcessManager ? 'true' : 'false' }}"
Expand DownExpand Up@@ -187,20 +187,20 @@ class="tab-pane card card-body border-top-0 p-3">
</div>
@endcan
@endif
<div class="tab-pane fade card card-body border-top-0 p-0" id="completed" role="tabpanel"
<div class="tab-pane card card-body border-top-0 p-0" id="completed" role="tabpanel"
aria-labelledby="completed-tab">
<request-detail ref="completed" :process-request-id="requestId" status="CLOSED"
:is-admin="{{ Auth::user()->is_administrator ? 'true' : 'false' }}">
</request-detail>
</div>

<template v-for="{ tab, component } in packages">
<div class="tab-pane fade card card-body border-top-0 p-0" :id="tab.target" role="tabpanel">
<div class="tab-pane card card-body border-top-0 p-0" :id="tab.target" role="tabpanel">
<component :is="component" :process-request-id="requestId"></component>
</div>
</template>

<div class="tab-pane fade card card-body border-top-0 p-3" id="files" role="tabpanel"
<div class="tab-pane card card-body border-top-0 p-3" id="files" role="tabpanel"
aria-labelledby="files-tab">
<div class="card">
<div>
Expand DownExpand Up@@ -228,12 +228,12 @@ class="tab-pane card card-body border-top-0 p-3">
</div>
</div>
</div>
<div class="tab-pane fade card card-body border-top-0 p-0" id="forms" role="tabpanel"
<div class="tab-pane card card-body border-top-0 p-0" id="forms" role="tabpanel"
aria-labelledby="forms-tab" v-show="canViewPrint">
<request-screens :id="requestId" :information="dataSummary" ref="forms">
</request-screens>
</div>
<div v-if="activeTab === 'overview'" class="tab-pane fade p-0" id="overview" role="tabpanel"
<div v-if="activeTab === 'overview'" class="tab-pane p-0" id="overview" role="tabpanel"
aria-labelledby="overview-tab">
<div class="card" style="border-top: none !important;">
<div class="card-body">
Expand DownExpand Up@@ -267,7 +267,7 @@ class="tab-pane card card-body border-top-0 p-3">

@isset($addons)
@foreach ($addons as $addon)
<div class="tab-pane fade show" id="{{ $addon['id'] }}" role="tabpanel"
<div class="tab-pane show" id="{{ $addon['id'] }}" role="tabpanel"
aria-labelledby="{{ $addon['id'] }}">
{!! $addon['content'] !!}
</div>
Expand DownExpand Up@@ -326,7 +326,7 @@ class="tab-pane card card-body border-top-0 p-3">
<div
v-if="showInfo"
id="details"
v-bind:class="{ 'tab-pane':true, fade: true, show: showInfo, active: showInfo }"
v-bind:class="{ 'tab-pane':true, show: showInfo, active: showInfo }"
role="tabpanel"
aria-labelledby="details-tab"
>
Expand DownExpand Up@@ -453,7 +453,7 @@ class="btn btn-outline-info btn-block"
<div
v-if="!showInfo"
id="comments"
v-bind:class="{ 'tab-pane':true, fade: true, show: !showInfo, active: !showInfo }"
v-bind:class="{ 'tab-pane':true, show: !showInfo, active: !showInfo }"
role="tabpanel"
aria-labelledby="comments-tab"
>
Expand Down
4 changes: 2 additions & 2 deletions resources/views/requests/showMobile.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -83,7 +83,7 @@ class="tab-content"
>
<div
id="tasks"
class="tab-pane fade show card card-body border-top-0 p-3 active"
class="tab-pane show card card-body border-top-0 p-3 active"
role="tabpanel"
aria-labelledby="tasks-tab"
>
Expand All@@ -110,7 +110,7 @@ class="tab-pane card card-body border-top-0 p-3"

<div
id="files"
class="tab-pane fade card card-body border-top-0 p-3"
class="tab-pane card card-body border-top-0 p-3"
role="tabpanel"
aria-labelledby="files-tab"
>
Expand Down
4 changes: 2 additions & 2 deletions resources/views/tasks/edit.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -164,7 +164,7 @@ class="card border-0"
<div
v-if="showInfo"
id="details"
v-bind:class="{ 'tab-pane':true, fade: true, show: showInfo, active: showInfo }"
v-bind:class="{ 'tab-pane':true, show: showInfo, active: showInfo }"
role="tabpanel"
aria-labelledby="details-tab">
<div class="ml-md-3 mt-3 mt-md-0">
Expand DownExpand Up@@ -313,7 +313,7 @@ class="d-inline-flex pull-left align-items-center"
<div
v-if="!showInfo"
id="comments"
v-bind:class="{ 'tab-pane':true, fade: true, show: !showInfo, active: !showInfo }"
v-bind:class="{ 'tab-pane':true, show: !showInfo, active: !showInfo }"
role="tabpanel"
aria-labelledby="comments-tab">
<div class="ml-md-3 mt-md-0 mt-3 collapse-content">
Expand Down
2 changes: 1 addition & 1 deletion resources/views/tasks/index.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -77,7 +77,7 @@ class="nav-link task-nav-link"
</ul>

<div class="tab-content" id="task-tabContent">
<div class="tab-pane fade show active" id="inbox" role="tabpanel" aria-labelledby="inbox-tab">
<div class="tab-pane show active" id="inbox" role="tabpanel" aria-labelledby="inbox-tab">
<div class="card card-body task-list-body">
<div id="search-bar" class="search advanced-search mb-2">
<div class="d-flex">
Expand Down
4 changes: 2 additions & 2 deletions resources/views/templates/configure.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -36,7 +36,7 @@
</nav>
<div class="card card-body card-body-nav-tabs">
<div class="tab-content" id="nav-tabContent">
<div class="tab-pane fade show active" id="nav-config" role="tabpanel"
<div class="tab-pane show active" id="nav-config" role="tabpanel"
aria-labelledby="nav-config-tab">
<required></required>
@if ($type === 'process')
Expand All@@ -59,7 +59,7 @@
</div>
@isset($addons)
@foreach ($addons as $addon)
<div class="tab-pane fade show" id="{{$addon['id']}}" role="tabpanel"
<div class="tab-pane show" id="{{$addon['id']}}" role="tabpanel"
aria-labelledby="nav-notifications-tab">
{!! $addon['content'] !!}
</div>
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

FOUR-20281: [WINTER] Remove fades on tab switching#7824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryancooley merged 4 commits into from
Jan 23, 2025
Merged

FOUR-20281: [WINTER] Remove fades on tab switching #7824

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8573753
FOUR-20281 : S2: Remove fades
hjonathan Nov 25, 2024
7658dea
Merge remote-tracking branch 'origin/release-2024-fall' into feature/…
pmPaulis Dec 4, 2024
9688ae5
Merge pull request #7763 from ProcessMaker/feature/FOUR-20281
pmPaulis Dec 13, 2024
416e506
Merge remote-tracking branch 'origin/release-2025-winter' into epic/F…
pmPaulis Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions resources/views/admin/users/index.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,13 +33,13 @@

<div>
<div class="tab-content">
<div class="tab-pane fade show active" id="nav-users" role="tabpanel" aria-labelledby="nav-users-tab">
<div class="tab-pane show active" id="nav-users" role="tabpanel" aria-labelledby="nav-users-tab">
<div class="card card-body p-3 border-top-0">
@include('admin.users.list')
</div>
</div>

<div class="tab-pane fade show" id="nav-deleted-users" role="tabpanel" aria-labelledby="nav-deleted-users-tab">
<div class="tab-pane show" id="nav-deleted-users" role="tabpanel" aria-labelledby="nav-deleted-users-tab">
<div class="card card-body p-3 border-top-0">
@include('admin.users.deletedUsers')
</div>
Expand Down
12 changes: 6 additions & 6 deletions resources/views/components/categorized_resource.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
<div class="px-3 page-content" id="categorizedList" style="display:none">
@php
$firstTab = $secondTab = 'nav-item nav-link';
$firstContent = $secondContent = 'tab-pane fade show';
$firstContent = $secondContent = 'tab-pane show';

$catListWebRoute = str_replace('.edit', '.index', $catConfig->routes->editCategoryWeb);
$showCategoriesTab = $catListWebRoute === \Request::route()->getName() || $listConfig->countCategories === 0
Expand DownExpand Up@@ -127,7 +127,7 @@ class="nav-item nav-link"
</div>
@if(isset($templatesList))
@can('view-process-templates')
<div class="tab-pane fade" id="nav-templates" role="tabpanel" aria-labelledby="nav-templates-tab">
<div class="tab-pane" id="nav-templates" role="tabpanel" aria-labelledby="nav-templates-tab">
<div class="card card-body p-3 border-top-0">
{{ $templatesList }}
</div>
Expand All@@ -139,7 +139,7 @@ class="nav-item nav-link"
</div>
</div>
@isset($tabs[3])
<div class="tab-pane fade" id="nav-archived" role="tabpanel" aria-labelledby="nav-archived-tab">
<div class="tab-pane" id="nav-archived" role="tabpanel" aria-labelledby="nav-archived-tab">
<div class="card card-body p-3 border-top-0">
{{ $archivedList }}
</div>
Expand All@@ -156,13 +156,13 @@ class="{{$secondContent}}"
{{ $categoryList }}
</div>
</div>
<div class="tab-pane fade" id="nav-myTemplates" role="tabpanel" aria-labelledby="nav-myTemplates-tab">
<div class="tab-pane" id="nav-myTemplates" role="tabpanel" aria-labelledby="nav-myTemplates-tab">
<div class="card card-body p-3 border-top-0">
{{ $myTemplatesList }}
</div>
</div>
<div
class="tab-pane fade"
class="tab-pane"
id="nav-publicTemplates"
role="tabpanel"
aria-labelledby="nav-publicTemplates-tab"
Expand All@@ -178,7 +178,7 @@ class="tab-pane fade"
</div>
</div>
@isset($tabs[2])
<div class="tab-pane fade" id="nav-archived" role="tabpanel" aria-labelledby="nav-archived-tab">
<div class="tab-pane" id="nav-archived" role="tabpanel" aria-labelledby="nav-archived-tab">
<div class="card card-body p-3 border-top-0">
{{ $archivedList }}
</div>
Expand Down
6 changes: 3 additions & 3 deletions resources/views/processes/edit.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -46,7 +46,7 @@

{{-- Configuration --}}
<div
class="tab-pane fade show"
class="tab-pane show"
:class="{'active': activeTab === '' || activeTab === 'nav-config'}"
id="nav-config"
role="tabpanel"
Expand DownExpand Up@@ -375,7 +375,7 @@ class="invalid-feedback"
</div>

{{-- Notifications --}}
<div class="tab-pane fade show p-3" id="nav-notifications" role="tabpanel"
<div class="tab-pane show p-3" id="nav-notifications" role="tabpanel"
aria-labelledby="nav-notifications-tab">
<div class="form-group p-0">

Expand DownExpand Up@@ -530,7 +530,7 @@ class="custom-control-input">
{{-- Addons --}}
@isset($addons)
@foreach ($addons as $addon)
<div class="tab-pane fade show" id="{{$addon['id']}}" role="tabpanel"
<div class="tab-pane show" id="{{$addon['id']}}" role="tabpanel"
aria-labelledby="nav-notifications-tab">
{!! $addon['content'] !!}
</div>
Expand Down
4 changes: 2 additions & 2 deletions resources/views/processes/screens/edit.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,7 +38,7 @@

<div class="card card-body card-body-nav-tabs">
<div class="tab-content" id="nav-tabContent">
<div class="tab-pane fade show active" id="nav-config" role="tabpanel" aria-labelledby="nav-config-tab">
<div class="tab-pane show active" id="nav-config" role="tabpanel" aria-labelledby="nav-config-tab">
<required></required>
<div class="form-group">
{!! Form::label('title', __('Name') . '<small class="ml-1">*</small>', [], false) !!}
Expand DownExpand Up@@ -76,7 +76,7 @@
</div>
@isset($addons)
@foreach ($addons as $addon)
<div class="tab-pane fade show" id="{{$addon['id']}}" role="tabpanel" aria-labelledby="'nav-tab-'+ {{$addon['id']}}">
<div class="tab-pane show" id="{{$addon['id']}}" role="tabpanel" aria-labelledby="'nav-tab-'+ {{$addon['id']}}">
{!! $addon['content'] !!}
</div>
@endforeach
Expand Down
4 changes: 2 additions & 2 deletions resources/views/processes/scripts/edit.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -39,7 +39,7 @@

<div class="card card-body card-body-nav-tabs">
<div class="tab-content" id="nav-tabContent">
<div class="tab-pane fade show active" id="nav-config" role="tabpanel" aria-labelledby="nav-config-tab">
<div class="tab-pane show active" id="nav-config" role="tabpanel" aria-labelledby="nav-config-tab">
<required></required>
<div class="form-group">
{!! Form::label('title', __('Name') . '<small class="ml-1">*</small>', [], false) !!}
Expand DownExpand Up@@ -130,7 +130,7 @@
</div>
@isset($addons)
@foreach ($addons as $addon)
<div class="tab-pane fade show" id="{{$addon['id']}}" role="tabpanel" aria-labelledby="'nav-tab-'+ {{$addon['id']}}">
<div class="tab-pane show" id="{{$addon['id']}}" role="tabpanel" aria-labelledby="'nav-tab-'+ {{$addon['id']}}">
{!! $addon['content'] !!}
</div>
@endforeach
Expand Down
4 changes: 2 additions & 2 deletions resources/views/processes/signals/edit.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,7 +33,7 @@

<div class="tab-content" id="nav-tabContent">

<div class="card card-body border-top-0 tab-pane p-3 fade show active" id="nav-detail" role="tabpanel" aria-labelledby="nav-detail-tab">
<div class="card card-body border-top-0 tab-pane p-3 show active" id="nav-detail" role="tabpanel" aria-labelledby="nav-detail-tab">
<div class="modal-body">
<required></required>
<div class="form-group">
Expand DownExpand Up@@ -68,7 +68,7 @@
</div>
@endif
</div>
<div class="card card-body border-top-0 tab-pane p-3 fade" id="nav-catch" role="tabpanel" aria-labelledby="nav-catch-tab">
<div class="card card-body border-top-0 tab-pane p-3" id="nav-catch" role="tabpanel" aria-labelledby="nav-catch-tab">
<catch-listing ref="catchList" :filter="filter" items="{{json_encode($signal['processes'])}}" />
</div>

Expand Down
2 changes: 1 addition & 1 deletion resources/views/requests/index.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -52,7 +52,7 @@ function() use ($title) { return [__($title), null]; }
</counter-card-group>

<div class="tab-content" id="requests-tabContent">
<div class="tab-pane fade show active" id="inbox" role="tabpanel" aria-labelledby="inbox-tab">
<div class="tab-pane show active" id="inbox" role="tabpanel" aria-labelledby="inbox-tab">

<div class="card card-body requests-list-body">
<div id="search-bar" class="search advanced-search mb-2">
Expand Down
18 changes: 9 additions & 9 deletions resources/views/requests/show.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -109,7 +109,7 @@
role="tabpanel" aria-labelledby="errors-tab">
<request-errors :errors="errorLogs"></request-errors>
</div>
<div class="tab-pane fade show card card-body border-top-0 p-0" :class="{ active: activePending }"
<div class="tab-pane show card card-body border-top-0 p-0" :class="{ active: activePending }"
id="pending" role="tabpanel" aria-labelledby="pending-tab">
<request-detail ref="pending" :process-request-id="requestId" status="ACTIVE"
:is-process-manager="{{ $isProcessManager ? 'true' : 'false' }}"
Expand DownExpand Up@@ -187,20 +187,20 @@ class="tab-pane card card-body border-top-0 p-3">
</div>
@endcan
@endif
<div class="tab-pane fade card card-body border-top-0 p-0" id="completed" role="tabpanel"
<div class="tab-pane card card-body border-top-0 p-0" id="completed" role="tabpanel"
aria-labelledby="completed-tab">
<request-detail ref="completed" :process-request-id="requestId" status="CLOSED"
:is-admin="{{ Auth::user()->is_administrator ? 'true' : 'false' }}">
</request-detail>
</div>

<template v-for="{ tab, component } in packages">
<div class="tab-pane fade card card-body border-top-0 p-0" :id="tab.target" role="tabpanel">
<div class="tab-pane card card-body border-top-0 p-0" :id="tab.target" role="tabpanel">
<component :is="component" :process-request-id="requestId"></component>
</div>
</template>

<div class="tab-pane fade card card-body border-top-0 p-3" id="files" role="tabpanel"
<div class="tab-pane card card-body border-top-0 p-3" id="files" role="tabpanel"
aria-labelledby="files-tab">
<div class="card">
<div>
Expand DownExpand Up@@ -228,12 +228,12 @@ class="tab-pane card card-body border-top-0 p-3">
</div>
</div>
</div>
<div class="tab-pane fade card card-body border-top-0 p-0" id="forms" role="tabpanel"
<div class="tab-pane card card-body border-top-0 p-0" id="forms" role="tabpanel"
aria-labelledby="forms-tab" v-show="canViewPrint">
<request-screens :id="requestId" :information="dataSummary" ref="forms">
</request-screens>
</div>
<div v-if="activeTab === 'overview'" class="tab-pane fade p-0" id="overview" role="tabpanel"
<div v-if="activeTab === 'overview'" class="tab-pane p-0" id="overview" role="tabpanel"
aria-labelledby="overview-tab">
<div class="card" style="border-top: none !important;">
<div class="card-body">
Expand DownExpand Up@@ -267,7 +267,7 @@ class="tab-pane card card-body border-top-0 p-3">

@isset($addons)
@foreach ($addons as $addon)
<div class="tab-pane fade show" id="{{ $addon['id'] }}" role="tabpanel"
<div class="tab-pane show" id="{{ $addon['id'] }}" role="tabpanel"
aria-labelledby="{{ $addon['id'] }}">
{!! $addon['content'] !!}
</div>
Expand DownExpand Up@@ -326,7 +326,7 @@ class="tab-pane card card-body border-top-0 p-3">
<div
v-if="showInfo"
id="details"
v-bind:class="{ 'tab-pane':true, fade: true, show: showInfo, active: showInfo }"
v-bind:class="{ 'tab-pane':true, show: showInfo, active: showInfo }"
role="tabpanel"
aria-labelledby="details-tab"
>
Expand DownExpand Up@@ -453,7 +453,7 @@ class="btn btn-outline-info btn-block"
<div
v-if="!showInfo"
id="comments"
v-bind:class="{ 'tab-pane':true, fade: true, show: !showInfo, active: !showInfo }"
v-bind:class="{ 'tab-pane':true, show: !showInfo, active: !showInfo }"
role="tabpanel"
aria-labelledby="comments-tab"
>
Expand Down
4 changes: 2 additions & 2 deletions resources/views/requests/showMobile.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -83,7 +83,7 @@ class="tab-content"
>
<div
id="tasks"
class="tab-pane fade show card card-body border-top-0 p-3 active"
class="tab-pane show card card-body border-top-0 p-3 active"
role="tabpanel"
aria-labelledby="tasks-tab"
>
Expand All@@ -110,7 +110,7 @@ class="tab-pane card card-body border-top-0 p-3"

<div
id="files"
class="tab-pane fade card card-body border-top-0 p-3"
class="tab-pane card card-body border-top-0 p-3"
role="tabpanel"
aria-labelledby="files-tab"
>
Expand Down
4 changes: 2 additions & 2 deletions resources/views/tasks/edit.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -164,7 +164,7 @@ class="card border-0"
<div
v-if="showInfo"
id="details"
v-bind:class="{ 'tab-pane':true, fade: true, show: showInfo, active: showInfo }"
v-bind:class="{ 'tab-pane':true, show: showInfo, active: showInfo }"
role="tabpanel"
aria-labelledby="details-tab">
<div class="ml-md-3 mt-3 mt-md-0">
Expand DownExpand Up@@ -313,7 +313,7 @@ class="d-inline-flex pull-left align-items-center"
<div
v-if="!showInfo"
id="comments"
v-bind:class="{ 'tab-pane':true, fade: true, show: !showInfo, active: !showInfo }"
v-bind:class="{ 'tab-pane':true, show: !showInfo, active: !showInfo }"
role="tabpanel"
aria-labelledby="comments-tab">
<div class="ml-md-3 mt-md-0 mt-3 collapse-content">
Expand Down
2 changes: 1 addition & 1 deletion resources/views/tasks/index.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -77,7 +77,7 @@ class="nav-link task-nav-link"
</ul>

<div class="tab-content" id="task-tabContent">
<div class="tab-pane fade show active" id="inbox" role="tabpanel" aria-labelledby="inbox-tab">
<div class="tab-pane show active" id="inbox" role="tabpanel" aria-labelledby="inbox-tab">
<div class="card card-body task-list-body">
<div id="search-bar" class="search advanced-search mb-2">
<div class="d-flex">
Expand Down
4 changes: 2 additions & 2 deletions resources/views/templates/configure.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -36,7 +36,7 @@
</nav>
<div class="card card-body card-body-nav-tabs">
<div class="tab-content" id="nav-tabContent">
<div class="tab-pane fade show active" id="nav-config" role="tabpanel"
<div class="tab-pane show active" id="nav-config" role="tabpanel"
aria-labelledby="nav-config-tab">
<required></required>
@if ($type === 'process')
Expand All@@ -59,7 +59,7 @@
</div>
@isset($addons)
@foreach ($addons as $addon)
<div class="tab-pane fade show" id="{{$addon['id']}}" role="tabpanel"
<div class="tab-pane show" id="{{$addon['id']}}" role="tabpanel"
aria-labelledby="nav-notifications-tab">
{!! $addon['content'] !!}
</div>
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length \u003e 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

FOUR-20281: [WINTER] Remove fades on tab switching#7824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryancooley merged 4 commits into from
Jan 23, 2025
Merged

FOUR-20281: [WINTER] Remove fades on tab switching #7824

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8573753
FOUR-20281 : S2: Remove fades
hjonathan Nov 25, 2024
7658dea
Merge remote-tracking branch 'origin/release-2024-fall' into feature/…
pmPaulis Dec 4, 2024
9688ae5
Merge pull request #7763 from ProcessMaker/feature/FOUR-20281
pmPaulis Dec 13, 2024
416e506
Merge remote-tracking branch 'origin/release-2025-winter' into epic/F…
pmPaulis Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions resources/views/admin/users/index.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,13 +33,13 @@

<div>
<div class="tab-content">
<div class="tab-pane fade show active" id="nav-users" role="tabpanel" aria-labelledby="nav-users-tab">
<div class="tab-pane show active" id="nav-users" role="tabpanel" aria-labelledby="nav-users-tab">
<div class="card card-body p-3 border-top-0">
@include('admin.users.list')
</div>
</div>

<div class="tab-pane fade show" id="nav-deleted-users" role="tabpanel" aria-labelledby="nav-deleted-users-tab">
<div class="tab-pane show" id="nav-deleted-users" role="tabpanel" aria-labelledby="nav-deleted-users-tab">
<div class="card card-body p-3 border-top-0">
@include('admin.users.deletedUsers')
</div>
Expand Down
12 changes: 6 additions & 6 deletions resources/views/components/categorized_resource.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
<div class="px-3 page-content" id="categorizedList" style="display:none">
@php
$firstTab = $secondTab = 'nav-item nav-link';
$firstContent = $secondContent = 'tab-pane fade show';
$firstContent = $secondContent = 'tab-pane show';

$catListWebRoute = str_replace('.edit', '.index', $catConfig->routes->editCategoryWeb);
$showCategoriesTab = $catListWebRoute === \Request::route()->getName() || $listConfig->countCategories === 0
Expand DownExpand Up@@ -127,7 +127,7 @@ class="nav-item nav-link"
</div>
@if(isset($templatesList))
@can('view-process-templates')
<div class="tab-pane fade" id="nav-templates" role="tabpanel" aria-labelledby="nav-templates-tab">
<div class="tab-pane" id="nav-templates" role="tabpanel" aria-labelledby="nav-templates-tab">
<div class="card card-body p-3 border-top-0">
{{ $templatesList }}
</div>
Expand All@@ -139,7 +139,7 @@ class="nav-item nav-link"
</div>
</div>
@isset($tabs[3])
<div class="tab-pane fade" id="nav-archived" role="tabpanel" aria-labelledby="nav-archived-tab">
<div class="tab-pane" id="nav-archived" role="tabpanel" aria-labelledby="nav-archived-tab">
<div class="card card-body p-3 border-top-0">
{{ $archivedList }}
</div>
Expand All@@ -156,13 +156,13 @@ class="{{$secondContent}}"
{{ $categoryList }}
</div>
</div>
<div class="tab-pane fade" id="nav-myTemplates" role="tabpanel" aria-labelledby="nav-myTemplates-tab">
<div class="tab-pane" id="nav-myTemplates" role="tabpanel" aria-labelledby="nav-myTemplates-tab">
<div class="card card-body p-3 border-top-0">
{{ $myTemplatesList }}
</div>
</div>
<div
class="tab-pane fade"
class="tab-pane"
id="nav-publicTemplates"
role="tabpanel"
aria-labelledby="nav-publicTemplates-tab"
Expand All@@ -178,7 +178,7 @@ class="tab-pane fade"
</div>
</div>
@isset($tabs[2])
<div class="tab-pane fade" id="nav-archived" role="tabpanel" aria-labelledby="nav-archived-tab">
<div class="tab-pane" id="nav-archived" role="tabpanel" aria-labelledby="nav-archived-tab">
<div class="card card-body p-3 border-top-0">
{{ $archivedList }}
</div>
Expand Down
6 changes: 3 additions & 3 deletions resources/views/processes/edit.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -46,7 +46,7 @@

{{-- Configuration --}}
<div
class="tab-pane fade show"
class="tab-pane show"
:class="{'active': activeTab === '' || activeTab === 'nav-config'}"
id="nav-config"
role="tabpanel"
Expand DownExpand Up@@ -375,7 +375,7 @@ class="invalid-feedback"
</div>

{{-- Notifications --}}
<div class="tab-pane fade show p-3" id="nav-notifications" role="tabpanel"
<div class="tab-pane show p-3" id="nav-notifications" role="tabpanel"
aria-labelledby="nav-notifications-tab">
<div class="form-group p-0">

Expand DownExpand Up@@ -530,7 +530,7 @@ class="custom-control-input">
{{-- Addons --}}
@isset($addons)
@foreach ($addons as $addon)
<div class="tab-pane fade show" id="{{$addon['id']}}" role="tabpanel"
<div class="tab-pane show" id="{{$addon['id']}}" role="tabpanel"
aria-labelledby="nav-notifications-tab">
{!! $addon['content'] !!}
</div>
Expand Down
4 changes: 2 additions & 2 deletions resources/views/processes/screens/edit.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,7 +38,7 @@

<div class="card card-body card-body-nav-tabs">
<div class="tab-content" id="nav-tabContent">
<div class="tab-pane fade show active" id="nav-config" role="tabpanel" aria-labelledby="nav-config-tab">
<div class="tab-pane show active" id="nav-config" role="tabpanel" aria-labelledby="nav-config-tab">
<required></required>
<div class="form-group">
{!! Form::label('title', __('Name') . '<small class="ml-1">*</small>', [], false) !!}
Expand DownExpand Up@@ -76,7 +76,7 @@
</div>
@isset($addons)
@foreach ($addons as $addon)
<div class="tab-pane fade show" id="{{$addon['id']}}" role="tabpanel" aria-labelledby="'nav-tab-'+ {{$addon['id']}}">
<div class="tab-pane show" id="{{$addon['id']}}" role="tabpanel" aria-labelledby="'nav-tab-'+ {{$addon['id']}}">
{!! $addon['content'] !!}
</div>
@endforeach
Expand Down
4 changes: 2 additions & 2 deletions resources/views/processes/scripts/edit.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -39,7 +39,7 @@

<div class="card card-body card-body-nav-tabs">
<div class="tab-content" id="nav-tabContent">
<div class="tab-pane fade show active" id="nav-config" role="tabpanel" aria-labelledby="nav-config-tab">
<div class="tab-pane show active" id="nav-config" role="tabpanel" aria-labelledby="nav-config-tab">
<required></required>
<div class="form-group">
{!! Form::label('title', __('Name') . '<small class="ml-1">*</small>', [], false) !!}
Expand DownExpand Up@@ -130,7 +130,7 @@
</div>
@isset($addons)
@foreach ($addons as $addon)
<div class="tab-pane fade show" id="{{$addon['id']}}" role="tabpanel" aria-labelledby="'nav-tab-'+ {{$addon['id']}}">
<div class="tab-pane show" id="{{$addon['id']}}" role="tabpanel" aria-labelledby="'nav-tab-'+ {{$addon['id']}}">
{!! $addon['content'] !!}
</div>
@endforeach
Expand Down
4 changes: 2 additions & 2 deletions resources/views/processes/signals/edit.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,7 +33,7 @@

<div class="tab-content" id="nav-tabContent">

<div class="card card-body border-top-0 tab-pane p-3 fade show active" id="nav-detail" role="tabpanel" aria-labelledby="nav-detail-tab">
<div class="card card-body border-top-0 tab-pane p-3 show active" id="nav-detail" role="tabpanel" aria-labelledby="nav-detail-tab">
<div class="modal-body">
<required></required>
<div class="form-group">
Expand DownExpand Up@@ -68,7 +68,7 @@
</div>
@endif
</div>
<div class="card card-body border-top-0 tab-pane p-3 fade" id="nav-catch" role="tabpanel" aria-labelledby="nav-catch-tab">
<div class="card card-body border-top-0 tab-pane p-3" id="nav-catch" role="tabpanel" aria-labelledby="nav-catch-tab">
<catch-listing ref="catchList" :filter="filter" items="{{json_encode($signal['processes'])}}" />
</div>

Expand Down
2 changes: 1 addition & 1 deletion resources/views/requests/index.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -52,7 +52,7 @@ function() use ($title) { return [__($title), null]; }
</counter-card-group>

<div class="tab-content" id="requests-tabContent">
<div class="tab-pane fade show active" id="inbox" role="tabpanel" aria-labelledby="inbox-tab">
<div class="tab-pane show active" id="inbox" role="tabpanel" aria-labelledby="inbox-tab">

<div class="card card-body requests-list-body">
<div id="search-bar" class="search advanced-search mb-2">
Expand Down
18 changes: 9 additions & 9 deletions resources/views/requests/show.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -109,7 +109,7 @@
role="tabpanel" aria-labelledby="errors-tab">
<request-errors :errors="errorLogs"></request-errors>
</div>
<div class="tab-pane fade show card card-body border-top-0 p-0" :class="{ active: activePending }"
<div class="tab-pane show card card-body border-top-0 p-0" :class="{ active: activePending }"
id="pending" role="tabpanel" aria-labelledby="pending-tab">
<request-detail ref="pending" :process-request-id="requestId" status="ACTIVE"
:is-process-manager="{{ $isProcessManager ? 'true' : 'false' }}"
Expand DownExpand Up@@ -187,20 +187,20 @@ class="tab-pane card card-body border-top-0 p-3">
</div>
@endcan
@endif
<div class="tab-pane fade card card-body border-top-0 p-0" id="completed" role="tabpanel"
<div class="tab-pane card card-body border-top-0 p-0" id="completed" role="tabpanel"
aria-labelledby="completed-tab">
<request-detail ref="completed" :process-request-id="requestId" status="CLOSED"
:is-admin="{{ Auth::user()->is_administrator ? 'true' : 'false' }}">
</request-detail>
</div>

<template v-for="{ tab, component } in packages">
<div class="tab-pane fade card card-body border-top-0 p-0" :id="tab.target" role="tabpanel">
<div class="tab-pane card card-body border-top-0 p-0" :id="tab.target" role="tabpanel">
<component :is="component" :process-request-id="requestId"></component>
</div>
</template>

<div class="tab-pane fade card card-body border-top-0 p-3" id="files" role="tabpanel"
<div class="tab-pane card card-body border-top-0 p-3" id="files" role="tabpanel"
aria-labelledby="files-tab">
<div class="card">
<div>
Expand DownExpand Up@@ -228,12 +228,12 @@ class="tab-pane card card-body border-top-0 p-3">
</div>
</div>
</div>
<div class="tab-pane fade card card-body border-top-0 p-0" id="forms" role="tabpanel"
<div class="tab-pane card card-body border-top-0 p-0" id="forms" role="tabpanel"
aria-labelledby="forms-tab" v-show="canViewPrint">
<request-screens :id="requestId" :information="dataSummary" ref="forms">
</request-screens>
</div>
<div v-if="activeTab === 'overview'" class="tab-pane fade p-0" id="overview" role="tabpanel"
<div v-if="activeTab === 'overview'" class="tab-pane p-0" id="overview" role="tabpanel"
aria-labelledby="overview-tab">
<div class="card" style="border-top: none !important;">
<div class="card-body">
Expand DownExpand Up@@ -267,7 +267,7 @@ class="tab-pane card card-body border-top-0 p-3">

@isset($addons)
@foreach ($addons as $addon)
<div class="tab-pane fade show" id="{{ $addon['id'] }}" role="tabpanel"
<div class="tab-pane show" id="{{ $addon['id'] }}" role="tabpanel"
aria-labelledby="{{ $addon['id'] }}">
{!! $addon['content'] !!}
</div>
Expand DownExpand Up@@ -326,7 +326,7 @@ class="tab-pane card card-body border-top-0 p-3">
<div
v-if="showInfo"
id="details"
v-bind:class="{ 'tab-pane':true, fade: true, show: showInfo, active: showInfo }"
v-bind:class="{ 'tab-pane':true, show: showInfo, active: showInfo }"
role="tabpanel"
aria-labelledby="details-tab"
>
Expand DownExpand Up@@ -453,7 +453,7 @@ class="btn btn-outline-info btn-block"
<div
v-if="!showInfo"
id="comments"
v-bind:class="{ 'tab-pane':true, fade: true, show: !showInfo, active: !showInfo }"
v-bind:class="{ 'tab-pane':true, show: !showInfo, active: !showInfo }"
role="tabpanel"
aria-labelledby="comments-tab"
>
Expand Down
4 changes: 2 additions & 2 deletions resources/views/requests/showMobile.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -83,7 +83,7 @@ class="tab-content"
>
<div
id="tasks"
class="tab-pane fade show card card-body border-top-0 p-3 active"
class="tab-pane show card card-body border-top-0 p-3 active"
role="tabpanel"
aria-labelledby="tasks-tab"
>
Expand All@@ -110,7 +110,7 @@ class="tab-pane card card-body border-top-0 p-3"

<div
id="files"
class="tab-pane fade card card-body border-top-0 p-3"
class="tab-pane card card-body border-top-0 p-3"
role="tabpanel"
aria-labelledby="files-tab"
>
Expand Down
4 changes: 2 additions & 2 deletions resources/views/tasks/edit.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -164,7 +164,7 @@ class="card border-0"
<div
v-if="showInfo"
id="details"
v-bind:class="{ 'tab-pane':true, fade: true, show: showInfo, active: showInfo }"
v-bind:class="{ 'tab-pane':true, show: showInfo, active: showInfo }"
role="tabpanel"
aria-labelledby="details-tab">
<div class="ml-md-3 mt-3 mt-md-0">
Expand DownExpand Up@@ -313,7 +313,7 @@ class="d-inline-flex pull-left align-items-center"
<div
v-if="!showInfo"
id="comments"
v-bind:class="{ 'tab-pane':true, fade: true, show: !showInfo, active: !showInfo }"
v-bind:class="{ 'tab-pane':true, show: !showInfo, active: !showInfo }"
role="tabpanel"
aria-labelledby="comments-tab">
<div class="ml-md-3 mt-md-0 mt-3 collapse-content">
Expand Down
2 changes: 1 addition & 1 deletion resources/views/tasks/index.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -77,7 +77,7 @@ class="nav-link task-nav-link"
</ul>

<div class="tab-content" id="task-tabContent">
<div class="tab-pane fade show active" id="inbox" role="tabpanel" aria-labelledby="inbox-tab">
<div class="tab-pane show active" id="inbox" role="tabpanel" aria-labelledby="inbox-tab">
<div class="card card-body task-list-body">
<div id="search-bar" class="search advanced-search mb-2">
<div class="d-flex">
Expand Down
4 changes: 2 additions & 2 deletions resources/views/templates/configure.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -36,7 +36,7 @@
</nav>
<div class="card card-body card-body-nav-tabs">
<div class="tab-content" id="nav-tabContent">
<div class="tab-pane fade show active" id="nav-config" role="tabpanel"
<div class="tab-pane show active" id="nav-config" role="tabpanel"
aria-labelledby="nav-config-tab">
<required></required>
@if ($type === 'process')
Expand All@@ -59,7 +59,7 @@
</div>
@isset($addons)
@foreach ($addons as $addon)
<div class="tab-pane fade show" id="{{$addon['id']}}" role="tabpanel"
<div class="tab-pane show" id="{{$addon['id']}}" role="tabpanel"
aria-labelledby="nav-notifications-tab">
{!! $addon['content'] !!}
</div>
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

FOUR-20281: [WINTER] Remove fades on tab switching#7824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryancooley merged 4 commits into from
Jan 23, 2025
Merged

FOUR-20281: [WINTER] Remove fades on tab switching #7824

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8573753
FOUR-20281 : S2: Remove fades
hjonathan Nov 25, 2024
7658dea
Merge remote-tracking branch 'origin/release-2024-fall' into feature/…
pmPaulis Dec 4, 2024
9688ae5
Merge pull request #7763 from ProcessMaker/feature/FOUR-20281
pmPaulis Dec 13, 2024
416e506
Merge remote-tracking branch 'origin/release-2025-winter' into epic/F…
pmPaulis Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions resources/views/admin/users/index.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,13 +33,13 @@

<div>
<div class="tab-content">
<div class="tab-pane fade show active" id="nav-users" role="tabpanel" aria-labelledby="nav-users-tab">
<div class="tab-pane show active" id="nav-users" role="tabpanel" aria-labelledby="nav-users-tab">
<div class="card card-body p-3 border-top-0">
@include('admin.users.list')
</div>
</div>

<div class="tab-pane fade show" id="nav-deleted-users" role="tabpanel" aria-labelledby="nav-deleted-users-tab">
<div class="tab-pane show" id="nav-deleted-users" role="tabpanel" aria-labelledby="nav-deleted-users-tab">
<div class="card card-body p-3 border-top-0">
@include('admin.users.deletedUsers')
</div>
Expand Down
12 changes: 6 additions & 6 deletions resources/views/components/categorized_resource.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
<div class="px-3 page-content" id="categorizedList" style="display:none">
@php
$firstTab = $secondTab = 'nav-item nav-link';
$firstContent = $secondContent = 'tab-pane fade show';
$firstContent = $secondContent = 'tab-pane show';

$catListWebRoute = str_replace('.edit', '.index', $catConfig->routes->editCategoryWeb);
$showCategoriesTab = $catListWebRoute === \Request::route()->getName() || $listConfig->countCategories === 0
Expand DownExpand Up@@ -127,7 +127,7 @@ class="nav-item nav-link"
</div>
@if(isset($templatesList))
@can('view-process-templates')
<div class="tab-pane fade" id="nav-templates" role="tabpanel" aria-labelledby="nav-templates-tab">
<div class="tab-pane" id="nav-templates" role="tabpanel" aria-labelledby="nav-templates-tab">
<div class="card card-body p-3 border-top-0">
{{ $templatesList }}
</div>
Expand All@@ -139,7 +139,7 @@ class="nav-item nav-link"
</div>
</div>
@isset($tabs[3])
<div class="tab-pane fade" id="nav-archived" role="tabpanel" aria-labelledby="nav-archived-tab">
<div class="tab-pane" id="nav-archived" role="tabpanel" aria-labelledby="nav-archived-tab">
<div class="card card-body p-3 border-top-0">
{{ $archivedList }}
</div>
Expand All@@ -156,13 +156,13 @@ class="{{$secondContent}}"
{{ $categoryList }}
</div>
</div>
<div class="tab-pane fade" id="nav-myTemplates" role="tabpanel" aria-labelledby="nav-myTemplates-tab">
<div class="tab-pane" id="nav-myTemplates" role="tabpanel" aria-labelledby="nav-myTemplates-tab">
<div class="card card-body p-3 border-top-0">
{{ $myTemplatesList }}
</div>
</div>
<div
class="tab-pane fade"
class="tab-pane"
id="nav-publicTemplates"
role="tabpanel"
aria-labelledby="nav-publicTemplates-tab"
Expand All@@ -178,7 +178,7 @@ class="tab-pane fade"
</div>
</div>
@isset($tabs[2])
<div class="tab-pane fade" id="nav-archived" role="tabpanel" aria-labelledby="nav-archived-tab">
<div class="tab-pane" id="nav-archived" role="tabpanel" aria-labelledby="nav-archived-tab">
<div class="card card-body p-3 border-top-0">
{{ $archivedList }}
</div>
Expand Down
6 changes: 3 additions & 3 deletions resources/views/processes/edit.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -46,7 +46,7 @@

{{-- Configuration --}}
<div
class="tab-pane fade show"
class="tab-pane show"
:class="{'active': activeTab === '' || activeTab === 'nav-config'}"
id="nav-config"
role="tabpanel"
Expand DownExpand Up@@ -375,7 +375,7 @@ class="invalid-feedback"
</div>

{{-- Notifications --}}
<div class="tab-pane fade show p-3" id="nav-notifications" role="tabpanel"
<div class="tab-pane show p-3" id="nav-notifications" role="tabpanel"
aria-labelledby="nav-notifications-tab">
<div class="form-group p-0">

Expand DownExpand Up@@ -530,7 +530,7 @@ class="custom-control-input">
{{-- Addons --}}
@isset($addons)
@foreach ($addons as $addon)
<div class="tab-pane fade show" id="{{$addon['id']}}" role="tabpanel"
<div class="tab-pane show" id="{{$addon['id']}}" role="tabpanel"
aria-labelledby="nav-notifications-tab">
{!! $addon['content'] !!}
</div>
Expand Down
4 changes: 2 additions & 2 deletions resources/views/processes/screens/edit.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,7 +38,7 @@

<div class="card card-body card-body-nav-tabs">
<div class="tab-content" id="nav-tabContent">
<div class="tab-pane fade show active" id="nav-config" role="tabpanel" aria-labelledby="nav-config-tab">
<div class="tab-pane show active" id="nav-config" role="tabpanel" aria-labelledby="nav-config-tab">
<required></required>
<div class="form-group">
{!! Form::label('title', __('Name') . '<small class="ml-1">*</small>', [], false) !!}
Expand DownExpand Up@@ -76,7 +76,7 @@
</div>
@isset($addons)
@foreach ($addons as $addon)
<div class="tab-pane fade show" id="{{$addon['id']}}" role="tabpanel" aria-labelledby="'nav-tab-'+ {{$addon['id']}}">
<div class="tab-pane show" id="{{$addon['id']}}" role="tabpanel" aria-labelledby="'nav-tab-'+ {{$addon['id']}}">
{!! $addon['content'] !!}
</div>
@endforeach
Expand Down
4 changes: 2 additions & 2 deletions resources/views/processes/scripts/edit.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -39,7 +39,7 @@

<div class="card card-body card-body-nav-tabs">
<div class="tab-content" id="nav-tabContent">
<div class="tab-pane fade show active" id="nav-config" role="tabpanel" aria-labelledby="nav-config-tab">
<div class="tab-pane show active" id="nav-config" role="tabpanel" aria-labelledby="nav-config-tab">
<required></required>
<div class="form-group">
{!! Form::label('title', __('Name') . '<small class="ml-1">*</small>', [], false) !!}
Expand DownExpand Up@@ -130,7 +130,7 @@
</div>
@isset($addons)
@foreach ($addons as $addon)
<div class="tab-pane fade show" id="{{$addon['id']}}" role="tabpanel" aria-labelledby="'nav-tab-'+ {{$addon['id']}}">
<div class="tab-pane show" id="{{$addon['id']}}" role="tabpanel" aria-labelledby="'nav-tab-'+ {{$addon['id']}}">
{!! $addon['content'] !!}
</div>
@endforeach
Expand Down
4 changes: 2 additions & 2 deletions resources/views/processes/signals/edit.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,7 +33,7 @@

<div class="tab-content" id="nav-tabContent">

<div class="card card-body border-top-0 tab-pane p-3 fade show active" id="nav-detail" role="tabpanel" aria-labelledby="nav-detail-tab">
<div class="card card-body border-top-0 tab-pane p-3 show active" id="nav-detail" role="tabpanel" aria-labelledby="nav-detail-tab">
<div class="modal-body">
<required></required>
<div class="form-group">
Expand DownExpand Up@@ -68,7 +68,7 @@
</div>
@endif
</div>
<div class="card card-body border-top-0 tab-pane p-3 fade" id="nav-catch" role="tabpanel" aria-labelledby="nav-catch-tab">
<div class="card card-body border-top-0 tab-pane p-3" id="nav-catch" role="tabpanel" aria-labelledby="nav-catch-tab">
<catch-listing ref="catchList" :filter="filter" items="{{json_encode($signal['processes'])}}" />
</div>

Expand Down
2 changes: 1 addition & 1 deletion resources/views/requests/index.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -52,7 +52,7 @@ function() use ($title) { return [__($title), null]; }
</counter-card-group>

<div class="tab-content" id="requests-tabContent">
<div class="tab-pane fade show active" id="inbox" role="tabpanel" aria-labelledby="inbox-tab">
<div class="tab-pane show active" id="inbox" role="tabpanel" aria-labelledby="inbox-tab">

<div class="card card-body requests-list-body">
<div id="search-bar" class="search advanced-search mb-2">
Expand Down
18 changes: 9 additions & 9 deletions resources/views/requests/show.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -109,7 +109,7 @@
role="tabpanel" aria-labelledby="errors-tab">
<request-errors :errors="errorLogs"></request-errors>
</div>
<div class="tab-pane fade show card card-body border-top-0 p-0" :class="{ active: activePending }"
<div class="tab-pane show card card-body border-top-0 p-0" :class="{ active: activePending }"
id="pending" role="tabpanel" aria-labelledby="pending-tab">
<request-detail ref="pending" :process-request-id="requestId" status="ACTIVE"
:is-process-manager="{{ $isProcessManager ? 'true' : 'false' }}"
Expand DownExpand Up@@ -187,20 +187,20 @@ class="tab-pane card card-body border-top-0 p-3">
</div>
@endcan
@endif
<div class="tab-pane fade card card-body border-top-0 p-0" id="completed" role="tabpanel"
<div class="tab-pane card card-body border-top-0 p-0" id="completed" role="tabpanel"
aria-labelledby="completed-tab">
<request-detail ref="completed" :process-request-id="requestId" status="CLOSED"
:is-admin="{{ Auth::user()->is_administrator ? 'true' : 'false' }}">
</request-detail>
</div>

<template v-for="{ tab, component } in packages">
<div class="tab-pane fade card card-body border-top-0 p-0" :id="tab.target" role="tabpanel">
<div class="tab-pane card card-body border-top-0 p-0" :id="tab.target" role="tabpanel">
<component :is="component" :process-request-id="requestId"></component>
</div>
</template>

<div class="tab-pane fade card card-body border-top-0 p-3" id="files" role="tabpanel"
<div class="tab-pane card card-body border-top-0 p-3" id="files" role="tabpanel"
aria-labelledby="files-tab">
<div class="card">
<div>
Expand DownExpand Up@@ -228,12 +228,12 @@ class="tab-pane card card-body border-top-0 p-3">
</div>
</div>
</div>
<div class="tab-pane fade card card-body border-top-0 p-0" id="forms" role="tabpanel"
<div class="tab-pane card card-body border-top-0 p-0" id="forms" role="tabpanel"
aria-labelledby="forms-tab" v-show="canViewPrint">
<request-screens :id="requestId" :information="dataSummary" ref="forms">
</request-screens>
</div>
<div v-if="activeTab === 'overview'" class="tab-pane fade p-0" id="overview" role="tabpanel"
<div v-if="activeTab === 'overview'" class="tab-pane p-0" id="overview" role="tabpanel"
aria-labelledby="overview-tab">
<div class="card" style="border-top: none !important;">
<div class="card-body">
Expand DownExpand Up@@ -267,7 +267,7 @@ class="tab-pane card card-body border-top-0 p-3">

@isset($addons)
@foreach ($addons as $addon)
<div class="tab-pane fade show" id="{{ $addon['id'] }}" role="tabpanel"
<div class="tab-pane show" id="{{ $addon['id'] }}" role="tabpanel"
aria-labelledby="{{ $addon['id'] }}">
{!! $addon['content'] !!}
</div>
Expand DownExpand Up@@ -326,7 +326,7 @@ class="tab-pane card card-body border-top-0 p-3">
<div
v-if="showInfo"
id="details"
v-bind:class="{ 'tab-pane':true, fade: true, show: showInfo, active: showInfo }"
v-bind:class="{ 'tab-pane':true, show: showInfo, active: showInfo }"
role="tabpanel"
aria-labelledby="details-tab"
>
Expand DownExpand Up@@ -453,7 +453,7 @@ class="btn btn-outline-info btn-block"
<div
v-if="!showInfo"
id="comments"
v-bind:class="{ 'tab-pane':true, fade: true, show: !showInfo, active: !showInfo }"
v-bind:class="{ 'tab-pane':true, show: !showInfo, active: !showInfo }"
role="tabpanel"
aria-labelledby="comments-tab"
>
Expand Down
4 changes: 2 additions & 2 deletions resources/views/requests/showMobile.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -83,7 +83,7 @@ class="tab-content"
>
<div
id="tasks"
class="tab-pane fade show card card-body border-top-0 p-3 active"
class="tab-pane show card card-body border-top-0 p-3 active"
role="tabpanel"
aria-labelledby="tasks-tab"
>
Expand All@@ -110,7 +110,7 @@ class="tab-pane card card-body border-top-0 p-3"

<div
id="files"
class="tab-pane fade card card-body border-top-0 p-3"
class="tab-pane card card-body border-top-0 p-3"
role="tabpanel"
aria-labelledby="files-tab"
>
Expand Down
4 changes: 2 additions & 2 deletions resources/views/tasks/edit.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -164,7 +164,7 @@ class="card border-0"
<div
v-if="showInfo"
id="details"
v-bind:class="{ 'tab-pane':true, fade: true, show: showInfo, active: showInfo }"
v-bind:class="{ 'tab-pane':true, show: showInfo, active: showInfo }"
role="tabpanel"
aria-labelledby="details-tab">
<div class="ml-md-3 mt-3 mt-md-0">
Expand DownExpand Up@@ -313,7 +313,7 @@ class="d-inline-flex pull-left align-items-center"
<div
v-if="!showInfo"
id="comments"
v-bind:class="{ 'tab-pane':true, fade: true, show: !showInfo, active: !showInfo }"
v-bind:class="{ 'tab-pane':true, show: !showInfo, active: !showInfo }"
role="tabpanel"
aria-labelledby="comments-tab">
<div class="ml-md-3 mt-md-0 mt-3 collapse-content">
Expand Down
2 changes: 1 addition & 1 deletion resources/views/tasks/index.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -77,7 +77,7 @@ class="nav-link task-nav-link"
</ul>

<div class="tab-content" id="task-tabContent">
<div class="tab-pane fade show active" id="inbox" role="tabpanel" aria-labelledby="inbox-tab">
<div class="tab-pane show active" id="inbox" role="tabpanel" aria-labelledby="inbox-tab">
<div class="card card-body task-list-body">
<div id="search-bar" class="search advanced-search mb-2">
<div class="d-flex">
Expand Down
4 changes: 2 additions & 2 deletions resources/views/templates/configure.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -36,7 +36,7 @@
</nav>
<div class="card card-body card-body-nav-tabs">
<div class="tab-content" id="nav-tabContent">
<div class="tab-pane fade show active" id="nav-config" role="tabpanel"
<div class="tab-pane show active" id="nav-config" role="tabpanel"
aria-labelledby="nav-config-tab">
<required></required>
@if ($type === 'process')
Expand All@@ -59,7 +59,7 @@
</div>
@isset($addons)
@foreach ($addons as $addon)
<div class="tab-pane fade show" id="{{$addon['id']}}" role="tabpanel"
<div class="tab-pane show" id="{{$addon['id']}}" role="tabpanel"
aria-labelledby="nav-notifications-tab">
{!! $addon['content'] !!}
</div>
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

FOUR-20281: [WINTER] Remove fades on tab switching#7824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryancooley merged 4 commits into from
Jan 23, 2025
Merged

FOUR-20281: [WINTER] Remove fades on tab switching #7824

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8573753
FOUR-20281 : S2: Remove fades
hjonathan Nov 25, 2024
7658dea
Merge remote-tracking branch 'origin/release-2024-fall' into feature/…
pmPaulis Dec 4, 2024
9688ae5
Merge pull request #7763 from ProcessMaker/feature/FOUR-20281
pmPaulis Dec 13, 2024
416e506
Merge remote-tracking branch 'origin/release-2025-winter' into epic/F…
pmPaulis Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions resources/views/admin/users/index.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,13 +33,13 @@

<div>
<div class="tab-content">
<div class="tab-pane fade show active" id="nav-users" role="tabpanel" aria-labelledby="nav-users-tab">
<div class="tab-pane show active" id="nav-users" role="tabpanel" aria-labelledby="nav-users-tab">
<div class="card card-body p-3 border-top-0">
@include('admin.users.list')
</div>
</div>

<div class="tab-pane fade show" id="nav-deleted-users" role="tabpanel" aria-labelledby="nav-deleted-users-tab">
<div class="tab-pane show" id="nav-deleted-users" role="tabpanel" aria-labelledby="nav-deleted-users-tab">
<div class="card card-body p-3 border-top-0">
@include('admin.users.deletedUsers')
</div>
Expand Down
12 changes: 6 additions & 6 deletions resources/views/components/categorized_resource.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
<div class="px-3 page-content" id="categorizedList" style="display:none">
@php
$firstTab = $secondTab = 'nav-item nav-link';
$firstContent = $secondContent = 'tab-pane fade show';
$firstContent = $secondContent = 'tab-pane show';

$catListWebRoute = str_replace('.edit', '.index', $catConfig->routes->editCategoryWeb);
$showCategoriesTab = $catListWebRoute === \Request::route()->getName() || $listConfig->countCategories === 0
Expand DownExpand Up@@ -127,7 +127,7 @@ class="nav-item nav-link"
</div>
@if(isset($templatesList))
@can('view-process-templates')
<div class="tab-pane fade" id="nav-templates" role="tabpanel" aria-labelledby="nav-templates-tab">
<div class="tab-pane" id="nav-templates" role="tabpanel" aria-labelledby="nav-templates-tab">
<div class="card card-body p-3 border-top-0">
{{ $templatesList }}
</div>
Expand All@@ -139,7 +139,7 @@ class="nav-item nav-link"
</div>
</div>
@isset($tabs[3])
<div class="tab-pane fade" id="nav-archived" role="tabpanel" aria-labelledby="nav-archived-tab">
<div class="tab-pane" id="nav-archived" role="tabpanel" aria-labelledby="nav-archived-tab">
<div class="card card-body p-3 border-top-0">
{{ $archivedList }}
</div>
Expand All@@ -156,13 +156,13 @@ class="{{$secondContent}}"
{{ $categoryList }}
</div>
</div>
<div class="tab-pane fade" id="nav-myTemplates" role="tabpanel" aria-labelledby="nav-myTemplates-tab">
<div class="tab-pane" id="nav-myTemplates" role="tabpanel" aria-labelledby="nav-myTemplates-tab">
<div class="card card-body p-3 border-top-0">
{{ $myTemplatesList }}
</div>
</div>
<div
class="tab-pane fade"
class="tab-pane"
id="nav-publicTemplates"
role="tabpanel"
aria-labelledby="nav-publicTemplates-tab"
Expand All@@ -178,7 +178,7 @@ class="tab-pane fade"
</div>
</div>
@isset($tabs[2])
<div class="tab-pane fade" id="nav-archived" role="tabpanel" aria-labelledby="nav-archived-tab">
<div class="tab-pane" id="nav-archived" role="tabpanel" aria-labelledby="nav-archived-tab">
<div class="card card-body p-3 border-top-0">
{{ $archivedList }}
</div>
Expand Down
6 changes: 3 additions & 3 deletions resources/views/processes/edit.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -46,7 +46,7 @@

{{-- Configuration --}}
<div
class="tab-pane fade show"
class="tab-pane show"
:class="{'active': activeTab === '' || activeTab === 'nav-config'}"
id="nav-config"
role="tabpanel"
Expand DownExpand Up@@ -375,7 +375,7 @@ class="invalid-feedback"
</div>

{{-- Notifications --}}
<div class="tab-pane fade show p-3" id="nav-notifications" role="tabpanel"
<div class="tab-pane show p-3" id="nav-notifications" role="tabpanel"
aria-labelledby="nav-notifications-tab">
<div class="form-group p-0">

Expand DownExpand Up@@ -530,7 +530,7 @@ class="custom-control-input">
{{-- Addons --}}
@isset($addons)
@foreach ($addons as $addon)
<div class="tab-pane fade show" id="{{$addon['id']}}" role="tabpanel"
<div class="tab-pane show" id="{{$addon['id']}}" role="tabpanel"
aria-labelledby="nav-notifications-tab">
{!! $addon['content'] !!}
</div>
Expand Down
4 changes: 2 additions & 2 deletions resources/views/processes/screens/edit.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,7 +38,7 @@

<div class="card card-body card-body-nav-tabs">
<div class="tab-content" id="nav-tabContent">
<div class="tab-pane fade show active" id="nav-config" role="tabpanel" aria-labelledby="nav-config-tab">
<div class="tab-pane show active" id="nav-config" role="tabpanel" aria-labelledby="nav-config-tab">
<required></required>
<div class="form-group">
{!! Form::label('title', __('Name') . '<small class="ml-1">*</small>', [], false) !!}
Expand DownExpand Up@@ -76,7 +76,7 @@
</div>
@isset($addons)
@foreach ($addons as $addon)
<div class="tab-pane fade show" id="{{$addon['id']}}" role="tabpanel" aria-labelledby="'nav-tab-'+ {{$addon['id']}}">
<div class="tab-pane show" id="{{$addon['id']}}" role="tabpanel" aria-labelledby="'nav-tab-'+ {{$addon['id']}}">
{!! $addon['content'] !!}
</div>
@endforeach
Expand Down
4 changes: 2 additions & 2 deletions resources/views/processes/scripts/edit.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -39,7 +39,7 @@

<div class="card card-body card-body-nav-tabs">
<div class="tab-content" id="nav-tabContent">
<div class="tab-pane fade show active" id="nav-config" role="tabpanel" aria-labelledby="nav-config-tab">
<div class="tab-pane show active" id="nav-config" role="tabpanel" aria-labelledby="nav-config-tab">
<required></required>
<div class="form-group">
{!! Form::label('title', __('Name') . '<small class="ml-1">*</small>', [], false) !!}
Expand DownExpand Up@@ -130,7 +130,7 @@
</div>
@isset($addons)
@foreach ($addons as $addon)
<div class="tab-pane fade show" id="{{$addon['id']}}" role="tabpanel" aria-labelledby="'nav-tab-'+ {{$addon['id']}}">
<div class="tab-pane show" id="{{$addon['id']}}" role="tabpanel" aria-labelledby="'nav-tab-'+ {{$addon['id']}}">
{!! $addon['content'] !!}
</div>
@endforeach
Expand Down
4 changes: 2 additions & 2 deletions resources/views/processes/signals/edit.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,7 +33,7 @@

<div class="tab-content" id="nav-tabContent">

<div class="card card-body border-top-0 tab-pane p-3 fade show active" id="nav-detail" role="tabpanel" aria-labelledby="nav-detail-tab">
<div class="card card-body border-top-0 tab-pane p-3 show active" id="nav-detail" role="tabpanel" aria-labelledby="nav-detail-tab">
<div class="modal-body">
<required></required>
<div class="form-group">
Expand DownExpand Up@@ -68,7 +68,7 @@
</div>
@endif
</div>
<div class="card card-body border-top-0 tab-pane p-3 fade" id="nav-catch" role="tabpanel" aria-labelledby="nav-catch-tab">
<div class="card card-body border-top-0 tab-pane p-3" id="nav-catch" role="tabpanel" aria-labelledby="nav-catch-tab">
<catch-listing ref="catchList" :filter="filter" items="{{json_encode($signal['processes'])}}" />
</div>

Expand Down
2 changes: 1 addition & 1 deletion resources/views/requests/index.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -52,7 +52,7 @@ function() use ($title) { return [__($title), null]; }
</counter-card-group>

<div class="tab-content" id="requests-tabContent">
<div class="tab-pane fade show active" id="inbox" role="tabpanel" aria-labelledby="inbox-tab">
<div class="tab-pane show active" id="inbox" role="tabpanel" aria-labelledby="inbox-tab">

<div class="card card-body requests-list-body">
<div id="search-bar" class="search advanced-search mb-2">
Expand Down
18 changes: 9 additions & 9 deletions resources/views/requests/show.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -109,7 +109,7 @@
role="tabpanel" aria-labelledby="errors-tab">
<request-errors :errors="errorLogs"></request-errors>
</div>
<div class="tab-pane fade show card card-body border-top-0 p-0" :class="{ active: activePending }"
<div class="tab-pane show card card-body border-top-0 p-0" :class="{ active: activePending }"
id="pending" role="tabpanel" aria-labelledby="pending-tab">
<request-detail ref="pending" :process-request-id="requestId" status="ACTIVE"
:is-process-manager="{{ $isProcessManager ? 'true' : 'false' }}"
Expand DownExpand Up@@ -187,20 +187,20 @@ class="tab-pane card card-body border-top-0 p-3">
</div>
@endcan
@endif
<div class="tab-pane fade card card-body border-top-0 p-0" id="completed" role="tabpanel"
<div class="tab-pane card card-body border-top-0 p-0" id="completed" role="tabpanel"
aria-labelledby="completed-tab">
<request-detail ref="completed" :process-request-id="requestId" status="CLOSED"
:is-admin="{{ Auth::user()->is_administrator ? 'true' : 'false' }}">
</request-detail>
</div>

<template v-for="{ tab, component } in packages">
<div class="tab-pane fade card card-body border-top-0 p-0" :id="tab.target" role="tabpanel">
<div class="tab-pane card card-body border-top-0 p-0" :id="tab.target" role="tabpanel">
<component :is="component" :process-request-id="requestId"></component>
</div>
</template>

<div class="tab-pane fade card card-body border-top-0 p-3" id="files" role="tabpanel"
<div class="tab-pane card card-body border-top-0 p-3" id="files" role="tabpanel"
aria-labelledby="files-tab">
<div class="card">
<div>
Expand DownExpand Up@@ -228,12 +228,12 @@ class="tab-pane card card-body border-top-0 p-3">
</div>
</div>
</div>
<div class="tab-pane fade card card-body border-top-0 p-0" id="forms" role="tabpanel"
<div class="tab-pane card card-body border-top-0 p-0" id="forms" role="tabpanel"
aria-labelledby="forms-tab" v-show="canViewPrint">
<request-screens :id="requestId" :information="dataSummary" ref="forms">
</request-screens>
</div>
<div v-if="activeTab === 'overview'" class="tab-pane fade p-0" id="overview" role="tabpanel"
<div v-if="activeTab === 'overview'" class="tab-pane p-0" id="overview" role="tabpanel"
aria-labelledby="overview-tab">
<div class="card" style="border-top: none !important;">
<div class="card-body">
Expand DownExpand Up@@ -267,7 +267,7 @@ class="tab-pane card card-body border-top-0 p-3">

@isset($addons)
@foreach ($addons as $addon)
<div class="tab-pane fade show" id="{{ $addon['id'] }}" role="tabpanel"
<div class="tab-pane show" id="{{ $addon['id'] }}" role="tabpanel"
aria-labelledby="{{ $addon['id'] }}">
{!! $addon['content'] !!}
</div>
Expand DownExpand Up@@ -326,7 +326,7 @@ class="tab-pane card card-body border-top-0 p-3">
<div
v-if="showInfo"
id="details"
v-bind:class="{ 'tab-pane':true, fade: true, show: showInfo, active: showInfo }"
v-bind:class="{ 'tab-pane':true, show: showInfo, active: showInfo }"
role="tabpanel"
aria-labelledby="details-tab"
>
Expand DownExpand Up@@ -453,7 +453,7 @@ class="btn btn-outline-info btn-block"
<div
v-if="!showInfo"
id="comments"
v-bind:class="{ 'tab-pane':true, fade: true, show: !showInfo, active: !showInfo }"
v-bind:class="{ 'tab-pane':true, show: !showInfo, active: !showInfo }"
role="tabpanel"
aria-labelledby="comments-tab"
>
Expand Down
4 changes: 2 additions & 2 deletions resources/views/requests/showMobile.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -83,7 +83,7 @@ class="tab-content"
>
<div
id="tasks"
class="tab-pane fade show card card-body border-top-0 p-3 active"
class="tab-pane show card card-body border-top-0 p-3 active"
role="tabpanel"
aria-labelledby="tasks-tab"
>
Expand All@@ -110,7 +110,7 @@ class="tab-pane card card-body border-top-0 p-3"

<div
id="files"
class="tab-pane fade card card-body border-top-0 p-3"
class="tab-pane card card-body border-top-0 p-3"
role="tabpanel"
aria-labelledby="files-tab"
>
Expand Down
4 changes: 2 additions & 2 deletions resources/views/tasks/edit.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -164,7 +164,7 @@ class="card border-0"
<div
v-if="showInfo"
id="details"
v-bind:class="{ 'tab-pane':true, fade: true, show: showInfo, active: showInfo }"
v-bind:class="{ 'tab-pane':true, show: showInfo, active: showInfo }"
role="tabpanel"
aria-labelledby="details-tab">
<div class="ml-md-3 mt-3 mt-md-0">
Expand DownExpand Up@@ -313,7 +313,7 @@ class="d-inline-flex pull-left align-items-center"
<div
v-if="!showInfo"
id="comments"
v-bind:class="{ 'tab-pane':true, fade: true, show: !showInfo, active: !showInfo }"
v-bind:class="{ 'tab-pane':true, show: !showInfo, active: !showInfo }"
role="tabpanel"
aria-labelledby="comments-tab">
<div class="ml-md-3 mt-md-0 mt-3 collapse-content">
Expand Down
2 changes: 1 addition & 1 deletion resources/views/tasks/index.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -77,7 +77,7 @@ class="nav-link task-nav-link"
</ul>

<div class="tab-content" id="task-tabContent">
<div class="tab-pane fade show active" id="inbox" role="tabpanel" aria-labelledby="inbox-tab">
<div class="tab-pane show active" id="inbox" role="tabpanel" aria-labelledby="inbox-tab">
<div class="card card-body task-list-body">
<div id="search-bar" class="search advanced-search mb-2">
<div class="d-flex">
Expand Down
4 changes: 2 additions & 2 deletions resources/views/templates/configure.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -36,7 +36,7 @@
</nav>
<div class="card card-body card-body-nav-tabs">
<div class="tab-content" id="nav-tabContent">
<div class="tab-pane fade show active" id="nav-config" role="tabpanel"
<div class="tab-pane show active" id="nav-config" role="tabpanel"
aria-labelledby="nav-config-tab">
<required></required>
@if ($type === 'process')
Expand All@@ -59,7 +59,7 @@
</div>
@isset($addons)
@foreach ($addons as $addon)
<div class="tab-pane fade show" id="{{$addon['id']}}" role="tabpanel"
<div class="tab-pane show" id="{{$addon['id']}}" role="tabpanel"
aria-labelledby="nav-notifications-tab">
{!! $addon['content'] !!}
</div>
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

FOUR-20281: [WINTER] Remove fades on tab switching#7824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryancooley merged 4 commits into from
Jan 23, 2025
Merged

FOUR-20281: [WINTER] Remove fades on tab switching #7824

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8573753
FOUR-20281 : S2: Remove fades
hjonathan Nov 25, 2024
7658dea
Merge remote-tracking branch 'origin/release-2024-fall' into feature/…
pmPaulis Dec 4, 2024
9688ae5
Merge pull request #7763 from ProcessMaker/feature/FOUR-20281
pmPaulis Dec 13, 2024
416e506
Merge remote-tracking branch 'origin/release-2025-winter' into epic/F…
pmPaulis Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions resources/views/admin/users/index.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,13 +33,13 @@

<div>
<div class="tab-content">
<div class="tab-pane fade show active" id="nav-users" role="tabpanel" aria-labelledby="nav-users-tab">
<div class="tab-pane show active" id="nav-users" role="tabpanel" aria-labelledby="nav-users-tab">
<div class="card card-body p-3 border-top-0">
@include('admin.users.list')
</div>
</div>

<div class="tab-pane fade show" id="nav-deleted-users" role="tabpanel" aria-labelledby="nav-deleted-users-tab">
<div class="tab-pane show" id="nav-deleted-users" role="tabpanel" aria-labelledby="nav-deleted-users-tab">
<div class="card card-body p-3 border-top-0">
@include('admin.users.deletedUsers')
</div>
Expand Down
12 changes: 6 additions & 6 deletions resources/views/components/categorized_resource.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
<div class="px-3 page-content" id="categorizedList" style="display:none">
@php
$firstTab = $secondTab = 'nav-item nav-link';
$firstContent = $secondContent = 'tab-pane fade show';
$firstContent = $secondContent = 'tab-pane show';

$catListWebRoute = str_replace('.edit', '.index', $catConfig->routes->editCategoryWeb);
$showCategoriesTab = $catListWebRoute === \Request::route()->getName() || $listConfig->countCategories === 0
Expand DownExpand Up@@ -127,7 +127,7 @@ class="nav-item nav-link"
</div>
@if(isset($templatesList))
@can('view-process-templates')
<div class="tab-pane fade" id="nav-templates" role="tabpanel" aria-labelledby="nav-templates-tab">
<div class="tab-pane" id="nav-templates" role="tabpanel" aria-labelledby="nav-templates-tab">
<div class="card card-body p-3 border-top-0">
{{ $templatesList }}
</div>
Expand All@@ -139,7 +139,7 @@ class="nav-item nav-link"
</div>
</div>
@isset($tabs[3])
<div class="tab-pane fade" id="nav-archived" role="tabpanel" aria-labelledby="nav-archived-tab">
<div class="tab-pane" id="nav-archived" role="tabpanel" aria-labelledby="nav-archived-tab">
<div class="card card-body p-3 border-top-0">
{{ $archivedList }}
</div>
Expand All@@ -156,13 +156,13 @@ class="{{$secondContent}}"
{{ $categoryList }}
</div>
</div>
<div class="tab-pane fade" id="nav-myTemplates" role="tabpanel" aria-labelledby="nav-myTemplates-tab">
<div class="tab-pane" id="nav-myTemplates" role="tabpanel" aria-labelledby="nav-myTemplates-tab">
<div class="card card-body p-3 border-top-0">
{{ $myTemplatesList }}
</div>
</div>
<div
class="tab-pane fade"
class="tab-pane"
id="nav-publicTemplates"
role="tabpanel"
aria-labelledby="nav-publicTemplates-tab"
Expand All@@ -178,7 +178,7 @@ class="tab-pane fade"
</div>
</div>
@isset($tabs[2])
<div class="tab-pane fade" id="nav-archived" role="tabpanel" aria-labelledby="nav-archived-tab">
<div class="tab-pane" id="nav-archived" role="tabpanel" aria-labelledby="nav-archived-tab">
<div class="card card-body p-3 border-top-0">
{{ $archivedList }}
</div>
Expand Down
6 changes: 3 additions & 3 deletions resources/views/processes/edit.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -46,7 +46,7 @@

{{-- Configuration --}}
<div
class="tab-pane fade show"
class="tab-pane show"
:class="{'active': activeTab === '' || activeTab === 'nav-config'}"
id="nav-config"
role="tabpanel"
Expand DownExpand Up@@ -375,7 +375,7 @@ class="invalid-feedback"
</div>

{{-- Notifications --}}
<div class="tab-pane fade show p-3" id="nav-notifications" role="tabpanel"
<div class="tab-pane show p-3" id="nav-notifications" role="tabpanel"
aria-labelledby="nav-notifications-tab">
<div class="form-group p-0">

Expand DownExpand Up@@ -530,7 +530,7 @@ class="custom-control-input">
{{-- Addons --}}
@isset($addons)
@foreach ($addons as $addon)
<div class="tab-pane fade show" id="{{$addon['id']}}" role="tabpanel"
<div class="tab-pane show" id="{{$addon['id']}}" role="tabpanel"
aria-labelledby="nav-notifications-tab">
{!! $addon['content'] !!}
</div>
Expand Down
4 changes: 2 additions & 2 deletions resources/views/processes/screens/edit.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,7 +38,7 @@

<div class="card card-body card-body-nav-tabs">
<div class="tab-content" id="nav-tabContent">
<div class="tab-pane fade show active" id="nav-config" role="tabpanel" aria-labelledby="nav-config-tab">
<div class="tab-pane show active" id="nav-config" role="tabpanel" aria-labelledby="nav-config-tab">
<required></required>
<div class="form-group">
{!! Form::label('title', __('Name') . '<small class="ml-1">*</small>', [], false) !!}
Expand DownExpand Up@@ -76,7 +76,7 @@
</div>
@isset($addons)
@foreach ($addons as $addon)
<div class="tab-pane fade show" id="{{$addon['id']}}" role="tabpanel" aria-labelledby="'nav-tab-'+ {{$addon['id']}}">
<div class="tab-pane show" id="{{$addon['id']}}" role="tabpanel" aria-labelledby="'nav-tab-'+ {{$addon['id']}}">
{!! $addon['content'] !!}
</div>
@endforeach
Expand Down
4 changes: 2 additions & 2 deletions resources/views/processes/scripts/edit.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -39,7 +39,7 @@

<div class="card card-body card-body-nav-tabs">
<div class="tab-content" id="nav-tabContent">
<div class="tab-pane fade show active" id="nav-config" role="tabpanel" aria-labelledby="nav-config-tab">
<div class="tab-pane show active" id="nav-config" role="tabpanel" aria-labelledby="nav-config-tab">
<required></required>
<div class="form-group">
{!! Form::label('title', __('Name') . '<small class="ml-1">*</small>', [], false) !!}
Expand DownExpand Up@@ -130,7 +130,7 @@
</div>
@isset($addons)
@foreach ($addons as $addon)
<div class="tab-pane fade show" id="{{$addon['id']}}" role="tabpanel" aria-labelledby="'nav-tab-'+ {{$addon['id']}}">
<div class="tab-pane show" id="{{$addon['id']}}" role="tabpanel" aria-labelledby="'nav-tab-'+ {{$addon['id']}}">
{!! $addon['content'] !!}
</div>
@endforeach
Expand Down
4 changes: 2 additions & 2 deletions resources/views/processes/signals/edit.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,7 +33,7 @@

<div class="tab-content" id="nav-tabContent">

<div class="card card-body border-top-0 tab-pane p-3 fade show active" id="nav-detail" role="tabpanel" aria-labelledby="nav-detail-tab">
<div class="card card-body border-top-0 tab-pane p-3 show active" id="nav-detail" role="tabpanel" aria-labelledby="nav-detail-tab">
<div class="modal-body">
<required></required>
<div class="form-group">
Expand DownExpand Up@@ -68,7 +68,7 @@
</div>
@endif
</div>
<div class="card card-body border-top-0 tab-pane p-3 fade" id="nav-catch" role="tabpanel" aria-labelledby="nav-catch-tab">
<div class="card card-body border-top-0 tab-pane p-3" id="nav-catch" role="tabpanel" aria-labelledby="nav-catch-tab">
<catch-listing ref="catchList" :filter="filter" items="{{json_encode($signal['processes'])}}" />
</div>

Expand Down
2 changes: 1 addition & 1 deletion resources/views/requests/index.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -52,7 +52,7 @@ function() use ($title) { return [__($title), null]; }
</counter-card-group>

<div class="tab-content" id="requests-tabContent">
<div class="tab-pane fade show active" id="inbox" role="tabpanel" aria-labelledby="inbox-tab">
<div class="tab-pane show active" id="inbox" role="tabpanel" aria-labelledby="inbox-tab">

<div class="card card-body requests-list-body">
<div id="search-bar" class="search advanced-search mb-2">
Expand Down
18 changes: 9 additions & 9 deletions resources/views/requests/show.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -109,7 +109,7 @@
role="tabpanel" aria-labelledby="errors-tab">
<request-errors :errors="errorLogs"></request-errors>
</div>
<div class="tab-pane fade show card card-body border-top-0 p-0" :class="{ active: activePending }"
<div class="tab-pane show card card-body border-top-0 p-0" :class="{ active: activePending }"
id="pending" role="tabpanel" aria-labelledby="pending-tab">
<request-detail ref="pending" :process-request-id="requestId" status="ACTIVE"
:is-process-manager="{{ $isProcessManager ? 'true' : 'false' }}"
Expand DownExpand Up@@ -187,20 +187,20 @@ class="tab-pane card card-body border-top-0 p-3">
</div>
@endcan
@endif
<div class="tab-pane fade card card-body border-top-0 p-0" id="completed" role="tabpanel"
<div class="tab-pane card card-body border-top-0 p-0" id="completed" role="tabpanel"
aria-labelledby="completed-tab">
<request-detail ref="completed" :process-request-id="requestId" status="CLOSED"
:is-admin="{{ Auth::user()->is_administrator ? 'true' : 'false' }}">
</request-detail>
</div>

<template v-for="{ tab, component } in packages">
<div class="tab-pane fade card card-body border-top-0 p-0" :id="tab.target" role="tabpanel">
<div class="tab-pane card card-body border-top-0 p-0" :id="tab.target" role="tabpanel">
<component :is="component" :process-request-id="requestId"></component>
</div>
</template>

<div class="tab-pane fade card card-body border-top-0 p-3" id="files" role="tabpanel"
<div class="tab-pane card card-body border-top-0 p-3" id="files" role="tabpanel"
aria-labelledby="files-tab">
<div class="card">
<div>
Expand DownExpand Up@@ -228,12 +228,12 @@ class="tab-pane card card-body border-top-0 p-3">
</div>
</div>
</div>
<div class="tab-pane fade card card-body border-top-0 p-0" id="forms" role="tabpanel"
<div class="tab-pane card card-body border-top-0 p-0" id="forms" role="tabpanel"
aria-labelledby="forms-tab" v-show="canViewPrint">
<request-screens :id="requestId" :information="dataSummary" ref="forms">
</request-screens>
</div>
<div v-if="activeTab === 'overview'" class="tab-pane fade p-0" id="overview" role="tabpanel"
<div v-if="activeTab === 'overview'" class="tab-pane p-0" id="overview" role="tabpanel"
aria-labelledby="overview-tab">
<div class="card" style="border-top: none !important;">
<div class="card-body">
Expand DownExpand Up@@ -267,7 +267,7 @@ class="tab-pane card card-body border-top-0 p-3">

@isset($addons)
@foreach ($addons as $addon)
<div class="tab-pane fade show" id="{{ $addon['id'] }}" role="tabpanel"
<div class="tab-pane show" id="{{ $addon['id'] }}" role="tabpanel"
aria-labelledby="{{ $addon['id'] }}">
{!! $addon['content'] !!}
</div>
Expand DownExpand Up@@ -326,7 +326,7 @@ class="tab-pane card card-body border-top-0 p-3">
<div
v-if="showInfo"
id="details"
v-bind:class="{ 'tab-pane':true, fade: true, show: showInfo, active: showInfo }"
v-bind:class="{ 'tab-pane':true, show: showInfo, active: showInfo }"
role="tabpanel"
aria-labelledby="details-tab"
>
Expand DownExpand Up@@ -453,7 +453,7 @@ class="btn btn-outline-info btn-block"
<div
v-if="!showInfo"
id="comments"
v-bind:class="{ 'tab-pane':true, fade: true, show: !showInfo, active: !showInfo }"
v-bind:class="{ 'tab-pane':true, show: !showInfo, active: !showInfo }"
role="tabpanel"
aria-labelledby="comments-tab"
>
Expand Down
4 changes: 2 additions & 2 deletions resources/views/requests/showMobile.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -83,7 +83,7 @@ class="tab-content"
>
<div
id="tasks"
class="tab-pane fade show card card-body border-top-0 p-3 active"
class="tab-pane show card card-body border-top-0 p-3 active"
role="tabpanel"
aria-labelledby="tasks-tab"
>
Expand All@@ -110,7 +110,7 @@ class="tab-pane card card-body border-top-0 p-3"

<div
id="files"
class="tab-pane fade card card-body border-top-0 p-3"
class="tab-pane card card-body border-top-0 p-3"
role="tabpanel"
aria-labelledby="files-tab"
>
Expand Down
4 changes: 2 additions & 2 deletions resources/views/tasks/edit.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -164,7 +164,7 @@ class="card border-0"
<div
v-if="showInfo"
id="details"
v-bind:class="{ 'tab-pane':true, fade: true, show: showInfo, active: showInfo }"
v-bind:class="{ 'tab-pane':true, show: showInfo, active: showInfo }"
role="tabpanel"
aria-labelledby="details-tab">
<div class="ml-md-3 mt-3 mt-md-0">
Expand DownExpand Up@@ -313,7 +313,7 @@ class="d-inline-flex pull-left align-items-center"
<div
v-if="!showInfo"
id="comments"
v-bind:class="{ 'tab-pane':true, fade: true, show: !showInfo, active: !showInfo }"
v-bind:class="{ 'tab-pane':true, show: !showInfo, active: !showInfo }"
role="tabpanel"
aria-labelledby="comments-tab">
<div class="ml-md-3 mt-md-0 mt-3 collapse-content">
Expand Down
2 changes: 1 addition & 1 deletion resources/views/tasks/index.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -77,7 +77,7 @@ class="nav-link task-nav-link"
</ul>

<div class="tab-content" id="task-tabContent">
<div class="tab-pane fade show active" id="inbox" role="tabpanel" aria-labelledby="inbox-tab">
<div class="tab-pane show active" id="inbox" role="tabpanel" aria-labelledby="inbox-tab">
<div class="card card-body task-list-body">
<div id="search-bar" class="search advanced-search mb-2">
<div class="d-flex">
Expand Down
4 changes: 2 additions & 2 deletions resources/views/templates/configure.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -36,7 +36,7 @@
</nav>
<div class="card card-body card-body-nav-tabs">
<div class="tab-content" id="nav-tabContent">
<div class="tab-pane fade show active" id="nav-config" role="tabpanel"
<div class="tab-pane show active" id="nav-config" role="tabpanel"
aria-labelledby="nav-config-tab">
<required></required>
@if ($type === 'process')
Expand All@@ -59,7 +59,7 @@
</div>
@isset($addons)
@foreach ($addons as $addon)
<div class="tab-pane fade show" id="{{$addon['id']}}" role="tabpanel"
<div class="tab-pane show" id="{{$addon['id']}}" role="tabpanel"
aria-labelledby="nav-notifications-tab">
{!! $addon['content'] !!}
</div>
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

FOUR-20281: [WINTER] Remove fades on tab switching#7824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryancooley merged 4 commits into from
Jan 23, 2025
Merged

FOUR-20281: [WINTER] Remove fades on tab switching #7824

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8573753
FOUR-20281 : S2: Remove fades
hjonathan Nov 25, 2024
7658dea
Merge remote-tracking branch 'origin/release-2024-fall' into feature/…
pmPaulis Dec 4, 2024
9688ae5
Merge pull request #7763 from ProcessMaker/feature/FOUR-20281
pmPaulis Dec 13, 2024
416e506
Merge remote-tracking branch 'origin/release-2025-winter' into epic/F…
pmPaulis Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions resources/views/admin/users/index.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,13 +33,13 @@

<div>
<div class="tab-content">
<div class="tab-pane fade show active" id="nav-users" role="tabpanel" aria-labelledby="nav-users-tab">
<div class="tab-pane show active" id="nav-users" role="tabpanel" aria-labelledby="nav-users-tab">
<div class="card card-body p-3 border-top-0">
@include('admin.users.list')
</div>
</div>

<div class="tab-pane fade show" id="nav-deleted-users" role="tabpanel" aria-labelledby="nav-deleted-users-tab">
<div class="tab-pane show" id="nav-deleted-users" role="tabpanel" aria-labelledby="nav-deleted-users-tab">
<div class="card card-body p-3 border-top-0">
@include('admin.users.deletedUsers')
</div>
Expand Down
12 changes: 6 additions & 6 deletions resources/views/components/categorized_resource.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
<div class="px-3 page-content" id="categorizedList" style="display:none">
@php
$firstTab = $secondTab = 'nav-item nav-link';
$firstContent = $secondContent = 'tab-pane fade show';
$firstContent = $secondContent = 'tab-pane show';

$catListWebRoute = str_replace('.edit', '.index', $catConfig->routes->editCategoryWeb);
$showCategoriesTab = $catListWebRoute === \Request::route()->getName() || $listConfig->countCategories === 0
Expand DownExpand Up@@ -127,7 +127,7 @@ class="nav-item nav-link"
</div>
@if(isset($templatesList))
@can('view-process-templates')
<div class="tab-pane fade" id="nav-templates" role="tabpanel" aria-labelledby="nav-templates-tab">
<div class="tab-pane" id="nav-templates" role="tabpanel" aria-labelledby="nav-templates-tab">
<div class="card card-body p-3 border-top-0">
{{ $templatesList }}
</div>
Expand All@@ -139,7 +139,7 @@ class="nav-item nav-link"
</div>
</div>
@isset($tabs[3])
<div class="tab-pane fade" id="nav-archived" role="tabpanel" aria-labelledby="nav-archived-tab">
<div class="tab-pane" id="nav-archived" role="tabpanel" aria-labelledby="nav-archived-tab">
<div class="card card-body p-3 border-top-0">
{{ $archivedList }}
</div>
Expand All@@ -156,13 +156,13 @@ class="{{$secondContent}}"
{{ $categoryList }}
</div>
</div>
<div class="tab-pane fade" id="nav-myTemplates" role="tabpanel" aria-labelledby="nav-myTemplates-tab">
<div class="tab-pane" id="nav-myTemplates" role="tabpanel" aria-labelledby="nav-myTemplates-tab">
<div class="card card-body p-3 border-top-0">
{{ $myTemplatesList }}
</div>
</div>
<div
class="tab-pane fade"
class="tab-pane"
id="nav-publicTemplates"
role="tabpanel"
aria-labelledby="nav-publicTemplates-tab"
Expand All@@ -178,7 +178,7 @@ class="tab-pane fade"
</div>
</div>
@isset($tabs[2])
<div class="tab-pane fade" id="nav-archived" role="tabpanel" aria-labelledby="nav-archived-tab">
<div class="tab-pane" id="nav-archived" role="tabpanel" aria-labelledby="nav-archived-tab">
<div class="card card-body p-3 border-top-0">
{{ $archivedList }}
</div>
Expand Down
6 changes: 3 additions & 3 deletions resources/views/processes/edit.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -46,7 +46,7 @@

{{-- Configuration --}}
<div
class="tab-pane fade show"
class="tab-pane show"
:class="{'active': activeTab === '' || activeTab === 'nav-config'}"
id="nav-config"
role="tabpanel"
Expand DownExpand Up@@ -375,7 +375,7 @@ class="invalid-feedback"
</div>

{{-- Notifications --}}
<div class="tab-pane fade show p-3" id="nav-notifications" role="tabpanel"
<div class="tab-pane show p-3" id="nav-notifications" role="tabpanel"
aria-labelledby="nav-notifications-tab">
<div class="form-group p-0">

Expand DownExpand Up@@ -530,7 +530,7 @@ class="custom-control-input">
{{-- Addons --}}
@isset($addons)
@foreach ($addons as $addon)
<div class="tab-pane fade show" id="{{$addon['id']}}" role="tabpanel"
<div class="tab-pane show" id="{{$addon['id']}}" role="tabpanel"
aria-labelledby="nav-notifications-tab">
{!! $addon['content'] !!}
</div>
Expand Down
4 changes: 2 additions & 2 deletions resources/views/processes/screens/edit.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -38,7 +38,7 @@

<div class="card card-body card-body-nav-tabs">
<div class="tab-content" id="nav-tabContent">
<div class="tab-pane fade show active" id="nav-config" role="tabpanel" aria-labelledby="nav-config-tab">
<div class="tab-pane show active" id="nav-config" role="tabpanel" aria-labelledby="nav-config-tab">
<required></required>
<div class="form-group">
{!! Form::label('title', __('Name') . '<small class="ml-1">*</small>', [], false) !!}
Expand DownExpand Up@@ -76,7 +76,7 @@
</div>
@isset($addons)
@foreach ($addons as $addon)
<div class="tab-pane fade show" id="{{$addon['id']}}" role="tabpanel" aria-labelledby="'nav-tab-'+ {{$addon['id']}}">
<div class="tab-pane show" id="{{$addon['id']}}" role="tabpanel" aria-labelledby="'nav-tab-'+ {{$addon['id']}}">
{!! $addon['content'] !!}
</div>
@endforeach
Expand Down
4 changes: 2 additions & 2 deletions resources/views/processes/scripts/edit.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -39,7 +39,7 @@

<div class="card card-body card-body-nav-tabs">
<div class="tab-content" id="nav-tabContent">
<div class="tab-pane fade show active" id="nav-config" role="tabpanel" aria-labelledby="nav-config-tab">
<div class="tab-pane show active" id="nav-config" role="tabpanel" aria-labelledby="nav-config-tab">
<required></required>
<div class="form-group">
{!! Form::label('title', __('Name') . '<small class="ml-1">*</small>', [], false) !!}
Expand DownExpand Up@@ -130,7 +130,7 @@
</div>
@isset($addons)
@foreach ($addons as $addon)
<div class="tab-pane fade show" id="{{$addon['id']}}" role="tabpanel" aria-labelledby="'nav-tab-'+ {{$addon['id']}}">
<div class="tab-pane show" id="{{$addon['id']}}" role="tabpanel" aria-labelledby="'nav-tab-'+ {{$addon['id']}}">
{!! $addon['content'] !!}
</div>
@endforeach
Expand Down
4 changes: 2 additions & 2 deletions resources/views/processes/signals/edit.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,7 +33,7 @@

<div class="tab-content" id="nav-tabContent">

<div class="card card-body border-top-0 tab-pane p-3 fade show active" id="nav-detail" role="tabpanel" aria-labelledby="nav-detail-tab">
<div class="card card-body border-top-0 tab-pane p-3 show active" id="nav-detail" role="tabpanel" aria-labelledby="nav-detail-tab">
<div class="modal-body">
<required></required>
<div class="form-group">
Expand DownExpand Up@@ -68,7 +68,7 @@
</div>
@endif
</div>
<div class="card card-body border-top-0 tab-pane p-3 fade" id="nav-catch" role="tabpanel" aria-labelledby="nav-catch-tab">
<div class="card card-body border-top-0 tab-pane p-3" id="nav-catch" role="tabpanel" aria-labelledby="nav-catch-tab">
<catch-listing ref="catchList" :filter="filter" items="{{json_encode($signal['processes'])}}" />
</div>

Expand Down
2 changes: 1 addition & 1 deletion resources/views/requests/index.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -52,7 +52,7 @@ function() use ($title) { return [__($title), null]; }
</counter-card-group>

<div class="tab-content" id="requests-tabContent">
<div class="tab-pane fade show active" id="inbox" role="tabpanel" aria-labelledby="inbox-tab">
<div class="tab-pane show active" id="inbox" role="tabpanel" aria-labelledby="inbox-tab">

<div class="card card-body requests-list-body">
<div id="search-bar" class="search advanced-search mb-2">
Expand Down
18 changes: 9 additions & 9 deletions resources/views/requests/show.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -109,7 +109,7 @@
role="tabpanel" aria-labelledby="errors-tab">
<request-errors :errors="errorLogs"></request-errors>
</div>
<div class="tab-pane fade show card card-body border-top-0 p-0" :class="{ active: activePending }"
<div class="tab-pane show card card-body border-top-0 p-0" :class="{ active: activePending }"
id="pending" role="tabpanel" aria-labelledby="pending-tab">
<request-detail ref="pending" :process-request-id="requestId" status="ACTIVE"
:is-process-manager="{{ $isProcessManager ? 'true' : 'false' }}"
Expand DownExpand Up@@ -187,20 +187,20 @@ class="tab-pane card card-body border-top-0 p-3">
</div>
@endcan
@endif
<div class="tab-pane fade card card-body border-top-0 p-0" id="completed" role="tabpanel"
<div class="tab-pane card card-body border-top-0 p-0" id="completed" role="tabpanel"
aria-labelledby="completed-tab">
<request-detail ref="completed" :process-request-id="requestId" status="CLOSED"
:is-admin="{{ Auth::user()->is_administrator ? 'true' : 'false' }}">
</request-detail>
</div>

<template v-for="{ tab, component } in packages">
<div class="tab-pane fade card card-body border-top-0 p-0" :id="tab.target" role="tabpanel">
<div class="tab-pane card card-body border-top-0 p-0" :id="tab.target" role="tabpanel">
<component :is="component" :process-request-id="requestId"></component>
</div>
</template>

<div class="tab-pane fade card card-body border-top-0 p-3" id="files" role="tabpanel"
<div class="tab-pane card card-body border-top-0 p-3" id="files" role="tabpanel"
aria-labelledby="files-tab">
<div class="card">
<div>
Expand DownExpand Up@@ -228,12 +228,12 @@ class="tab-pane card card-body border-top-0 p-3">
</div>
</div>
</div>
<div class="tab-pane fade card card-body border-top-0 p-0" id="forms" role="tabpanel"
<div class="tab-pane card card-body border-top-0 p-0" id="forms" role="tabpanel"
aria-labelledby="forms-tab" v-show="canViewPrint">
<request-screens :id="requestId" :information="dataSummary" ref="forms">
</request-screens>
</div>
<div v-if="activeTab === 'overview'" class="tab-pane fade p-0" id="overview" role="tabpanel"
<div v-if="activeTab === 'overview'" class="tab-pane p-0" id="overview" role="tabpanel"
aria-labelledby="overview-tab">
<div class="card" style="border-top: none !important;">
<div class="card-body">
Expand DownExpand Up@@ -267,7 +267,7 @@ class="tab-pane card card-body border-top-0 p-3">

@isset($addons)
@foreach ($addons as $addon)
<div class="tab-pane fade show" id="{{ $addon['id'] }}" role="tabpanel"
<div class="tab-pane show" id="{{ $addon['id'] }}" role="tabpanel"
aria-labelledby="{{ $addon['id'] }}">
{!! $addon['content'] !!}
</div>
Expand DownExpand Up@@ -326,7 +326,7 @@ class="tab-pane card card-body border-top-0 p-3">
<div
v-if="showInfo"
id="details"
v-bind:class="{ 'tab-pane':true, fade: true, show: showInfo, active: showInfo }"
v-bind:class="{ 'tab-pane':true, show: showInfo, active: showInfo }"
role="tabpanel"
aria-labelledby="details-tab"
>
Expand DownExpand Up@@ -453,7 +453,7 @@ class="btn btn-outline-info btn-block"
<div
v-if="!showInfo"
id="comments"
v-bind:class="{ 'tab-pane':true, fade: true, show: !showInfo, active: !showInfo }"
v-bind:class="{ 'tab-pane':true, show: !showInfo, active: !showInfo }"
role="tabpanel"
aria-labelledby="comments-tab"
>
Expand Down
4 changes: 2 additions & 2 deletions resources/views/requests/showMobile.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -83,7 +83,7 @@ class="tab-content"
>
<div
id="tasks"
class="tab-pane fade show card card-body border-top-0 p-3 active"
class="tab-pane show card card-body border-top-0 p-3 active"
role="tabpanel"
aria-labelledby="tasks-tab"
>
Expand All@@ -110,7 +110,7 @@ class="tab-pane card card-body border-top-0 p-3"

<div
id="files"
class="tab-pane fade card card-body border-top-0 p-3"
class="tab-pane card card-body border-top-0 p-3"
role="tabpanel"
aria-labelledby="files-tab"
>
Expand Down
4 changes: 2 additions & 2 deletions resources/views/tasks/edit.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -164,7 +164,7 @@ class="card border-0"
<div
v-if="showInfo"
id="details"
v-bind:class="{ 'tab-pane':true, fade: true, show: showInfo, active: showInfo }"
v-bind:class="{ 'tab-pane':true, show: showInfo, active: showInfo }"
role="tabpanel"
aria-labelledby="details-tab">
<div class="ml-md-3 mt-3 mt-md-0">
Expand DownExpand Up@@ -313,7 +313,7 @@ class="d-inline-flex pull-left align-items-center"
<div
v-if="!showInfo"
id="comments"
v-bind:class="{ 'tab-pane':true, fade: true, show: !showInfo, active: !showInfo }"
v-bind:class="{ 'tab-pane':true, show: !showInfo, active: !showInfo }"
role="tabpanel"
aria-labelledby="comments-tab">
<div class="ml-md-3 mt-md-0 mt-3 collapse-content">
Expand Down
2 changes: 1 addition & 1 deletion resources/views/tasks/index.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -77,7 +77,7 @@ class="nav-link task-nav-link"
</ul>

<div class="tab-content" id="task-tabContent">
<div class="tab-pane fade show active" id="inbox" role="tabpanel" aria-labelledby="inbox-tab">
<div class="tab-pane show active" id="inbox" role="tabpanel" aria-labelledby="inbox-tab">
<div class="card card-body task-list-body">
<div id="search-bar" class="search advanced-search mb-2">
<div class="d-flex">
Expand Down
4 changes: 2 additions & 2 deletions resources/views/templates/configure.blade.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -36,7 +36,7 @@
</nav>
<div class="card card-body card-body-nav-tabs">
<div class="tab-content" id="nav-tabContent">
<div class="tab-pane fade show active" id="nav-config" role="tabpanel"
<div class="tab-pane show active" id="nav-config" role="tabpanel"
aria-labelledby="nav-config-tab">
<required></required>
@if ($type === 'process')
Expand All@@ -59,7 +59,7 @@
</div>
@isset($addons)
@foreach ($addons as $addon)
<div class="tab-pane fade show" id="{{$addon['id']}}" role="tabpanel"
<div class="tab-pane show" id="{{$addon['id']}}" role="tabpanel"
aria-labelledby="nav-notifications-tab">
{!! $addon['content'] !!}
</div>
Expand Down