FOUR-32764 Process Manager gets an unauthorized error when loading the summary screen without the View All request permission#9007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devmiguelangel wants to merge 3 commits into
base:develop
Choose a base branch
from
+280 −1
Open

FOUR-32764 Process Manager gets an unauthorized error when loading the summary screen without the View All request permission #9007

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cd3fcfe
feat: refactor process manager check and enhance view policy
devmiguelangel Aug 24, 2026
8ab16f3
test: add tests for process manager request visibility and permissions
devmiguelangel Aug 24, 2026
bc5249b
test: enhance process manager permissions and request visibility tests
devmiguelangel Aug 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ProcessMaker/Http/Controllers/RequestController.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -200,7 +200,7 @@ public function show(ProcessRequest $request, Media $mediaItems)
$addons = $this->getPluginAddons('edit', compact(['request']));
$dataActionsAddons = $this->getPluginAddons('edit.dataActions', []);

$isProcessManager = $request->process?->manager_id === Auth::user()->id;
$isProcessManager = in_array(Auth::user()->id, $request->process?->manager_id ?? []);

$eligibleRollbackTask = null;
$errorTask = RollbackProcessRequest::getErrorTask($request);
Expand Down
4 changes: 4 additions & 0 deletions ProcessMaker/Policies/ProcessRequestPolicy.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,6 +33,10 @@ public function before(User $user)
*/
public function view(User $user, ProcessRequest $processRequest)
{
if (in_array($user->id, $processRequest->process?->manager_id ?? [])) {
return true;
}

// Policy defined in ForUserScope
return ProcessRequest::forUser($user)
->where('process_requests.id', $processRequest->id)
Expand Down
200 changes: 200 additions & 0 deletions tests/Feature/Api/ProcessRequestPolicyTest.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@
namespace Tests\Feature\Api;

use Database\Seeders\PermissionSeeder;
use ProcessMaker\Models\Process;
use ProcessMaker\Models\ProcessRequest;
use ProcessMaker\Models\ProcessRequestToken;
use ProcessMaker\Models\User;
Expand DownExpand Up@@ -72,4 +73,203 @@ public function testUserHasPermission()
$response = $this->apiCall('GET', $route);
$response->assertStatus(200);
}

public function testProcessManagerCanViewManagedRequestAndEndEventDestination()
{
$firstManager = User::factory()->create();
$process = Process::factory()->create([
'bpmn' => file_get_contents(__DIR__ . '/../../Fixtures/action_by_email_process_no_require_login.bpmn'),
'manager_id' => [$firstManager->id, $this->user->id],
]);
$request = ProcessRequest::factory()->create([
'process_id' => $process->id,
'status' => 'COMPLETED',
]);
ProcessRequestToken::factory()->create([
'element_id' => 'node_18',
'element_type' => 'end_event',
'process_id' => $process->id,
'process_request_id' => $request->id,
'status' => 'CLOSED',
]);

$this->apiCall('GET', route('api.requests.show', [$request]))
->assertStatus(200);

$this->apiCall('GET', route('api.requests.end_event_destination', [$request]))
->assertStatus(200)
->assertJsonPath('data.endEventDestination.type', 'summaryScreen')
->assertJsonPath('data.endEventDestination.value', null);
}

public function testProcessManagerCannotViewRequestFromUnmanagedProcess()
{
$managedProcess = Process::factory()->create([
'manager_id' => [$this->user->id],
]);
$unmanagedRequest = ProcessRequest::factory()->create();

$this->assertNotEquals($managedProcess->id, $unmanagedRequest->process_id);

$this->apiCall('GET', route('api.requests.show', [$unmanagedRequest]))
->assertStatus(403);

$this->apiCall('GET', route('api.requests.end_event_destination', [$unmanagedRequest]))
->assertStatus(403);
}

public function testProcessManagerAccessIsRevokedWhenRemovedFromProcess()
{
$process = Process::factory()->create([
'manager_id' => [$this->user->id],
]);
$request = ProcessRequest::factory()->create([
'process_id' => $process->id,
]);

$this->apiCall('GET', route('api.requests.show', [$request]))
->assertStatus(200);

$process->manager_id = [];
$process->save();

$this->apiCall('GET', route('api.requests.show', [$request]))
->assertStatus(403);
}

public function testProcessManagerCannotUpdateOrDeleteManagedRequest()
{
$process = Process::factory()->create([
'manager_id' => [$this->user->id],
]);
$request = ProcessRequest::factory()->create([
'process_id' => $process->id,
]);

$this->apiCall('PUT', route('api.requests.update', [$request]), [
'name' => 'Unauthorized update',
])->assertStatus(403);

$this->apiCall('DELETE', route('api.requests.destroy', [$request]))
->assertStatus(403);
}

public function testManagedRequestIsNotAddedToRequestListing()
{
$process = Process::factory()->create([
'manager_id' => [$this->user->id],
]);
$request = ProcessRequest::factory()->create([
'process_id' => $process->id,
]);

$this->apiCall('GET', route('api.requests.show', [$request]))
->assertStatus(200);

$this->apiCall('GET', route('api.requests.index'))
->assertStatus(200)
->assertJsonMissing(['id' => $request->id]);
}

public function testScalarProcessManagerValueIsNormalizedForAuthorization()
{
$process = Process::factory()->create([
'manager_id' => $this->user->id,
]);
$request = ProcessRequest::factory()->create([
'process_id' => $process->id,
]);

$this->assertSame([$this->user->id], $process->fresh()->manager_id);

$this->apiCall('GET', route('api.requests.show', [$request]))
->assertStatus(200);
}

public function testProcessManagerReassignmentUpdatesRequestAccess()
{
$newManager = User::factory()->create();
$process = Process::factory()->create([
'manager_id' => [$this->user->id],
]);
$request = ProcessRequest::factory()->create([
'process_id' => $process->id,
]);

$this->apiCall('GET', route('api.requests.show', [$request]))
->assertStatus(200);

$process->manager_id = [$newManager->id];
$process->save();

$this->apiCall('GET', route('api.requests.show', [$request]))
->assertStatus(403);

$this->user = $newManager;

$this->apiCall('GET', route('api.requests.show', [$request]))
->assertStatus(200);
}

public function testProcessManagerCanViewManagedRequestsInEveryStatus()
{
$process = Process::factory()->create([
'manager_id' => [$this->user->id],
]);

foreach (['ACTIVE', 'COMPLETED', 'CANCELED', 'ERROR'] as $status) {
$request = ProcessRequest::factory()->create([
'process_id' => $process->id,
'status' => $status,
]);

$this->apiCall('GET', route('api.requests.show', [$request]))
->assertStatus(200);
}
}

public function testEndEventDestinationReturnsNullWhenManagedRequestHasNoEndEvent()
{
$process = Process::factory()->create([
'manager_id' => [$this->user->id],
]);
$request = ProcessRequest::factory()->create([
'process_id' => $process->id,
'status' => 'COMPLETED',
]);

$this->apiCall('GET', route('api.requests.end_event_destination', [$request]))
->assertStatus(200)
->assertJsonPath('data', null);
}

public function testEndEventDestinationReturnsConfiguredExternalUrlForProcessManager()
{
$bpmn = file_get_contents(__DIR__ . '/../../Fixtures/action_by_email_process_no_require_login.bpmn');
$bpmn = str_replace(
'{"type":"summaryScreen","value":null}',
'{"type":"externalURL","value":"https://example.com/summary"}',
$bpmn,
);
$process = Process::factory()->create([
'bpmn' => $bpmn,
'manager_id' => [$this->user->id],
]);
$request = ProcessRequest::factory()->create([
'process_id' => $process->id,
'status' => 'COMPLETED',
]);
ProcessRequestToken::factory()->create([
'element_id' => 'node_18',
'element_type' => 'end_event',
'process_id' => $process->id,
'process_request_id' => $request->id,
'status' => 'CLOSED',
]);

$this->apiCall('GET', route('api.requests.end_event_destination', [$request]))
->assertStatus(200)
->assertJsonPath('data.endEventDestination.type', 'externalURL')
->assertJsonPath('data.endEventDestination.value', 'https://example.com/summary');
}
}
25 changes: 25 additions & 0 deletions tests/Feature/CasesControllerTest.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -62,6 +62,31 @@ public function testShowCaseWithUserWithoutParticipation()
$response->assertStatus(403);
}

public function testProcessManagerCanOpenManagedCaseButUnrelatedUserCannot()
{
$processManager = User::factory()->create();
$firstManager = User::factory()->create();
$process = Process::factory()->create([
'manager_id' => [$firstManager->id, $processManager->id],
]);
$request = ProcessRequest::factory()->create([
'parent_request_id' => null,
'process_id' => $process->id,
'status' => 'COMPLETED',
]);
$route = route('cases.show', ['case_number' => $request->case_number]);

$response = $this->actingAs($processManager)->get($route);

$response->assertStatus(200);
$response->assertViewIs('cases.edit');
$response->assertViewHas('isProcessManager', true);

$this->actingAs(User::factory()->create())
->get($route)
->assertStatus(403);
}

public function testCasesAllPageReturns403WithoutViewAllCasesPermission()
{
Permission::firstOrCreate(
Expand Down
50 changes: 50 additions & 0 deletions tests/Feature/RequestTest.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,8 @@
namespace Tests\Feature;

use Illuminate\Http\Testing\File;
use Illuminate\Support\Facades\Gate;
use ProcessMaker\Models\Permission;
use ProcessMaker\Models\Process;
use ProcessMaker\Models\ProcessCategory;
use ProcessMaker\Models\ProcessRequest;
Expand DownExpand Up@@ -123,6 +125,54 @@ public function testShowRouteWithAssignedUser()
$response->assertStatus(200);
}

public function testProcessManagerCanViewManagedRequestSummary()
{
$this->user = User::factory()->create();
$firstManager = User::factory()->create();
$process = Process::factory()->create([
'manager_id' => [$firstManager->id, $this->user->id],
]);
$request = ProcessRequest::factory()->create([
'process_id' => $process->id,
'status' => 'COMPLETED',
]);

$response = $this->webCall('GET', route('requests.show', [$request]));

$response->assertStatus(200);
$response->assertViewIs('requests.show');
$response->assertViewHas('isProcessManager', true);
}

public function testProcessManagerCannotViewUnmanagedRequestSummary()
{
$this->user = User::factory()->create();
Process::factory()->create([
'manager_id' => [$this->user->id],
]);
$unmanagedRequest = ProcessRequest::factory()->create();

$this->webCall('GET', route('requests.show', [$unmanagedRequest]))
->assertStatus(403);
}

public function testProcessManagerCannotViewAllRequestsWithoutPermission()
{
Permission::firstOrCreate(
['name' => 'view-all_requests'],
['title' => 'View All Requests'],
);
Gate::define('view-all_requests', fn ($user) => $user->hasPermission('view-all_requests'));

$this->user = User::factory()->create();
Process::factory()->create([
'manager_id' => [$this->user->id],
]);

$this->webCall('GET', route('requests_by_type', ['type' => 'all']))
->assertStatus(403);
}

public function testShowRouteWithAdministrator()
{
$this->user = User::factory()->create([
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
FOUR-32764 Process Manager gets an unauthorized error when loading the summary screen without the View All request permission#9007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Open

devmiguelangel
wants to merge
3
commits into

base:develop
Choose a base branch

from


+280

−1

 Open


FOUR-32764 Process Manager gets an unauthorized error when loading the summary screen without the View All request permission
#9007
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
cd3fcfe

feat: refactor process manager check and enhance view policy


devmiguelangel Aug 24, 2026
8ab16f3

test: add tests for process manager request visibility and permissions


devmiguelangel Aug 24, 2026
bc5249b

test: enhance process manager permissions and request visibility tests


devmiguelangel Aug 24, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
ProcessMaker/Http/Controllers/RequestController.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -200,7 +200,7 @@ public function show(ProcessRequest $request, Media $mediaItems)
 $addons = $this->getPluginAddons('edit', compact(['request']));
 $dataActionsAddons = $this->getPluginAddons('edit.dataActions', []);

 $isProcessManager = $request->process?->manager_id === Auth::user()->id;
 $isProcessManager = in_array(Auth::user()->id, $request->process?->manager_id ?? []);

 $eligibleRollbackTask = null;
 $errorTask = RollbackProcessRequest::getErrorTask($request);
Expand Down

4 changes: 4 additions & 0 deletions
ProcessMaker/Policies/ProcessRequestPolicy.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -33,6 +33,10 @@ public function before(User $user)
 */
 public function view(User $user, ProcessRequest $processRequest)
 {
 if (in_array($user->id, $processRequest->process?->manager_id ?? [])) {
 return true;
 }

 // Policy defined in ForUserScope
 return ProcessRequest::forUser($user)
 ->where('process_requests.id', $processRequest->id)
Expand Down

200 changes: 200 additions & 0 deletions
tests/Feature/Api/ProcessRequestPolicyTest.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@
namespace Tests\Feature\Api;

use Database\Seeders\PermissionSeeder;
use ProcessMaker\Models\Process;
use ProcessMaker\Models\ProcessRequest;
use ProcessMaker\Models\ProcessRequestToken;
use ProcessMaker\Models\User;
Expand DownExpand Up@@ -72,4 +73,203 @@ public function testUserHasPermission()
 $response = $this->apiCall('GET', $route);
 $response->assertStatus(200);
 }

 public function testProcessManagerCanViewManagedRequestAndEndEventDestination()
 {
 $firstManager = User::factory()->create();
 $process = Process::factory()->create([
 'bpmn' => file_get_contents(__DIR__ . '/../../Fixtures/action_by_email_process_no_require_login.bpmn'),
 'manager_id' => [$firstManager->id, $this->user->id],
 ]);
 $request = ProcessRequest::factory()->create([
 'process_id' => $process->id,
 'status' => 'COMPLETED',
 ]);
 ProcessRequestToken::factory()->create([
 'element_id' => 'node_18',
 'element_type' => 'end_event',
 'process_id' => $process->id,
 'process_request_id' => $request->id,
 'status' => 'CLOSED',
 ]);

 $this->apiCall('GET', route('api.requests.show', [$request]))
 ->assertStatus(200);

 $this->apiCall('GET', route('api.requests.end_event_destination', [$request]))
 ->assertStatus(200)
 ->assertJsonPath('data.endEventDestination.type', 'summaryScreen')
 ->assertJsonPath('data.endEventDestination.value', null);
 }

 public function testProcessManagerCannotViewRequestFromUnmanagedProcess()
 {
 $managedProcess = Process::factory()->create([
 'manager_id' => [$this->user->id],
 ]);
 $unmanagedRequest = ProcessRequest::factory()->create();

 $this->assertNotEquals($managedProcess->id, $unmanagedRequest->process_id);

 $this->apiCall('GET', route('api.requests.show', [$unmanagedRequest]))
 ->assertStatus(403);

 $this->apiCall('GET', route('api.requests.end_event_destination', [$unmanagedRequest]))
 ->assertStatus(403);
 }

 public function testProcessManagerAccessIsRevokedWhenRemovedFromProcess()
 {
 $process = Process::factory()->create([
 'manager_id' => [$this->user->id],
 ]);
 $request = ProcessRequest::factory()->create([
 'process_id' => $process->id,
 ]);

 $this->apiCall('GET', route('api.requests.show', [$request]))
 ->assertStatus(200);

 $process->manager_id = [];
 $process->save();

 $this->apiCall('GET', route('api.requests.show', [$request]))
 ->assertStatus(403);
 }

 public function testProcessManagerCannotUpdateOrDeleteManagedRequest()
 {
 $process = Process::factory()->create([
 'manager_id' => [$this->user->id],
 ]);
 $request = ProcessRequest::factory()->create([
 'process_id' => $process->id,
 ]);

 $this->apiCall('PUT', route('api.requests.update', [$request]), [
 'name' => 'Unauthorized update',
 ])->assertStatus(403);

 $this->apiCall('DELETE', route('api.requests.destroy', [$request]))
 ->assertStatus(403);
 }

 public function testManagedRequestIsNotAddedToRequestListing()
 {
 $process = Process::factory()->create([
 'manager_id' => [$this->user->id],
 ]);
 $request = ProcessRequest::factory()->create([
 'process_id' => $process->id,
 ]);

 $this->apiCall('GET', route('api.requests.show', [$request]))
 ->assertStatus(200);

 $this->apiCall('GET', route('api.requests.index'))
 ->assertStatus(200)
 ->assertJsonMissing(['id' => $request->id]);
 }

 public function testScalarProcessManagerValueIsNormalizedForAuthorization()
 {
 $process = Process::factory()->create([
 'manager_id' => $this->user->id,
 ]);
 $request = ProcessRequest::factory()->create([
 'process_id' => $process->id,
 ]);

 $this->assertSame([$this->user->id], $process->fresh()->manager_id);

 $this->apiCall('GET', route('api.requests.show', [$request]))
 ->assertStatus(200);
 }

 public function testProcessManagerReassignmentUpdatesRequestAccess()
 {
 $newManager = User::factory()->create();
 $process = Process::factory()->create([
 'manager_id' => [$this->user->id],
 ]);
 $request = ProcessRequest::factory()->create([
 'process_id' => $process->id,
 ]);

 $this->apiCall('GET', route('api.requests.show', [$request]))
 ->assertStatus(200);

 $process->manager_id = [$newManager->id];
 $process->save();

 $this->apiCall('GET', route('api.requests.show', [$request]))
 ->assertStatus(403);

 $this->user = $newManager;

 $this->apiCall('GET', route('api.requests.show', [$request]))
 ->assertStatus(200);
 }

 public function testProcessManagerCanViewManagedRequestsInEveryStatus()
 {
 $process = Process::factory()->create([
 'manager_id' => [$this->user->id],
 ]);

 foreach (['ACTIVE', 'COMPLETED', 'CANCELED', 'ERROR'] as $status) {
 $request = ProcessRequest::factory()->create([
 'process_id' => $process->id,
 'status' => $status,
 ]);

 $this->apiCall('GET', route('api.requests.show', [$request]))
 ->assertStatus(200);
 }
 }

 public function testEndEventDestinationReturnsNullWhenManagedRequestHasNoEndEvent()
 {
 $process = Process::factory()->create([
 'manager_id' => [$this->user->id],
 ]);
 $request = ProcessRequest::factory()->create([
 'process_id' => $process->id,
 'status' => 'COMPLETED',
 ]);

 $this->apiCall('GET', route('api.requests.end_event_destination', [$request]))
 ->assertStatus(200)
 ->assertJsonPath('data', null);
 }

 public function testEndEventDestinationReturnsConfiguredExternalUrlForProcessManager()
 {
 $bpmn = file_get_contents(__DIR__ . '/../../Fixtures/action_by_email_process_no_require_login.bpmn');
 $bpmn = str_replace(
 '{"type":"summaryScreen","value":null}',
 '{"type":"externalURL","value":"https://example.com/summary"}',
 $bpmn,
 );
 $process = Process::factory()->create([
 'bpmn' => $bpmn,
 'manager_id' => [$this->user->id],
 ]);
 $request = ProcessRequest::factory()->create([
 'process_id' => $process->id,
 'status' => 'COMPLETED',
 ]);
 ProcessRequestToken::factory()->create([
 'element_id' => 'node_18',
 'element_type' => 'end_event',
 'process_id' => $process->id,
 'process_request_id' => $request->id,
 'status' => 'CLOSED',
 ]);

 $this->apiCall('GET', route('api.requests.end_event_destination', [$request]))
 ->assertStatus(200)
 ->assertJsonPath('data.endEventDestination.type', 'externalURL')
 ->assertJsonPath('data.endEventDestination.value', 'https://example.com/summary');
 }
}

25 changes: 25 additions & 0 deletions
tests/Feature/CasesControllerTest.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -62,6 +62,31 @@ public function testShowCaseWithUserWithoutParticipation()
 $response->assertStatus(403);
 }

 public function testProcessManagerCanOpenManagedCaseButUnrelatedUserCannot()
 {
 $processManager = User::factory()->create();
 $firstManager = User::factory()->create();
 $process = Process::factory()->create([
 'manager_id' => [$firstManager->id, $processManager->id],
 ]);
 $request = ProcessRequest::factory()->create([
 'parent_request_id' => null,
 'process_id' => $process->id,
 'status' => 'COMPLETED',
 ]);
 $route = route('cases.show', ['case_number' => $request->case_number]);

 $response = $this->actingAs($processManager)->get($route);

 $response->assertStatus(200);
 $response->assertViewIs('cases.edit');
 $response->assertViewHas('isProcessManager', true);

 $this->actingAs(User::factory()->create())
 ->get($route)
 ->assertStatus(403);
 }

 public function testCasesAllPageReturns403WithoutViewAllCasesPermission()
 {
 Permission::firstOrCreate(
Expand Down

50 changes: 50 additions & 0 deletions
tests/Feature/RequestTest.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,8 @@
namespace Tests\Feature;

use Illuminate\Http\Testing\File;
use Illuminate\Support\Facades\Gate;
use ProcessMaker\Models\Permission;
use ProcessMaker\Models\Process;
use ProcessMaker\Models\ProcessCategory;
use ProcessMaker\Models\ProcessRequest;
Expand DownExpand Up@@ -123,6 +125,54 @@ public function testShowRouteWithAssignedUser()
 $response->assertStatus(200);
 }

 public function testProcessManagerCanViewManagedRequestSummary()
 {
 $this->user = User::factory()->create();
 $firstManager = User::factory()->create();
 $process = Process::factory()->create([
 'manager_id' => [$firstManager->id, $this->user->id],
 ]);
 $request = ProcessRequest::factory()->create([
 'process_id' => $process->id,
 'status' => 'COMPLETED',
 ]);

 $response = $this->webCall('GET', route('requests.show', [$request]));

 $response->assertStatus(200);
 $response->assertViewIs('requests.show');
 $response->assertViewHas('isProcessManager', true);
 }

 public function testProcessManagerCannotViewUnmanagedRequestSummary()
 {
 $this->user = User::factory()->create();
 Process::factory()->create([
 'manager_id' => [$this->user->id],
 ]);
 $unmanagedRequest = ProcessRequest::factory()->create();

 $this->webCall('GET', route('requests.show', [$unmanagedRequest]))
 ->assertStatus(403);
 }

 public function testProcessManagerCannotViewAllRequestsWithoutPermission()
 {
 Permission::firstOrCreate(
 ['name' => 'view-all_requests'],
 ['title' => 'View All Requests'],
 );
 Gate::define('view-all_requests', fn ($user) => $user->hasPermission('view-all_requests'));

 $this->user = User::factory()->create();
 Process::factory()->create([
 'manager_id' => [$this->user->id],
 ]);

 $this->webCall('GET', route('requests_by_type', ['type' => 'all']))
 ->assertStatus(403);
 }

 public function testShowRouteWithAdministrator()
 {
 $this->user = User::factory()->create([
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
FOUR-32764 Process Manager gets an unauthorized error when loading the summary screen without the View All request permission#9007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Open

devmiguelangel
wants to merge
3
commits into

base:develop
Choose a base branch

from


+280

−1

 Open


FOUR-32764 Process Manager gets an unauthorized error when loading the summary screen without the View All request permission
#9007
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
cd3fcfe

feat: refactor process manager check and enhance view policy


devmiguelangel Aug 24, 2026
8ab16f3

test: add tests for process manager request visibility and permissions


devmiguelangel Aug 24, 2026
bc5249b

test: enhance process manager permissions and request visibility tests


devmiguelangel Aug 24, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
ProcessMaker/Http/Controllers/RequestController.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -200,7 +200,7 @@ public function show(ProcessRequest $request, Media $mediaItems)
 $addons = $this->getPluginAddons('edit', compact(['request']));
 $dataActionsAddons = $this->getPluginAddons('edit.dataActions', []);

 $isProcessManager = $request->process?->manager_id === Auth::user()->id;
 $isProcessManager = in_array(Auth::user()->id, $request->process?->manager_id ?? []);

 $eligibleRollbackTask = null;
 $errorTask = RollbackProcessRequest::getErrorTask($request);
Expand Down

4 changes: 4 additions & 0 deletions
ProcessMaker/Policies/ProcessRequestPolicy.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -33,6 +33,10 @@ public function before(User $user)
 */
 public function view(User $user, ProcessRequest $processRequest)
 {
 if (in_array($user->id, $processRequest->process?->manager_id ?? [])) {
 return true;
 }

 // Policy defined in ForUserScope
 return ProcessRequest::forUser($user)
 ->where('process_requests.id', $processRequest->id)
Expand Down

200 changes: 200 additions & 0 deletions
tests/Feature/Api/ProcessRequestPolicyTest.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@
namespace Tests\Feature\Api;

use Database\Seeders\PermissionSeeder;
use ProcessMaker\Models\Process;
use ProcessMaker\Models\ProcessRequest;
use ProcessMaker\Models\ProcessRequestToken;
use ProcessMaker\Models\User;
Expand DownExpand Up@@ -72,4 +73,203 @@ public function testUserHasPermission()
 $response = $this->apiCall('GET', $route);
 $response->assertStatus(200);
 }

 public function testProcessManagerCanViewManagedRequestAndEndEventDestination()
 {
 $firstManager = User::factory()->create();
 $process = Process::factory()->create([
 'bpmn' => file_get_contents(__DIR__ . '/../../Fixtures/action_by_email_process_no_require_login.bpmn'),
 'manager_id' => [$firstManager->id, $this->user->id],
 ]);
 $request = ProcessRequest::factory()->create([
 'process_id' => $process->id,
 'status' => 'COMPLETED',
 ]);
 ProcessRequestToken::factory()->create([
 'element_id' => 'node_18',
 'element_type' => 'end_event',
 'process_id' => $process->id,
 'process_request_id' => $request->id,
 'status' => 'CLOSED',
 ]);

 $this->apiCall('GET', route('api.requests.show', [$request]))
 ->assertStatus(200);

 $this->apiCall('GET', route('api.requests.end_event_destination', [$request]))
 ->assertStatus(200)
 ->assertJsonPath('data.endEventDestination.type', 'summaryScreen')
 ->assertJsonPath('data.endEventDestination.value', null);
 }

 public function testProcessManagerCannotViewRequestFromUnmanagedProcess()
 {
 $managedProcess = Process::factory()->create([
 'manager_id' => [$this->user->id],
 ]);
 $unmanagedRequest = ProcessRequest::factory()->create();

 $this->assertNotEquals($managedProcess->id, $unmanagedRequest->process_id);

 $this->apiCall('GET', route('api.requests.show', [$unmanagedRequest]))
 ->assertStatus(403);

 $this->apiCall('GET', route('api.requests.end_event_destination', [$unmanagedRequest]))
 ->assertStatus(403);
 }

 public function testProcessManagerAccessIsRevokedWhenRemovedFromProcess()
 {
 $process = Process::factory()->create([
 'manager_id' => [$this->user->id],
 ]);
 $request = ProcessRequest::factory()->create([
 'process_id' => $process->id,
 ]);

 $this->apiCall('GET', route('api.requests.show', [$request]))
 ->assertStatus(200);

 $process->manager_id = [];
 $process->save();

 $this->apiCall('GET', route('api.requests.show', [$request]))
 ->assertStatus(403);
 }

 public function testProcessManagerCannotUpdateOrDeleteManagedRequest()
 {
 $process = Process::factory()->create([
 'manager_id' => [$this->user->id],
 ]);
 $request = ProcessRequest::factory()->create([
 'process_id' => $process->id,
 ]);

 $this->apiCall('PUT', route('api.requests.update', [$request]), [
 'name' => 'Unauthorized update',
 ])->assertStatus(403);

 $this->apiCall('DELETE', route('api.requests.destroy', [$request]))
 ->assertStatus(403);
 }

 public function testManagedRequestIsNotAddedToRequestListing()
 {
 $process = Process::factory()->create([
 'manager_id' => [$this->user->id],
 ]);
 $request = ProcessRequest::factory()->create([
 'process_id' => $process->id,
 ]);

 $this->apiCall('GET', route('api.requests.show', [$request]))
 ->assertStatus(200);

 $this->apiCall('GET', route('api.requests.index'))
 ->assertStatus(200)
 ->assertJsonMissing(['id' => $request->id]);
 }

 public function testScalarProcessManagerValueIsNormalizedForAuthorization()
 {
 $process = Process::factory()->create([
 'manager_id' => $this->user->id,
 ]);
 $request = ProcessRequest::factory()->create([
 'process_id' => $process->id,
 ]);

 $this->assertSame([$this->user->id], $process->fresh()->manager_id);

 $this->apiCall('GET', route('api.requests.show', [$request]))
 ->assertStatus(200);
 }

 public function testProcessManagerReassignmentUpdatesRequestAccess()
 {
 $newManager = User::factory()->create();
 $process = Process::factory()->create([
 'manager_id' => [$this->user->id],
 ]);
 $request = ProcessRequest::factory()->create([
 'process_id' => $process->id,
 ]);

 $this->apiCall('GET', route('api.requests.show', [$request]))
 ->assertStatus(200);

 $process->manager_id = [$newManager->id];
 $process->save();

 $this->apiCall('GET', route('api.requests.show', [$request]))
 ->assertStatus(403);

 $this->user = $newManager;

 $this->apiCall('GET', route('api.requests.show', [$request]))
 ->assertStatus(200);
 }

 public function testProcessManagerCanViewManagedRequestsInEveryStatus()
 {
 $process = Process::factory()->create([
 'manager_id' => [$this->user->id],
 ]);

 foreach (['ACTIVE', 'COMPLETED', 'CANCELED', 'ERROR'] as $status) {
 $request = ProcessRequest::factory()->create([
 'process_id' => $process->id,
 'status' => $status,
 ]);

 $this->apiCall('GET', route('api.requests.show', [$request]))
 ->assertStatus(200);
 }
 }

 public function testEndEventDestinationReturnsNullWhenManagedRequestHasNoEndEvent()
 {
 $process = Process::factory()->create([
 'manager_id' => [$this->user->id],
 ]);
 $request = ProcessRequest::factory()->create([
 'process_id' => $process->id,
 'status' => 'COMPLETED',
 ]);

 $this->apiCall('GET', route('api.requests.end_event_destination', [$request]))
 ->assertStatus(200)
 ->assertJsonPath('data', null);
 }

 public function testEndEventDestinationReturnsConfiguredExternalUrlForProcessManager()
 {
 $bpmn = file_get_contents(__DIR__ . '/../../Fixtures/action_by_email_process_no_require_login.bpmn');
 $bpmn = str_replace(
 '{"type":"summaryScreen","value":null}',
 '{"type":"externalURL","value":"https://example.com/summary"}',
 $bpmn,
 );
 $process = Process::factory()->create([
 'bpmn' => $bpmn,
 'manager_id' => [$this->user->id],
 ]);
 $request = ProcessRequest::factory()->create([
 'process_id' => $process->id,
 'status' => 'COMPLETED',
 ]);
 ProcessRequestToken::factory()->create([
 'element_id' => 'node_18',
 'element_type' => 'end_event',
 'process_id' => $process->id,
 'process_request_id' => $request->id,
 'status' => 'CLOSED',
 ]);

 $this->apiCall('GET', route('api.requests.end_event_destination', [$request]))
 ->assertStatus(200)
 ->assertJsonPath('data.endEventDestination.type', 'externalURL')
 ->assertJsonPath('data.endEventDestination.value', 'https://example.com/summary');
 }
}

25 changes: 25 additions & 0 deletions
tests/Feature/CasesControllerTest.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -62,6 +62,31 @@ public function testShowCaseWithUserWithoutParticipation()
 $response->assertStatus(403);
 }

 public function testProcessManagerCanOpenManagedCaseButUnrelatedUserCannot()
 {
 $processManager = User::factory()->create();
 $firstManager = User::factory()->create();
 $process = Process::factory()->create([
 'manager_id' => [$firstManager->id, $processManager->id],
 ]);
 $request = ProcessRequest::factory()->create([
 'parent_request_id' => null,
 'process_id' => $process->id,
 'status' => 'COMPLETED',
 ]);
 $route = route('cases.show', ['case_number' => $request->case_number]);

 $response = $this->actingAs($processManager)->get($route);

 $response->assertStatus(200);
 $response->assertViewIs('cases.edit');
 $response->assertViewHas('isProcessManager', true);

 $this->actingAs(User::factory()->create())
 ->get($route)
 ->assertStatus(403);
 }

 public function testCasesAllPageReturns403WithoutViewAllCasesPermission()
 {
 Permission::firstOrCreate(
Expand Down

50 changes: 50 additions & 0 deletions
tests/Feature/RequestTest.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,8 @@
namespace Tests\Feature;

use Illuminate\Http\Testing\File;
use Illuminate\Support\Facades\Gate;
use ProcessMaker\Models\Permission;
use ProcessMaker\Models\Process;
use ProcessMaker\Models\ProcessCategory;
use ProcessMaker\Models\ProcessRequest;
Expand DownExpand Up@@ -123,6 +125,54 @@ public function testShowRouteWithAssignedUser()
 $response->assertStatus(200);
 }

 public function testProcessManagerCanViewManagedRequestSummary()
 {
 $this->user = User::factory()->create();
 $firstManager = User::factory()->create();
 $process = Process::factory()->create([
 'manager_id' => [$firstManager->id, $this->user->id],
 ]);
 $request = ProcessRequest::factory()->create([
 'process_id' => $process->id,
 'status' => 'COMPLETED',
 ]);

 $response = $this->webCall('GET', route('requests.show', [$request]));

 $response->assertStatus(200);
 $response->assertViewIs('requests.show');
 $response->assertViewHas('isProcessManager', true);
 }

 public function testProcessManagerCannotViewUnmanagedRequestSummary()
 {
 $this->user = User::factory()->create();
 Process::factory()->create([
 'manager_id' => [$this->user->id],
 ]);
 $unmanagedRequest = ProcessRequest::factory()->create();

 $this->webCall('GET', route('requests.show', [$unmanagedRequest]))
 ->assertStatus(403);
 }

 public function testProcessManagerCannotViewAllRequestsWithoutPermission()
 {
 Permission::firstOrCreate(
 ['name' => 'view-all_requests'],
 ['title' => 'View All Requests'],
 );
 Gate::define('view-all_requests', fn ($user) => $user->hasPermission('view-all_requests'));

 $this->user = User::factory()->create();
 Process::factory()->create([
 'manager_id' => [$this->user->id],
 ]);

 $this->webCall('GET', route('requests_by_type', ['type' => 'all']))
 ->assertStatus(403);
 }

 public function testShowRouteWithAdministrator()
 {
 $this->user = User::factory()->create([
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
FOUR-32764 Process Manager gets an unauthorized error when loading the summary screen without the View All request permission#9007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Open

devmiguelangel
wants to merge
3
commits into

base:develop
Choose a base branch

from


+280

−1

 Open


FOUR-32764 Process Manager gets an unauthorized error when loading the summary screen without the View All request permission
#9007
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
cd3fcfe

feat: refactor process manager check and enhance view policy


devmiguelangel Aug 24, 2026
8ab16f3

test: add tests for process manager request visibility and permissions


devmiguelangel Aug 24, 2026
bc5249b

test: enhance process manager permissions and request visibility tests


devmiguelangel Aug 24, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
ProcessMaker/Http/Controllers/RequestController.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -200,7 +200,7 @@ public function show(ProcessRequest $request, Media $mediaItems)
 $addons = $this->getPluginAddons('edit', compact(['request']));
 $dataActionsAddons = $this->getPluginAddons('edit.dataActions', []);

 $isProcessManager = $request->process?->manager_id === Auth::user()->id;
 $isProcessManager = in_array(Auth::user()->id, $request->process?->manager_id ?? []);

 $eligibleRollbackTask = null;
 $errorTask = RollbackProcessRequest::getErrorTask($request);
Expand Down

4 changes: 4 additions & 0 deletions
ProcessMaker/Policies/ProcessRequestPolicy.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -33,6 +33,10 @@ public function before(User $user)
 */
 public function view(User $user, ProcessRequest $processRequest)
 {
 if (in_array($user->id, $processRequest->process?->manager_id ?? [])) {
 return true;
 }

 // Policy defined in ForUserScope
 return ProcessRequest::forUser($user)
 ->where('process_requests.id', $processRequest->id)
Expand Down

200 changes: 200 additions & 0 deletions
tests/Feature/Api/ProcessRequestPolicyTest.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@
namespace Tests\Feature\Api;

use Database\Seeders\PermissionSeeder;
use ProcessMaker\Models\Process;
use ProcessMaker\Models\ProcessRequest;
use ProcessMaker\Models\ProcessRequestToken;
use ProcessMaker\Models\User;
Expand DownExpand Up@@ -72,4 +73,203 @@ public function testUserHasPermission()
 $response = $this->apiCall('GET', $route);
 $response->assertStatus(200);
 }

 public function testProcessManagerCanViewManagedRequestAndEndEventDestination()
 {
 $firstManager = User::factory()->create();
 $process = Process::factory()->create([
 'bpmn' => file_get_contents(__DIR__ . '/../../Fixtures/action_by_email_process_no_require_login.bpmn'),
 'manager_id' => [$firstManager->id, $this->user->id],
 ]);
 $request = ProcessRequest::factory()->create([
 'process_id' => $process->id,
 'status' => 'COMPLETED',
 ]);
 ProcessRequestToken::factory()->create([
 'element_id' => 'node_18',
 'element_type' => 'end_event',
 'process_id' => $process->id,
 'process_request_id' => $request->id,
 'status' => 'CLOSED',
 ]);

 $this->apiCall('GET', route('api.requests.show', [$request]))
 ->assertStatus(200);

 $this->apiCall('GET', route('api.requests.end_event_destination', [$request]))
 ->assertStatus(200)
 ->assertJsonPath('data.endEventDestination.type', 'summaryScreen')
 ->assertJsonPath('data.endEventDestination.value', null);
 }

 public function testProcessManagerCannotViewRequestFromUnmanagedProcess()
 {
 $managedProcess = Process::factory()->create([
 'manager_id' => [$this->user->id],
 ]);
 $unmanagedRequest = ProcessRequest::factory()->create();

 $this->assertNotEquals($managedProcess->id, $unmanagedRequest->process_id);

 $this->apiCall('GET', route('api.requests.show', [$unmanagedRequest]))
 ->assertStatus(403);

 $this->apiCall('GET', route('api.requests.end_event_destination', [$unmanagedRequest]))
 ->assertStatus(403);
 }

 public function testProcessManagerAccessIsRevokedWhenRemovedFromProcess()
 {
 $process = Process::factory()->create([
 'manager_id' => [$this->user->id],
 ]);
 $request = ProcessRequest::factory()->create([
 'process_id' => $process->id,
 ]);

 $this->apiCall('GET', route('api.requests.show', [$request]))
 ->assertStatus(200);

 $process->manager_id = [];
 $process->save();

 $this->apiCall('GET', route('api.requests.show', [$request]))
 ->assertStatus(403);
 }

 public function testProcessManagerCannotUpdateOrDeleteManagedRequest()
 {
 $process = Process::factory()->create([
 'manager_id' => [$this->user->id],
 ]);
 $request = ProcessRequest::factory()->create([
 'process_id' => $process->id,
 ]);

 $this->apiCall('PUT', route('api.requests.update', [$request]), [
 'name' => 'Unauthorized update',
 ])->assertStatus(403);

 $this->apiCall('DELETE', route('api.requests.destroy', [$request]))
 ->assertStatus(403);
 }

 public function testManagedRequestIsNotAddedToRequestListing()
 {
 $process = Process::factory()->create([
 'manager_id' => [$this->user->id],
 ]);
 $request = ProcessRequest::factory()->create([
 'process_id' => $process->id,
 ]);

 $this->apiCall('GET', route('api.requests.show', [$request]))
 ->assertStatus(200);

 $this->apiCall('GET', route('api.requests.index'))
 ->assertStatus(200)
 ->assertJsonMissing(['id' => $request->id]);
 }

 public function testScalarProcessManagerValueIsNormalizedForAuthorization()
 {
 $process = Process::factory()->create([
 'manager_id' => $this->user->id,
 ]);
 $request = ProcessRequest::factory()->create([
 'process_id' => $process->id,
 ]);

 $this->assertSame([$this->user->id], $process->fresh()->manager_id);

 $this->apiCall('GET', route('api.requests.show', [$request]))
 ->assertStatus(200);
 }

 public function testProcessManagerReassignmentUpdatesRequestAccess()
 {
 $newManager = User::factory()->create();
 $process = Process::factory()->create([
 'manager_id' => [$this->user->id],
 ]);
 $request = ProcessRequest::factory()->create([
 'process_id' => $process->id,
 ]);

 $this->apiCall('GET', route('api.requests.show', [$request]))
 ->assertStatus(200);

 $process->manager_id = [$newManager->id];
 $process->save();

 $this->apiCall('GET', route('api.requests.show', [$request]))
 ->assertStatus(403);

 $this->user = $newManager;

 $this->apiCall('GET', route('api.requests.show', [$request]))
 ->assertStatus(200);
 }

 public function testProcessManagerCanViewManagedRequestsInEveryStatus()
 {
 $process = Process::factory()->create([
 'manager_id' => [$this->user->id],
 ]);

 foreach (['ACTIVE', 'COMPLETED', 'CANCELED', 'ERROR'] as $status) {
 $request = ProcessRequest::factory()->create([
 'process_id' => $process->id,
 'status' => $status,
 ]);

 $this->apiCall('GET', route('api.requests.show', [$request]))
 ->assertStatus(200);
 }
 }

 public function testEndEventDestinationReturnsNullWhenManagedRequestHasNoEndEvent()
 {
 $process = Process::factory()->create([
 'manager_id' => [$this->user->id],
 ]);
 $request = ProcessRequest::factory()->create([
 'process_id' => $process->id,
 'status' => 'COMPLETED',
 ]);

 $this->apiCall('GET', route('api.requests.end_event_destination', [$request]))
 ->assertStatus(200)
 ->assertJsonPath('data', null);
 }

 public function testEndEventDestinationReturnsConfiguredExternalUrlForProcessManager()
 {
 $bpmn = file_get_contents(__DIR__ . '/../../Fixtures/action_by_email_process_no_require_login.bpmn');
 $bpmn = str_replace(
 '{"type":"summaryScreen","value":null}',
 '{"type":"externalURL","value":"https://example.com/summary"}',
 $bpmn,
 );
 $process = Process::factory()->create([
 'bpmn' => $bpmn,
 'manager_id' => [$this->user->id],
 ]);
 $request = ProcessRequest::factory()->create([
 'process_id' => $process->id,
 'status' => 'COMPLETED',
 ]);
 ProcessRequestToken::factory()->create([
 'element_id' => 'node_18',
 'element_type' => 'end_event',
 'process_id' => $process->id,
 'process_request_id' => $request->id,
 'status' => 'CLOSED',
 ]);

 $this->apiCall('GET', route('api.requests.end_event_destination', [$request]))
 ->assertStatus(200)
 ->assertJsonPath('data.endEventDestination.type', 'externalURL')
 ->assertJsonPath('data.endEventDestination.value', 'https://example.com/summary');
 }
}

25 changes: 25 additions & 0 deletions
tests/Feature/CasesControllerTest.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -62,6 +62,31 @@ public function testShowCaseWithUserWithoutParticipation()
 $response->assertStatus(403);
 }

 public function testProcessManagerCanOpenManagedCaseButUnrelatedUserCannot()
 {
 $processManager = User::factory()->create();
 $firstManager = User::factory()->create();
 $process = Process::factory()->create([
 'manager_id' => [$firstManager->id, $processManager->id],
 ]);
 $request = ProcessRequest::factory()->create([
 'parent_request_id' => null,
 'process_id' => $process->id,
 'status' => 'COMPLETED',
 ]);
 $route = route('cases.show', ['case_number' => $request->case_number]);

 $response = $this->actingAs($processManager)->get($route);

 $response->assertStatus(200);
 $response->assertViewIs('cases.edit');
 $response->assertViewHas('isProcessManager', true);

 $this->actingAs(User::factory()->create())
 ->get($route)
 ->assertStatus(403);
 }

 public function testCasesAllPageReturns403WithoutViewAllCasesPermission()
 {
 Permission::firstOrCreate(
Expand Down

50 changes: 50 additions & 0 deletions
tests/Feature/RequestTest.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,8 @@
namespace Tests\Feature;

use Illuminate\Http\Testing\File;
use Illuminate\Support\Facades\Gate;
use ProcessMaker\Models\Permission;
use ProcessMaker\Models\Process;
use ProcessMaker\Models\ProcessCategory;
use ProcessMaker\Models\ProcessRequest;
Expand DownExpand Up@@ -123,6 +125,54 @@ public function testShowRouteWithAssignedUser()
 $response->assertStatus(200);
 }

 public function testProcessManagerCanViewManagedRequestSummary()
 {
 $this->user = User::factory()->create();
 $firstManager = User::factory()->create();
 $process = Process::factory()->create([
 'manager_id' => [$firstManager->id, $this->user->id],
 ]);
 $request = ProcessRequest::factory()->create([
 'process_id' => $process->id,
 'status' => 'COMPLETED',
 ]);

 $response = $this->webCall('GET', route('requests.show', [$request]));

 $response->assertStatus(200);
 $response->assertViewIs('requests.show');
 $response->assertViewHas('isProcessManager', true);
 }

 public function testProcessManagerCannotViewUnmanagedRequestSummary()
 {
 $this->user = User::factory()->create();
 Process::factory()->create([
 'manager_id' => [$this->user->id],
 ]);
 $unmanagedRequest = ProcessRequest::factory()->create();

 $this->webCall('GET', route('requests.show', [$unmanagedRequest]))
 ->assertStatus(403);
 }

 public function testProcessManagerCannotViewAllRequestsWithoutPermission()
 {
 Permission::firstOrCreate(
 ['name' => 'view-all_requests'],
 ['title' => 'View All Requests'],
 );
 Gate::define('view-all_requests', fn ($user) => $user->hasPermission('view-all_requests'));

 $this->user = User::factory()->create();
 Process::factory()->create([
 'manager_id' => [$this->user->id],
 ]);

 $this->webCall('GET', route('requests_by_type', ['type' => 'all']))
 ->assertStatus(403);
 }

 public function testShowRouteWithAdministrator()
 {
 $this->user = User::factory()->create([
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
FOUR-32764 Process Manager gets an unauthorized error when loading the summary screen without the View All request permission#9007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Open

devmiguelangel
wants to merge
3
commits into

base:develop
Choose a base branch

from


+280

−1

 Open


FOUR-32764 Process Manager gets an unauthorized error when loading the summary screen without the View All request permission
#9007
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
cd3fcfe

feat: refactor process manager check and enhance view policy


devmiguelangel Aug 24, 2026
8ab16f3

test: add tests for process manager request visibility and permissions


devmiguelangel Aug 24, 2026
bc5249b

test: enhance process manager permissions and request visibility tests


devmiguelangel Aug 24, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
ProcessMaker/Http/Controllers/RequestController.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -200,7 +200,7 @@ public function show(ProcessRequest $request, Media $mediaItems)
 $addons = $this->getPluginAddons('edit', compact(['request']));
 $dataActionsAddons = $this->getPluginAddons('edit.dataActions', []);

 $isProcessManager = $request->process?->manager_id === Auth::user()->id;
 $isProcessManager = in_array(Auth::user()->id, $request->process?->manager_id ?? []);

 $eligibleRollbackTask = null;
 $errorTask = RollbackProcessRequest::getErrorTask($request);
Expand Down

4 changes: 4 additions & 0 deletions
ProcessMaker/Policies/ProcessRequestPolicy.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -33,6 +33,10 @@ public function before(User $user)
 */
 public function view(User $user, ProcessRequest $processRequest)
 {
 if (in_array($user->id, $processRequest->process?->manager_id ?? [])) {
 return true;
 }

 // Policy defined in ForUserScope
 return ProcessRequest::forUser($user)
 ->where('process_requests.id', $processRequest->id)
Expand Down

200 changes: 200 additions & 0 deletions
tests/Feature/Api/ProcessRequestPolicyTest.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@
namespace Tests\Feature\Api;

use Database\Seeders\PermissionSeeder;
use ProcessMaker\Models\Process;
use ProcessMaker\Models\ProcessRequest;
use ProcessMaker\Models\ProcessRequestToken;
use ProcessMaker\Models\User;
Expand DownExpand Up@@ -72,4 +73,203 @@ public function testUserHasPermission()
 $response = $this->apiCall('GET', $route);
 $response->assertStatus(200);
 }

 public function testProcessManagerCanViewManagedRequestAndEndEventDestination()
 {
 $firstManager = User::factory()->create();
 $process = Process::factory()->create([
 'bpmn' => file_get_contents(__DIR__ . '/../../Fixtures/action_by_email_process_no_require_login.bpmn'),
 'manager_id' => [$firstManager->id, $this->user->id],
 ]);
 $request = ProcessRequest::factory()->create([
 'process_id' => $process->id,
 'status' => 'COMPLETED',
 ]);
 ProcessRequestToken::factory()->create([
 'element_id' => 'node_18',
 'element_type' => 'end_event',
 'process_id' => $process->id,
 'process_request_id' => $request->id,
 'status' => 'CLOSED',
 ]);

 $this->apiCall('GET', route('api.requests.show', [$request]))
 ->assertStatus(200);

 $this->apiCall('GET', route('api.requests.end_event_destination', [$request]))
 ->assertStatus(200)
 ->assertJsonPath('data.endEventDestination.type', 'summaryScreen')
 ->assertJsonPath('data.endEventDestination.value', null);
 }

 public function testProcessManagerCannotViewRequestFromUnmanagedProcess()
 {
 $managedProcess = Process::factory()->create([
 'manager_id' => [$this->user->id],
 ]);
 $unmanagedRequest = ProcessRequest::factory()->create();

 $this->assertNotEquals($managedProcess->id, $unmanagedRequest->process_id);

 $this->apiCall('GET', route('api.requests.show', [$unmanagedRequest]))
 ->assertStatus(403);

 $this->apiCall('GET', route('api.requests.end_event_destination', [$unmanagedRequest]))
 ->assertStatus(403);
 }

 public function testProcessManagerAccessIsRevokedWhenRemovedFromProcess()
 {
 $process = Process::factory()->create([
 'manager_id' => [$this->user->id],
 ]);
 $request = ProcessRequest::factory()->create([
 'process_id' => $process->id,
 ]);

 $this->apiCall('GET', route('api.requests.show', [$request]))
 ->assertStatus(200);

 $process->manager_id = [];
 $process->save();

 $this->apiCall('GET', route('api.requests.show', [$request]))
 ->assertStatus(403);
 }

 public function testProcessManagerCannotUpdateOrDeleteManagedRequest()
 {
 $process = Process::factory()->create([
 'manager_id' => [$this->user->id],
 ]);
 $request = ProcessRequest::factory()->create([
 'process_id' => $process->id,
 ]);

 $this->apiCall('PUT', route('api.requests.update', [$request]), [
 'name' => 'Unauthorized update',
 ])->assertStatus(403);

 $this->apiCall('DELETE', route('api.requests.destroy', [$request]))
 ->assertStatus(403);
 }

 public function testManagedRequestIsNotAddedToRequestListing()
 {
 $process = Process::factory()->create([
 'manager_id' => [$this->user->id],
 ]);
 $request = ProcessRequest::factory()->create([
 'process_id' => $process->id,
 ]);

 $this->apiCall('GET', route('api.requests.show', [$request]))
 ->assertStatus(200);

 $this->apiCall('GET', route('api.requests.index'))
 ->assertStatus(200)
 ->assertJsonMissing(['id' => $request->id]);
 }

 public function testScalarProcessManagerValueIsNormalizedForAuthorization()
 {
 $process = Process::factory()->create([
 'manager_id' => $this->user->id,
 ]);
 $request = ProcessRequest::factory()->create([
 'process_id' => $process->id,
 ]);

 $this->assertSame([$this->user->id], $process->fresh()->manager_id);

 $this->apiCall('GET', route('api.requests.show', [$request]))
 ->assertStatus(200);
 }

 public function testProcessManagerReassignmentUpdatesRequestAccess()
 {
 $newManager = User::factory()->create();
 $process = Process::factory()->create([
 'manager_id' => [$this->user->id],
 ]);
 $request = ProcessRequest::factory()->create([
 'process_id' => $process->id,
 ]);

 $this->apiCall('GET', route('api.requests.show', [$request]))
 ->assertStatus(200);

 $process->manager_id = [$newManager->id];
 $process->save();

 $this->apiCall('GET', route('api.requests.show', [$request]))
 ->assertStatus(403);

 $this->user = $newManager;

 $this->apiCall('GET', route('api.requests.show', [$request]))
 ->assertStatus(200);
 }

 public function testProcessManagerCanViewManagedRequestsInEveryStatus()
 {
 $process = Process::factory()->create([
 'manager_id' => [$this->user->id],
 ]);

 foreach (['ACTIVE', 'COMPLETED', 'CANCELED', 'ERROR'] as $status) {
 $request = ProcessRequest::factory()->create([
 'process_id' => $process->id,
 'status' => $status,
 ]);

 $this->apiCall('GET', route('api.requests.show', [$request]))
 ->assertStatus(200);
 }
 }

 public function testEndEventDestinationReturnsNullWhenManagedRequestHasNoEndEvent()
 {
 $process = Process::factory()->create([
 'manager_id' => [$this->user->id],
 ]);
 $request = ProcessRequest::factory()->create([
 'process_id' => $process->id,
 'status' => 'COMPLETED',
 ]);

 $this->apiCall('GET', route('api.requests.end_event_destination', [$request]))
 ->assertStatus(200)
 ->assertJsonPath('data', null);
 }

 public function testEndEventDestinationReturnsConfiguredExternalUrlForProcessManager()
 {
 $bpmn = file_get_contents(__DIR__ . '/../../Fixtures/action_by_email_process_no_require_login.bpmn');
 $bpmn = str_replace(
 '{"type":"summaryScreen","value":null}',
 '{"type":"externalURL","value":"https://example.com/summary"}',
 $bpmn,
 );
 $process = Process::factory()->create([
 'bpmn' => $bpmn,
 'manager_id' => [$this->user->id],
 ]);
 $request = ProcessRequest::factory()->create([
 'process_id' => $process->id,
 'status' => 'COMPLETED',
 ]);
 ProcessRequestToken::factory()->create([
 'element_id' => 'node_18',
 'element_type' => 'end_event',
 'process_id' => $process->id,
 'process_request_id' => $request->id,
 'status' => 'CLOSED',
 ]);

 $this->apiCall('GET', route('api.requests.end_event_destination', [$request]))
 ->assertStatus(200)
 ->assertJsonPath('data.endEventDestination.type', 'externalURL')
 ->assertJsonPath('data.endEventDestination.value', 'https://example.com/summary');
 }
}

25 changes: 25 additions & 0 deletions
tests/Feature/CasesControllerTest.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -62,6 +62,31 @@ public function testShowCaseWithUserWithoutParticipation()
 $response->assertStatus(403);
 }

 public function testProcessManagerCanOpenManagedCaseButUnrelatedUserCannot()
 {
 $processManager = User::factory()->create();
 $firstManager = User::factory()->create();
 $process = Process::factory()->create([
 'manager_id' => [$firstManager->id, $processManager->id],
 ]);
 $request = ProcessRequest::factory()->create([
 'parent_request_id' => null,
 'process_id' => $process->id,
 'status' => 'COMPLETED',
 ]);
 $route = route('cases.show', ['case_number' => $request->case_number]);

 $response = $this->actingAs($processManager)->get($route);

 $response->assertStatus(200);
 $response->assertViewIs('cases.edit');
 $response->assertViewHas('isProcessManager', true);

 $this->actingAs(User::factory()->create())
 ->get($route)
 ->assertStatus(403);
 }

 public function testCasesAllPageReturns403WithoutViewAllCasesPermission()
 {
 Permission::firstOrCreate(
Expand Down

50 changes: 50 additions & 0 deletions
tests/Feature/RequestTest.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,8 @@
namespace Tests\Feature;

use Illuminate\Http\Testing\File;
use Illuminate\Support\Facades\Gate;
use ProcessMaker\Models\Permission;
use ProcessMaker\Models\Process;
use ProcessMaker\Models\ProcessCategory;
use ProcessMaker\Models\ProcessRequest;
Expand DownExpand Up@@ -123,6 +125,54 @@ public function testShowRouteWithAssignedUser()
 $response->assertStatus(200);
 }

 public function testProcessManagerCanViewManagedRequestSummary()
 {
 $this->user = User::factory()->create();
 $firstManager = User::factory()->create();
 $process = Process::factory()->create([
 'manager_id' => [$firstManager->id, $this->user->id],
 ]);
 $request = ProcessRequest::factory()->create([
 'process_id' => $process->id,
 'status' => 'COMPLETED',
 ]);

 $response = $this->webCall('GET', route('requests.show', [$request]));

 $response->assertStatus(200);
 $response->assertViewIs('requests.show');
 $response->assertViewHas('isProcessManager', true);
 }

 public function testProcessManagerCannotViewUnmanagedRequestSummary()
 {
 $this->user = User::factory()->create();
 Process::factory()->create([
 'manager_id' => [$this->user->id],
 ]);
 $unmanagedRequest = ProcessRequest::factory()->create();

 $this->webCall('GET', route('requests.show', [$unmanagedRequest]))
 ->assertStatus(403);
 }

 public function testProcessManagerCannotViewAllRequestsWithoutPermission()
 {
 Permission::firstOrCreate(
 ['name' => 'view-all_requests'],
 ['title' => 'View All Requests'],
 );
 Gate::define('view-all_requests', fn ($user) => $user->hasPermission('view-all_requests'));

 $this->user = User::factory()->create();
 Process::factory()->create([
 'manager_id' => [$this->user->id],
 ]);

 $this->webCall('GET', route('requests_by_type', ['type' => 'all']))
 ->assertStatus(403);
 }

 public function testShowRouteWithAdministrator()
 {
 $this->user = User::factory()->create([
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
FOUR-32764 Process Manager gets an unauthorized error when loading the summary screen without the View All request permission#9007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Open

devmiguelangel
wants to merge
3
commits into

base:develop
Choose a base branch

from


+280

−1

 Open


FOUR-32764 Process Manager gets an unauthorized error when loading the summary screen without the View All request permission
#9007
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
cd3fcfe

feat: refactor process manager check and enhance view policy


devmiguelangel Aug 24, 2026
8ab16f3

test: add tests for process manager request visibility and permissions


devmiguelangel Aug 24, 2026
bc5249b

test: enhance process manager permissions and request visibility tests


devmiguelangel Aug 24, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
ProcessMaker/Http/Controllers/RequestController.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -200,7 +200,7 @@ public function show(ProcessRequest $request, Media $mediaItems)
 $addons = $this->getPluginAddons('edit', compact(['request']));
 $dataActionsAddons = $this->getPluginAddons('edit.dataActions', []);

 $isProcessManager = $request->process?->manager_id === Auth::user()->id;
 $isProcessManager = in_array(Auth::user()->id, $request->process?->manager_id ?? []);

 $eligibleRollbackTask = null;
 $errorTask = RollbackProcessRequest::getErrorTask($request);
Expand Down

4 changes: 4 additions & 0 deletions
ProcessMaker/Policies/ProcessRequestPolicy.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -33,6 +33,10 @@ public function before(User $user)
 */
 public function view(User $user, ProcessRequest $processRequest)
 {
 if (in_array($user->id, $processRequest->process?->manager_id ?? [])) {
 return true;
 }

 // Policy defined in ForUserScope
 return ProcessRequest::forUser($user)
 ->where('process_requests.id', $processRequest->id)
Expand Down

200 changes: 200 additions & 0 deletions
tests/Feature/Api/ProcessRequestPolicyTest.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@
namespace Tests\Feature\Api;

use Database\Seeders\PermissionSeeder;
use ProcessMaker\Models\Process;
use ProcessMaker\Models\ProcessRequest;
use ProcessMaker\Models\ProcessRequestToken;
use ProcessMaker\Models\User;
Expand DownExpand Up@@ -72,4 +73,203 @@ public function testUserHasPermission()
 $response = $this->apiCall('GET', $route);
 $response->assertStatus(200);
 }

 public function testProcessManagerCanViewManagedRequestAndEndEventDestination()
 {
 $firstManager = User::factory()->create();
 $process = Process::factory()->create([
 'bpmn' => file_get_contents(__DIR__ . '/../../Fixtures/action_by_email_process_no_require_login.bpmn'),
 'manager_id' => [$firstManager->id, $this->user->id],
 ]);
 $request = ProcessRequest::factory()->create([
 'process_id' => $process->id,
 'status' => 'COMPLETED',
 ]);
 ProcessRequestToken::factory()->create([
 'element_id' => 'node_18',
 'element_type' => 'end_event',
 'process_id' => $process->id,
 'process_request_id' => $request->id,
 'status' => 'CLOSED',
 ]);

 $this->apiCall('GET', route('api.requests.show', [$request]))
 ->assertStatus(200);

 $this->apiCall('GET', route('api.requests.end_event_destination', [$request]))
 ->assertStatus(200)
 ->assertJsonPath('data.endEventDestination.type', 'summaryScreen')
 ->assertJsonPath('data.endEventDestination.value', null);
 }

 public function testProcessManagerCannotViewRequestFromUnmanagedProcess()
 {
 $managedProcess = Process::factory()->create([
 'manager_id' => [$this->user->id],
 ]);
 $unmanagedRequest = ProcessRequest::factory()->create();

 $this->assertNotEquals($managedProcess->id, $unmanagedRequest->process_id);

 $this->apiCall('GET', route('api.requests.show', [$unmanagedRequest]))
 ->assertStatus(403);

 $this->apiCall('GET', route('api.requests.end_event_destination', [$unmanagedRequest]))
 ->assertStatus(403);
 }

 public function testProcessManagerAccessIsRevokedWhenRemovedFromProcess()
 {
 $process = Process::factory()->create([
 'manager_id' => [$this->user->id],
 ]);
 $request = ProcessRequest::factory()->create([
 'process_id' => $process->id,
 ]);

 $this->apiCall('GET', route('api.requests.show', [$request]))
 ->assertStatus(200);

 $process->manager_id = [];
 $process->save();

 $this->apiCall('GET', route('api.requests.show', [$request]))
 ->assertStatus(403);
 }

 public function testProcessManagerCannotUpdateOrDeleteManagedRequest()
 {
 $process = Process::factory()->create([
 'manager_id' => [$this->user->id],
 ]);
 $request = ProcessRequest::factory()->create([
 'process_id' => $process->id,
 ]);

 $this->apiCall('PUT', route('api.requests.update', [$request]), [
 'name' => 'Unauthorized update',
 ])->assertStatus(403);

 $this->apiCall('DELETE', route('api.requests.destroy', [$request]))
 ->assertStatus(403);
 }

 public function testManagedRequestIsNotAddedToRequestListing()
 {
 $process = Process::factory()->create([
 'manager_id' => [$this->user->id],
 ]);
 $request = ProcessRequest::factory()->create([
 'process_id' => $process->id,
 ]);

 $this->apiCall('GET', route('api.requests.show', [$request]))
 ->assertStatus(200);

 $this->apiCall('GET', route('api.requests.index'))
 ->assertStatus(200)
 ->assertJsonMissing(['id' => $request->id]);
 }

 public function testScalarProcessManagerValueIsNormalizedForAuthorization()
 {
 $process = Process::factory()->create([
 'manager_id' => $this->user->id,
 ]);
 $request = ProcessRequest::factory()->create([
 'process_id' => $process->id,
 ]);

 $this->assertSame([$this->user->id], $process->fresh()->manager_id);

 $this->apiCall('GET', route('api.requests.show', [$request]))
 ->assertStatus(200);
 }

 public function testProcessManagerReassignmentUpdatesRequestAccess()
 {
 $newManager = User::factory()->create();
 $process = Process::factory()->create([
 'manager_id' => [$this->user->id],
 ]);
 $request = ProcessRequest::factory()->create([
 'process_id' => $process->id,
 ]);

 $this->apiCall('GET', route('api.requests.show', [$request]))
 ->assertStatus(200);

 $process->manager_id = [$newManager->id];
 $process->save();

 $this->apiCall('GET', route('api.requests.show', [$request]))
 ->assertStatus(403);

 $this->user = $newManager;

 $this->apiCall('GET', route('api.requests.show', [$request]))
 ->assertStatus(200);
 }

 public function testProcessManagerCanViewManagedRequestsInEveryStatus()
 {
 $process = Process::factory()->create([
 'manager_id' => [$this->user->id],
 ]);

 foreach (['ACTIVE', 'COMPLETED', 'CANCELED', 'ERROR'] as $status) {
 $request = ProcessRequest::factory()->create([
 'process_id' => $process->id,
 'status' => $status,
 ]);

 $this->apiCall('GET', route('api.requests.show', [$request]))
 ->assertStatus(200);
 }
 }

 public function testEndEventDestinationReturnsNullWhenManagedRequestHasNoEndEvent()
 {
 $process = Process::factory()->create([
 'manager_id' => [$this->user->id],
 ]);
 $request = ProcessRequest::factory()->create([
 'process_id' => $process->id,
 'status' => 'COMPLETED',
 ]);

 $this->apiCall('GET', route('api.requests.end_event_destination', [$request]))
 ->assertStatus(200)
 ->assertJsonPath('data', null);
 }

 public function testEndEventDestinationReturnsConfiguredExternalUrlForProcessManager()
 {
 $bpmn = file_get_contents(__DIR__ . '/../../Fixtures/action_by_email_process_no_require_login.bpmn');
 $bpmn = str_replace(
 '{"type":"summaryScreen","value":null}',
 '{"type":"externalURL","value":"https://example.com/summary"}',
 $bpmn,
 );
 $process = Process::factory()->create([
 'bpmn' => $bpmn,
 'manager_id' => [$this->user->id],
 ]);
 $request = ProcessRequest::factory()->create([
 'process_id' => $process->id,
 'status' => 'COMPLETED',
 ]);
 ProcessRequestToken::factory()->create([
 'element_id' => 'node_18',
 'element_type' => 'end_event',
 'process_id' => $process->id,
 'process_request_id' => $request->id,
 'status' => 'CLOSED',
 ]);

 $this->apiCall('GET', route('api.requests.end_event_destination', [$request]))
 ->assertStatus(200)
 ->assertJsonPath('data.endEventDestination.type', 'externalURL')
 ->assertJsonPath('data.endEventDestination.value', 'https://example.com/summary');
 }
}

25 changes: 25 additions & 0 deletions
tests/Feature/CasesControllerTest.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -62,6 +62,31 @@ public function testShowCaseWithUserWithoutParticipation()
 $response->assertStatus(403);
 }

 public function testProcessManagerCanOpenManagedCaseButUnrelatedUserCannot()
 {
 $processManager = User::factory()->create();
 $firstManager = User::factory()->create();
 $process = Process::factory()->create([
 'manager_id' => [$firstManager->id, $processManager->id],
 ]);
 $request = ProcessRequest::factory()->create([
 'parent_request_id' => null,
 'process_id' => $process->id,
 'status' => 'COMPLETED',
 ]);
 $route = route('cases.show', ['case_number' => $request->case_number]);

 $response = $this->actingAs($processManager)->get($route);

 $response->assertStatus(200);
 $response->assertViewIs('cases.edit');
 $response->assertViewHas('isProcessManager', true);

 $this->actingAs(User::factory()->create())
 ->get($route)
 ->assertStatus(403);
 }

 public function testCasesAllPageReturns403WithoutViewAllCasesPermission()
 {
 Permission::firstOrCreate(
Expand Down

50 changes: 50 additions & 0 deletions
tests/Feature/RequestTest.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,8 @@
namespace Tests\Feature;

use Illuminate\Http\Testing\File;
use Illuminate\Support\Facades\Gate;
use ProcessMaker\Models\Permission;
use ProcessMaker\Models\Process;
use ProcessMaker\Models\ProcessCategory;
use ProcessMaker\Models\ProcessRequest;
Expand DownExpand Up@@ -123,6 +125,54 @@ public function testShowRouteWithAssignedUser()
 $response->assertStatus(200);
 }

 public function testProcessManagerCanViewManagedRequestSummary()
 {
 $this->user = User::factory()->create();
 $firstManager = User::factory()->create();
 $process = Process::factory()->create([
 'manager_id' => [$firstManager->id, $this->user->id],
 ]);
 $request = ProcessRequest::factory()->create([
 'process_id' => $process->id,
 'status' => 'COMPLETED',
 ]);

 $response = $this->webCall('GET', route('requests.show', [$request]));

 $response->assertStatus(200);
 $response->assertViewIs('requests.show');
 $response->assertViewHas('isProcessManager', true);
 }

 public function testProcessManagerCannotViewUnmanagedRequestSummary()
 {
 $this->user = User::factory()->create();
 Process::factory()->create([
 'manager_id' => [$this->user->id],
 ]);
 $unmanagedRequest = ProcessRequest::factory()->create();

 $this->webCall('GET', route('requests.show', [$unmanagedRequest]))
 ->assertStatus(403);
 }

 public function testProcessManagerCannotViewAllRequestsWithoutPermission()
 {
 Permission::firstOrCreate(
 ['name' => 'view-all_requests'],
 ['title' => 'View All Requests'],
 );
 Gate::define('view-all_requests', fn ($user) => $user->hasPermission('view-all_requests'));

 $this->user = User::factory()->create();
 Process::factory()->create([
 'manager_id' => [$this->user->id],
 ]);

 $this->webCall('GET', route('requests_by_type', ['type' => 'all']))
 ->assertStatus(403);
 }

 public function testShowRouteWithAdministrator()
 {
 $this->user = User::factory()->create([
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
FOUR-32764 Process Manager gets an unauthorized error when loading the summary screen without the View All request permission#9007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Open

devmiguelangel
wants to merge
3
commits into

base:develop
Choose a base branch

from


+280

−1

 Open


FOUR-32764 Process Manager gets an unauthorized error when loading the summary screen without the View All request permission
#9007
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
cd3fcfe

feat: refactor process manager check and enhance view policy


devmiguelangel Aug 24, 2026
8ab16f3

test: add tests for process manager request visibility and permissions


devmiguelangel Aug 24, 2026
bc5249b

test: enhance process manager permissions and request visibility tests


devmiguelangel Aug 24, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
ProcessMaker/Http/Controllers/RequestController.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -200,7 +200,7 @@ public function show(ProcessRequest $request, Media $mediaItems)
 $addons = $this->getPluginAddons('edit', compact(['request']));
 $dataActionsAddons = $this->getPluginAddons('edit.dataActions', []);

 $isProcessManager = $request->process?->manager_id === Auth::user()->id;
 $isProcessManager = in_array(Auth::user()->id, $request->process?->manager_id ?? []);

 $eligibleRollbackTask = null;
 $errorTask = RollbackProcessRequest::getErrorTask($request);
Expand Down

4 changes: 4 additions & 0 deletions
ProcessMaker/Policies/ProcessRequestPolicy.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -33,6 +33,10 @@ public function before(User $user)
 */
 public function view(User $user, ProcessRequest $processRequest)
 {
 if (in_array($user->id, $processRequest->process?->manager_id ?? [])) {
 return true;
 }

 // Policy defined in ForUserScope
 return ProcessRequest::forUser($user)
 ->where('process_requests.id', $processRequest->id)
Expand Down

200 changes: 200 additions & 0 deletions
tests/Feature/Api/ProcessRequestPolicyTest.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@
namespace Tests\Feature\Api;

use Database\Seeders\PermissionSeeder;
use ProcessMaker\Models\Process;
use ProcessMaker\Models\ProcessRequest;
use ProcessMaker\Models\ProcessRequestToken;
use ProcessMaker\Models\User;
Expand DownExpand Up@@ -72,4 +73,203 @@ public function testUserHasPermission()
 $response = $this->apiCall('GET', $route);
 $response->assertStatus(200);
 }

 public function testProcessManagerCanViewManagedRequestAndEndEventDestination()
 {
 $firstManager = User::factory()->create();
 $process = Process::factory()->create([
 'bpmn' => file_get_contents(__DIR__ . '/../../Fixtures/action_by_email_process_no_require_login.bpmn'),
 'manager_id' => [$firstManager->id, $this->user->id],
 ]);
 $request = ProcessRequest::factory()->create([
 'process_id' => $process->id,
 'status' => 'COMPLETED',
 ]);
 ProcessRequestToken::factory()->create([
 'element_id' => 'node_18',
 'element_type' => 'end_event',
 'process_id' => $process->id,
 'process_request_id' => $request->id,
 'status' => 'CLOSED',
 ]);

 $this->apiCall('GET', route('api.requests.show', [$request]))
 ->assertStatus(200);

 $this->apiCall('GET', route('api.requests.end_event_destination', [$request]))
 ->assertStatus(200)
 ->assertJsonPath('data.endEventDestination.type', 'summaryScreen')
 ->assertJsonPath('data.endEventDestination.value', null);
 }

 public function testProcessManagerCannotViewRequestFromUnmanagedProcess()
 {
 $managedProcess = Process::factory()->create([
 'manager_id' => [$this->user->id],
 ]);
 $unmanagedRequest = ProcessRequest::factory()->create();

 $this->assertNotEquals($managedProcess->id, $unmanagedRequest->process_id);

 $this->apiCall('GET', route('api.requests.show', [$unmanagedRequest]))
 ->assertStatus(403);

 $this->apiCall('GET', route('api.requests.end_event_destination', [$unmanagedRequest]))
 ->assertStatus(403);
 }

 public function testProcessManagerAccessIsRevokedWhenRemovedFromProcess()
 {
 $process = Process::factory()->create([
 'manager_id' => [$this->user->id],
 ]);
 $request = ProcessRequest::factory()->create([
 'process_id' => $process->id,
 ]);

 $this->apiCall('GET', route('api.requests.show', [$request]))
 ->assertStatus(200);

 $process->manager_id = [];
 $process->save();

 $this->apiCall('GET', route('api.requests.show', [$request]))
 ->assertStatus(403);
 }

 public function testProcessManagerCannotUpdateOrDeleteManagedRequest()
 {
 $process = Process::factory()->create([
 'manager_id' => [$this->user->id],
 ]);
 $request = ProcessRequest::factory()->create([
 'process_id' => $process->id,
 ]);

 $this->apiCall('PUT', route('api.requests.update', [$request]), [
 'name' => 'Unauthorized update',
 ])->assertStatus(403);

 $this->apiCall('DELETE', route('api.requests.destroy', [$request]))
 ->assertStatus(403);
 }

 public function testManagedRequestIsNotAddedToRequestListing()
 {
 $process = Process::factory()->create([
 'manager_id' => [$this->user->id],
 ]);
 $request = ProcessRequest::factory()->create([
 'process_id' => $process->id,
 ]);

 $this->apiCall('GET', route('api.requests.show', [$request]))
 ->assertStatus(200);

 $this->apiCall('GET', route('api.requests.index'))
 ->assertStatus(200)
 ->assertJsonMissing(['id' => $request->id]);
 }

 public function testScalarProcessManagerValueIsNormalizedForAuthorization()
 {
 $process = Process::factory()->create([
 'manager_id' => $this->user->id,
 ]);
 $request = ProcessRequest::factory()->create([
 'process_id' => $process->id,
 ]);

 $this->assertSame([$this->user->id], $process->fresh()->manager_id);

 $this->apiCall('GET', route('api.requests.show', [$request]))
 ->assertStatus(200);
 }

 public function testProcessManagerReassignmentUpdatesRequestAccess()
 {
 $newManager = User::factory()->create();
 $process = Process::factory()->create([
 'manager_id' => [$this->user->id],
 ]);
 $request = ProcessRequest::factory()->create([
 'process_id' => $process->id,
 ]);

 $this->apiCall('GET', route('api.requests.show', [$request]))
 ->assertStatus(200);

 $process->manager_id = [$newManager->id];
 $process->save();

 $this->apiCall('GET', route('api.requests.show', [$request]))
 ->assertStatus(403);

 $this->user = $newManager;

 $this->apiCall('GET', route('api.requests.show', [$request]))
 ->assertStatus(200);
 }

 public function testProcessManagerCanViewManagedRequestsInEveryStatus()
 {
 $process = Process::factory()->create([
 'manager_id' => [$this->user->id],
 ]);

 foreach (['ACTIVE', 'COMPLETED', 'CANCELED', 'ERROR'] as $status) {
 $request = ProcessRequest::factory()->create([
 'process_id' => $process->id,
 'status' => $status,
 ]);

 $this->apiCall('GET', route('api.requests.show', [$request]))
 ->assertStatus(200);
 }
 }

 public function testEndEventDestinationReturnsNullWhenManagedRequestHasNoEndEvent()
 {
 $process = Process::factory()->create([
 'manager_id' => [$this->user->id],
 ]);
 $request = ProcessRequest::factory()->create([
 'process_id' => $process->id,
 'status' => 'COMPLETED',
 ]);

 $this->apiCall('GET', route('api.requests.end_event_destination', [$request]))
 ->assertStatus(200)
 ->assertJsonPath('data', null);
 }

 public function testEndEventDestinationReturnsConfiguredExternalUrlForProcessManager()
 {
 $bpmn = file_get_contents(__DIR__ . '/../../Fixtures/action_by_email_process_no_require_login.bpmn');
 $bpmn = str_replace(
 '{"type":"summaryScreen","value":null}',
 '{"type":"externalURL","value":"https://example.com/summary"}',
 $bpmn,
 );
 $process = Process::factory()->create([
 'bpmn' => $bpmn,
 'manager_id' => [$this->user->id],
 ]);
 $request = ProcessRequest::factory()->create([
 'process_id' => $process->id,
 'status' => 'COMPLETED',
 ]);
 ProcessRequestToken::factory()->create([
 'element_id' => 'node_18',
 'element_type' => 'end_event',
 'process_id' => $process->id,
 'process_request_id' => $request->id,
 'status' => 'CLOSED',
 ]);

 $this->apiCall('GET', route('api.requests.end_event_destination', [$request]))
 ->assertStatus(200)
 ->assertJsonPath('data.endEventDestination.type', 'externalURL')
 ->assertJsonPath('data.endEventDestination.value', 'https://example.com/summary');
 }
}

25 changes: 25 additions & 0 deletions
tests/Feature/CasesControllerTest.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -62,6 +62,31 @@ public function testShowCaseWithUserWithoutParticipation()
 $response->assertStatus(403);
 }

 public function testProcessManagerCanOpenManagedCaseButUnrelatedUserCannot()
 {
 $processManager = User::factory()->create();
 $firstManager = User::factory()->create();
 $process = Process::factory()->create([
 'manager_id' => [$firstManager->id, $processManager->id],
 ]);
 $request = ProcessRequest::factory()->create([
 'parent_request_id' => null,
 'process_id' => $process->id,
 'status' => 'COMPLETED',
 ]);
 $route = route('cases.show', ['case_number' => $request->case_number]);

 $response = $this->actingAs($processManager)->get($route);

 $response->assertStatus(200);
 $response->assertViewIs('cases.edit');
 $response->assertViewHas('isProcessManager', true);

 $this->actingAs(User::factory()->create())
 ->get($route)
 ->assertStatus(403);
 }

 public function testCasesAllPageReturns403WithoutViewAllCasesPermission()
 {
 Permission::firstOrCreate(
Expand Down

50 changes: 50 additions & 0 deletions
tests/Feature/RequestTest.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,8 @@
namespace Tests\Feature;

use Illuminate\Http\Testing\File;
use Illuminate\Support\Facades\Gate;
use ProcessMaker\Models\Permission;
use ProcessMaker\Models\Process;
use ProcessMaker\Models\ProcessCategory;
use ProcessMaker\Models\ProcessRequest;
Expand DownExpand Up@@ -123,6 +125,54 @@ public function testShowRouteWithAssignedUser()
 $response->assertStatus(200);
 }

 public function testProcessManagerCanViewManagedRequestSummary()
 {
 $this->user = User::factory()->create();
 $firstManager = User::factory()->create();
 $process = Process::factory()->create([
 'manager_id' => [$firstManager->id, $this->user->id],
 ]);
 $request = ProcessRequest::factory()->create([
 'process_id' => $process->id,
 'status' => 'COMPLETED',
 ]);

 $response = $this->webCall('GET', route('requests.show', [$request]));

 $response->assertStatus(200);
 $response->assertViewIs('requests.show');
 $response->assertViewHas('isProcessManager', true);
 }

 public function testProcessManagerCannotViewUnmanagedRequestSummary()
 {
 $this->user = User::factory()->create();
 Process::factory()->create([
 'manager_id' => [$this->user->id],
 ]);
 $unmanagedRequest = ProcessRequest::factory()->create();

 $this->webCall('GET', route('requests.show', [$unmanagedRequest]))
 ->assertStatus(403);
 }

 public function testProcessManagerCannotViewAllRequestsWithoutPermission()
 {
 Permission::firstOrCreate(
 ['name' => 'view-all_requests'],
 ['title' => 'View All Requests'],
 );
 Gate::define('view-all_requests', fn ($user) => $user->hasPermission('view-all_requests'));

 $this->user = User::factory()->create();
 Process::factory()->create([
 'manager_id' => [$this->user->id],
 ]);

 $this->webCall('GET', route('requests_by_type', ['type' => 'all']))
 ->assertStatus(403);
 }

 public function testShowRouteWithAdministrator()
 {
 $this->user = User::factory()->create([
Expand Down
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
FOUR-32764 Process Manager gets an unauthorized error when loading the summary screen without the View All request permission#9007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Open

devmiguelangel
wants to merge
3
commits into

base:develop
Choose a base branch

from


+280

−1

 Open


FOUR-32764 Process Manager gets an unauthorized error when loading the summary screen without the View All request permission
#9007
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


3 commits


Select commit
Hold shift + click to select a range
cd3fcfe

feat: refactor process manager check and enhance view policy


devmiguelangel Aug 24, 2026
8ab16f3

test: add tests for process manager request visibility and permissions


devmiguelangel Aug 24, 2026
bc5249b

test: enhance process manager permissions and request visibility tests


devmiguelangel Aug 24, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
ProcessMaker/Http/Controllers/RequestController.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -200,7 +200,7 @@ public function show(ProcessRequest $request, Media $mediaItems)
 $addons = $this->getPluginAddons('edit', compact(['request']));
 $dataActionsAddons = $this->getPluginAddons('edit.dataActions', []);

 $isProcessManager = $request->process?->manager_id === Auth::user()->id;
 $isProcessManager = in_array(Auth::user()->id, $request->process?->manager_id ?? []);

 $eligibleRollbackTask = null;
 $errorTask = RollbackProcessRequest::getErrorTask($request);
Expand Down

4 changes: 4 additions & 0 deletions
ProcessMaker/Policies/ProcessRequestPolicy.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -33,6 +33,10 @@ public function before(User $user)
 */
 public function view(User $user, ProcessRequest $processRequest)
 {
 if (in_array($user->id, $processRequest->process?->manager_id ?? [])) {
 return true;
 }

 // Policy defined in ForUserScope
 return ProcessRequest::forUser($user)
 ->where('process_requests.id', $processRequest->id)
Expand Down

200 changes: 200 additions & 0 deletions
tests/Feature/Api/ProcessRequestPolicyTest.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,7 @@
namespace Tests\Feature\Api;

use Database\Seeders\PermissionSeeder;
use ProcessMaker\Models\Process;
use ProcessMaker\Models\ProcessRequest;
use ProcessMaker\Models\ProcessRequestToken;
use ProcessMaker\Models\User;
Expand DownExpand Up@@ -72,4 +73,203 @@ public function testUserHasPermission()
 $response = $this->apiCall('GET', $route);
 $response->assertStatus(200);
 }

 public function testProcessManagerCanViewManagedRequestAndEndEventDestination()
 {
 $firstManager = User::factory()->create();
 $process = Process::factory()->create([
 'bpmn' => file_get_contents(__DIR__ . '/../../Fixtures/action_by_email_process_no_require_login.bpmn'),
 'manager_id' => [$firstManager->id, $this->user->id],
 ]);
 $request = ProcessRequest::factory()->create([
 'process_id' => $process->id,
 'status' => 'COMPLETED',
 ]);
 ProcessRequestToken::factory()->create([
 'element_id' => 'node_18',
 'element_type' => 'end_event',
 'process_id' => $process->id,
 'process_request_id' => $request->id,
 'status' => 'CLOSED',
 ]);

 $this->apiCall('GET', route('api.requests.show', [$request]))
 ->assertStatus(200);

 $this->apiCall('GET', route('api.requests.end_event_destination', [$request]))
 ->assertStatus(200)
 ->assertJsonPath('data.endEventDestination.type', 'summaryScreen')
 ->assertJsonPath('data.endEventDestination.value', null);
 }

 public function testProcessManagerCannotViewRequestFromUnmanagedProcess()
 {
 $managedProcess = Process::factory()->create([
 'manager_id' => [$this->user->id],
 ]);
 $unmanagedRequest = ProcessRequest::factory()->create();

 $this->assertNotEquals($managedProcess->id, $unmanagedRequest->process_id);

 $this->apiCall('GET', route('api.requests.show', [$unmanagedRequest]))
 ->assertStatus(403);

 $this->apiCall('GET', route('api.requests.end_event_destination', [$unmanagedRequest]))
 ->assertStatus(403);
 }

 public function testProcessManagerAccessIsRevokedWhenRemovedFromProcess()
 {
 $process = Process::factory()->create([
 'manager_id' => [$this->user->id],
 ]);
 $request = ProcessRequest::factory()->create([
 'process_id' => $process->id,
 ]);

 $this->apiCall('GET', route('api.requests.show', [$request]))
 ->assertStatus(200);

 $process->manager_id = [];
 $process->save();

 $this->apiCall('GET', route('api.requests.show', [$request]))
 ->assertStatus(403);
 }

 public function testProcessManagerCannotUpdateOrDeleteManagedRequest()
 {
 $process = Process::factory()->create([
 'manager_id' => [$this->user->id],
 ]);
 $request = ProcessRequest::factory()->create([
 'process_id' => $process->id,
 ]);

 $this->apiCall('PUT', route('api.requests.update', [$request]), [
 'name' => 'Unauthorized update',
 ])->assertStatus(403);

 $this->apiCall('DELETE', route('api.requests.destroy', [$request]))
 ->assertStatus(403);
 }

 public function testManagedRequestIsNotAddedToRequestListing()
 {
 $process = Process::factory()->create([
 'manager_id' => [$this->user->id],
 ]);
 $request = ProcessRequest::factory()->create([
 'process_id' => $process->id,
 ]);

 $this->apiCall('GET', route('api.requests.show', [$request]))
 ->assertStatus(200);

 $this->apiCall('GET', route('api.requests.index'))
 ->assertStatus(200)
 ->assertJsonMissing(['id' => $request->id]);
 }

 public function testScalarProcessManagerValueIsNormalizedForAuthorization()
 {
 $process = Process::factory()->create([
 'manager_id' => $this->user->id,
 ]);
 $request = ProcessRequest::factory()->create([
 'process_id' => $process->id,
 ]);

 $this->assertSame([$this->user->id], $process->fresh()->manager_id);

 $this->apiCall('GET', route('api.requests.show', [$request]))
 ->assertStatus(200);
 }

 public function testProcessManagerReassignmentUpdatesRequestAccess()
 {
 $newManager = User::factory()->create();
 $process = Process::factory()->create([
 'manager_id' => [$this->user->id],
 ]);
 $request = ProcessRequest::factory()->create([
 'process_id' => $process->id,
 ]);

 $this->apiCall('GET', route('api.requests.show', [$request]))
 ->assertStatus(200);

 $process->manager_id = [$newManager->id];
 $process->save();

 $this->apiCall('GET', route('api.requests.show', [$request]))
 ->assertStatus(403);

 $this->user = $newManager;

 $this->apiCall('GET', route('api.requests.show', [$request]))
 ->assertStatus(200);
 }

 public function testProcessManagerCanViewManagedRequestsInEveryStatus()
 {
 $process = Process::factory()->create([
 'manager_id' => [$this->user->id],
 ]);

 foreach (['ACTIVE', 'COMPLETED', 'CANCELED', 'ERROR'] as $status) {
 $request = ProcessRequest::factory()->create([
 'process_id' => $process->id,
 'status' => $status,
 ]);

 $this->apiCall('GET', route('api.requests.show', [$request]))
 ->assertStatus(200);
 }
 }

 public function testEndEventDestinationReturnsNullWhenManagedRequestHasNoEndEvent()
 {
 $process = Process::factory()->create([
 'manager_id' => [$this->user->id],
 ]);
 $request = ProcessRequest::factory()->create([
 'process_id' => $process->id,
 'status' => 'COMPLETED',
 ]);

 $this->apiCall('GET', route('api.requests.end_event_destination', [$request]))
 ->assertStatus(200)
 ->assertJsonPath('data', null);
 }

 public function testEndEventDestinationReturnsConfiguredExternalUrlForProcessManager()
 {
 $bpmn = file_get_contents(__DIR__ . '/../../Fixtures/action_by_email_process_no_require_login.bpmn');
 $bpmn = str_replace(
 '{"type":"summaryScreen","value":null}',
 '{"type":"externalURL","value":"https://example.com/summary"}',
 $bpmn,
 );
 $process = Process::factory()->create([
 'bpmn' => $bpmn,
 'manager_id' => [$this->user->id],
 ]);
 $request = ProcessRequest::factory()->create([
 'process_id' => $process->id,
 'status' => 'COMPLETED',
 ]);
 ProcessRequestToken::factory()->create([
 'element_id' => 'node_18',
 'element_type' => 'end_event',
 'process_id' => $process->id,
 'process_request_id' => $request->id,
 'status' => 'CLOSED',
 ]);

 $this->apiCall('GET', route('api.requests.end_event_destination', [$request]))
 ->assertStatus(200)
 ->assertJsonPath('data.endEventDestination.type', 'externalURL')
 ->assertJsonPath('data.endEventDestination.value', 'https://example.com/summary');
 }
}

25 changes: 25 additions & 0 deletions
tests/Feature/CasesControllerTest.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -62,6 +62,31 @@ public function testShowCaseWithUserWithoutParticipation()
 $response->assertStatus(403);
 }

 public function testProcessManagerCanOpenManagedCaseButUnrelatedUserCannot()
 {
 $processManager = User::factory()->create();
 $firstManager = User::factory()->create();
 $process = Process::factory()->create([
 'manager_id' => [$firstManager->id, $processManager->id],
 ]);
 $request = ProcessRequest::factory()->create([
 'parent_request_id' => null,
 'process_id' => $process->id,
 'status' => 'COMPLETED',
 ]);
 $route = route('cases.show', ['case_number' => $request->case_number]);

 $response = $this->actingAs($processManager)->get($route);

 $response->assertStatus(200);
 $response->assertViewIs('cases.edit');
 $response->assertViewHas('isProcessManager', true);

 $this->actingAs(User::factory()->create())
 ->get($route)
 ->assertStatus(403);
 }

 public function testCasesAllPageReturns403WithoutViewAllCasesPermission()
 {
 Permission::firstOrCreate(
Expand Down

50 changes: 50 additions & 0 deletions
tests/Feature/RequestTest.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -3,6 +3,8 @@
namespace Tests\Feature;

use Illuminate\Http\Testing\File;
use Illuminate\Support\Facades\Gate;
use ProcessMaker\Models\Permission;
use ProcessMaker\Models\Process;
use ProcessMaker\Models\ProcessCategory;
use ProcessMaker\Models\ProcessRequest;
Expand DownExpand Up@@ -123,6 +125,54 @@ public function testShowRouteWithAssignedUser()
 $response->assertStatus(200);
 }

 public function testProcessManagerCanViewManagedRequestSummary()
 {
 $this->user = User::factory()->create();
 $firstManager = User::factory()->create();
 $process = Process::factory()->create([
 'manager_id' => [$firstManager->id, $this->user->id],
 ]);
 $request = ProcessRequest::factory()->create([
 'process_id' => $process->id,
 'status' => 'COMPLETED',
 ]);

 $response = $this->webCall('GET', route('requests.show', [$request]));

 $response->assertStatus(200);
 $response->assertViewIs('requests.show');
 $response->assertViewHas('isProcessManager', true);
 }

 public function testProcessManagerCannotViewUnmanagedRequestSummary()
 {
 $this->user = User::factory()->create();
 Process::factory()->create([
 'manager_id' => [$this->user->id],
 ]);
 $unmanagedRequest = ProcessRequest::factory()->create();

 $this->webCall('GET', route('requests.show', [$unmanagedRequest]))
 ->assertStatus(403);
 }

 public function testProcessManagerCannotViewAllRequestsWithoutPermission()
 {
 Permission::firstOrCreate(
 ['name' => 'view-all_requests'],
 ['title' => 'View All Requests'],
 );
 Gate::define('view-all_requests', fn ($user) => $user->hasPermission('view-all_requests'));

 $this->user = User::factory()->create();
 Process::factory()->create([
 'manager_id' => [$this->user->id],
 ]);

 $this->webCall('GET', route('requests_by_type', ['type' => 'all']))
 ->assertStatus(403);
 }

 public function testShowRouteWithAdministrator()
 {
 $this->user = User::factory()->create([
Expand Down
Loading