Skip to content

swish and mish activation functions - #1235

Merged
wyli merged 6 commits into
Project-MONAI:masterfrom
rijobro:activations
Nov 16, 2020
Merged

swish and mish activation functions#1235
wyli merged 6 commits into
Project-MONAI:masterfrom
rijobro:activations

Conversation

@rijobro

@rijobrorijobro commented Nov 16, 2020

Copy link
Copy Markdown
Contributor

Description

Swish and Mish activation functions.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh --codeformat --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
@rijobro
rijobro requested review from Nic-Ma, ericspod and wyli and removed request for ericspodNovember 16, 2020 12:55
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>

@wyliwyli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! could you please also update monai/networks/blocks/__init__.py with the new classes? and perhaps docs/source/networks.rst

Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
Signed-off-by: Richard Brown <33289025+rijobro@users.noreply.github.com>
@rijobro

Copy link
Copy Markdown
ContributorAuthor

@wyli done, thanks!

@wyli

wyli commented Nov 16, 2020

Copy link
Copy Markdown
Contributor

/integration-test
(testing the integration command)

@wyli
wyli merged commit 8bbdc41 into Project-MONAI:masterNov 16, 2020
@bhashemian

Copy link
Copy Markdown
Member

It seems that it the integration command works! Yay! But please let me know if you find any problem with that.

@rijobro
rijobro deleted the activations branch November 17, 2020 11:50
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@rijobro@wyli@bhashemian