Uh oh!
There was an error while loading. Please reload this page.
fix: close remaining sharding correctness holes - #59
Conversation
Refuse multi-table UPDATE/DELETE when any table is sharded or backends differ. Evaluate HAVING against aggregate output so COUNT(*) filters work locally and distributed. Push equi-joins of same-layout sharded tables to each shard. sqlengine and mysql_server use 2PC when backends are configured; SELECTs inside an open distributed txn hit pinned sessions. Optional --txn-log on sqlengine.
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Uh oh!
There was an error while loading. Please reload this page.
Summary
Stacked on #58.
COUNT(*)/ other aggs to aggregate-output columns.JOINSQL.DistributedTransactionManager; in-txn SELECTs use pinned sessions.sqlengine --txn-log PATHoptional.Validation
./run_tests --gtest_brief=1: 1320 passed, 38 skipped./run_tests --gtest_filter='PlanExecutorTest.Having*:DistributedPlannerTest.Having*:DistributedPlannerTest.Colocated*:DistributedDmlTest.MultiTable*'sqlengine.cppandmysql_server.cppcompile