Skip to content

fix: canonicalize keywords - #66

Open
Snehil-Shah wants to merge 1 commit into
ProxySQL:mainfrom
Snehil-Shah:keyword-canonicalization
Open

fix: canonicalize keywords#66
Snehil-Shah wants to merge 1 commit into
ProxySQL:mainfrom
Snehil-Shah:keyword-canonicalization

Conversation

@Snehil-Shah

Copy link
Copy Markdown

Currently, many keyword values are stored as direct input values in the AST which later also produces a different digest for different casings.

This PR now stores the canonical spelling at parse time instead of deriving from input, resulting in stable ASTs and stable digests.

It also adds dialect-aware canonicalization to function names and how their semantics change when they are delimited, across both MySQL and PgSQL.

Signed-off-by: Snehil Shah <snehilshah.989@gmail.com>
@coderabbitai

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: e1a1b9c3-b69d-47f6-b1c2-2c726f4d0627


Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@renecannao I added a dedicated file as an AST-level regression suite for this. Let me know if you want it spread across existing files instead.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@Snehil-Shah