') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Evaluate hashicorp/raft upstream migration · Issue #56 · ProxySQL/orchestrator · GitHub
Skip to content

Evaluate hashicorp/raft upstream migration #56

Closed
#59
Closed
Evaluate hashicorp/raft upstream migration#56
#59
Labels
enhancementNew feature or request

Description

@renecannao
renecannao
opened on Mar 24, 2026

Raft Fork Assessment

Orchestrator uses openark/raft, a 2017-era fork of hashicorp/raft with ~9 years of divergence.

Evaluation Complete

Full evaluation document: docs/raft-evaluation.md

Key Findings

Divergent APIs identified (10 items):

  • PeerStore / StaticPeers / AddUniquePeer — replaced by Configuration-based membership
  • EnableSingleNode / DisableBootstrapAfterElect — replaced by BootstrapCluster()
  • NewRaft() 7-arg constructor — now 6 args (no peerStore)
  • AddPeer() / RemovePeer() — replaced by AddVoter() / RemoveServer()
  • Yield() / StepDown() — replaced by LeadershipTransfer()
  • Leader() return type — now ServerAddress (typed string) instead of plain string
  • SnapshotStore.Create() signature — completely changed, most impactful divergence

Compatible APIs (no changes needed):

  • RelationalStore (LogStore + StableStore) — fully compatible
  • FSM interface (Apply, Snapshot, Restore) — compatible
  • Raft.Apply(), Raft.State(), Raft.Snapshot(), Raft.LeaderCh() — compatible

Risk Assessment

Staying on the fork carries high security risk: 9 years of upstream CVE patches, bug fixes, and correctness improvements are missing. The fork also lacks pre-vote protocol, improved snapshot transfer, and batch FSM apply.

Effort Estimate

~32 hours (3-5 working days) for migration. The custom RelationalStore requires zero changes. The FileSnapshotStore has the most impactful signature change but could potentially be replaced with upstream's built-in implementation.

Recommendation

Migrate to upstream hashicorp/raft v1.7.x. The security risk of staying on the fork outweighs the bounded migration effort. Creating our own fork (Option C) would only defer the problem while adding ongoing maintenance burden.

Investigation Checklist

  • Catalog all divergent API calls in go/raft/
  • Estimate effort to migrate to hashicorp/raft v1.7+
  • Assess risk of staying on the fork
  • Prototype migration in a branch (future work, tracked separately)

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions