Uh oh!
There was an error while loading. Please reload this page.
Bunch of PureMVC improvements and bug fixings - #1
Conversation
…nsumed after the first execution
… fail the if statement
This reverts commit 541b972.
tekool
commented
Oct 19, 2012
I'll make a quick code review with a colleague of mine in the day. Keep you informed, but a first glimpse at what you made seems pretty needed, thank you. |
expobrain
commented
Oct 19, 2012
Ok, done here https://github.com/expobrain/puremvc-python-standard-framework/commit/bb6ac2d22640796169c8c7a1574f1df7dacb3cb6, with a brand new unit test |
Bunch of PureMVC improvements and bug fixings
tekool
commented
Oct 19, 2012
My colleague who knows Python very well validated your work and tells me that your choices were all the smart ones. |
expobrain
commented
Oct 19, 2012
Thank you sir, but I did only my job :-) What about increasing the version number to 1.2.1? |
tekool
commented
Oct 20, 2012
Just make any changes you think useful, integrating changes with Github is really painless. Version number must be edited by you in the version.txt first. I'll report it in the Python port home page if Cliff is agree to. |
Fixed som bugs in the implementation of some interfaces and classes and added little improvements on the code and unit tests