Skip to content

Download zip separated folders - #41

Merged
eamanu merged 11 commits into
PyAr:masterfrom
Juerodriguez:fix-10-separatedfolders
Jul 13, 2021
Merged

Download zip separated folders#41
eamanu merged 11 commits into
PyAr:masterfrom
Juerodriguez:fix-10-separatedfolders

Conversation

@Juerodriguez

@JuerodriguezJuerodriguez commented Jul 1, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

Resumen

closeJuerodriguez#15
closeJuerodriguez#20
close#10
close#53

Here we manage to separate the files according to their respective expedient and download the writings from table movimiento.

Checklist

  • Variables, funciones y comentarios en Español
  • Corrector ortográfico ok
  • Cdigo Python cumple PEP8
  • Cobertura de tests con Playwright
  • Revisores asignados (pares & al menos 1 mentor)

Screenshots

test_download_chromium.mp4

@JuerodriguezJuerodriguez mentioned this pull request Jul 1, 2021
Closed
@Juerodriguez
Juerodriguez marked this pull request as draft July 10, 2021 12:54
@JuerodriguezJuerodriguez mentioned this pull request Jul 11, 2021
Closed
Juerodriguez
Juerodriguez commented Jul 11, 2021
View reviewed changes
Comment threadcontrollers/expedientes.py Outdated
@Juerodriguez
Juerodriguez marked this pull request as ready for review July 11, 2021 18:17
eamanu
eamanu requested changes Jul 11, 2021
View reviewed changes
Comment threadcontrollers/expedientes.py Outdated
Comment threadcontrollers/expedientes.py Outdated
Comment threadcontrollers/expedientes.py Outdated
Comment threadcontrollers/expedientes.py Outdated
Comment threadcontrollers/expedientes.py Outdated
Comment threadcontrollers/expedientes.py Outdated
Comment threadcontrollers/expedientes.py Outdated
Comment threadcontrollers/expedientes.py Outdated
Comment threadcontrollers/expedientes.py Outdated
Comment threadcontrollers/expedientes.py Outdated
@Juerodriguez
Juerodriguez requested a review from eamanuJuly 12, 2021 00:12
eamanu
eamanu requested changes Jul 12, 2021
View reviewed changes
Comment threadcontrollers/expedientes.py Outdated
Comment threadconftest.py
Comment threadcontrollers/expedientes.py
@Juerodriguez
Juerodriguez requested a review from eamanuJuly 13, 2021 00:05
@eamanu

eamanu commented Jul 13, 2021

Copy link
Copy Markdown
Collaborator

Great job @Juerodriguez. Thanks for your contribution :)

@eamanu
eamanu merged commit c8151eb into PyAr:masterJul 13, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eamanueamanueamanu approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

2 participants

@Juerodriguez@eamanu