Uh oh!
There was an error while loading. Please reload this page.
Conversation
There was a problem hiding this comment.
Pull request overview
Este PR migra la gestión de dependencias Python a uv (con pyproject.toml y lockfile), eliminando requirements.txt/test-requirements.txt para simplificar la instalación local y estandarizar CI/CD y Netlify.
Changes:
- Se introducen dependencias y grupos (
dev) enpyproject.tomly se elimina el uso derequirements*.txt. - Se actualizan workflows de GitHub Actions y la documentación para ejecutar comandos vía
uv sync/uv run. - Se ajusta el fixture de Selenium para soportar ejecución remota o local según
TEST_COMMAND_EXECUTOR.
Reviewed changes
Copilot reviewed 12 out of 14 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/conftest.py | Cambia el setup del webdriver para soportar Remote vs local según env vars. |
| test-requirements.txt | Elimina el archivo de dependencias de tests. |
| runtime.txt | Elimina el pin de runtime Python. |
| requirements.txt | Elimina el archivo principal de dependencias. |
| README.md | Actualiza comandos y guías para usar uv en dev/tests/scripts. |
| pyproject.toml | Define dependencias del proyecto y grupo dev; habilita tool.uv. |
| netlify.toml | Cambia build para instalar uv y construir con uv run lektor. |
| install.md | Actualiza guía de instalación para uv y Python 3.12+. |
| django-quilla.lektorproject | Remueve sección [packages] del proyecto Lektor. |
| .python-version | Fija versión de Python para entorno local. |
| .github/workflows/test-e2e.yml | Migra workflow E2E a uv (setup-uv, uv sync, uv run). |
| .github/workflows/deploy.yml | Migra build/deploy a uv y actualiza acciones. |
| .github/workflows/actualizar-eventos-meetup.yml | Migra workflow de actualización de eventos a uv. |
Suppressed comments (1)
README.md:115
uv run scripts/create_events.pyprobablemente no funciona por la misma razón que el otro script (sin shebang/ejecutable). En la guía y en el workflow se usauv run python ....
Para ejecutar localmente el script que genera los content.lr para cada uno de los eventos
uv run scripts/create_events.py
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+23
to
26
| browser = os.getenv("TEST_BROWSER", "chrome").lower() | ||
| # Si no existe la variable, dejamos None para saber que es local | ||
| command_executor = os.getenv("TEST_COMMAND_EXECUTOR") | ||
| options = posible_options[browser] |
Comment on lines
+17
to
+28
| [dependency-groups] | ||
| dev = [ | ||
| "cryptography>=50.0.0", | ||
| "online-w3c-validator>=0.3.21", | ||
| "pylint>=4.0.6", | ||
| "pytest>=9.1.1", | ||
| "pytest-base-url>=2.1.0", | ||
| "requests>=2.34.2", | ||
| "screenpy>=5.0.0", | ||
| "screenpy-selenium>=4.0.4", | ||
| "selenium>=4.46.0", | ||
| ] |
Comment on lines
+30
to
+31
| [tool.uv] | ||
| managed = true |
Comment on lines
+104
to
107
| Para ejecutar localmente el script que extrae la información de meetup | ||
| python scripts/events.py | ||
| uv run scripts/graphql_api.py | ||
Comment on lines
84
to
88
| para ejecutar los test ejecuta los siguientes comandos | ||
| docker compose up | ||
| python -m pytest | ||
| uv run pytest | ||
Comment on lines
+63
to
66
| Los paquetes de pruebas ya están incluidos en `uv sync`. | ||
| pip install -r test-requirements.txt | ||
| Puedes verificar que todo esté listo ejecutando | ||
| [build] | ||
| environment = { PYTHON_VERSION = "3.13" } No newline at end of file | ||
| environment = { PYTHON_VERSION = "3.13" } | ||
| command = "curl -LsSf https://astral.sh/uv/install.sh | sh && uv sync --locked && uv run lektor build --output-path public" |
| @@ -0,0 +1 @@ | |||
| 3.14 | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request
Para actualizar las dependencias y no complicarnos con el tema de las versiones en 2 archivos separados requirements propongo la instalación de UV y simplificar bastante el proceso de instalación y configuración
https://github.com/PyBAQ/website/actions/runs/31187466442/job/92895552548