Obstacle areas (issue 120) by Davidek523 · Pull Request #125 · PyCeas/Pyceas

Davidek523 · 2025-06-02T08:56:49Z

Pull Request Template

Type of Pull Request

Only check one box per pull request.

🛠️ Code - Changes to the codebase.
🔄 Revert - Reverts a previously merged commit or PR.
📄 Documentation - Updates to documentation files.
🎵 Audio - Changes to audio files.
🎨 Asset - Updates to design or visual assets.

Summary

This PR adds obstacles objects to the game. Now when the player comes in contact with such a object, the player will receive damage and on the screen it will be shown how much!

Related Issues

This PR closes issue(s) #120

✅ Checklist:

Tested the changes locally.
Verified that no breaking changes are introduced.
Updated documentation (if applicable).

🏷️ Labels:

type: ..., area: ..., game-..., ...

Added: - new state for obstacles - state methods within this class

Added: - obstacles to the map - in setup drew the obstacles onto the map - in obstacle state added logic for collision

Fixed: - in game running: Typo from the imported class - obstacle state: logical issues with collision

Changed: - Removed the object state from states and refactored it to not use state anymore - Changed file name and the file place

Called: - object handler in game running

Fixed: - issue where message of dealing damage was not showing up Changed: - commentend display flip method in object handler to save frames

Changed: - the black block for the message transparent

Changed: - the color of the message

…-areas-(issue-120)

Small fix groups

Fixed all the typehints

ultimateownsz

Hi, since there is no objective for the player yet, I think what could work with the collisions is that is the player health < 0, that it will reset the player's position to the starting position.

Also, I think it could be helpful if you make it that you see the player getting a white border or flashing sprite that it shows to the player that you hit an object, because now it is static, and the drawing order could be different, so the player's (rectangle for now) behind the obstacle, instead of over the obstacle.

Fixed: - Health going infinitly low

Added: - a flashing effect when the player gets hurt by the obstacles

Changed: - the location of the dt from the handler to the game loop

Fixed: - Flash not working properly Removed: - unnecessary delta time

Finished: - when the player comes in contact with a obstacle the rect will flash

Added: - when the player reaches 0 health, he will respawn at the start position with the maximum amount of health

Fixed: - typehint issues

Davidek523 · 2025-06-02T12:09:33Z

Addressed the issues that you mentioned! Could you take a look?

ultimateownsz · 2025-06-02T20:26:45Z

It's looking good, could you also add the collision with islands? And make the flashing player hit only when it's bein hit and not constantly?

Fixed: - constant flashing when the player stays on the obstacle.

Changed: - the file name to object_manager - class name to ObjectManager - as requested

Davidek523 · 2025-06-04T11:00:39Z

Fixed the issues you we're talking about and also changed the name of the file and the class as requested! Everything works, no bugs!

ultimateownsz

Looking good, it all works. Before I forget, I would only want you to add unit tests since your obstacle_manager is a new feature for the project. Do this and your code can be merged!

Davidek523 · 2025-06-02T08:56:49Z

Pull Request Template

Type of Pull Request

Only check one box per pull request.

🛠️ Code - Changes to the codebase.
🔄 Revert - Reverts a previously merged commit or PR.
📄 Documentation - Updates to documentation files.
🎵 Audio - Changes to audio files.
🎨 Asset - Updates to design or visual assets.

Summary

This PR adds obstacles objects to the game. Now when the player comes in contact with such a object, the player will receive damage and on the screen it will be shown how much!

Related Issues

This PR closes issue(s) #120

✅ Checklist:

Tested the changes locally.
Verified that no breaking changes are introduced.
Updated documentation (if applicable).

🏷️ Labels:

type: ..., area: ..., game-..., ...

Added: - new state for obstacles - state methods within this class

Added: - obstacles to the map - in setup drew the obstacles onto the map - in obstacle state added logic for collision

Fixed: - in game running: Typo from the imported class - obstacle state: logical issues with collision

Changed: - Removed the object state from states and refactored it to not use state anymore - Changed file name and the file place

Called: - object handler in game running

Fixed: - issue where message of dealing damage was not showing up Changed: - commentend display flip method in object handler to save frames

Changed: - the black block for the message transparent

Changed: - the color of the message

…-areas-(issue-120)

Small fix groups

Fixed all the typehints

ultimateownsz

Hi, since there is no objective for the player yet, I think what could work with the collisions is that is the player health < 0, that it will reset the player's position to the starting position.

Also, I think it could be helpful if you make it that you see the player getting a white border or flashing sprite that it shows to the player that you hit an object, because now it is static, and the drawing order could be different, so the player's (rectangle for now) behind the obstacle, instead of over the obstacle.

Fixed: - Health going infinitly low

Added: - a flashing effect when the player gets hurt by the obstacles

Changed: - the location of the dt from the handler to the game loop

Fixed: - Flash not working properly Removed: - unnecessary delta time

Finished: - when the player comes in contact with a obstacle the rect will flash

Added: - when the player reaches 0 health, he will respawn at the start position with the maximum amount of health

Fixed: - typehint issues

Davidek523 · 2025-06-02T12:09:33Z

Addressed the issues that you mentioned! Could you take a look?

ultimateownsz · 2025-06-02T20:26:45Z

It's looking good, could you also add the collision with islands? And make the flashing player hit only when it's bein hit and not constantly?

Fixed: - constant flashing when the player stays on the obstacle.

Changed: - the file name to object_manager - class name to ObjectManager - as requested

Davidek523 · 2025-06-04T11:00:39Z

Fixed the issues you we're talking about and also changed the name of the file and the class as requested! Everything works, no bugs!

ultimateownsz

Looking good, it all works. Before I forget, I would only want you to add unit tests since your obstacle_manager is a new feature for the project. Do this and your code can be merged!

Davidek523 · 2025-06-02T08:56:49Z

Pull Request Template

Type of Pull Request

Only check one box per pull request.

🛠️ Code - Changes to the codebase.
🔄 Revert - Reverts a previously merged commit or PR.
📄 Documentation - Updates to documentation files.
🎵 Audio - Changes to audio files.
🎨 Asset - Updates to design or visual assets.

Summary

This PR adds obstacles objects to the game. Now when the player comes in contact with such a object, the player will receive damage and on the screen it will be shown how much!

Related Issues

This PR closes issue(s) #120

✅ Checklist:

Tested the changes locally.
Verified that no breaking changes are introduced.
Updated documentation (if applicable).

🏷️ Labels:

type: ..., area: ..., game-..., ...

Added: - new state for obstacles - state methods within this class

Added: - obstacles to the map - in setup drew the obstacles onto the map - in obstacle state added logic for collision

Fixed: - in game running: Typo from the imported class - obstacle state: logical issues with collision

Changed: - Removed the object state from states and refactored it to not use state anymore - Changed file name and the file place

Called: - object handler in game running

Fixed: - issue where message of dealing damage was not showing up Changed: - commentend display flip method in object handler to save frames

Changed: - the black block for the message transparent

Changed: - the color of the message

…-areas-(issue-120)

Small fix groups

Fixed all the typehints

ultimateownsz

Hi, since there is no objective for the player yet, I think what could work with the collisions is that is the player health < 0, that it will reset the player's position to the starting position.

Also, I think it could be helpful if you make it that you see the player getting a white border or flashing sprite that it shows to the player that you hit an object, because now it is static, and the drawing order could be different, so the player's (rectangle for now) behind the obstacle, instead of over the obstacle.

Fixed: - Health going infinitly low

Added: - a flashing effect when the player gets hurt by the obstacles

Changed: - the location of the dt from the handler to the game loop

Fixed: - Flash not working properly Removed: - unnecessary delta time

Finished: - when the player comes in contact with a obstacle the rect will flash

Added: - when the player reaches 0 health, he will respawn at the start position with the maximum amount of health

Fixed: - typehint issues

Davidek523 · 2025-06-02T12:09:33Z

Addressed the issues that you mentioned! Could you take a look?

ultimateownsz · 2025-06-02T20:26:45Z

It's looking good, could you also add the collision with islands? And make the flashing player hit only when it's bein hit and not constantly?

Fixed: - constant flashing when the player stays on the obstacle.

Changed: - the file name to object_manager - class name to ObjectManager - as requested

Davidek523 · 2025-06-04T11:00:39Z

Fixed the issues you we're talking about and also changed the name of the file and the class as requested! Everything works, no bugs!

ultimateownsz

Looking good, it all works. Before I forget, I would only want you to add unit tests since your obstacle_manager is a new feature for the project. Do this and your code can be merged!

Davidek523 · 2025-06-02T08:56:49Z

Pull Request Template

Type of Pull Request

Only check one box per pull request.

🛠️ Code - Changes to the codebase.
🔄 Revert - Reverts a previously merged commit or PR.
📄 Documentation - Updates to documentation files.
🎵 Audio - Changes to audio files.
🎨 Asset - Updates to design or visual assets.

Summary

This PR adds obstacles objects to the game. Now when the player comes in contact with such a object, the player will receive damage and on the screen it will be shown how much!

Related Issues

This PR closes issue(s) #120

✅ Checklist:

Tested the changes locally.
Verified that no breaking changes are introduced.
Updated documentation (if applicable).

🏷️ Labels:

type: ..., area: ..., game-..., ...

Added: - new state for obstacles - state methods within this class

Added: - obstacles to the map - in setup drew the obstacles onto the map - in obstacle state added logic for collision

Fixed: - in game running: Typo from the imported class - obstacle state: logical issues with collision

Changed: - Removed the object state from states and refactored it to not use state anymore - Changed file name and the file place

Called: - object handler in game running

Fixed: - issue where message of dealing damage was not showing up Changed: - commentend display flip method in object handler to save frames

Changed: - the black block for the message transparent

Changed: - the color of the message

…-areas-(issue-120)

Small fix groups

Fixed all the typehints

ultimateownsz

Hi, since there is no objective for the player yet, I think what could work with the collisions is that is the player health < 0, that it will reset the player's position to the starting position.

Also, I think it could be helpful if you make it that you see the player getting a white border or flashing sprite that it shows to the player that you hit an object, because now it is static, and the drawing order could be different, so the player's (rectangle for now) behind the obstacle, instead of over the obstacle.

Fixed: - Health going infinitly low

Added: - a flashing effect when the player gets hurt by the obstacles

Changed: - the location of the dt from the handler to the game loop

Fixed: - Flash not working properly Removed: - unnecessary delta time

Finished: - when the player comes in contact with a obstacle the rect will flash

Added: - when the player reaches 0 health, he will respawn at the start position with the maximum amount of health

Fixed: - typehint issues

Davidek523 · 2025-06-02T12:09:33Z

Addressed the issues that you mentioned! Could you take a look?

ultimateownsz · 2025-06-02T20:26:45Z

It's looking good, could you also add the collision with islands? And make the flashing player hit only when it's bein hit and not constantly?

Fixed: - constant flashing when the player stays on the obstacle.

Changed: - the file name to object_manager - class name to ObjectManager - as requested

Davidek523 · 2025-06-04T11:00:39Z

Fixed the issues you we're talking about and also changed the name of the file and the class as requested! Everything works, no bugs!

ultimateownsz

Looking good, it all works. Before I forget, I would only want you to add unit tests since your obstacle_manager is a new feature for the project. Do this and your code can be merged!

Davidek523 · 2025-06-02T08:56:49Z

Pull Request Template

Type of Pull Request

Only check one box per pull request.

🛠️ Code - Changes to the codebase.
🔄 Revert - Reverts a previously merged commit or PR.
📄 Documentation - Updates to documentation files.
🎵 Audio - Changes to audio files.
🎨 Asset - Updates to design or visual assets.

Summary

This PR adds obstacles objects to the game. Now when the player comes in contact with such a object, the player will receive damage and on the screen it will be shown how much!

Related Issues

This PR closes issue(s) #120

✅ Checklist:

Tested the changes locally.
Verified that no breaking changes are introduced.
Updated documentation (if applicable).

🏷️ Labels:

type: ..., area: ..., game-..., ...

Added: - new state for obstacles - state methods within this class

Added: - obstacles to the map - in setup drew the obstacles onto the map - in obstacle state added logic for collision

Fixed: - in game running: Typo from the imported class - obstacle state: logical issues with collision

Changed: - Removed the object state from states and refactored it to not use state anymore - Changed file name and the file place

Called: - object handler in game running

Fixed: - issue where message of dealing damage was not showing up Changed: - commentend display flip method in object handler to save frames

Changed: - the black block for the message transparent

Changed: - the color of the message

…-areas-(issue-120)

Small fix groups

Fixed all the typehints

ultimateownsz

Hi, since there is no objective for the player yet, I think what could work with the collisions is that is the player health < 0, that it will reset the player's position to the starting position.

Also, I think it could be helpful if you make it that you see the player getting a white border or flashing sprite that it shows to the player that you hit an object, because now it is static, and the drawing order could be different, so the player's (rectangle for now) behind the obstacle, instead of over the obstacle.

Fixed: - Health going infinitly low

Added: - a flashing effect when the player gets hurt by the obstacles

Changed: - the location of the dt from the handler to the game loop

Fixed: - Flash not working properly Removed: - unnecessary delta time

Finished: - when the player comes in contact with a obstacle the rect will flash

Added: - when the player reaches 0 health, he will respawn at the start position with the maximum amount of health

Fixed: - typehint issues

Davidek523 · 2025-06-02T12:09:33Z

Addressed the issues that you mentioned! Could you take a look?

ultimateownsz · 2025-06-02T20:26:45Z

It's looking good, could you also add the collision with islands? And make the flashing player hit only when it's bein hit and not constantly?

Fixed: - constant flashing when the player stays on the obstacle.

Changed: - the file name to object_manager - class name to ObjectManager - as requested

Davidek523 · 2025-06-04T11:00:39Z

Fixed the issues you we're talking about and also changed the name of the file and the class as requested! Everything works, no bugs!

ultimateownsz

Looking good, it all works. Before I forget, I would only want you to add unit tests since your obstacle_manager is a new feature for the project. Do this and your code can be merged!

Davidek523 · 2025-06-02T08:56:49Z

Pull Request Template

Type of Pull Request

Only check one box per pull request.

🛠️ Code - Changes to the codebase.
🔄 Revert - Reverts a previously merged commit or PR.
📄 Documentation - Updates to documentation files.
🎵 Audio - Changes to audio files.
🎨 Asset - Updates to design or visual assets.

Summary

This PR adds obstacles objects to the game. Now when the player comes in contact with such a object, the player will receive damage and on the screen it will be shown how much!

Related Issues

This PR closes issue(s) #120

✅ Checklist:

Tested the changes locally.
Verified that no breaking changes are introduced.
Updated documentation (if applicable).

🏷️ Labels:

type: ..., area: ..., game-..., ...

Added: - new state for obstacles - state methods within this class

Added: - obstacles to the map - in setup drew the obstacles onto the map - in obstacle state added logic for collision

Fixed: - in game running: Typo from the imported class - obstacle state: logical issues with collision

Changed: - Removed the object state from states and refactored it to not use state anymore - Changed file name and the file place

Called: - object handler in game running

Fixed: - issue where message of dealing damage was not showing up Changed: - commentend display flip method in object handler to save frames

Changed: - the black block for the message transparent

Changed: - the color of the message

…-areas-(issue-120)

Small fix groups

Fixed all the typehints

ultimateownsz

Hi, since there is no objective for the player yet, I think what could work with the collisions is that is the player health < 0, that it will reset the player's position to the starting position.

Also, I think it could be helpful if you make it that you see the player getting a white border or flashing sprite that it shows to the player that you hit an object, because now it is static, and the drawing order could be different, so the player's (rectangle for now) behind the obstacle, instead of over the obstacle.

Fixed: - Health going infinitly low

Added: - a flashing effect when the player gets hurt by the obstacles

Changed: - the location of the dt from the handler to the game loop

Fixed: - Flash not working properly Removed: - unnecessary delta time

Finished: - when the player comes in contact with a obstacle the rect will flash

Added: - when the player reaches 0 health, he will respawn at the start position with the maximum amount of health

Fixed: - typehint issues

Davidek523 · 2025-06-02T12:09:33Z

Addressed the issues that you mentioned! Could you take a look?

ultimateownsz · 2025-06-02T20:26:45Z

It's looking good, could you also add the collision with islands? And make the flashing player hit only when it's bein hit and not constantly?

Fixed: - constant flashing when the player stays on the obstacle.

Changed: - the file name to object_manager - class name to ObjectManager - as requested

Davidek523 · 2025-06-04T11:00:39Z

Fixed the issues you we're talking about and also changed the name of the file and the class as requested! Everything works, no bugs!

ultimateownsz

Looking good, it all works. Before I forget, I would only want you to add unit tests since your obstacle_manager is a new feature for the project. Do this and your code can be merged!

Davidek523 · 2025-06-02T08:56:49Z

Pull Request Template

Type of Pull Request

Only check one box per pull request.

🛠️ Code - Changes to the codebase.
🔄 Revert - Reverts a previously merged commit or PR.
📄 Documentation - Updates to documentation files.
🎵 Audio - Changes to audio files.
🎨 Asset - Updates to design or visual assets.

Summary

This PR adds obstacles objects to the game. Now when the player comes in contact with such a object, the player will receive damage and on the screen it will be shown how much!

Related Issues

This PR closes issue(s) #120

✅ Checklist:

Tested the changes locally.
Verified that no breaking changes are introduced.
Updated documentation (if applicable).

🏷️ Labels:

type: ..., area: ..., game-..., ...

Added: - new state for obstacles - state methods within this class

Added: - obstacles to the map - in setup drew the obstacles onto the map - in obstacle state added logic for collision

Fixed: - in game running: Typo from the imported class - obstacle state: logical issues with collision

Changed: - Removed the object state from states and refactored it to not use state anymore - Changed file name and the file place

Called: - object handler in game running

Fixed: - issue where message of dealing damage was not showing up Changed: - commentend display flip method in object handler to save frames

Changed: - the black block for the message transparent

Changed: - the color of the message

…-areas-(issue-120)

Small fix groups

Fixed all the typehints

ultimateownsz

Hi, since there is no objective for the player yet, I think what could work with the collisions is that is the player health < 0, that it will reset the player's position to the starting position.

Also, I think it could be helpful if you make it that you see the player getting a white border or flashing sprite that it shows to the player that you hit an object, because now it is static, and the drawing order could be different, so the player's (rectangle for now) behind the obstacle, instead of over the obstacle.

Fixed: - Health going infinitly low

Added: - a flashing effect when the player gets hurt by the obstacles

Changed: - the location of the dt from the handler to the game loop

Fixed: - Flash not working properly Removed: - unnecessary delta time

Finished: - when the player comes in contact with a obstacle the rect will flash

Added: - when the player reaches 0 health, he will respawn at the start position with the maximum amount of health

Fixed: - typehint issues

Davidek523 · 2025-06-02T12:09:33Z

Addressed the issues that you mentioned! Could you take a look?

ultimateownsz · 2025-06-02T20:26:45Z

It's looking good, could you also add the collision with islands? And make the flashing player hit only when it's bein hit and not constantly?

Fixed: - constant flashing when the player stays on the obstacle.

Changed: - the file name to object_manager - class name to ObjectManager - as requested

Davidek523 · 2025-06-04T11:00:39Z

Fixed the issues you we're talking about and also changed the name of the file and the class as requested! Everything works, no bugs!

ultimateownsz

Looking good, it all works. Before I forget, I would only want you to add unit tests since your obstacle_manager is a new feature for the project. Do this and your code can be merged!

Davidek523 · 2025-06-02T08:56:49Z

Pull Request Template

Type of Pull Request

Only check one box per pull request.

🛠️ Code - Changes to the codebase.
🔄 Revert - Reverts a previously merged commit or PR.
📄 Documentation - Updates to documentation files.
🎵 Audio - Changes to audio files.
🎨 Asset - Updates to design or visual assets.

Summary

This PR adds obstacles objects to the game. Now when the player comes in contact with such a object, the player will receive damage and on the screen it will be shown how much!

Related Issues

This PR closes issue(s) #120

✅ Checklist:

Tested the changes locally.
Verified that no breaking changes are introduced.
Updated documentation (if applicable).

🏷️ Labels:

type: ..., area: ..., game-..., ...

Added: - new state for obstacles - state methods within this class

Added: - obstacles to the map - in setup drew the obstacles onto the map - in obstacle state added logic for collision

Fixed: - in game running: Typo from the imported class - obstacle state: logical issues with collision

Changed: - Removed the object state from states and refactored it to not use state anymore - Changed file name and the file place

Called: - object handler in game running

Fixed: - issue where message of dealing damage was not showing up Changed: - commentend display flip method in object handler to save frames

Changed: - the black block for the message transparent

Changed: - the color of the message

…-areas-(issue-120)

Small fix groups

Fixed all the typehints

ultimateownsz

Hi, since there is no objective for the player yet, I think what could work with the collisions is that is the player health < 0, that it will reset the player's position to the starting position.

Also, I think it could be helpful if you make it that you see the player getting a white border or flashing sprite that it shows to the player that you hit an object, because now it is static, and the drawing order could be different, so the player's (rectangle for now) behind the obstacle, instead of over the obstacle.

Fixed: - Health going infinitly low

Added: - a flashing effect when the player gets hurt by the obstacles

Changed: - the location of the dt from the handler to the game loop

Fixed: - Flash not working properly Removed: - unnecessary delta time

Finished: - when the player comes in contact with a obstacle the rect will flash

Added: - when the player reaches 0 health, he will respawn at the start position with the maximum amount of health

Fixed: - typehint issues

Davidek523 · 2025-06-02T12:09:33Z

Addressed the issues that you mentioned! Could you take a look?

ultimateownsz · 2025-06-02T20:26:45Z

It's looking good, could you also add the collision with islands? And make the flashing player hit only when it's bein hit and not constantly?

Fixed: - constant flashing when the player stays on the obstacle.

Changed: - the file name to object_manager - class name to ObjectManager - as requested

Davidek523 · 2025-06-04T11:00:39Z

Fixed the issues you we're talking about and also changed the name of the file and the class as requested! Everything works, no bugs!

ultimateownsz

Looking good, it all works. Before I forget, I would only want you to add unit tests since your obstacle_manager is a new feature for the project. Do this and your code can be merged!

Davidek523 added 11 commits May 26, 2025 14:14

Added new class
7571df4
Added: - new state for obstacles - state methods within this class

Added obstacles
4e20da5
Added: - obstacles to the map - in setup drew the obstacles onto the map - in obstacle state added logic for collision

fixed some small issues
c7c2f6a
Fixed: - in game running: Typo from the imported class - obstacle state: logical issues with collision

Changing some file structure
269dd04
Changed: - Removed the object state from states and refactored it to not use state anymore - Changed file name and the file place

Calling the class in game running
5b56c2d
Called: - object handler in game running

Fixed setup issue
708fc25
Fixed: - issue where message of dealing damage was not showing up Changed: - commentend display flip method in object handler to save frames

Making the black screen transparent
7d76161
Changed: - the black block for the message transparent

Changed color
65c59f2
Changed: - the color of the message

Merge branch 'main' ofhttps://github.com/PyCeas/Pyceasinto Obstacle…
6e246ee
…-areas-(issue-120)

Small fix
126c7a6
Small fix groups

Typehints check
6637ed5
Fixed all the typehints

ultimateownsz requested changes Jun 2, 2025
View reviewed changes

Comment threadsrc/obstacle_handler.py Outdated

Davidek523 added 7 commits June 2, 2025 11:40

Fixed health issue
d80164d
Fixed: - Health going infinitly low

Created a flash
0e54be9
Added: - a flashing effect when the player gets hurt by the obstacles

Changed the location of the dt
f0ef8ff
Changed: - the location of the dt from the handler to the game loop

Fixed some minor issues with the flash
8290836
Fixed: - Flash not working properly Removed: - unnecessary delta time

Finished flashing feature
58084dd
Finished: - when the player comes in contact with a obstacle the rect will flash

Added respawning
368d345
Added: - when the player reaches 0 health, he will respawn at the start position with the maximum amount of health

Fixed some typehint issues
823453d
Fixed: - typehint issues

Davidek523 requested a review from ultimateownsz June 2, 2025 12:08

Davidek523 added 2 commits June 4, 2025 12:55

Fixed constant flashing
741a6d2
Fixed: - constant flashing when the player stays on the obstacle.

Changed file name
718d170
Changed: - the file name to object_manager - class name to ObjectManager - as requested

ultimateownsz requested changes Jun 4, 2025
View reviewed changes

Merge branch 'main' into Obstacle-areas-(issue-120)
a85fe21

ultimateownsz closed this Dec 6, 2025