Skip to content

Region cannot be set using url parameters #83

Description

@sdorgancs

Hello,
I would like to be able to set the region using url parameters, like in the example below:

fs=open_fs('s3://testbucket?endpoint_url=localhost:9000&region=us-east-1')

But S3FSOpener in opener.py doest not get it

classS3FSOpener(Opener):
protocols= ["s3"]
defopen_fs(self, fs_url, parse_result, writeable, create, cwd):
bucket_name, _, dir_path=parse_result.resource.partition("/")
ifnotbucket_name:
raiseOpenerError("invalid bucket name in '{}'".format(fs_url))
strict= (
parse_result.params["strict"] =="1"if"strict"inparse_result.paramselseTrue
)
s3fs=S3FS(
bucket_name,
dir_path=dir_pathor"/",
aws_access_key_id=parse_result.usernameorNone,
aws_secret_access_key=parse_result.passwordorNone,
endpoint_url=parse_result.params.get("endpoint_url", None),
acl=parse_result.params.get("acl", None),
cache_control=parse_result.params.get("cache_control", None),
strict=strict,
)
returns3fs

The change to make it working is very simple

classS3FSOpener(Opener):
protocols= ["s3"]
defopen_fs(self, fs_url, parse_result, writeable, create, cwd):
bucket_name, _, dir_path=parse_result.resource.partition("/")
ifnotbucket_name:
raiseOpenerError("invalid bucket name in '{}'".format(fs_url))
strict= (
parse_result.params["strict"] =="1"if"strict"inparse_result.paramselseTrue
)
s3fs=S3FS(
bucket_name,
dir_path=dir_pathor"/",
aws_access_key_id=parse_result.usernameorNone,
aws_secret_access_key=parse_result.passwordorNone,
endpoint_url=parse_result.params.get("endpoint_url", None),
# line to addregion=parse_result.params.get("region", None),
acl=parse_result.params.get("acl", None),
cache_control=parse_result.params.get("cache_control", None),
strict=strict,
)
returns3fs

Could you manage this?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions