Feature/str pattern completion

[Ashwolaa]

Pattern completer subpart of PR#105:

This PR contains:

• the PatternCompleter class which can be used with QTextEdit/QLineEdit/QPlainTextEdit, resulting in PatternTextEdit/PatternLineEdit/PatternPlainTextEdit
  See pattern_completer_demo.py in examples for some demonstration.
• the PatternParameter which makes use of the PatternCompleter class. It provides a QPlainTextEdit making it similar to the usual parameter item but with the PatternCompleter methods.
  See parameter_ex.py in examples for an application

[codecov]

Codecov Report

❌ Patch coverage is 50.00000% with 284 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.39%. Comparing base (19a66e8) to head (000a12d).
⚠️ Report is 23 commits behind head on 5.0.x_dev.

Files with missing lines	Patch %	Lines
...modaq_gui/parameter/pymodaq_ptypes/text_pattern.py	29.49%	153 Missing ⚠️
src/pymodaq_gui/utils/widgets/pattern_completer.py	61.86%	127 Missing ⚠️
src/pymodaq_gui/parameter/ioxml.py	75.00%	4 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## 5.0.x_dev #109 +/- ##
=============================================
- Coverage 64.22% 63.39% -0.84% 
=============================================
Files 73 75 +2 Lines 9201 9768 +567 =============================================
+ Hits 5909 6192 +283 - Misses 3292 3576 +284 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[seb5g]

A few comments to start on this huge PR:

• when there is only one elt in the proposed choices (from the pattern filtering) it would be nice to just press enter to use it. As it is, one has to use the down arrow key or the mouse click
• for emoji, you should include a space just after the emoji otherwise it breaks the emoji representation
• could not see any difference in your wordwrap example

[Ashwolaa]

A few comments to start on this huge PR:

• when there is only one elt in the proposed choices (from the pattern filtering) it would be nice to just press enter to use it. As it is, one has to use the down arrow key or the mouse click

I agree, I changed it to have a behavior close to an IDE. The first item proposed is selected by default. Pressing Enter/Tab will autocomplete it (Tab only works well with QPlainText though)

• for emoji, you should include a space just after the emoji otherwise it breaks the emoji representation

I removed them and I changed the example with more standard Unicodes. The issue with the emojis is that they consist of multiple characters which make the whole identification struggle.

• could not see any difference in your wordwrap example

I updated the example, it should be more explanatory now.

[seb5g]

@malik-irain could you have a go to check this as well and merge it if it is fine. We have to move on to the monorepo ...

[malik-irain]

I know that's what's the doc says about subclassing WidgetParameterItem but I would be careful about monkeypatching qt methods as it already made tests fails without any apparent reason. I would have implemented a value attribute and a setValue method in PatternPlainTextEdit widget that call toPlainText and setPlainText. For the signal, it might be tricky.

Anyways for now, it works so we can leave it like that

[Ashwolaa]

I can add this if you think it is better. There is no impact on the tests.

Not sure, how to deal with the signal though.

[Ashwolaa]

Claude calls it "Duck typing adapter"

[malik-irain]

Yeah it works very well in python, but when using objects from C++ it can lead to segmentation faults (we had the issue recently), but as it doesn't seem to make tests fail, it's ok with me!

[malik-irain]

@Ashwolaa Can you rebase or merge the last modification of pymodaq_gui in you PR so that I can see if tests are passing?

[Ashwolaa]

Pattern completer subpart of PR#105:

This PR contains:

• the PatternCompleter class which can be used with QTextEdit/QLineEdit/QPlainTextEdit, resulting in PatternTextEdit/PatternLineEdit/PatternPlainTextEdit
  See pattern_completer_demo.py in examples for some demonstration.
• the PatternParameter which makes use of the PatternCompleter class. It provides a QPlainTextEdit making it similar to the usual parameter item but with the PatternCompleter methods.
  See parameter_ex.py in examples for an application

[codecov]

Codecov Report

❌ Patch coverage is 50.00000% with 284 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.39%. Comparing base (19a66e8) to head (000a12d).
⚠️ Report is 23 commits behind head on 5.0.x_dev.

Files with missing lines	Patch %	Lines
...modaq_gui/parameter/pymodaq_ptypes/text_pattern.py	29.49%	153 Missing ⚠️
src/pymodaq_gui/utils/widgets/pattern_completer.py	61.86%	127 Missing ⚠️
src/pymodaq_gui/parameter/ioxml.py	75.00%	4 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## 5.0.x_dev #109 +/- ##
=============================================
- Coverage 64.22% 63.39% -0.84% 
=============================================
Files 73 75 +2 Lines 9201 9768 +567 =============================================
+ Hits 5909 6192 +283 - Misses 3292 3576 +284 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[seb5g]

A few comments to start on this huge PR:

• when there is only one elt in the proposed choices (from the pattern filtering) it would be nice to just press enter to use it. As it is, one has to use the down arrow key or the mouse click
• for emoji, you should include a space just after the emoji otherwise it breaks the emoji representation
• could not see any difference in your wordwrap example

[Ashwolaa]

A few comments to start on this huge PR:

• when there is only one elt in the proposed choices (from the pattern filtering) it would be nice to just press enter to use it. As it is, one has to use the down arrow key or the mouse click

I agree, I changed it to have a behavior close to an IDE. The first item proposed is selected by default. Pressing Enter/Tab will autocomplete it (Tab only works well with QPlainText though)

• for emoji, you should include a space just after the emoji otherwise it breaks the emoji representation

I removed them and I changed the example with more standard Unicodes. The issue with the emojis is that they consist of multiple characters which make the whole identification struggle.

• could not see any difference in your wordwrap example

I updated the example, it should be more explanatory now.

[seb5g]

@malik-irain could you have a go to check this as well and merge it if it is fine. We have to move on to the monorepo ...

[malik-irain]

I know that's what's the doc says about subclassing WidgetParameterItem but I would be careful about monkeypatching qt methods as it already made tests fails without any apparent reason. I would have implemented a value attribute and a setValue method in PatternPlainTextEdit widget that call toPlainText and setPlainText. For the signal, it might be tricky.

Anyways for now, it works so we can leave it like that

[Ashwolaa]

I can add this if you think it is better. There is no impact on the tests.

Not sure, how to deal with the signal though.

[Ashwolaa]

Claude calls it "Duck typing adapter"

[malik-irain]

Yeah it works very well in python, but when using objects from C++ it can lead to segmentation faults (we had the issue recently), but as it doesn't seem to make tests fail, it's ok with me!

[malik-irain]

@Ashwolaa Can you rebase or merge the last modification of pymodaq_gui in you PR so that I can see if tests are passing?

[Ashwolaa]

Pattern completer subpart of PR#105:

This PR contains:

• the PatternCompleter class which can be used with QTextEdit/QLineEdit/QPlainTextEdit, resulting in PatternTextEdit/PatternLineEdit/PatternPlainTextEdit
  See pattern_completer_demo.py in examples for some demonstration.
• the PatternParameter which makes use of the PatternCompleter class. It provides a QPlainTextEdit making it similar to the usual parameter item but with the PatternCompleter methods.
  See parameter_ex.py in examples for an application

[codecov]

Codecov Report

❌ Patch coverage is 50.00000% with 284 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.39%. Comparing base (19a66e8) to head (000a12d).
⚠️ Report is 23 commits behind head on 5.0.x_dev.

Files with missing lines	Patch %	Lines
...modaq_gui/parameter/pymodaq_ptypes/text_pattern.py	29.49%	153 Missing ⚠️
src/pymodaq_gui/utils/widgets/pattern_completer.py	61.86%	127 Missing ⚠️
src/pymodaq_gui/parameter/ioxml.py	75.00%	4 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## 5.0.x_dev #109 +/- ##
=============================================
- Coverage 64.22% 63.39% -0.84% 
=============================================
Files 73 75 +2 Lines 9201 9768 +567 =============================================
+ Hits 5909 6192 +283 - Misses 3292 3576 +284 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[seb5g]

A few comments to start on this huge PR:

• when there is only one elt in the proposed choices (from the pattern filtering) it would be nice to just press enter to use it. As it is, one has to use the down arrow key or the mouse click
• for emoji, you should include a space just after the emoji otherwise it breaks the emoji representation
• could not see any difference in your wordwrap example

[Ashwolaa]

A few comments to start on this huge PR:

• when there is only one elt in the proposed choices (from the pattern filtering) it would be nice to just press enter to use it. As it is, one has to use the down arrow key or the mouse click

I agree, I changed it to have a behavior close to an IDE. The first item proposed is selected by default. Pressing Enter/Tab will autocomplete it (Tab only works well with QPlainText though)

• for emoji, you should include a space just after the emoji otherwise it breaks the emoji representation

I removed them and I changed the example with more standard Unicodes. The issue with the emojis is that they consist of multiple characters which make the whole identification struggle.

• could not see any difference in your wordwrap example

I updated the example, it should be more explanatory now.

[seb5g]

@malik-irain could you have a go to check this as well and merge it if it is fine. We have to move on to the monorepo ...

[malik-irain]

I know that's what's the doc says about subclassing WidgetParameterItem but I would be careful about monkeypatching qt methods as it already made tests fails without any apparent reason. I would have implemented a value attribute and a setValue method in PatternPlainTextEdit widget that call toPlainText and setPlainText. For the signal, it might be tricky.

Anyways for now, it works so we can leave it like that

[Ashwolaa]

I can add this if you think it is better. There is no impact on the tests.

Not sure, how to deal with the signal though.

[Ashwolaa]

Claude calls it "Duck typing adapter"

[malik-irain]

Yeah it works very well in python, but when using objects from C++ it can lead to segmentation faults (we had the issue recently), but as it doesn't seem to make tests fail, it's ok with me!

[malik-irain]

@Ashwolaa Can you rebase or merge the last modification of pymodaq_gui in you PR so that I can see if tests are passing?

[Ashwolaa]

Pattern completer subpart of PR#105:

This PR contains:

• the PatternCompleter class which can be used with QTextEdit/QLineEdit/QPlainTextEdit, resulting in PatternTextEdit/PatternLineEdit/PatternPlainTextEdit
  See pattern_completer_demo.py in examples for some demonstration.
• the PatternParameter which makes use of the PatternCompleter class. It provides a QPlainTextEdit making it similar to the usual parameter item but with the PatternCompleter methods.
  See parameter_ex.py in examples for an application

[codecov]

Codecov Report

❌ Patch coverage is 50.00000% with 284 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.39%. Comparing base (19a66e8) to head (000a12d).
⚠️ Report is 23 commits behind head on 5.0.x_dev.

Files with missing lines	Patch %	Lines
...modaq_gui/parameter/pymodaq_ptypes/text_pattern.py	29.49%	153 Missing ⚠️
src/pymodaq_gui/utils/widgets/pattern_completer.py	61.86%	127 Missing ⚠️
src/pymodaq_gui/parameter/ioxml.py	75.00%	4 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## 5.0.x_dev #109 +/- ##
=============================================
- Coverage 64.22% 63.39% -0.84% 
=============================================
Files 73 75 +2 Lines 9201 9768 +567 =============================================
+ Hits 5909 6192 +283 - Misses 3292 3576 +284 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[seb5g]

A few comments to start on this huge PR:

• when there is only one elt in the proposed choices (from the pattern filtering) it would be nice to just press enter to use it. As it is, one has to use the down arrow key or the mouse click
• for emoji, you should include a space just after the emoji otherwise it breaks the emoji representation
• could not see any difference in your wordwrap example

[Ashwolaa]

A few comments to start on this huge PR:

• when there is only one elt in the proposed choices (from the pattern filtering) it would be nice to just press enter to use it. As it is, one has to use the down arrow key or the mouse click

I agree, I changed it to have a behavior close to an IDE. The first item proposed is selected by default. Pressing Enter/Tab will autocomplete it (Tab only works well with QPlainText though)

• for emoji, you should include a space just after the emoji otherwise it breaks the emoji representation

I removed them and I changed the example with more standard Unicodes. The issue with the emojis is that they consist of multiple characters which make the whole identification struggle.

• could not see any difference in your wordwrap example

I updated the example, it should be more explanatory now.

[seb5g]

@malik-irain could you have a go to check this as well and merge it if it is fine. We have to move on to the monorepo ...

[malik-irain]

I know that's what's the doc says about subclassing WidgetParameterItem but I would be careful about monkeypatching qt methods as it already made tests fails without any apparent reason. I would have implemented a value attribute and a setValue method in PatternPlainTextEdit widget that call toPlainText and setPlainText. For the signal, it might be tricky.

Anyways for now, it works so we can leave it like that

[Ashwolaa]

I can add this if you think it is better. There is no impact on the tests.

Not sure, how to deal with the signal though.

[Ashwolaa]

Claude calls it "Duck typing adapter"

[malik-irain]

Yeah it works very well in python, but when using objects from C++ it can lead to segmentation faults (we had the issue recently), but as it doesn't seem to make tests fail, it's ok with me!

[malik-irain]

@Ashwolaa Can you rebase or merge the last modification of pymodaq_gui in you PR so that I can see if tests are passing?

[Ashwolaa]

Pattern completer subpart of PR#105:

This PR contains:

• the PatternCompleter class which can be used with QTextEdit/QLineEdit/QPlainTextEdit, resulting in PatternTextEdit/PatternLineEdit/PatternPlainTextEdit
  See pattern_completer_demo.py in examples for some demonstration.
• the PatternParameter which makes use of the PatternCompleter class. It provides a QPlainTextEdit making it similar to the usual parameter item but with the PatternCompleter methods.
  See parameter_ex.py in examples for an application

[codecov]

Codecov Report

❌ Patch coverage is 50.00000% with 284 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.39%. Comparing base (19a66e8) to head (000a12d).
⚠️ Report is 23 commits behind head on 5.0.x_dev.

Files with missing lines	Patch %	Lines
...modaq_gui/parameter/pymodaq_ptypes/text_pattern.py	29.49%	153 Missing ⚠️
src/pymodaq_gui/utils/widgets/pattern_completer.py	61.86%	127 Missing ⚠️
src/pymodaq_gui/parameter/ioxml.py	75.00%	4 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## 5.0.x_dev #109 +/- ##
=============================================
- Coverage 64.22% 63.39% -0.84% 
=============================================
Files 73 75 +2 Lines 9201 9768 +567 =============================================
+ Hits 5909 6192 +283 - Misses 3292 3576 +284 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[seb5g]

A few comments to start on this huge PR:

• when there is only one elt in the proposed choices (from the pattern filtering) it would be nice to just press enter to use it. As it is, one has to use the down arrow key or the mouse click
• for emoji, you should include a space just after the emoji otherwise it breaks the emoji representation
• could not see any difference in your wordwrap example

[Ashwolaa]

A few comments to start on this huge PR:

• when there is only one elt in the proposed choices (from the pattern filtering) it would be nice to just press enter to use it. As it is, one has to use the down arrow key or the mouse click

I agree, I changed it to have a behavior close to an IDE. The first item proposed is selected by default. Pressing Enter/Tab will autocomplete it (Tab only works well with QPlainText though)

• for emoji, you should include a space just after the emoji otherwise it breaks the emoji representation

I removed them and I changed the example with more standard Unicodes. The issue with the emojis is that they consist of multiple characters which make the whole identification struggle.

• could not see any difference in your wordwrap example

I updated the example, it should be more explanatory now.

[seb5g]

@malik-irain could you have a go to check this as well and merge it if it is fine. We have to move on to the monorepo ...

[malik-irain]

I know that's what's the doc says about subclassing WidgetParameterItem but I would be careful about monkeypatching qt methods as it already made tests fails without any apparent reason. I would have implemented a value attribute and a setValue method in PatternPlainTextEdit widget that call toPlainText and setPlainText. For the signal, it might be tricky.

Anyways for now, it works so we can leave it like that

[Ashwolaa]

I can add this if you think it is better. There is no impact on the tests.

Not sure, how to deal with the signal though.

[Ashwolaa]

Claude calls it "Duck typing adapter"

[malik-irain]

Yeah it works very well in python, but when using objects from C++ it can lead to segmentation faults (we had the issue recently), but as it doesn't seem to make tests fail, it's ok with me!

[malik-irain]

@Ashwolaa Can you rebase or merge the last modification of pymodaq_gui in you PR so that I can see if tests are passing?

[Ashwolaa]

Pattern completer subpart of PR#105:

This PR contains:

• the PatternCompleter class which can be used with QTextEdit/QLineEdit/QPlainTextEdit, resulting in PatternTextEdit/PatternLineEdit/PatternPlainTextEdit
  See pattern_completer_demo.py in examples for some demonstration.
• the PatternParameter which makes use of the PatternCompleter class. It provides a QPlainTextEdit making it similar to the usual parameter item but with the PatternCompleter methods.
  See parameter_ex.py in examples for an application

[codecov]

Codecov Report

❌ Patch coverage is 50.00000% with 284 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.39%. Comparing base (19a66e8) to head (000a12d).
⚠️ Report is 23 commits behind head on 5.0.x_dev.

Files with missing lines	Patch %	Lines
...modaq_gui/parameter/pymodaq_ptypes/text_pattern.py	29.49%	153 Missing ⚠️
src/pymodaq_gui/utils/widgets/pattern_completer.py	61.86%	127 Missing ⚠️
src/pymodaq_gui/parameter/ioxml.py	75.00%	4 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## 5.0.x_dev #109 +/- ##
=============================================
- Coverage 64.22% 63.39% -0.84% 
=============================================
Files 73 75 +2 Lines 9201 9768 +567 =============================================
+ Hits 5909 6192 +283 - Misses 3292 3576 +284 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[seb5g]

A few comments to start on this huge PR:

• when there is only one elt in the proposed choices (from the pattern filtering) it would be nice to just press enter to use it. As it is, one has to use the down arrow key or the mouse click
• for emoji, you should include a space just after the emoji otherwise it breaks the emoji representation
• could not see any difference in your wordwrap example

[Ashwolaa]

A few comments to start on this huge PR:

• when there is only one elt in the proposed choices (from the pattern filtering) it would be nice to just press enter to use it. As it is, one has to use the down arrow key or the mouse click

I agree, I changed it to have a behavior close to an IDE. The first item proposed is selected by default. Pressing Enter/Tab will autocomplete it (Tab only works well with QPlainText though)

• for emoji, you should include a space just after the emoji otherwise it breaks the emoji representation

I removed them and I changed the example with more standard Unicodes. The issue with the emojis is that they consist of multiple characters which make the whole identification struggle.

• could not see any difference in your wordwrap example

I updated the example, it should be more explanatory now.

[seb5g]

@malik-irain could you have a go to check this as well and merge it if it is fine. We have to move on to the monorepo ...

[malik-irain]

I know that's what's the doc says about subclassing WidgetParameterItem but I would be careful about monkeypatching qt methods as it already made tests fails without any apparent reason. I would have implemented a value attribute and a setValue method in PatternPlainTextEdit widget that call toPlainText and setPlainText. For the signal, it might be tricky.

Anyways for now, it works so we can leave it like that

[Ashwolaa]

I can add this if you think it is better. There is no impact on the tests.

Not sure, how to deal with the signal though.

[Ashwolaa]

Claude calls it "Duck typing adapter"

[malik-irain]

Yeah it works very well in python, but when using objects from C++ it can lead to segmentation faults (we had the issue recently), but as it doesn't seem to make tests fail, it's ok with me!

[malik-irain]

@Ashwolaa Can you rebase or merge the last modification of pymodaq_gui in you PR so that I can see if tests are passing?

[Ashwolaa]

Pattern completer subpart of PR#105:

This PR contains:

• the PatternCompleter class which can be used with QTextEdit/QLineEdit/QPlainTextEdit, resulting in PatternTextEdit/PatternLineEdit/PatternPlainTextEdit
  See pattern_completer_demo.py in examples for some demonstration.
• the PatternParameter which makes use of the PatternCompleter class. It provides a QPlainTextEdit making it similar to the usual parameter item but with the PatternCompleter methods.
  See parameter_ex.py in examples for an application

[codecov]

Codecov Report

❌ Patch coverage is 50.00000% with 284 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.39%. Comparing base (19a66e8) to head (000a12d).
⚠️ Report is 23 commits behind head on 5.0.x_dev.

Files with missing lines	Patch %	Lines
...modaq_gui/parameter/pymodaq_ptypes/text_pattern.py	29.49%	153 Missing ⚠️
src/pymodaq_gui/utils/widgets/pattern_completer.py	61.86%	127 Missing ⚠️
src/pymodaq_gui/parameter/ioxml.py	75.00%	4 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## 5.0.x_dev #109 +/- ##
=============================================
- Coverage 64.22% 63.39% -0.84% 
=============================================
Files 73 75 +2 Lines 9201 9768 +567 =============================================
+ Hits 5909 6192 +283 - Misses 3292 3576 +284 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[seb5g]

A few comments to start on this huge PR:

• when there is only one elt in the proposed choices (from the pattern filtering) it would be nice to just press enter to use it. As it is, one has to use the down arrow key or the mouse click
• for emoji, you should include a space just after the emoji otherwise it breaks the emoji representation
• could not see any difference in your wordwrap example

[Ashwolaa]

A few comments to start on this huge PR:

• when there is only one elt in the proposed choices (from the pattern filtering) it would be nice to just press enter to use it. As it is, one has to use the down arrow key or the mouse click

I agree, I changed it to have a behavior close to an IDE. The first item proposed is selected by default. Pressing Enter/Tab will autocomplete it (Tab only works well with QPlainText though)

• for emoji, you should include a space just after the emoji otherwise it breaks the emoji representation

I removed them and I changed the example with more standard Unicodes. The issue with the emojis is that they consist of multiple characters which make the whole identification struggle.

• could not see any difference in your wordwrap example

I updated the example, it should be more explanatory now.

[seb5g]

@malik-irain could you have a go to check this as well and merge it if it is fine. We have to move on to the monorepo ...

[malik-irain]

I know that's what's the doc says about subclassing WidgetParameterItem but I would be careful about monkeypatching qt methods as it already made tests fails without any apparent reason. I would have implemented a value attribute and a setValue method in PatternPlainTextEdit widget that call toPlainText and setPlainText. For the signal, it might be tricky.

Anyways for now, it works so we can leave it like that

[Ashwolaa]

I can add this if you think it is better. There is no impact on the tests.

Not sure, how to deal with the signal though.

[Ashwolaa]

Claude calls it "Duck typing adapter"

[malik-irain]

Yeah it works very well in python, but when using objects from C++ it can lead to segmentation faults (we had the issue recently), but as it doesn't seem to make tests fail, it's ok with me!

[malik-irain]

@Ashwolaa Can you rebase or merge the last modification of pymodaq_gui in you PR so that I can see if tests are passing?

[Ashwolaa]

Pattern completer subpart of PR#105:

This PR contains:

• the PatternCompleter class which can be used with QTextEdit/QLineEdit/QPlainTextEdit, resulting in PatternTextEdit/PatternLineEdit/PatternPlainTextEdit
  See pattern_completer_demo.py in examples for some demonstration.
• the PatternParameter which makes use of the PatternCompleter class. It provides a QPlainTextEdit making it similar to the usual parameter item but with the PatternCompleter methods.
  See parameter_ex.py in examples for an application

[codecov]

Codecov Report

❌ Patch coverage is 50.00000% with 284 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.39%. Comparing base (19a66e8) to head (000a12d).
⚠️ Report is 23 commits behind head on 5.0.x_dev.

Files with missing lines	Patch %	Lines
...modaq_gui/parameter/pymodaq_ptypes/text_pattern.py	29.49%	153 Missing ⚠️
src/pymodaq_gui/utils/widgets/pattern_completer.py	61.86%	127 Missing ⚠️
src/pymodaq_gui/parameter/ioxml.py	75.00%	4 Missing ⚠️

Additional details and impacted files

@@ Coverage Diff @@## 5.0.x_dev #109 +/- ##
=============================================
- Coverage 64.22% 63.39% -0.84% 
=============================================
Files 73 75 +2 Lines 9201 9768 +567 =============================================
+ Hits 5909 6192 +283 - Misses 3292 3576 +284 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[seb5g]

A few comments to start on this huge PR:

• when there is only one elt in the proposed choices (from the pattern filtering) it would be nice to just press enter to use it. As it is, one has to use the down arrow key or the mouse click
• for emoji, you should include a space just after the emoji otherwise it breaks the emoji representation
• could not see any difference in your wordwrap example

[Ashwolaa]

A few comments to start on this huge PR:

• when there is only one elt in the proposed choices (from the pattern filtering) it would be nice to just press enter to use it. As it is, one has to use the down arrow key or the mouse click

I agree, I changed it to have a behavior close to an IDE. The first item proposed is selected by default. Pressing Enter/Tab will autocomplete it (Tab only works well with QPlainText though)

• for emoji, you should include a space just after the emoji otherwise it breaks the emoji representation

I removed them and I changed the example with more standard Unicodes. The issue with the emojis is that they consist of multiple characters which make the whole identification struggle.

• could not see any difference in your wordwrap example

I updated the example, it should be more explanatory now.

[seb5g]

@malik-irain could you have a go to check this as well and merge it if it is fine. We have to move on to the monorepo ...

[malik-irain]

I know that's what's the doc says about subclassing WidgetParameterItem but I would be careful about monkeypatching qt methods as it already made tests fails without any apparent reason. I would have implemented a value attribute and a setValue method in PatternPlainTextEdit widget that call toPlainText and setPlainText. For the signal, it might be tricky.

Anyways for now, it works so we can leave it like that

[Ashwolaa]

I can add this if you think it is better. There is no impact on the tests.

Not sure, how to deal with the signal though.

[Ashwolaa]

Claude calls it "Duck typing adapter"

[malik-irain]

Yeah it works very well in python, but when using objects from C++ it can lead to segmentation faults (we had the issue recently), but as it doesn't seem to make tests fail, it's ok with me!

[malik-irain]

@Ashwolaa Can you rebase or merge the last modification of pymodaq_gui in you PR so that I can see if tests are passing?