fix(telemetry): emit the pfc_ event prefix the ingest service routes on

[elkaix]

Related Issue

No issue — found while auditing the telemetry path before cutting a release.

Problem

The telemetry ingest service selects crash reports by an exact event name and its
dashboards query events by prefix. The client was emitting a different prefix than
the one the service routes on, so:

• every crash report was silently dropped at ingest instead of reaching the error tracker;
• ordinary events landed in storage but were invisible to every dashboard panel;
• crashes were recorded at INFO severity rather than ERROR.

Nothing failed loudly — the ingest endpoint returns 200 {ok:true} regardless — so
the client looked healthy while reporting nothing usable.

What changed

• packages/telemetry/src/transport.ts and
  packages/agent-core-v2/src/app/telemetry/cloudTransport.ts emit the prefix the
  ingest service actually routes on, for both the event name and the payload user id.
• Both constants now carry JSDoc naming them as a wire contract, so a future edit has
  to acknowledge what depends on them.
• The existing prefix-locking tests were the mechanism that caught this; they now
  assert the correct value and fail if either constant drifts again.

Verified: packages/telemetry 72/72 and the packages/agent-core-v2 telemetry suites
39/39 pass; a repo-wide search finds no remaining use of the old prefix.

[skip changeset] — this fixes an internal reporting path with no user-visible behavior.

Checklist

• I have read the CONTRIBUTING document.
• I have linked a related issue (external PRs: the issue must have a maintainer's /approve).
• I have added tests that prove my feature works.
• Ran gen-changesets skill, or this PR needs no changeset.
• Ran gen-docs skill, or this PR needs no doc update.

Summary by CodeRabbit

• Bug Fixes

  • Restored telemetry events and active device reporting in observability dashboards.
  • Corrected telemetry identifiers to use the current event and device ID naming format.

• Tests

  • Updated telemetry validation to confirm correct event names, user identifiers, retries, fallbacks, and initialization behavior.

• Release

  • Included a patch release for the code package.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 4483df96-deb9-4964-bdcc-dc3c58c83c1e

📥 Commits

Reviewing files that changed from the base of the PR and between 496169d and b5ead8b.

📒 Files selected for processing (5)

• .changeset/fix-telemetry-dashboard.md
• packages/agent-core-v2/src/app/telemetry/cloudTransport.ts
• packages/agent-core-v2/test/app/telemetry/cloudAppender.test.ts
• packages/telemetry/src/transport.ts
• packages/telemetry/test/telemetry.test.ts

Included review availability: Your plan provides up to 10 included reviews per hour; 6 remain after this review.

---

📝 Walkthrough

Walkthrough

Telemetry transport prefixes changed from kfc_ to pfc_ and from kfc_device_id_ to pfc_device_id_. Agent and package tests now validate the new prefixes. A patch Changeset records the telemetry dashboard update.

Changes

Telemetry Prefix Restoration

Layer / File(s)	Summary
Update telemetry transport prefixes packages/agent-core-v2/src/app/telemetry/cloudTransport.ts, packages/telemetry/src/transport.ts	The exported event and device identity prefixes now use pfc_ and pfc_device_id_.
Align telemetry validation and release metadata packages/agent-core-v2/test/app/telemetry/cloudAppender.test.ts, packages/telemetry/test/telemetry.test.ts, .changeset/fix-telemetry-dashboard.md	Telemetry tests expect the updated prefixes across payload, transport, retry, fallback, and bootstrap cases. The Changeset records a patch release.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk:⚪ Minimal · up to b5ead

This localized telemetry prefix correction is merge-ready after normal checks and review; no actionable merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title uses the required fix prefix, stays within 72 characters, uses imperative mood, and accurately describes the telemetry prefix correction.
Description check	✅ Passed	The description includes all template sections, explains the problem and solution, documents testing, and completes the checklist.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 4 files. (1 skipped: 1 unsupported.)
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

---

_{Comment @coderabbitai help to get the list of available commands.}

[pkg-pr-new]

pnpm dlx https://pkg.pr.new/@pymodel/pythinker-code@b5ead8b

npx https://pkg.pr.new/@pymodel/pythinker-code@b5ead8b

commit: b5ead8b