Uh oh!
There was an error while loading. Please reload this page.
feat: reconcile reminders and complete desktop update channels - #185
Merged
Conversation
Unify reminder activation and system prompts under one agent runtime. Keep lifecycle context active until asynchronous scope teardown finishes. Install gateway process handlers only after startup succeeds.
Expose update status, channel selection, automatic checks, and notifications in a dedicated desktop settings tab. Keep download and installation behind explicit user actions.
Point desktop users to the dedicated Update tab and document channel and notification controls.
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (197)
📝 WalkthroughWalkthroughThe changes add Stable, Beta, and Nightly desktop release flows and update controls. They introduce a lifecycle-owned reminder runtime, asynchronous dependency disposal, process failure handlers, incomplete-turn resume coverage, generated web assets, and related tests and documentation. ChangesDesktop release channels
Desktop update preferences
Reminder runtime and lifecycle disposal
Generated web assets
Server and resume reliability
Estimated code review effort: 5 (Critical) | ~120 minutes Warning Some tools did not complete. Review the errors below. 🔧 ast-grep (0.45.2)apps/pythinker-code/dist-web/assets/cynefin-OW5HDTMX-l1QOd-xU.jsast-grep timed out on this file apps/pythinker-code/dist-web/assets/chunk-F27PBJKO-CqXmbFOg.jsast-grep did not scan this file: retry isolation stopped after a systemic timeout or after exhausting the retry isolation budget apps/pythinker-code/dist-web/assets/chunk-G27WJ6UU-BjElWXp6.jsast-grep did not scan this file: retry isolation stopped after a systemic timeout or after exhausting the retry isolation budget
Comment |
commit: |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
elkaix
commented
Aug 25, 2026
MemberAuthor
Resolved the three semicolon-insertion findings because they target minified Vite output under |
elkaix
commented
Aug 25, 2026
MemberAuthor
Action performedReview triggered.
|
Complete BN3-BN5 from the desktop release plan. Use explicit update channels and reuse the signed draft-first workflow so Beta tags and scheduled Nightly builds produce verifiable update manifests.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
elkaix
commented
Aug 25, 2026
MemberAuthor
@coderabbitai review |
Action performedReview triggered.
|
elkaix
commented
Aug 25, 2026
MemberAuthor
The three new semicolon-insertion findings again target minified Vite output regenerated by |
Uh oh!
There was an error while loading. Please reload this page.
Merged
elkaix pushed a commit
that referenced
this pull request
Aug 25, 2026
This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## @pymodel/pythinker-code@1.3.1 ### Patch Changes - [#186](#186) [`50f1437`](50f1437) Thanks [@elkaix](https://github.com/elkaix)! - Make task output copy-path actions visually distinct. - [#186](#186) [`50f1437`](50f1437) Thanks [@elkaix](https://github.com/elkaix)! - Fix chat prompt anchors to use a connected timeline beside the sidebar with keyboard navigation. - [#186](#186) [`50f1437`](50f1437) Thanks [@elkaix](https://github.com/elkaix)! - Fix the chat composer so model and thinking-effort menus open separately. - [#186](#186) [`50f1437`](50f1437) Thanks [@elkaix](https://github.com/elkaix)! - Pause active goals during automatic context compaction and resume them after compaction succeeds. - [#185](#185) [`283020c`](283020c) Thanks [@elkaix](https://github.com/elkaix)! - Fix repeated server crashes when resuming a session that stopped during a turn. ## @pymodel/pythinker-desktop@0.3.0 ### Minor Changes - [#185](#185) [`283020c`](283020c) Thanks [@elkaix](https://github.com/elkaix)! - Add signed Beta and Nightly desktop update feeds. Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
No linked issue. This is a maintainer-directed repository update.
Problem
Reminder context and system reminders used separate runtime services, and agent teardown could deactivate lifecycle context before asynchronous scope cleanup finished. The desktop Update UI exposed Stable, Beta, and Nightly choices, but only Stable had a complete signed publication path.
What changed
latest,beta, andnightlyelectron-builder feeds through one signed, notarized, draft-first workflow. Stable and Beta use reviewed tags; scheduled Nightly derives a deterministic version from the exactmaincommit.Automatic download, quit-time installation, and downgrade remain disabled. Manual workflow dispatches are non-publishing release rehearsals.
Review guide
5c38b192e— reminder runtime consolidation, lifecycle teardown, gateway startup, SDK, and focused tests.0ae46cb97— desktop updater state and IPC, dedicated Update tab, UI tests, and generated web assets.57bb4e4d1— desktop update documentation.7403218f1— signed Beta and Nightly feeds, manifest verification, reconciliation, tests, docs, and updated web assets.Activation state
desktop-v*tags.desktop-v<version>-beta.<n>tag.Verification
pnpm test— 1,215 files passed; 20,321 tests passed; 3 expected failures; 79 skipped; 2 todo.pnpm test:release— 19 tests passed.pnpm typecheckpnpm lint— 0 errors; existing warnings only.pnpm buildnix build .#pythinker-codenode scripts/check-nix-workspace.mjs— 18 workspaces.node apps/pythinker-code/scripts/check-web-assets.mjs— 670 bundle entries validated.pnpm sherifpnpm -C docs run buildactionlint1.7.12 on both changed workflows.Checklist
gen-changesets; this PR includes an approved minor desktop changeset.gen-docs; the desktop and release-channel guides are updated. Changelog sync is deferred until release.Summary by CodeRabbit
New Features
Bug Fixes
Documentation