Uh oh!
There was an error while loading. Please reload this page.
ci: update ffi-check for PyPy symbol mangling change - #6389
Open
davidhewitt wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per pypy/binary-testing#55 (comment) this updates ffi-check to confirm that symbols are being resolved properly for PyPy ahead of the change in PyPy 3.12 to support abi3 by removing the special
PyPyprefix from many functions.I make this practical by forcing pyo3-ffi-check to resolve actual addresses of all functions and check they match the pypy headers.