Skip to content

Improve filename consistency in the sources - #178

Closed
tgilon wants to merge 10 commits into
PyPSA:masterfrom
open-energy-transition:fix-fn-consistency
Closed

Improve filename consistency in the sources#178
tgilon wants to merge 10 commits into
PyPSA:masterfrom
open-energy-transition:fix-fn-consistency

Conversation

@tgilon

@tgilontgilon commented Feb 6, 2025

Copy link
Copy Markdown
Contributor

Changes proposed in this Pull Request

This PR proposes to improve the filename consistency in the sources, using the top-level folder as a reference.

Checklist

  • Code changes are sufficiently documented; i.e. new functions contain docstrings and further explanations may be given in doc.
  • Data source for new technologies is clearly stated.
  • Newly introduced dependencies are added to environment.yaml (if applicable).
  • A note for the release notes doc/release_notes.rst of the upcoming release is included.
  • I consent to the release of this PR's code under the GPLv3 license.

@tgilontgilon changed the title Improve file name consistency in the sourcesImprove filename consistency in the sourcesFeb 6, 2025
@tgilon
tgilon marked this pull request as ready for review February 6, 2025 09:32

@fneumfneum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lkstrp

Copy link
Copy Markdown
Member

This needs some wild merge conflict resolution and then is good to go @finozzifa ?

@finozzifa

finozzifa commented Mar 6, 2025

Copy link
Copy Markdown
Contributor

This needs some wild merge conflict resolution and then is good to go @finozzifa ?

Hi @lkstrp I guess so. I think we should ask @tgilon what his opinion is though.

Thanks!!!

@tgilon

Copy link
Copy Markdown
ContributorAuthor

@lkstrp I've fixed the conflicts

@lkstrp

Copy link
Copy Markdown
Member

There is still a small pre-commit issue that cannot be resolved since you are merging from an org account, I think. Maybe something that makes sense to change in your org settings

@tgilon

Copy link
Copy Markdown
ContributorAuthor

There is still a small pre-commit issue that cannot be resolved since you are merging from an org account, I think. Maybe something that makes sense to change in your org settings

I've fixed it manually for now. I'll look into how to enable it.

@tgilon
tgilon deleted the fix-fn-consistency branch March 11, 2025 11:54
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@tgilon@lkstrp@finozzifa@fneum