Skip to content

Raise when data is both specification and section - #120

Merged
leonlan merged 2 commits into
mainfrom
raise-duplicate-specification-section
Jun 24, 2024
Merged

Raise when data is both specification and section#120
leonlan merged 2 commits into
mainfrom
raise-duplicate-specification-section

Conversation

@leonlan

Copy link
Copy Markdown
Member

This PR raises errors when parsing VRPLIB instances that uses the same keyword as specification and data section.

@leonlan
leonlan requested review from N-WoudaJune 24, 2024 17:58
Comment on lines +241 to +244
"SERVICE_TIME: 10",
"SERVICE_TIME_SECTION",
"1 20",
"2 20",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens when the section comes before the specification? Does that also raise?

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That raises an error, but it's not related to sections coming before specifications. I think we should be strict and add that too. I'll do that in another PR

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that works

@leonlan
leonlan merged commit 9c99a4b into mainJun 24, 2024
@leonlan
leonlan deleted the raise-duplicate-specification-section branch June 24, 2024 18:21
@leonlanleonlan mentioned this pull request Jun 24, 2024
17 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@leonlan@N-Wouda