Add linter#687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rgommers merged 9 commits into from
Mar 8, 2024
Merged

Add linter #687

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
058856b
Use ruff pre-commit
jarrodmillman Sep 8, 2023
d531f66
Run flynt
jarrodmillman Sep 14, 2023
bb1d188
Run pre-commit run -a
jarrodmillman Sep 14, 2023
c5279ec
Tell git to ignore linting noise
jarrodmillman Sep 18, 2023
96ad4a8
Add linter to CI
jarrodmillman Sep 14, 2023
a28c6fd
Incorporate cclauss feedback
jarrodmillman Sep 17, 2023
556e9d3
Merge branch 'master' into ruff
rgommers Mar 8, 2024
a8f9792
MAINT: fix new warnings with latest `ruff` version
rgommers Mar 8, 2024
54ddd0d
CI: upgrade ruff to latest (0.3.1) and fix two minor tool nits
rgommers Mar 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .coveragerc
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,4 +10,4 @@ omit =
*/pywt/data/create_dat.py
*.pxd
stringsource
plugins = Cython.Coverage
plugins = Cython.Coverage
2 changes: 2 additions & 0 deletions .git-blame-ignore-revs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
# .git-blame-ignore-revs
# Applied codespell to the codebase
5ce73c91800829950474aaa4f4036b2a589a2418
d531f668d60503d55387d7d0ffae4afd199c5f80
bb1d1888fd63381ce35805e0cb3623a8bd47163c
4 changes: 2 additions & 2 deletions .github/workflows/emscripten.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -27,7 +27,7 @@ jobs:
id: setup-python
uses: actions/setup-python@v2
with:
python-version: '3.11.2'
python-version: "3.11.2"

- name: Install prerequisites
run: |
Expand All@@ -43,7 +43,7 @@ jobs:
- name: Set up Node.js
uses: actions/setup-node@v4.0.2
with:
node-version: '18'
node-version: "18"

- name: Build PyWavelets
run: |
Expand Down
31 changes: 31 additions & 0 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
name: style

on: [push, pull_request]

concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
cancel-in-progress: true

jobs:
format:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: ["3.11"]

steps:
- uses: actions/checkout@v4

- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v4
with:
python-version: ${{ matrix.python-version }}

- name: Install packages
run: |
pip install --upgrade pip
pip install pre-commit
pip list

- name: Lint
run: pre-commit run --all-files --show-diff-on-failure --color always
164 changes: 81 additions & 83 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,6 @@ on:
- v1.**

jobs:

test_pywavelets_linux:
name: linux-cp${{ matrix.python-version }}-${{ matrix.OPTIONS_NAME }}
runs-on: ubuntu-latest
Expand All@@ -27,7 +26,7 @@ jobs:
# Ensure that a wheel builder finishes even if another fails
fail-fast: false
matrix:
python-version: [3.9, '3.10', '3.11', '3.12']
python-version: [3.9, "3.10", "3.11", "3.12"]
MINIMUM_REQUIREMENTS: [0]
USE_SCIPY: [0]
USE_SDIST: [0]
Expand All@@ -48,7 +47,7 @@ jobs:
USE_SDIST: 1
OPTIONS_NAME: "install-from-sdist"
- platform_id: manylinux_x86_64
python-version: '3.12'
python-version: "3.12"
PIP_FLAGS: "--pre"
OPTIONS_NAME: "pre-releases"

Expand All@@ -64,32 +63,32 @@ jobs:

- name: Build package
env:
VERSION: ${{ matrix.python-version }}
MINIMUM_REQUIREMENTS: ${{ matrix.MINIMUM_REQUIREMENTS }}
PIP_FLAGS: ${{ matrix.PIP_FLAGS }}
USE_SDIST: ${{ matrix.USE_SDIST }}
USE_SCIPY: ${{ matrix.USE_SCIPY }}
REFGUIDE_CHECK: ${{ matrix.REFGUIDE_CHECK }}
VERSION: ${{ matrix.python-version }}
MINIMUM_REQUIREMENTS: ${{ matrix.MINIMUM_REQUIREMENTS }}
PIP_FLAGS: ${{ matrix.PIP_FLAGS }}
USE_SDIST: ${{ matrix.USE_SDIST }}
USE_SCIPY: ${{ matrix.USE_SCIPY }}
REFGUIDE_CHECK: ${{ matrix.REFGUIDE_CHECK }}
run: |
uname -a
df -h
ulimit -a
# ccache -s
which python
python --version
# sudo apt-get install libatlas-base-dev
pip install --upgrade pip build
# Set numpy version first, other packages link against it
if [ "${MINIMUM_REQUIREMENTS}" == "1" ]; then
pip install ${CYTHON_MIN}
pip install ${NUMPY_MIN}
if [ "${USE_SCIPY}" == "1" ]; then pip install ${SCIPY_MIN}; fi
else
pip install ${PIP_FLAGS} cython
pip install ${PIP_FLAGS} numpy
if [ "${USE_SCIPY}" == "1" ]; then pip install ${PIP_FLAGS} scipy; fi
fi
pip install ${PIP_FLAGS} matplotlib pytest
uname -a
df -h
ulimit -a
# ccache -s
which python
python --version
# sudo apt-get install libatlas-base-dev
pip install --upgrade pip build
# Set numpy version first, other packages link against it
if [ "${MINIMUM_REQUIREMENTS}" == "1" ]; then
pip install ${CYTHON_MIN}
pip install ${NUMPY_MIN}
if [ "${USE_SCIPY}" == "1" ]; then pip install ${SCIPY_MIN}; fi
else
pip install ${PIP_FLAGS} cython
pip install ${PIP_FLAGS} numpy
if [ "${USE_SCIPY}" == "1" ]; then pip install ${PIP_FLAGS} scipy; fi
fi
pip install ${PIP_FLAGS} matplotlib pytest

set -o pipefail
if [ "${USE_SDIST}" == "1" ]; then
Expand All@@ -104,22 +103,21 @@ jobs:

- name: Run tests
env:
USE_SDIST: ${{ matrix.USE_SDIST }}
REFGUIDE_CHECK: ${{ matrix.REFGUIDE_CHECK }}
USE_SDIST: ${{ matrix.USE_SDIST }}
REFGUIDE_CHECK: ${{ matrix.REFGUIDE_CHECK }}
run: |
set -o pipefail
# Move out of source directory to avoid finding local pywt
pushd demo
if [ "${USE_SDIST}" == "1" ]; then
pytest --pyargs pywt
python ../pywt/tests/test_doc.py
elif [ "${REFGUIDE_CHECK}" == "1" ]; then
python util/refguide_check.py --doctests
else
pytest --pyargs pywt
fi
popd

set -o pipefail
# Move out of source directory to avoid finding local pywt
pushd demo
if [ "${USE_SDIST}" == "1" ]; then
pytest --pyargs pywt
python ../pywt/tests/test_doc.py
elif [ "${REFGUIDE_CHECK}" == "1" ]; then
python util/refguide_check.py --doctests
else
pytest --pyargs pywt
fi
popd

test_pywavelets_macos:
name: macos-cp${{ matrix.python-version }}-${{ matrix.OPTIONS_NAME }}
Expand All@@ -136,18 +134,18 @@ jobs:
# Ensure that a wheel builder finishes even if another fails
fail-fast: false
matrix:
python-version: [3.9, '3.12']
python-version: [3.9, "3.12"]
MINIMUM_REQUIREMENTS: [0]
USE_SCIPY: [0]
USE_SDIST: [0]
REFGUIDE_CHECK: [0]
PIP_FLAGS: [""]
OPTIONS_NAME: ["default"]
include:
- python-version: '3.9'
- python-version: "3.9"
MINIMUM_REQUIREMENTS: 1
OPTIONS_NAME: "osx-minimum-req"
- python-version: '3.12'
- python-version: "3.12"
PIP_FLAGS: "--pre"
OPTIONS_NAME: "pre-releases"

Expand All@@ -163,30 +161,30 @@ jobs:

- name: Build package
env:
VERSION: ${{ matrix.python-version }}
MINIMUM_REQUIREMENTS: ${{ matrix.MINIMUM_REQUIREMENTS }}
PIP_FLAGS: ${{ matrix.PIP_FLAGS }}
USE_SDIST: ${{ matrix.USE_SDIST }}
USE_SCIPY: ${{ matrix.USE_SCIPY }}
REFGUIDE_CHECK: ${{ matrix.REFGUIDE_CHECK }}
CC: /usr/bin/clang
CXX: /usr/bin/clang++
VERSION: ${{ matrix.python-version }}
MINIMUM_REQUIREMENTS: ${{ matrix.MINIMUM_REQUIREMENTS }}
PIP_FLAGS: ${{ matrix.PIP_FLAGS }}
USE_SDIST: ${{ matrix.USE_SDIST }}
USE_SCIPY: ${{ matrix.USE_SCIPY }}
REFGUIDE_CHECK: ${{ matrix.REFGUIDE_CHECK }}
CC: /usr/bin/clang
CXX: /usr/bin/clang++
run: |
uname -a
df -h
ulimit -a
which python
python --version
pip install --upgrade pip build
# Set numpy version first, other packages link against it
if [ "${MINIMUM_REQUIREMENTS}" == "1" ]; then
pip install ${CYTHON_MIN} ${NUMPY_MIN}
if [ "${USE_SCIPY}" == "1" ]; then pip install ${SCIPY_MIN}; fi
else
pip install ${PIP_FLAGS} cython numpy
if [ "${USE_SCIPY}" == "1" ]; then pip install ${PIP_FLAGS} scipy; fi
fi
pip install ${PIP_FLAGS} matplotlib pytest
uname -a
df -h
ulimit -a
which python
python --version
pip install --upgrade pip build
# Set numpy version first, other packages link against it
if [ "${MINIMUM_REQUIREMENTS}" == "1" ]; then
pip install ${CYTHON_MIN} ${NUMPY_MIN}
if [ "${USE_SCIPY}" == "1" ]; then pip install ${SCIPY_MIN}; fi
else
pip install ${PIP_FLAGS} cython numpy
if [ "${USE_SCIPY}" == "1" ]; then pip install ${PIP_FLAGS} scipy; fi
fi
pip install ${PIP_FLAGS} matplotlib pytest

set -o pipefail
if [ "${USE_SDIST}" == "1" ]; then
Expand All@@ -201,18 +199,18 @@ jobs:

- name: Run tests
env:
PIP_FLAGS: ${{ matrix.PIP_FLAGS }}
USE_SDIST: ${{ matrix.USE_SDIST }}
REFGUIDE_CHECK: ${{ matrix.REFGUIDE_CHECK }}
PIP_FLAGS: ${{ matrix.PIP_FLAGS }}
USE_SDIST: ${{ matrix.USE_SDIST }}
REFGUIDE_CHECK: ${{ matrix.REFGUIDE_CHECK }}
run: |
# Move out of source directory to avoid finding local pywt
pushd demo
if [ "${USE_SDIST}" == "1" ]; then
pytest --pyargs pywt
python ../pywt/tests/test_doc.py
elif [ "${REFGUIDE_CHECK}" == "1" ]; then
python util/refguide_check.py --doctests
else
pytest --pyargs pywt
fi
popd
# Move out of source directory to avoid finding local pywt
pushd demo
if [ "${USE_SDIST}" == "1" ]; then
pytest --pyargs pywt
python ../pywt/tests/test_doc.py
elif [ "${REFGUIDE_CHECK}" == "1" ]; then
python util/refguide_check.py --doctests
else
pytest --pyargs pywt
fi
popd
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Add linter#687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

rgommers
merged 9 commits into

from

Mar 8, 2024
 Merged


Add linter
#687
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


9 commits


Select commit
Hold shift + click to select a range
058856b

Use ruff pre-commit


jarrodmillman Sep 8, 2023
d531f66

Run flynt


jarrodmillman Sep 14, 2023
bb1d188

Run pre-commit run -a


jarrodmillman Sep 14, 2023
c5279ec

Tell git to ignore linting noise


jarrodmillman Sep 18, 2023
96ad4a8

Add linter to CI


jarrodmillman Sep 14, 2023
a28c6fd

Incorporate cclauss feedback


jarrodmillman Sep 17, 2023
556e9d3

Merge branch 'master' into ruff


rgommers Mar 8, 2024
a8f9792

MAINT: fix new warnings with latest `ruff` version


rgommers Mar 8, 2024
54ddd0d

CI: upgrade ruff to latest (0.3.1) and fix two minor tool nits


rgommers Mar 8, 2024

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
.coveragerc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,4 +10,4 @@ omit =
 */pywt/data/create_dat.py
 *.pxd
 stringsource
plugins = Cython.Coverage
plugins = Cython.Coverage

2 changes: 2 additions & 0 deletions
.git-blame-ignore-revs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
# .git-blame-ignore-revs
# Applied codespell to the codebase
5ce73c91800829950474aaa4f4036b2a589a2418
d531f668d60503d55387d7d0ffae4afd199c5f80
bb1d1888fd63381ce35805e0cb3623a8bd47163c

4 changes: 2 additions & 2 deletions
.github/workflows/emscripten.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -27,7 +27,7 @@ jobs:
 id: setup-python
 uses: actions/setup-python@v2
 with:
 python-version: '3.11.2'
 python-version: "3.11.2"

 - name: Install prerequisites
 run: |
Expand All@@ -43,7 +43,7 @@ jobs:
 - name: Set up Node.js
 uses: actions/setup-node@v4.0.2
 with:
 node-version: '18'
 node-version: "18"

 - name: Build PyWavelets
 run: |
Expand Down

31 changes: 31 additions & 0 deletions
.github/workflows/lint.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
name: style

on: [push, pull_request]

concurrency:
 group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
 cancel-in-progress: true

jobs:
 format:
 runs-on: ubuntu-latest
 strategy:
 matrix:
 python-version: ["3.11"]

 steps:
 - uses: actions/checkout@v4

 - name: Set up Python ${{ matrix.python-version }}
 uses: actions/setup-python@v4
 with:
 python-version: ${{ matrix.python-version }}

 - name: Install packages
 run: |
 pip install --upgrade pip
 pip install pre-commit
 pip list

 - name: Lint
 run: pre-commit run --all-files --show-diff-on-failure --color always

164 changes: 81 additions & 83 deletions
.github/workflows/tests.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,6 @@ on:
 - v1.**

jobs:

 test_pywavelets_linux:
 name: linux-cp${{ matrix.python-version }}-${{ matrix.OPTIONS_NAME }}
 runs-on: ubuntu-latest
Expand All@@ -27,7 +26,7 @@ jobs:
 # Ensure that a wheel builder finishes even if another fails
 fail-fast: false
 matrix:
 python-version: [3.9, '3.10', '3.11', '3.12']
 python-version: [3.9, "3.10", "3.11", "3.12"]
 MINIMUM_REQUIREMENTS: [0]
 USE_SCIPY: [0]
 USE_SDIST: [0]
Expand All@@ -48,7 +47,7 @@ jobs:
 USE_SDIST: 1
 OPTIONS_NAME: "install-from-sdist"
 - platform_id: manylinux_x86_64
 python-version: '3.12'
 python-version: "3.12"
 PIP_FLAGS: "--pre"
 OPTIONS_NAME: "pre-releases"

Expand All@@ -64,32 +63,32 @@ jobs:

 - name: Build package
 env:
VERSION: ${{ matrix.python-version }}
MINIMUM_REQUIREMENTS: ${{ matrix.MINIMUM_REQUIREMENTS }}
PIP_FLAGS: ${{ matrix.PIP_FLAGS }}
USE_SDIST: ${{ matrix.USE_SDIST }}
USE_SCIPY: ${{ matrix.USE_SCIPY }}
REFGUIDE_CHECK: ${{ matrix.REFGUIDE_CHECK }}
 VERSION: ${{ matrix.python-version }}
 MINIMUM_REQUIREMENTS: ${{ matrix.MINIMUM_REQUIREMENTS }}
 PIP_FLAGS: ${{ matrix.PIP_FLAGS }}
 USE_SDIST: ${{ matrix.USE_SDIST }}
 USE_SCIPY: ${{ matrix.USE_SCIPY }}
 REFGUIDE_CHECK: ${{ matrix.REFGUIDE_CHECK }}
 run: |
uname -a
df -h
ulimit -a
# ccache -s
which python
python --version
# sudo apt-get install libatlas-base-dev
pip install --upgrade pip build
# Set numpy version first, other packages link against it
if [ "${MINIMUM_REQUIREMENTS}" == "1" ]; then
pip install ${CYTHON_MIN}
pip install ${NUMPY_MIN}
if [ "${USE_SCIPY}" == "1" ]; then pip install ${SCIPY_MIN}; fi
else
pip install ${PIP_FLAGS} cython
pip install ${PIP_FLAGS} numpy
if [ "${USE_SCIPY}" == "1" ]; then pip install ${PIP_FLAGS} scipy; fi
fi
pip install ${PIP_FLAGS} matplotlib pytest
 uname -a
 df -h
 ulimit -a
 # ccache -s
 which python
 python --version
 # sudo apt-get install libatlas-base-dev
 pip install --upgrade pip build
 # Set numpy version first, other packages link against it
 if [ "${MINIMUM_REQUIREMENTS}" == "1" ]; then
 pip install ${CYTHON_MIN}
 pip install ${NUMPY_MIN}
 if [ "${USE_SCIPY}" == "1" ]; then pip install ${SCIPY_MIN}; fi
 else
 pip install ${PIP_FLAGS} cython
 pip install ${PIP_FLAGS} numpy
 if [ "${USE_SCIPY}" == "1" ]; then pip install ${PIP_FLAGS} scipy; fi
 fi
 pip install ${PIP_FLAGS} matplotlib pytest

 set -o pipefail
 if [ "${USE_SDIST}" == "1" ]; then
Expand All@@ -104,22 +103,21 @@ jobs:

 - name: Run tests
 env:
USE_SDIST: ${{ matrix.USE_SDIST }}
REFGUIDE_CHECK: ${{ matrix.REFGUIDE_CHECK }}
 USE_SDIST: ${{ matrix.USE_SDIST }}
 REFGUIDE_CHECK: ${{ matrix.REFGUIDE_CHECK }}
 run: |
 set -o pipefail
 # Move out of source directory to avoid finding local pywt
 pushd demo
 if [ "${USE_SDIST}" == "1" ]; then
 pytest --pyargs pywt
 python ../pywt/tests/test_doc.py
 elif [ "${REFGUIDE_CHECK}" == "1" ]; then
 python util/refguide_check.py --doctests
 else
 pytest --pyargs pywt
 fi
 popd

 set -o pipefail
 # Move out of source directory to avoid finding local pywt
 pushd demo
 if [ "${USE_SDIST}" == "1" ]; then
 pytest --pyargs pywt
 python ../pywt/tests/test_doc.py
 elif [ "${REFGUIDE_CHECK}" == "1" ]; then
 python util/refguide_check.py --doctests
 else
 pytest --pyargs pywt
 fi
 popd

 test_pywavelets_macos:
 name: macos-cp${{ matrix.python-version }}-${{ matrix.OPTIONS_NAME }}
Expand All@@ -136,18 +134,18 @@ jobs:
 # Ensure that a wheel builder finishes even if another fails
 fail-fast: false
 matrix:
 python-version: [3.9, '3.12']
 python-version: [3.9, "3.12"]
 MINIMUM_REQUIREMENTS: [0]
 USE_SCIPY: [0]
 USE_SDIST: [0]
 REFGUIDE_CHECK: [0]
 PIP_FLAGS: [""]
 OPTIONS_NAME: ["default"]
 include:
 - python-version: '3.9'
 - python-version: "3.9"
 MINIMUM_REQUIREMENTS: 1
 OPTIONS_NAME: "osx-minimum-req"
 - python-version: '3.12'
 - python-version: "3.12"
 PIP_FLAGS: "--pre"
 OPTIONS_NAME: "pre-releases"

Expand All@@ -163,30 +161,30 @@ jobs:

 - name: Build package
 env:
VERSION: ${{ matrix.python-version }}
MINIMUM_REQUIREMENTS: ${{ matrix.MINIMUM_REQUIREMENTS }}
PIP_FLAGS: ${{ matrix.PIP_FLAGS }}
USE_SDIST: ${{ matrix.USE_SDIST }}
USE_SCIPY: ${{ matrix.USE_SCIPY }}
REFGUIDE_CHECK: ${{ matrix.REFGUIDE_CHECK }}
CC: /usr/bin/clang
CXX: /usr/bin/clang++
 VERSION: ${{ matrix.python-version }}
 MINIMUM_REQUIREMENTS: ${{ matrix.MINIMUM_REQUIREMENTS }}
 PIP_FLAGS: ${{ matrix.PIP_FLAGS }}
 USE_SDIST: ${{ matrix.USE_SDIST }}
 USE_SCIPY: ${{ matrix.USE_SCIPY }}
 REFGUIDE_CHECK: ${{ matrix.REFGUIDE_CHECK }}
 CC: /usr/bin/clang
 CXX: /usr/bin/clang++
 run: |
uname -a
df -h
ulimit -a
which python
python --version
pip install --upgrade pip build
# Set numpy version first, other packages link against it
if [ "${MINIMUM_REQUIREMENTS}" == "1" ]; then
pip install ${CYTHON_MIN} ${NUMPY_MIN}
if [ "${USE_SCIPY}" == "1" ]; then pip install ${SCIPY_MIN}; fi
else
pip install ${PIP_FLAGS} cython numpy
if [ "${USE_SCIPY}" == "1" ]; then pip install ${PIP_FLAGS} scipy; fi
fi
pip install ${PIP_FLAGS} matplotlib pytest
 uname -a
 df -h
 ulimit -a
 which python
 python --version
 pip install --upgrade pip build
 # Set numpy version first, other packages link against it
 if [ "${MINIMUM_REQUIREMENTS}" == "1" ]; then
 pip install ${CYTHON_MIN} ${NUMPY_MIN}
 if [ "${USE_SCIPY}" == "1" ]; then pip install ${SCIPY_MIN}; fi
 else
 pip install ${PIP_FLAGS} cython numpy
 if [ "${USE_SCIPY}" == "1" ]; then pip install ${PIP_FLAGS} scipy; fi
 fi
 pip install ${PIP_FLAGS} matplotlib pytest

 set -o pipefail
 if [ "${USE_SDIST}" == "1" ]; then
Expand All@@ -201,18 +199,18 @@ jobs:

 - name: Run tests
 env:
PIP_FLAGS: ${{ matrix.PIP_FLAGS }}
USE_SDIST: ${{ matrix.USE_SDIST }}
REFGUIDE_CHECK: ${{ matrix.REFGUIDE_CHECK }}
 PIP_FLAGS: ${{ matrix.PIP_FLAGS }}
 USE_SDIST: ${{ matrix.USE_SDIST }}
 REFGUIDE_CHECK: ${{ matrix.REFGUIDE_CHECK }}
 run: |
# Move out of source directory to avoid finding local pywt
pushd demo
if [ "${USE_SDIST}" == "1" ]; then
pytest --pyargs pywt
python ../pywt/tests/test_doc.py
elif [ "${REFGUIDE_CHECK}" == "1" ]; then
python util/refguide_check.py --doctests
else
pytest --pyargs pywt
fi
popd
 # Move out of source directory to avoid finding local pywt
 pushd demo
 if [ "${USE_SDIST}" == "1" ]; then
 pytest --pyargs pywt
 python ../pywt/tests/test_doc.py
 elif [ "${REFGUIDE_CHECK}" == "1" ]; then
 python util/refguide_check.py --doctests
 else
 pytest --pyargs pywt
 fi
 popd
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Add linter#687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

rgommers
merged 9 commits into

from

Mar 8, 2024
 Merged


Add linter
#687
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


9 commits


Select commit
Hold shift + click to select a range
058856b

Use ruff pre-commit


jarrodmillman Sep 8, 2023
d531f66

Run flynt


jarrodmillman Sep 14, 2023
bb1d188

Run pre-commit run -a


jarrodmillman Sep 14, 2023
c5279ec

Tell git to ignore linting noise


jarrodmillman Sep 18, 2023
96ad4a8

Add linter to CI


jarrodmillman Sep 14, 2023
a28c6fd

Incorporate cclauss feedback


jarrodmillman Sep 17, 2023
556e9d3

Merge branch 'master' into ruff


rgommers Mar 8, 2024
a8f9792

MAINT: fix new warnings with latest `ruff` version


rgommers Mar 8, 2024
54ddd0d

CI: upgrade ruff to latest (0.3.1) and fix two minor tool nits


rgommers Mar 8, 2024

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
.coveragerc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,4 +10,4 @@ omit =
 */pywt/data/create_dat.py
 *.pxd
 stringsource
plugins = Cython.Coverage
plugins = Cython.Coverage

2 changes: 2 additions & 0 deletions
.git-blame-ignore-revs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
# .git-blame-ignore-revs
# Applied codespell to the codebase
5ce73c91800829950474aaa4f4036b2a589a2418
d531f668d60503d55387d7d0ffae4afd199c5f80
bb1d1888fd63381ce35805e0cb3623a8bd47163c

4 changes: 2 additions & 2 deletions
.github/workflows/emscripten.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -27,7 +27,7 @@ jobs:
 id: setup-python
 uses: actions/setup-python@v2
 with:
 python-version: '3.11.2'
 python-version: "3.11.2"

 - name: Install prerequisites
 run: |
Expand All@@ -43,7 +43,7 @@ jobs:
 - name: Set up Node.js
 uses: actions/setup-node@v4.0.2
 with:
 node-version: '18'
 node-version: "18"

 - name: Build PyWavelets
 run: |
Expand Down

31 changes: 31 additions & 0 deletions
.github/workflows/lint.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
name: style

on: [push, pull_request]

concurrency:
 group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
 cancel-in-progress: true

jobs:
 format:
 runs-on: ubuntu-latest
 strategy:
 matrix:
 python-version: ["3.11"]

 steps:
 - uses: actions/checkout@v4

 - name: Set up Python ${{ matrix.python-version }}
 uses: actions/setup-python@v4
 with:
 python-version: ${{ matrix.python-version }}

 - name: Install packages
 run: |
 pip install --upgrade pip
 pip install pre-commit
 pip list

 - name: Lint
 run: pre-commit run --all-files --show-diff-on-failure --color always

164 changes: 81 additions & 83 deletions
.github/workflows/tests.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,6 @@ on:
 - v1.**

jobs:

 test_pywavelets_linux:
 name: linux-cp${{ matrix.python-version }}-${{ matrix.OPTIONS_NAME }}
 runs-on: ubuntu-latest
Expand All@@ -27,7 +26,7 @@ jobs:
 # Ensure that a wheel builder finishes even if another fails
 fail-fast: false
 matrix:
 python-version: [3.9, '3.10', '3.11', '3.12']
 python-version: [3.9, "3.10", "3.11", "3.12"]
 MINIMUM_REQUIREMENTS: [0]
 USE_SCIPY: [0]
 USE_SDIST: [0]
Expand All@@ -48,7 +47,7 @@ jobs:
 USE_SDIST: 1
 OPTIONS_NAME: "install-from-sdist"
 - platform_id: manylinux_x86_64
 python-version: '3.12'
 python-version: "3.12"
 PIP_FLAGS: "--pre"
 OPTIONS_NAME: "pre-releases"

Expand All@@ -64,32 +63,32 @@ jobs:

 - name: Build package
 env:
VERSION: ${{ matrix.python-version }}
MINIMUM_REQUIREMENTS: ${{ matrix.MINIMUM_REQUIREMENTS }}
PIP_FLAGS: ${{ matrix.PIP_FLAGS }}
USE_SDIST: ${{ matrix.USE_SDIST }}
USE_SCIPY: ${{ matrix.USE_SCIPY }}
REFGUIDE_CHECK: ${{ matrix.REFGUIDE_CHECK }}
 VERSION: ${{ matrix.python-version }}
 MINIMUM_REQUIREMENTS: ${{ matrix.MINIMUM_REQUIREMENTS }}
 PIP_FLAGS: ${{ matrix.PIP_FLAGS }}
 USE_SDIST: ${{ matrix.USE_SDIST }}
 USE_SCIPY: ${{ matrix.USE_SCIPY }}
 REFGUIDE_CHECK: ${{ matrix.REFGUIDE_CHECK }}
 run: |
uname -a
df -h
ulimit -a
# ccache -s
which python
python --version
# sudo apt-get install libatlas-base-dev
pip install --upgrade pip build
# Set numpy version first, other packages link against it
if [ "${MINIMUM_REQUIREMENTS}" == "1" ]; then
pip install ${CYTHON_MIN}
pip install ${NUMPY_MIN}
if [ "${USE_SCIPY}" == "1" ]; then pip install ${SCIPY_MIN}; fi
else
pip install ${PIP_FLAGS} cython
pip install ${PIP_FLAGS} numpy
if [ "${USE_SCIPY}" == "1" ]; then pip install ${PIP_FLAGS} scipy; fi
fi
pip install ${PIP_FLAGS} matplotlib pytest
 uname -a
 df -h
 ulimit -a
 # ccache -s
 which python
 python --version
 # sudo apt-get install libatlas-base-dev
 pip install --upgrade pip build
 # Set numpy version first, other packages link against it
 if [ "${MINIMUM_REQUIREMENTS}" == "1" ]; then
 pip install ${CYTHON_MIN}
 pip install ${NUMPY_MIN}
 if [ "${USE_SCIPY}" == "1" ]; then pip install ${SCIPY_MIN}; fi
 else
 pip install ${PIP_FLAGS} cython
 pip install ${PIP_FLAGS} numpy
 if [ "${USE_SCIPY}" == "1" ]; then pip install ${PIP_FLAGS} scipy; fi
 fi
 pip install ${PIP_FLAGS} matplotlib pytest

 set -o pipefail
 if [ "${USE_SDIST}" == "1" ]; then
Expand All@@ -104,22 +103,21 @@ jobs:

 - name: Run tests
 env:
USE_SDIST: ${{ matrix.USE_SDIST }}
REFGUIDE_CHECK: ${{ matrix.REFGUIDE_CHECK }}
 USE_SDIST: ${{ matrix.USE_SDIST }}
 REFGUIDE_CHECK: ${{ matrix.REFGUIDE_CHECK }}
 run: |
 set -o pipefail
 # Move out of source directory to avoid finding local pywt
 pushd demo
 if [ "${USE_SDIST}" == "1" ]; then
 pytest --pyargs pywt
 python ../pywt/tests/test_doc.py
 elif [ "${REFGUIDE_CHECK}" == "1" ]; then
 python util/refguide_check.py --doctests
 else
 pytest --pyargs pywt
 fi
 popd

 set -o pipefail
 # Move out of source directory to avoid finding local pywt
 pushd demo
 if [ "${USE_SDIST}" == "1" ]; then
 pytest --pyargs pywt
 python ../pywt/tests/test_doc.py
 elif [ "${REFGUIDE_CHECK}" == "1" ]; then
 python util/refguide_check.py --doctests
 else
 pytest --pyargs pywt
 fi
 popd

 test_pywavelets_macos:
 name: macos-cp${{ matrix.python-version }}-${{ matrix.OPTIONS_NAME }}
Expand All@@ -136,18 +134,18 @@ jobs:
 # Ensure that a wheel builder finishes even if another fails
 fail-fast: false
 matrix:
 python-version: [3.9, '3.12']
 python-version: [3.9, "3.12"]
 MINIMUM_REQUIREMENTS: [0]
 USE_SCIPY: [0]
 USE_SDIST: [0]
 REFGUIDE_CHECK: [0]
 PIP_FLAGS: [""]
 OPTIONS_NAME: ["default"]
 include:
 - python-version: '3.9'
 - python-version: "3.9"
 MINIMUM_REQUIREMENTS: 1
 OPTIONS_NAME: "osx-minimum-req"
 - python-version: '3.12'
 - python-version: "3.12"
 PIP_FLAGS: "--pre"
 OPTIONS_NAME: "pre-releases"

Expand All@@ -163,30 +161,30 @@ jobs:

 - name: Build package
 env:
VERSION: ${{ matrix.python-version }}
MINIMUM_REQUIREMENTS: ${{ matrix.MINIMUM_REQUIREMENTS }}
PIP_FLAGS: ${{ matrix.PIP_FLAGS }}
USE_SDIST: ${{ matrix.USE_SDIST }}
USE_SCIPY: ${{ matrix.USE_SCIPY }}
REFGUIDE_CHECK: ${{ matrix.REFGUIDE_CHECK }}
CC: /usr/bin/clang
CXX: /usr/bin/clang++
 VERSION: ${{ matrix.python-version }}
 MINIMUM_REQUIREMENTS: ${{ matrix.MINIMUM_REQUIREMENTS }}
 PIP_FLAGS: ${{ matrix.PIP_FLAGS }}
 USE_SDIST: ${{ matrix.USE_SDIST }}
 USE_SCIPY: ${{ matrix.USE_SCIPY }}
 REFGUIDE_CHECK: ${{ matrix.REFGUIDE_CHECK }}
 CC: /usr/bin/clang
 CXX: /usr/bin/clang++
 run: |
uname -a
df -h
ulimit -a
which python
python --version
pip install --upgrade pip build
# Set numpy version first, other packages link against it
if [ "${MINIMUM_REQUIREMENTS}" == "1" ]; then
pip install ${CYTHON_MIN} ${NUMPY_MIN}
if [ "${USE_SCIPY}" == "1" ]; then pip install ${SCIPY_MIN}; fi
else
pip install ${PIP_FLAGS} cython numpy
if [ "${USE_SCIPY}" == "1" ]; then pip install ${PIP_FLAGS} scipy; fi
fi
pip install ${PIP_FLAGS} matplotlib pytest
 uname -a
 df -h
 ulimit -a
 which python
 python --version
 pip install --upgrade pip build
 # Set numpy version first, other packages link against it
 if [ "${MINIMUM_REQUIREMENTS}" == "1" ]; then
 pip install ${CYTHON_MIN} ${NUMPY_MIN}
 if [ "${USE_SCIPY}" == "1" ]; then pip install ${SCIPY_MIN}; fi
 else
 pip install ${PIP_FLAGS} cython numpy
 if [ "${USE_SCIPY}" == "1" ]; then pip install ${PIP_FLAGS} scipy; fi
 fi
 pip install ${PIP_FLAGS} matplotlib pytest

 set -o pipefail
 if [ "${USE_SDIST}" == "1" ]; then
Expand All@@ -201,18 +199,18 @@ jobs:

 - name: Run tests
 env:
PIP_FLAGS: ${{ matrix.PIP_FLAGS }}
USE_SDIST: ${{ matrix.USE_SDIST }}
REFGUIDE_CHECK: ${{ matrix.REFGUIDE_CHECK }}
 PIP_FLAGS: ${{ matrix.PIP_FLAGS }}
 USE_SDIST: ${{ matrix.USE_SDIST }}
 REFGUIDE_CHECK: ${{ matrix.REFGUIDE_CHECK }}
 run: |
# Move out of source directory to avoid finding local pywt
pushd demo
if [ "${USE_SDIST}" == "1" ]; then
pytest --pyargs pywt
python ../pywt/tests/test_doc.py
elif [ "${REFGUIDE_CHECK}" == "1" ]; then
python util/refguide_check.py --doctests
else
pytest --pyargs pywt
fi
popd
 # Move out of source directory to avoid finding local pywt
 pushd demo
 if [ "${USE_SDIST}" == "1" ]; then
 pytest --pyargs pywt
 python ../pywt/tests/test_doc.py
 elif [ "${REFGUIDE_CHECK}" == "1" ]; then
 python util/refguide_check.py --doctests
 else
 pytest --pyargs pywt
 fi
 popd
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Add linter#687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

rgommers
merged 9 commits into

from

Mar 8, 2024
 Merged


Add linter
#687
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


9 commits


Select commit
Hold shift + click to select a range
058856b

Use ruff pre-commit


jarrodmillman Sep 8, 2023
d531f66

Run flynt


jarrodmillman Sep 14, 2023
bb1d188

Run pre-commit run -a


jarrodmillman Sep 14, 2023
c5279ec

Tell git to ignore linting noise


jarrodmillman Sep 18, 2023
96ad4a8

Add linter to CI


jarrodmillman Sep 14, 2023
a28c6fd

Incorporate cclauss feedback


jarrodmillman Sep 17, 2023
556e9d3

Merge branch 'master' into ruff


rgommers Mar 8, 2024
a8f9792

MAINT: fix new warnings with latest `ruff` version


rgommers Mar 8, 2024
54ddd0d

CI: upgrade ruff to latest (0.3.1) and fix two minor tool nits


rgommers Mar 8, 2024

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
.coveragerc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,4 +10,4 @@ omit =
 */pywt/data/create_dat.py
 *.pxd
 stringsource
plugins = Cython.Coverage
plugins = Cython.Coverage

2 changes: 2 additions & 0 deletions
.git-blame-ignore-revs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
# .git-blame-ignore-revs
# Applied codespell to the codebase
5ce73c91800829950474aaa4f4036b2a589a2418
d531f668d60503d55387d7d0ffae4afd199c5f80
bb1d1888fd63381ce35805e0cb3623a8bd47163c

4 changes: 2 additions & 2 deletions
.github/workflows/emscripten.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -27,7 +27,7 @@ jobs:
 id: setup-python
 uses: actions/setup-python@v2
 with:
 python-version: '3.11.2'
 python-version: "3.11.2"

 - name: Install prerequisites
 run: |
Expand All@@ -43,7 +43,7 @@ jobs:
 - name: Set up Node.js
 uses: actions/setup-node@v4.0.2
 with:
 node-version: '18'
 node-version: "18"

 - name: Build PyWavelets
 run: |
Expand Down

31 changes: 31 additions & 0 deletions
.github/workflows/lint.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
name: style

on: [push, pull_request]

concurrency:
 group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
 cancel-in-progress: true

jobs:
 format:
 runs-on: ubuntu-latest
 strategy:
 matrix:
 python-version: ["3.11"]

 steps:
 - uses: actions/checkout@v4

 - name: Set up Python ${{ matrix.python-version }}
 uses: actions/setup-python@v4
 with:
 python-version: ${{ matrix.python-version }}

 - name: Install packages
 run: |
 pip install --upgrade pip
 pip install pre-commit
 pip list

 - name: Lint
 run: pre-commit run --all-files --show-diff-on-failure --color always

164 changes: 81 additions & 83 deletions
.github/workflows/tests.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,6 @@ on:
 - v1.**

jobs:

 test_pywavelets_linux:
 name: linux-cp${{ matrix.python-version }}-${{ matrix.OPTIONS_NAME }}
 runs-on: ubuntu-latest
Expand All@@ -27,7 +26,7 @@ jobs:
 # Ensure that a wheel builder finishes even if another fails
 fail-fast: false
 matrix:
 python-version: [3.9, '3.10', '3.11', '3.12']
 python-version: [3.9, "3.10", "3.11", "3.12"]
 MINIMUM_REQUIREMENTS: [0]
 USE_SCIPY: [0]
 USE_SDIST: [0]
Expand All@@ -48,7 +47,7 @@ jobs:
 USE_SDIST: 1
 OPTIONS_NAME: "install-from-sdist"
 - platform_id: manylinux_x86_64
 python-version: '3.12'
 python-version: "3.12"
 PIP_FLAGS: "--pre"
 OPTIONS_NAME: "pre-releases"

Expand All@@ -64,32 +63,32 @@ jobs:

 - name: Build package
 env:
VERSION: ${{ matrix.python-version }}
MINIMUM_REQUIREMENTS: ${{ matrix.MINIMUM_REQUIREMENTS }}
PIP_FLAGS: ${{ matrix.PIP_FLAGS }}
USE_SDIST: ${{ matrix.USE_SDIST }}
USE_SCIPY: ${{ matrix.USE_SCIPY }}
REFGUIDE_CHECK: ${{ matrix.REFGUIDE_CHECK }}
 VERSION: ${{ matrix.python-version }}
 MINIMUM_REQUIREMENTS: ${{ matrix.MINIMUM_REQUIREMENTS }}
 PIP_FLAGS: ${{ matrix.PIP_FLAGS }}
 USE_SDIST: ${{ matrix.USE_SDIST }}
 USE_SCIPY: ${{ matrix.USE_SCIPY }}
 REFGUIDE_CHECK: ${{ matrix.REFGUIDE_CHECK }}
 run: |
uname -a
df -h
ulimit -a
# ccache -s
which python
python --version
# sudo apt-get install libatlas-base-dev
pip install --upgrade pip build
# Set numpy version first, other packages link against it
if [ "${MINIMUM_REQUIREMENTS}" == "1" ]; then
pip install ${CYTHON_MIN}
pip install ${NUMPY_MIN}
if [ "${USE_SCIPY}" == "1" ]; then pip install ${SCIPY_MIN}; fi
else
pip install ${PIP_FLAGS} cython
pip install ${PIP_FLAGS} numpy
if [ "${USE_SCIPY}" == "1" ]; then pip install ${PIP_FLAGS} scipy; fi
fi
pip install ${PIP_FLAGS} matplotlib pytest
 uname -a
 df -h
 ulimit -a
 # ccache -s
 which python
 python --version
 # sudo apt-get install libatlas-base-dev
 pip install --upgrade pip build
 # Set numpy version first, other packages link against it
 if [ "${MINIMUM_REQUIREMENTS}" == "1" ]; then
 pip install ${CYTHON_MIN}
 pip install ${NUMPY_MIN}
 if [ "${USE_SCIPY}" == "1" ]; then pip install ${SCIPY_MIN}; fi
 else
 pip install ${PIP_FLAGS} cython
 pip install ${PIP_FLAGS} numpy
 if [ "${USE_SCIPY}" == "1" ]; then pip install ${PIP_FLAGS} scipy; fi
 fi
 pip install ${PIP_FLAGS} matplotlib pytest

 set -o pipefail
 if [ "${USE_SDIST}" == "1" ]; then
Expand All@@ -104,22 +103,21 @@ jobs:

 - name: Run tests
 env:
USE_SDIST: ${{ matrix.USE_SDIST }}
REFGUIDE_CHECK: ${{ matrix.REFGUIDE_CHECK }}
 USE_SDIST: ${{ matrix.USE_SDIST }}
 REFGUIDE_CHECK: ${{ matrix.REFGUIDE_CHECK }}
 run: |
 set -o pipefail
 # Move out of source directory to avoid finding local pywt
 pushd demo
 if [ "${USE_SDIST}" == "1" ]; then
 pytest --pyargs pywt
 python ../pywt/tests/test_doc.py
 elif [ "${REFGUIDE_CHECK}" == "1" ]; then
 python util/refguide_check.py --doctests
 else
 pytest --pyargs pywt
 fi
 popd

 set -o pipefail
 # Move out of source directory to avoid finding local pywt
 pushd demo
 if [ "${USE_SDIST}" == "1" ]; then
 pytest --pyargs pywt
 python ../pywt/tests/test_doc.py
 elif [ "${REFGUIDE_CHECK}" == "1" ]; then
 python util/refguide_check.py --doctests
 else
 pytest --pyargs pywt
 fi
 popd

 test_pywavelets_macos:
 name: macos-cp${{ matrix.python-version }}-${{ matrix.OPTIONS_NAME }}
Expand All@@ -136,18 +134,18 @@ jobs:
 # Ensure that a wheel builder finishes even if another fails
 fail-fast: false
 matrix:
 python-version: [3.9, '3.12']
 python-version: [3.9, "3.12"]
 MINIMUM_REQUIREMENTS: [0]
 USE_SCIPY: [0]
 USE_SDIST: [0]
 REFGUIDE_CHECK: [0]
 PIP_FLAGS: [""]
 OPTIONS_NAME: ["default"]
 include:
 - python-version: '3.9'
 - python-version: "3.9"
 MINIMUM_REQUIREMENTS: 1
 OPTIONS_NAME: "osx-minimum-req"
 - python-version: '3.12'
 - python-version: "3.12"
 PIP_FLAGS: "--pre"
 OPTIONS_NAME: "pre-releases"

Expand All@@ -163,30 +161,30 @@ jobs:

 - name: Build package
 env:
VERSION: ${{ matrix.python-version }}
MINIMUM_REQUIREMENTS: ${{ matrix.MINIMUM_REQUIREMENTS }}
PIP_FLAGS: ${{ matrix.PIP_FLAGS }}
USE_SDIST: ${{ matrix.USE_SDIST }}
USE_SCIPY: ${{ matrix.USE_SCIPY }}
REFGUIDE_CHECK: ${{ matrix.REFGUIDE_CHECK }}
CC: /usr/bin/clang
CXX: /usr/bin/clang++
 VERSION: ${{ matrix.python-version }}
 MINIMUM_REQUIREMENTS: ${{ matrix.MINIMUM_REQUIREMENTS }}
 PIP_FLAGS: ${{ matrix.PIP_FLAGS }}
 USE_SDIST: ${{ matrix.USE_SDIST }}
 USE_SCIPY: ${{ matrix.USE_SCIPY }}
 REFGUIDE_CHECK: ${{ matrix.REFGUIDE_CHECK }}
 CC: /usr/bin/clang
 CXX: /usr/bin/clang++
 run: |
uname -a
df -h
ulimit -a
which python
python --version
pip install --upgrade pip build
# Set numpy version first, other packages link against it
if [ "${MINIMUM_REQUIREMENTS}" == "1" ]; then
pip install ${CYTHON_MIN} ${NUMPY_MIN}
if [ "${USE_SCIPY}" == "1" ]; then pip install ${SCIPY_MIN}; fi
else
pip install ${PIP_FLAGS} cython numpy
if [ "${USE_SCIPY}" == "1" ]; then pip install ${PIP_FLAGS} scipy; fi
fi
pip install ${PIP_FLAGS} matplotlib pytest
 uname -a
 df -h
 ulimit -a
 which python
 python --version
 pip install --upgrade pip build
 # Set numpy version first, other packages link against it
 if [ "${MINIMUM_REQUIREMENTS}" == "1" ]; then
 pip install ${CYTHON_MIN} ${NUMPY_MIN}
 if [ "${USE_SCIPY}" == "1" ]; then pip install ${SCIPY_MIN}; fi
 else
 pip install ${PIP_FLAGS} cython numpy
 if [ "${USE_SCIPY}" == "1" ]; then pip install ${PIP_FLAGS} scipy; fi
 fi
 pip install ${PIP_FLAGS} matplotlib pytest

 set -o pipefail
 if [ "${USE_SDIST}" == "1" ]; then
Expand All@@ -201,18 +199,18 @@ jobs:

 - name: Run tests
 env:
PIP_FLAGS: ${{ matrix.PIP_FLAGS }}
USE_SDIST: ${{ matrix.USE_SDIST }}
REFGUIDE_CHECK: ${{ matrix.REFGUIDE_CHECK }}
 PIP_FLAGS: ${{ matrix.PIP_FLAGS }}
 USE_SDIST: ${{ matrix.USE_SDIST }}
 REFGUIDE_CHECK: ${{ matrix.REFGUIDE_CHECK }}
 run: |
# Move out of source directory to avoid finding local pywt
pushd demo
if [ "${USE_SDIST}" == "1" ]; then
pytest --pyargs pywt
python ../pywt/tests/test_doc.py
elif [ "${REFGUIDE_CHECK}" == "1" ]; then
python util/refguide_check.py --doctests
else
pytest --pyargs pywt
fi
popd
 # Move out of source directory to avoid finding local pywt
 pushd demo
 if [ "${USE_SDIST}" == "1" ]; then
 pytest --pyargs pywt
 python ../pywt/tests/test_doc.py
 elif [ "${REFGUIDE_CHECK}" == "1" ]; then
 python util/refguide_check.py --doctests
 else
 pytest --pyargs pywt
 fi
 popd
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Add linter#687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

rgommers
merged 9 commits into

from

Mar 8, 2024
 Merged


Add linter
#687
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


9 commits


Select commit
Hold shift + click to select a range
058856b

Use ruff pre-commit


jarrodmillman Sep 8, 2023
d531f66

Run flynt


jarrodmillman Sep 14, 2023
bb1d188

Run pre-commit run -a


jarrodmillman Sep 14, 2023
c5279ec

Tell git to ignore linting noise


jarrodmillman Sep 18, 2023
96ad4a8

Add linter to CI


jarrodmillman Sep 14, 2023
a28c6fd

Incorporate cclauss feedback


jarrodmillman Sep 17, 2023
556e9d3

Merge branch 'master' into ruff


rgommers Mar 8, 2024
a8f9792

MAINT: fix new warnings with latest `ruff` version


rgommers Mar 8, 2024
54ddd0d

CI: upgrade ruff to latest (0.3.1) and fix two minor tool nits


rgommers Mar 8, 2024

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
.coveragerc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,4 +10,4 @@ omit =
 */pywt/data/create_dat.py
 *.pxd
 stringsource
plugins = Cython.Coverage
plugins = Cython.Coverage

2 changes: 2 additions & 0 deletions
.git-blame-ignore-revs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
# .git-blame-ignore-revs
# Applied codespell to the codebase
5ce73c91800829950474aaa4f4036b2a589a2418
d531f668d60503d55387d7d0ffae4afd199c5f80
bb1d1888fd63381ce35805e0cb3623a8bd47163c

4 changes: 2 additions & 2 deletions
.github/workflows/emscripten.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -27,7 +27,7 @@ jobs:
 id: setup-python
 uses: actions/setup-python@v2
 with:
 python-version: '3.11.2'
 python-version: "3.11.2"

 - name: Install prerequisites
 run: |
Expand All@@ -43,7 +43,7 @@ jobs:
 - name: Set up Node.js
 uses: actions/setup-node@v4.0.2
 with:
 node-version: '18'
 node-version: "18"

 - name: Build PyWavelets
 run: |
Expand Down

31 changes: 31 additions & 0 deletions
.github/workflows/lint.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
name: style

on: [push, pull_request]

concurrency:
 group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
 cancel-in-progress: true

jobs:
 format:
 runs-on: ubuntu-latest
 strategy:
 matrix:
 python-version: ["3.11"]

 steps:
 - uses: actions/checkout@v4

 - name: Set up Python ${{ matrix.python-version }}
 uses: actions/setup-python@v4
 with:
 python-version: ${{ matrix.python-version }}

 - name: Install packages
 run: |
 pip install --upgrade pip
 pip install pre-commit
 pip list

 - name: Lint
 run: pre-commit run --all-files --show-diff-on-failure --color always

164 changes: 81 additions & 83 deletions
.github/workflows/tests.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,6 @@ on:
 - v1.**

jobs:

 test_pywavelets_linux:
 name: linux-cp${{ matrix.python-version }}-${{ matrix.OPTIONS_NAME }}
 runs-on: ubuntu-latest
Expand All@@ -27,7 +26,7 @@ jobs:
 # Ensure that a wheel builder finishes even if another fails
 fail-fast: false
 matrix:
 python-version: [3.9, '3.10', '3.11', '3.12']
 python-version: [3.9, "3.10", "3.11", "3.12"]
 MINIMUM_REQUIREMENTS: [0]
 USE_SCIPY: [0]
 USE_SDIST: [0]
Expand All@@ -48,7 +47,7 @@ jobs:
 USE_SDIST: 1
 OPTIONS_NAME: "install-from-sdist"
 - platform_id: manylinux_x86_64
 python-version: '3.12'
 python-version: "3.12"
 PIP_FLAGS: "--pre"
 OPTIONS_NAME: "pre-releases"

Expand All@@ -64,32 +63,32 @@ jobs:

 - name: Build package
 env:
VERSION: ${{ matrix.python-version }}
MINIMUM_REQUIREMENTS: ${{ matrix.MINIMUM_REQUIREMENTS }}
PIP_FLAGS: ${{ matrix.PIP_FLAGS }}
USE_SDIST: ${{ matrix.USE_SDIST }}
USE_SCIPY: ${{ matrix.USE_SCIPY }}
REFGUIDE_CHECK: ${{ matrix.REFGUIDE_CHECK }}
 VERSION: ${{ matrix.python-version }}
 MINIMUM_REQUIREMENTS: ${{ matrix.MINIMUM_REQUIREMENTS }}
 PIP_FLAGS: ${{ matrix.PIP_FLAGS }}
 USE_SDIST: ${{ matrix.USE_SDIST }}
 USE_SCIPY: ${{ matrix.USE_SCIPY }}
 REFGUIDE_CHECK: ${{ matrix.REFGUIDE_CHECK }}
 run: |
uname -a
df -h
ulimit -a
# ccache -s
which python
python --version
# sudo apt-get install libatlas-base-dev
pip install --upgrade pip build
# Set numpy version first, other packages link against it
if [ "${MINIMUM_REQUIREMENTS}" == "1" ]; then
pip install ${CYTHON_MIN}
pip install ${NUMPY_MIN}
if [ "${USE_SCIPY}" == "1" ]; then pip install ${SCIPY_MIN}; fi
else
pip install ${PIP_FLAGS} cython
pip install ${PIP_FLAGS} numpy
if [ "${USE_SCIPY}" == "1" ]; then pip install ${PIP_FLAGS} scipy; fi
fi
pip install ${PIP_FLAGS} matplotlib pytest
 uname -a
 df -h
 ulimit -a
 # ccache -s
 which python
 python --version
 # sudo apt-get install libatlas-base-dev
 pip install --upgrade pip build
 # Set numpy version first, other packages link against it
 if [ "${MINIMUM_REQUIREMENTS}" == "1" ]; then
 pip install ${CYTHON_MIN}
 pip install ${NUMPY_MIN}
 if [ "${USE_SCIPY}" == "1" ]; then pip install ${SCIPY_MIN}; fi
 else
 pip install ${PIP_FLAGS} cython
 pip install ${PIP_FLAGS} numpy
 if [ "${USE_SCIPY}" == "1" ]; then pip install ${PIP_FLAGS} scipy; fi
 fi
 pip install ${PIP_FLAGS} matplotlib pytest

 set -o pipefail
 if [ "${USE_SDIST}" == "1" ]; then
Expand All@@ -104,22 +103,21 @@ jobs:

 - name: Run tests
 env:
USE_SDIST: ${{ matrix.USE_SDIST }}
REFGUIDE_CHECK: ${{ matrix.REFGUIDE_CHECK }}
 USE_SDIST: ${{ matrix.USE_SDIST }}
 REFGUIDE_CHECK: ${{ matrix.REFGUIDE_CHECK }}
 run: |
 set -o pipefail
 # Move out of source directory to avoid finding local pywt
 pushd demo
 if [ "${USE_SDIST}" == "1" ]; then
 pytest --pyargs pywt
 python ../pywt/tests/test_doc.py
 elif [ "${REFGUIDE_CHECK}" == "1" ]; then
 python util/refguide_check.py --doctests
 else
 pytest --pyargs pywt
 fi
 popd

 set -o pipefail
 # Move out of source directory to avoid finding local pywt
 pushd demo
 if [ "${USE_SDIST}" == "1" ]; then
 pytest --pyargs pywt
 python ../pywt/tests/test_doc.py
 elif [ "${REFGUIDE_CHECK}" == "1" ]; then
 python util/refguide_check.py --doctests
 else
 pytest --pyargs pywt
 fi
 popd

 test_pywavelets_macos:
 name: macos-cp${{ matrix.python-version }}-${{ matrix.OPTIONS_NAME }}
Expand All@@ -136,18 +134,18 @@ jobs:
 # Ensure that a wheel builder finishes even if another fails
 fail-fast: false
 matrix:
 python-version: [3.9, '3.12']
 python-version: [3.9, "3.12"]
 MINIMUM_REQUIREMENTS: [0]
 USE_SCIPY: [0]
 USE_SDIST: [0]
 REFGUIDE_CHECK: [0]
 PIP_FLAGS: [""]
 OPTIONS_NAME: ["default"]
 include:
 - python-version: '3.9'
 - python-version: "3.9"
 MINIMUM_REQUIREMENTS: 1
 OPTIONS_NAME: "osx-minimum-req"
 - python-version: '3.12'
 - python-version: "3.12"
 PIP_FLAGS: "--pre"
 OPTIONS_NAME: "pre-releases"

Expand All@@ -163,30 +161,30 @@ jobs:

 - name: Build package
 env:
VERSION: ${{ matrix.python-version }}
MINIMUM_REQUIREMENTS: ${{ matrix.MINIMUM_REQUIREMENTS }}
PIP_FLAGS: ${{ matrix.PIP_FLAGS }}
USE_SDIST: ${{ matrix.USE_SDIST }}
USE_SCIPY: ${{ matrix.USE_SCIPY }}
REFGUIDE_CHECK: ${{ matrix.REFGUIDE_CHECK }}
CC: /usr/bin/clang
CXX: /usr/bin/clang++
 VERSION: ${{ matrix.python-version }}
 MINIMUM_REQUIREMENTS: ${{ matrix.MINIMUM_REQUIREMENTS }}
 PIP_FLAGS: ${{ matrix.PIP_FLAGS }}
 USE_SDIST: ${{ matrix.USE_SDIST }}
 USE_SCIPY: ${{ matrix.USE_SCIPY }}
 REFGUIDE_CHECK: ${{ matrix.REFGUIDE_CHECK }}
 CC: /usr/bin/clang
 CXX: /usr/bin/clang++
 run: |
uname -a
df -h
ulimit -a
which python
python --version
pip install --upgrade pip build
# Set numpy version first, other packages link against it
if [ "${MINIMUM_REQUIREMENTS}" == "1" ]; then
pip install ${CYTHON_MIN} ${NUMPY_MIN}
if [ "${USE_SCIPY}" == "1" ]; then pip install ${SCIPY_MIN}; fi
else
pip install ${PIP_FLAGS} cython numpy
if [ "${USE_SCIPY}" == "1" ]; then pip install ${PIP_FLAGS} scipy; fi
fi
pip install ${PIP_FLAGS} matplotlib pytest
 uname -a
 df -h
 ulimit -a
 which python
 python --version
 pip install --upgrade pip build
 # Set numpy version first, other packages link against it
 if [ "${MINIMUM_REQUIREMENTS}" == "1" ]; then
 pip install ${CYTHON_MIN} ${NUMPY_MIN}
 if [ "${USE_SCIPY}" == "1" ]; then pip install ${SCIPY_MIN}; fi
 else
 pip install ${PIP_FLAGS} cython numpy
 if [ "${USE_SCIPY}" == "1" ]; then pip install ${PIP_FLAGS} scipy; fi
 fi
 pip install ${PIP_FLAGS} matplotlib pytest

 set -o pipefail
 if [ "${USE_SDIST}" == "1" ]; then
Expand All@@ -201,18 +199,18 @@ jobs:

 - name: Run tests
 env:
PIP_FLAGS: ${{ matrix.PIP_FLAGS }}
USE_SDIST: ${{ matrix.USE_SDIST }}
REFGUIDE_CHECK: ${{ matrix.REFGUIDE_CHECK }}
 PIP_FLAGS: ${{ matrix.PIP_FLAGS }}
 USE_SDIST: ${{ matrix.USE_SDIST }}
 REFGUIDE_CHECK: ${{ matrix.REFGUIDE_CHECK }}
 run: |
# Move out of source directory to avoid finding local pywt
pushd demo
if [ "${USE_SDIST}" == "1" ]; then
pytest --pyargs pywt
python ../pywt/tests/test_doc.py
elif [ "${REFGUIDE_CHECK}" == "1" ]; then
python util/refguide_check.py --doctests
else
pytest --pyargs pywt
fi
popd
 # Move out of source directory to avoid finding local pywt
 pushd demo
 if [ "${USE_SDIST}" == "1" ]; then
 pytest --pyargs pywt
 python ../pywt/tests/test_doc.py
 elif [ "${REFGUIDE_CHECK}" == "1" ]; then
 python util/refguide_check.py --doctests
 else
 pytest --pyargs pywt
 fi
 popd
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Add linter#687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

rgommers
merged 9 commits into

from

Mar 8, 2024
 Merged


Add linter
#687
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


9 commits


Select commit
Hold shift + click to select a range
058856b

Use ruff pre-commit


jarrodmillman Sep 8, 2023
d531f66

Run flynt


jarrodmillman Sep 14, 2023
bb1d188

Run pre-commit run -a


jarrodmillman Sep 14, 2023
c5279ec

Tell git to ignore linting noise


jarrodmillman Sep 18, 2023
96ad4a8

Add linter to CI


jarrodmillman Sep 14, 2023
a28c6fd

Incorporate cclauss feedback


jarrodmillman Sep 17, 2023
556e9d3

Merge branch 'master' into ruff


rgommers Mar 8, 2024
a8f9792

MAINT: fix new warnings with latest `ruff` version


rgommers Mar 8, 2024
54ddd0d

CI: upgrade ruff to latest (0.3.1) and fix two minor tool nits


rgommers Mar 8, 2024

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
.coveragerc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,4 +10,4 @@ omit =
 */pywt/data/create_dat.py
 *.pxd
 stringsource
plugins = Cython.Coverage
plugins = Cython.Coverage

2 changes: 2 additions & 0 deletions
.git-blame-ignore-revs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
# .git-blame-ignore-revs
# Applied codespell to the codebase
5ce73c91800829950474aaa4f4036b2a589a2418
d531f668d60503d55387d7d0ffae4afd199c5f80
bb1d1888fd63381ce35805e0cb3623a8bd47163c

4 changes: 2 additions & 2 deletions
.github/workflows/emscripten.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -27,7 +27,7 @@ jobs:
 id: setup-python
 uses: actions/setup-python@v2
 with:
 python-version: '3.11.2'
 python-version: "3.11.2"

 - name: Install prerequisites
 run: |
Expand All@@ -43,7 +43,7 @@ jobs:
 - name: Set up Node.js
 uses: actions/setup-node@v4.0.2
 with:
 node-version: '18'
 node-version: "18"

 - name: Build PyWavelets
 run: |
Expand Down

31 changes: 31 additions & 0 deletions
.github/workflows/lint.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
name: style

on: [push, pull_request]

concurrency:
 group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
 cancel-in-progress: true

jobs:
 format:
 runs-on: ubuntu-latest
 strategy:
 matrix:
 python-version: ["3.11"]

 steps:
 - uses: actions/checkout@v4

 - name: Set up Python ${{ matrix.python-version }}
 uses: actions/setup-python@v4
 with:
 python-version: ${{ matrix.python-version }}

 - name: Install packages
 run: |
 pip install --upgrade pip
 pip install pre-commit
 pip list

 - name: Lint
 run: pre-commit run --all-files --show-diff-on-failure --color always

164 changes: 81 additions & 83 deletions
.github/workflows/tests.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,6 @@ on:
 - v1.**

jobs:

 test_pywavelets_linux:
 name: linux-cp${{ matrix.python-version }}-${{ matrix.OPTIONS_NAME }}
 runs-on: ubuntu-latest
Expand All@@ -27,7 +26,7 @@ jobs:
 # Ensure that a wheel builder finishes even if another fails
 fail-fast: false
 matrix:
 python-version: [3.9, '3.10', '3.11', '3.12']
 python-version: [3.9, "3.10", "3.11", "3.12"]
 MINIMUM_REQUIREMENTS: [0]
 USE_SCIPY: [0]
 USE_SDIST: [0]
Expand All@@ -48,7 +47,7 @@ jobs:
 USE_SDIST: 1
 OPTIONS_NAME: "install-from-sdist"
 - platform_id: manylinux_x86_64
 python-version: '3.12'
 python-version: "3.12"
 PIP_FLAGS: "--pre"
 OPTIONS_NAME: "pre-releases"

Expand All@@ -64,32 +63,32 @@ jobs:

 - name: Build package
 env:
VERSION: ${{ matrix.python-version }}
MINIMUM_REQUIREMENTS: ${{ matrix.MINIMUM_REQUIREMENTS }}
PIP_FLAGS: ${{ matrix.PIP_FLAGS }}
USE_SDIST: ${{ matrix.USE_SDIST }}
USE_SCIPY: ${{ matrix.USE_SCIPY }}
REFGUIDE_CHECK: ${{ matrix.REFGUIDE_CHECK }}
 VERSION: ${{ matrix.python-version }}
 MINIMUM_REQUIREMENTS: ${{ matrix.MINIMUM_REQUIREMENTS }}
 PIP_FLAGS: ${{ matrix.PIP_FLAGS }}
 USE_SDIST: ${{ matrix.USE_SDIST }}
 USE_SCIPY: ${{ matrix.USE_SCIPY }}
 REFGUIDE_CHECK: ${{ matrix.REFGUIDE_CHECK }}
 run: |
uname -a
df -h
ulimit -a
# ccache -s
which python
python --version
# sudo apt-get install libatlas-base-dev
pip install --upgrade pip build
# Set numpy version first, other packages link against it
if [ "${MINIMUM_REQUIREMENTS}" == "1" ]; then
pip install ${CYTHON_MIN}
pip install ${NUMPY_MIN}
if [ "${USE_SCIPY}" == "1" ]; then pip install ${SCIPY_MIN}; fi
else
pip install ${PIP_FLAGS} cython
pip install ${PIP_FLAGS} numpy
if [ "${USE_SCIPY}" == "1" ]; then pip install ${PIP_FLAGS} scipy; fi
fi
pip install ${PIP_FLAGS} matplotlib pytest
 uname -a
 df -h
 ulimit -a
 # ccache -s
 which python
 python --version
 # sudo apt-get install libatlas-base-dev
 pip install --upgrade pip build
 # Set numpy version first, other packages link against it
 if [ "${MINIMUM_REQUIREMENTS}" == "1" ]; then
 pip install ${CYTHON_MIN}
 pip install ${NUMPY_MIN}
 if [ "${USE_SCIPY}" == "1" ]; then pip install ${SCIPY_MIN}; fi
 else
 pip install ${PIP_FLAGS} cython
 pip install ${PIP_FLAGS} numpy
 if [ "${USE_SCIPY}" == "1" ]; then pip install ${PIP_FLAGS} scipy; fi
 fi
 pip install ${PIP_FLAGS} matplotlib pytest

 set -o pipefail
 if [ "${USE_SDIST}" == "1" ]; then
Expand All@@ -104,22 +103,21 @@ jobs:

 - name: Run tests
 env:
USE_SDIST: ${{ matrix.USE_SDIST }}
REFGUIDE_CHECK: ${{ matrix.REFGUIDE_CHECK }}
 USE_SDIST: ${{ matrix.USE_SDIST }}
 REFGUIDE_CHECK: ${{ matrix.REFGUIDE_CHECK }}
 run: |
 set -o pipefail
 # Move out of source directory to avoid finding local pywt
 pushd demo
 if [ "${USE_SDIST}" == "1" ]; then
 pytest --pyargs pywt
 python ../pywt/tests/test_doc.py
 elif [ "${REFGUIDE_CHECK}" == "1" ]; then
 python util/refguide_check.py --doctests
 else
 pytest --pyargs pywt
 fi
 popd

 set -o pipefail
 # Move out of source directory to avoid finding local pywt
 pushd demo
 if [ "${USE_SDIST}" == "1" ]; then
 pytest --pyargs pywt
 python ../pywt/tests/test_doc.py
 elif [ "${REFGUIDE_CHECK}" == "1" ]; then
 python util/refguide_check.py --doctests
 else
 pytest --pyargs pywt
 fi
 popd

 test_pywavelets_macos:
 name: macos-cp${{ matrix.python-version }}-${{ matrix.OPTIONS_NAME }}
Expand All@@ -136,18 +134,18 @@ jobs:
 # Ensure that a wheel builder finishes even if another fails
 fail-fast: false
 matrix:
 python-version: [3.9, '3.12']
 python-version: [3.9, "3.12"]
 MINIMUM_REQUIREMENTS: [0]
 USE_SCIPY: [0]
 USE_SDIST: [0]
 REFGUIDE_CHECK: [0]
 PIP_FLAGS: [""]
 OPTIONS_NAME: ["default"]
 include:
 - python-version: '3.9'
 - python-version: "3.9"
 MINIMUM_REQUIREMENTS: 1
 OPTIONS_NAME: "osx-minimum-req"
 - python-version: '3.12'
 - python-version: "3.12"
 PIP_FLAGS: "--pre"
 OPTIONS_NAME: "pre-releases"

Expand All@@ -163,30 +161,30 @@ jobs:

 - name: Build package
 env:
VERSION: ${{ matrix.python-version }}
MINIMUM_REQUIREMENTS: ${{ matrix.MINIMUM_REQUIREMENTS }}
PIP_FLAGS: ${{ matrix.PIP_FLAGS }}
USE_SDIST: ${{ matrix.USE_SDIST }}
USE_SCIPY: ${{ matrix.USE_SCIPY }}
REFGUIDE_CHECK: ${{ matrix.REFGUIDE_CHECK }}
CC: /usr/bin/clang
CXX: /usr/bin/clang++
 VERSION: ${{ matrix.python-version }}
 MINIMUM_REQUIREMENTS: ${{ matrix.MINIMUM_REQUIREMENTS }}
 PIP_FLAGS: ${{ matrix.PIP_FLAGS }}
 USE_SDIST: ${{ matrix.USE_SDIST }}
 USE_SCIPY: ${{ matrix.USE_SCIPY }}
 REFGUIDE_CHECK: ${{ matrix.REFGUIDE_CHECK }}
 CC: /usr/bin/clang
 CXX: /usr/bin/clang++
 run: |
uname -a
df -h
ulimit -a
which python
python --version
pip install --upgrade pip build
# Set numpy version first, other packages link against it
if [ "${MINIMUM_REQUIREMENTS}" == "1" ]; then
pip install ${CYTHON_MIN} ${NUMPY_MIN}
if [ "${USE_SCIPY}" == "1" ]; then pip install ${SCIPY_MIN}; fi
else
pip install ${PIP_FLAGS} cython numpy
if [ "${USE_SCIPY}" == "1" ]; then pip install ${PIP_FLAGS} scipy; fi
fi
pip install ${PIP_FLAGS} matplotlib pytest
 uname -a
 df -h
 ulimit -a
 which python
 python --version
 pip install --upgrade pip build
 # Set numpy version first, other packages link against it
 if [ "${MINIMUM_REQUIREMENTS}" == "1" ]; then
 pip install ${CYTHON_MIN} ${NUMPY_MIN}
 if [ "${USE_SCIPY}" == "1" ]; then pip install ${SCIPY_MIN}; fi
 else
 pip install ${PIP_FLAGS} cython numpy
 if [ "${USE_SCIPY}" == "1" ]; then pip install ${PIP_FLAGS} scipy; fi
 fi
 pip install ${PIP_FLAGS} matplotlib pytest

 set -o pipefail
 if [ "${USE_SDIST}" == "1" ]; then
Expand All@@ -201,18 +199,18 @@ jobs:

 - name: Run tests
 env:
PIP_FLAGS: ${{ matrix.PIP_FLAGS }}
USE_SDIST: ${{ matrix.USE_SDIST }}
REFGUIDE_CHECK: ${{ matrix.REFGUIDE_CHECK }}
 PIP_FLAGS: ${{ matrix.PIP_FLAGS }}
 USE_SDIST: ${{ matrix.USE_SDIST }}
 REFGUIDE_CHECK: ${{ matrix.REFGUIDE_CHECK }}
 run: |
# Move out of source directory to avoid finding local pywt
pushd demo
if [ "${USE_SDIST}" == "1" ]; then
pytest --pyargs pywt
python ../pywt/tests/test_doc.py
elif [ "${REFGUIDE_CHECK}" == "1" ]; then
python util/refguide_check.py --doctests
else
pytest --pyargs pywt
fi
popd
 # Move out of source directory to avoid finding local pywt
 pushd demo
 if [ "${USE_SDIST}" == "1" ]; then
 pytest --pyargs pywt
 python ../pywt/tests/test_doc.py
 elif [ "${REFGUIDE_CHECK}" == "1" ]; then
 python util/refguide_check.py --doctests
 else
 pytest --pyargs pywt
 fi
 popd
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Add linter#687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

rgommers
merged 9 commits into

from

Mar 8, 2024
 Merged


Add linter
#687
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


9 commits


Select commit
Hold shift + click to select a range
058856b

Use ruff pre-commit


jarrodmillman Sep 8, 2023
d531f66

Run flynt


jarrodmillman Sep 14, 2023
bb1d188

Run pre-commit run -a


jarrodmillman Sep 14, 2023
c5279ec

Tell git to ignore linting noise


jarrodmillman Sep 18, 2023
96ad4a8

Add linter to CI


jarrodmillman Sep 14, 2023
a28c6fd

Incorporate cclauss feedback


jarrodmillman Sep 17, 2023
556e9d3

Merge branch 'master' into ruff


rgommers Mar 8, 2024
a8f9792

MAINT: fix new warnings with latest `ruff` version


rgommers Mar 8, 2024
54ddd0d

CI: upgrade ruff to latest (0.3.1) and fix two minor tool nits


rgommers Mar 8, 2024

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
.coveragerc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,4 +10,4 @@ omit =
 */pywt/data/create_dat.py
 *.pxd
 stringsource
plugins = Cython.Coverage
plugins = Cython.Coverage

2 changes: 2 additions & 0 deletions
.git-blame-ignore-revs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
# .git-blame-ignore-revs
# Applied codespell to the codebase
5ce73c91800829950474aaa4f4036b2a589a2418
d531f668d60503d55387d7d0ffae4afd199c5f80
bb1d1888fd63381ce35805e0cb3623a8bd47163c

4 changes: 2 additions & 2 deletions
.github/workflows/emscripten.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -27,7 +27,7 @@ jobs:
 id: setup-python
 uses: actions/setup-python@v2
 with:
 python-version: '3.11.2'
 python-version: "3.11.2"

 - name: Install prerequisites
 run: |
Expand All@@ -43,7 +43,7 @@ jobs:
 - name: Set up Node.js
 uses: actions/setup-node@v4.0.2
 with:
 node-version: '18'
 node-version: "18"

 - name: Build PyWavelets
 run: |
Expand Down

31 changes: 31 additions & 0 deletions
.github/workflows/lint.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
name: style

on: [push, pull_request]

concurrency:
 group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
 cancel-in-progress: true

jobs:
 format:
 runs-on: ubuntu-latest
 strategy:
 matrix:
 python-version: ["3.11"]

 steps:
 - uses: actions/checkout@v4

 - name: Set up Python ${{ matrix.python-version }}
 uses: actions/setup-python@v4
 with:
 python-version: ${{ matrix.python-version }}

 - name: Install packages
 run: |
 pip install --upgrade pip
 pip install pre-commit
 pip list

 - name: Lint
 run: pre-commit run --all-files --show-diff-on-failure --color always

164 changes: 81 additions & 83 deletions
.github/workflows/tests.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,6 @@ on:
 - v1.**

jobs:

 test_pywavelets_linux:
 name: linux-cp${{ matrix.python-version }}-${{ matrix.OPTIONS_NAME }}
 runs-on: ubuntu-latest
Expand All@@ -27,7 +26,7 @@ jobs:
 # Ensure that a wheel builder finishes even if another fails
 fail-fast: false
 matrix:
 python-version: [3.9, '3.10', '3.11', '3.12']
 python-version: [3.9, "3.10", "3.11", "3.12"]
 MINIMUM_REQUIREMENTS: [0]
 USE_SCIPY: [0]
 USE_SDIST: [0]
Expand All@@ -48,7 +47,7 @@ jobs:
 USE_SDIST: 1
 OPTIONS_NAME: "install-from-sdist"
 - platform_id: manylinux_x86_64
 python-version: '3.12'
 python-version: "3.12"
 PIP_FLAGS: "--pre"
 OPTIONS_NAME: "pre-releases"

Expand All@@ -64,32 +63,32 @@ jobs:

 - name: Build package
 env:
VERSION: ${{ matrix.python-version }}
MINIMUM_REQUIREMENTS: ${{ matrix.MINIMUM_REQUIREMENTS }}
PIP_FLAGS: ${{ matrix.PIP_FLAGS }}
USE_SDIST: ${{ matrix.USE_SDIST }}
USE_SCIPY: ${{ matrix.USE_SCIPY }}
REFGUIDE_CHECK: ${{ matrix.REFGUIDE_CHECK }}
 VERSION: ${{ matrix.python-version }}
 MINIMUM_REQUIREMENTS: ${{ matrix.MINIMUM_REQUIREMENTS }}
 PIP_FLAGS: ${{ matrix.PIP_FLAGS }}
 USE_SDIST: ${{ matrix.USE_SDIST }}
 USE_SCIPY: ${{ matrix.USE_SCIPY }}
 REFGUIDE_CHECK: ${{ matrix.REFGUIDE_CHECK }}
 run: |
uname -a
df -h
ulimit -a
# ccache -s
which python
python --version
# sudo apt-get install libatlas-base-dev
pip install --upgrade pip build
# Set numpy version first, other packages link against it
if [ "${MINIMUM_REQUIREMENTS}" == "1" ]; then
pip install ${CYTHON_MIN}
pip install ${NUMPY_MIN}
if [ "${USE_SCIPY}" == "1" ]; then pip install ${SCIPY_MIN}; fi
else
pip install ${PIP_FLAGS} cython
pip install ${PIP_FLAGS} numpy
if [ "${USE_SCIPY}" == "1" ]; then pip install ${PIP_FLAGS} scipy; fi
fi
pip install ${PIP_FLAGS} matplotlib pytest
 uname -a
 df -h
 ulimit -a
 # ccache -s
 which python
 python --version
 # sudo apt-get install libatlas-base-dev
 pip install --upgrade pip build
 # Set numpy version first, other packages link against it
 if [ "${MINIMUM_REQUIREMENTS}" == "1" ]; then
 pip install ${CYTHON_MIN}
 pip install ${NUMPY_MIN}
 if [ "${USE_SCIPY}" == "1" ]; then pip install ${SCIPY_MIN}; fi
 else
 pip install ${PIP_FLAGS} cython
 pip install ${PIP_FLAGS} numpy
 if [ "${USE_SCIPY}" == "1" ]; then pip install ${PIP_FLAGS} scipy; fi
 fi
 pip install ${PIP_FLAGS} matplotlib pytest

 set -o pipefail
 if [ "${USE_SDIST}" == "1" ]; then
Expand All@@ -104,22 +103,21 @@ jobs:

 - name: Run tests
 env:
USE_SDIST: ${{ matrix.USE_SDIST }}
REFGUIDE_CHECK: ${{ matrix.REFGUIDE_CHECK }}
 USE_SDIST: ${{ matrix.USE_SDIST }}
 REFGUIDE_CHECK: ${{ matrix.REFGUIDE_CHECK }}
 run: |
 set -o pipefail
 # Move out of source directory to avoid finding local pywt
 pushd demo
 if [ "${USE_SDIST}" == "1" ]; then
 pytest --pyargs pywt
 python ../pywt/tests/test_doc.py
 elif [ "${REFGUIDE_CHECK}" == "1" ]; then
 python util/refguide_check.py --doctests
 else
 pytest --pyargs pywt
 fi
 popd

 set -o pipefail
 # Move out of source directory to avoid finding local pywt
 pushd demo
 if [ "${USE_SDIST}" == "1" ]; then
 pytest --pyargs pywt
 python ../pywt/tests/test_doc.py
 elif [ "${REFGUIDE_CHECK}" == "1" ]; then
 python util/refguide_check.py --doctests
 else
 pytest --pyargs pywt
 fi
 popd

 test_pywavelets_macos:
 name: macos-cp${{ matrix.python-version }}-${{ matrix.OPTIONS_NAME }}
Expand All@@ -136,18 +134,18 @@ jobs:
 # Ensure that a wheel builder finishes even if another fails
 fail-fast: false
 matrix:
 python-version: [3.9, '3.12']
 python-version: [3.9, "3.12"]
 MINIMUM_REQUIREMENTS: [0]
 USE_SCIPY: [0]
 USE_SDIST: [0]
 REFGUIDE_CHECK: [0]
 PIP_FLAGS: [""]
 OPTIONS_NAME: ["default"]
 include:
 - python-version: '3.9'
 - python-version: "3.9"
 MINIMUM_REQUIREMENTS: 1
 OPTIONS_NAME: "osx-minimum-req"
 - python-version: '3.12'
 - python-version: "3.12"
 PIP_FLAGS: "--pre"
 OPTIONS_NAME: "pre-releases"

Expand All@@ -163,30 +161,30 @@ jobs:

 - name: Build package
 env:
VERSION: ${{ matrix.python-version }}
MINIMUM_REQUIREMENTS: ${{ matrix.MINIMUM_REQUIREMENTS }}
PIP_FLAGS: ${{ matrix.PIP_FLAGS }}
USE_SDIST: ${{ matrix.USE_SDIST }}
USE_SCIPY: ${{ matrix.USE_SCIPY }}
REFGUIDE_CHECK: ${{ matrix.REFGUIDE_CHECK }}
CC: /usr/bin/clang
CXX: /usr/bin/clang++
 VERSION: ${{ matrix.python-version }}
 MINIMUM_REQUIREMENTS: ${{ matrix.MINIMUM_REQUIREMENTS }}
 PIP_FLAGS: ${{ matrix.PIP_FLAGS }}
 USE_SDIST: ${{ matrix.USE_SDIST }}
 USE_SCIPY: ${{ matrix.USE_SCIPY }}
 REFGUIDE_CHECK: ${{ matrix.REFGUIDE_CHECK }}
 CC: /usr/bin/clang
 CXX: /usr/bin/clang++
 run: |
uname -a
df -h
ulimit -a
which python
python --version
pip install --upgrade pip build
# Set numpy version first, other packages link against it
if [ "${MINIMUM_REQUIREMENTS}" == "1" ]; then
pip install ${CYTHON_MIN} ${NUMPY_MIN}
if [ "${USE_SCIPY}" == "1" ]; then pip install ${SCIPY_MIN}; fi
else
pip install ${PIP_FLAGS} cython numpy
if [ "${USE_SCIPY}" == "1" ]; then pip install ${PIP_FLAGS} scipy; fi
fi
pip install ${PIP_FLAGS} matplotlib pytest
 uname -a
 df -h
 ulimit -a
 which python
 python --version
 pip install --upgrade pip build
 # Set numpy version first, other packages link against it
 if [ "${MINIMUM_REQUIREMENTS}" == "1" ]; then
 pip install ${CYTHON_MIN} ${NUMPY_MIN}
 if [ "${USE_SCIPY}" == "1" ]; then pip install ${SCIPY_MIN}; fi
 else
 pip install ${PIP_FLAGS} cython numpy
 if [ "${USE_SCIPY}" == "1" ]; then pip install ${PIP_FLAGS} scipy; fi
 fi
 pip install ${PIP_FLAGS} matplotlib pytest

 set -o pipefail
 if [ "${USE_SDIST}" == "1" ]; then
Expand All@@ -201,18 +199,18 @@ jobs:

 - name: Run tests
 env:
PIP_FLAGS: ${{ matrix.PIP_FLAGS }}
USE_SDIST: ${{ matrix.USE_SDIST }}
REFGUIDE_CHECK: ${{ matrix.REFGUIDE_CHECK }}
 PIP_FLAGS: ${{ matrix.PIP_FLAGS }}
 USE_SDIST: ${{ matrix.USE_SDIST }}
 REFGUIDE_CHECK: ${{ matrix.REFGUIDE_CHECK }}
 run: |
# Move out of source directory to avoid finding local pywt
pushd demo
if [ "${USE_SDIST}" == "1" ]; then
pytest --pyargs pywt
python ../pywt/tests/test_doc.py
elif [ "${REFGUIDE_CHECK}" == "1" ]; then
python util/refguide_check.py --doctests
else
pytest --pyargs pywt
fi
popd
 # Move out of source directory to avoid finding local pywt
 pushd demo
 if [ "${USE_SDIST}" == "1" ]; then
 pytest --pyargs pywt
 python ../pywt/tests/test_doc.py
 elif [ "${REFGUIDE_CHECK}" == "1" ]; then
 python util/refguide_check.py --doctests
 else
 pytest --pyargs pywt
 fi
 popd
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Add linter#687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

rgommers
merged 9 commits into

from

Mar 8, 2024
 Merged


Add linter
#687
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


9 commits


Select commit
Hold shift + click to select a range
058856b

Use ruff pre-commit


jarrodmillman Sep 8, 2023
d531f66

Run flynt


jarrodmillman Sep 14, 2023
bb1d188

Run pre-commit run -a


jarrodmillman Sep 14, 2023
c5279ec

Tell git to ignore linting noise


jarrodmillman Sep 18, 2023
96ad4a8

Add linter to CI


jarrodmillman Sep 14, 2023
a28c6fd

Incorporate cclauss feedback


jarrodmillman Sep 17, 2023
556e9d3

Merge branch 'master' into ruff


rgommers Mar 8, 2024
a8f9792

MAINT: fix new warnings with latest `ruff` version


rgommers Mar 8, 2024
54ddd0d

CI: upgrade ruff to latest (0.3.1) and fix two minor tool nits


rgommers Mar 8, 2024

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 1 addition & 1 deletion
.coveragerc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -10,4 +10,4 @@ omit =
 */pywt/data/create_dat.py
 *.pxd
 stringsource
plugins = Cython.Coverage
plugins = Cython.Coverage

2 changes: 2 additions & 0 deletions
.git-blame-ignore-revs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
# .git-blame-ignore-revs
# Applied codespell to the codebase
5ce73c91800829950474aaa4f4036b2a589a2418
d531f668d60503d55387d7d0ffae4afd199c5f80
bb1d1888fd63381ce35805e0cb3623a8bd47163c

4 changes: 2 additions & 2 deletions
.github/workflows/emscripten.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -27,7 +27,7 @@ jobs:
 id: setup-python
 uses: actions/setup-python@v2
 with:
 python-version: '3.11.2'
 python-version: "3.11.2"

 - name: Install prerequisites
 run: |
Expand All@@ -43,7 +43,7 @@ jobs:
 - name: Set up Node.js
 uses: actions/setup-node@v4.0.2
 with:
 node-version: '18'
 node-version: "18"

 - name: Build PyWavelets
 run: |
Expand Down

31 changes: 31 additions & 0 deletions
.github/workflows/lint.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
name: style

on: [push, pull_request]

concurrency:
 group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
 cancel-in-progress: true

jobs:
 format:
 runs-on: ubuntu-latest
 strategy:
 matrix:
 python-version: ["3.11"]

 steps:
 - uses: actions/checkout@v4

 - name: Set up Python ${{ matrix.python-version }}
 uses: actions/setup-python@v4
 with:
 python-version: ${{ matrix.python-version }}

 - name: Install packages
 run: |
 pip install --upgrade pip
 pip install pre-commit
 pip list

 - name: Lint
 run: pre-commit run --all-files --show-diff-on-failure --color always

164 changes: 81 additions & 83 deletions
.github/workflows/tests.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,6 @@ on:
 - v1.**

jobs:

 test_pywavelets_linux:
 name: linux-cp${{ matrix.python-version }}-${{ matrix.OPTIONS_NAME }}
 runs-on: ubuntu-latest
Expand All@@ -27,7 +26,7 @@ jobs:
 # Ensure that a wheel builder finishes even if another fails
 fail-fast: false
 matrix:
 python-version: [3.9, '3.10', '3.11', '3.12']
 python-version: [3.9, "3.10", "3.11", "3.12"]
 MINIMUM_REQUIREMENTS: [0]
 USE_SCIPY: [0]
 USE_SDIST: [0]
Expand All@@ -48,7 +47,7 @@ jobs:
 USE_SDIST: 1
 OPTIONS_NAME: "install-from-sdist"
 - platform_id: manylinux_x86_64
 python-version: '3.12'
 python-version: "3.12"
 PIP_FLAGS: "--pre"
 OPTIONS_NAME: "pre-releases"

Expand All@@ -64,32 +63,32 @@ jobs:

 - name: Build package
 env:
VERSION: ${{ matrix.python-version }}
MINIMUM_REQUIREMENTS: ${{ matrix.MINIMUM_REQUIREMENTS }}
PIP_FLAGS: ${{ matrix.PIP_FLAGS }}
USE_SDIST: ${{ matrix.USE_SDIST }}
USE_SCIPY: ${{ matrix.USE_SCIPY }}
REFGUIDE_CHECK: ${{ matrix.REFGUIDE_CHECK }}
 VERSION: ${{ matrix.python-version }}
 MINIMUM_REQUIREMENTS: ${{ matrix.MINIMUM_REQUIREMENTS }}
 PIP_FLAGS: ${{ matrix.PIP_FLAGS }}
 USE_SDIST: ${{ matrix.USE_SDIST }}
 USE_SCIPY: ${{ matrix.USE_SCIPY }}
 REFGUIDE_CHECK: ${{ matrix.REFGUIDE_CHECK }}
 run: |
uname -a
df -h
ulimit -a
# ccache -s
which python
python --version
# sudo apt-get install libatlas-base-dev
pip install --upgrade pip build
# Set numpy version first, other packages link against it
if [ "${MINIMUM_REQUIREMENTS}" == "1" ]; then
pip install ${CYTHON_MIN}
pip install ${NUMPY_MIN}
if [ "${USE_SCIPY}" == "1" ]; then pip install ${SCIPY_MIN}; fi
else
pip install ${PIP_FLAGS} cython
pip install ${PIP_FLAGS} numpy
if [ "${USE_SCIPY}" == "1" ]; then pip install ${PIP_FLAGS} scipy; fi
fi
pip install ${PIP_FLAGS} matplotlib pytest
 uname -a
 df -h
 ulimit -a
 # ccache -s
 which python
 python --version
 # sudo apt-get install libatlas-base-dev
 pip install --upgrade pip build
 # Set numpy version first, other packages link against it
 if [ "${MINIMUM_REQUIREMENTS}" == "1" ]; then
 pip install ${CYTHON_MIN}
 pip install ${NUMPY_MIN}
 if [ "${USE_SCIPY}" == "1" ]; then pip install ${SCIPY_MIN}; fi
 else
 pip install ${PIP_FLAGS} cython
 pip install ${PIP_FLAGS} numpy
 if [ "${USE_SCIPY}" == "1" ]; then pip install ${PIP_FLAGS} scipy; fi
 fi
 pip install ${PIP_FLAGS} matplotlib pytest

 set -o pipefail
 if [ "${USE_SDIST}" == "1" ]; then
Expand All@@ -104,22 +103,21 @@ jobs:

 - name: Run tests
 env:
USE_SDIST: ${{ matrix.USE_SDIST }}
REFGUIDE_CHECK: ${{ matrix.REFGUIDE_CHECK }}
 USE_SDIST: ${{ matrix.USE_SDIST }}
 REFGUIDE_CHECK: ${{ matrix.REFGUIDE_CHECK }}
 run: |
 set -o pipefail
 # Move out of source directory to avoid finding local pywt
 pushd demo
 if [ "${USE_SDIST}" == "1" ]; then
 pytest --pyargs pywt
 python ../pywt/tests/test_doc.py
 elif [ "${REFGUIDE_CHECK}" == "1" ]; then
 python util/refguide_check.py --doctests
 else
 pytest --pyargs pywt
 fi
 popd

 set -o pipefail
 # Move out of source directory to avoid finding local pywt
 pushd demo
 if [ "${USE_SDIST}" == "1" ]; then
 pytest --pyargs pywt
 python ../pywt/tests/test_doc.py
 elif [ "${REFGUIDE_CHECK}" == "1" ]; then
 python util/refguide_check.py --doctests
 else
 pytest --pyargs pywt
 fi
 popd

 test_pywavelets_macos:
 name: macos-cp${{ matrix.python-version }}-${{ matrix.OPTIONS_NAME }}
Expand All@@ -136,18 +134,18 @@ jobs:
 # Ensure that a wheel builder finishes even if another fails
 fail-fast: false
 matrix:
 python-version: [3.9, '3.12']
 python-version: [3.9, "3.12"]
 MINIMUM_REQUIREMENTS: [0]
 USE_SCIPY: [0]
 USE_SDIST: [0]
 REFGUIDE_CHECK: [0]
 PIP_FLAGS: [""]
 OPTIONS_NAME: ["default"]
 include:
 - python-version: '3.9'
 - python-version: "3.9"
 MINIMUM_REQUIREMENTS: 1
 OPTIONS_NAME: "osx-minimum-req"
 - python-version: '3.12'
 - python-version: "3.12"
 PIP_FLAGS: "--pre"
 OPTIONS_NAME: "pre-releases"

Expand All@@ -163,30 +161,30 @@ jobs:

 - name: Build package
 env:
VERSION: ${{ matrix.python-version }}
MINIMUM_REQUIREMENTS: ${{ matrix.MINIMUM_REQUIREMENTS }}
PIP_FLAGS: ${{ matrix.PIP_FLAGS }}
USE_SDIST: ${{ matrix.USE_SDIST }}
USE_SCIPY: ${{ matrix.USE_SCIPY }}
REFGUIDE_CHECK: ${{ matrix.REFGUIDE_CHECK }}
CC: /usr/bin/clang
CXX: /usr/bin/clang++
 VERSION: ${{ matrix.python-version }}
 MINIMUM_REQUIREMENTS: ${{ matrix.MINIMUM_REQUIREMENTS }}
 PIP_FLAGS: ${{ matrix.PIP_FLAGS }}
 USE_SDIST: ${{ matrix.USE_SDIST }}
 USE_SCIPY: ${{ matrix.USE_SCIPY }}
 REFGUIDE_CHECK: ${{ matrix.REFGUIDE_CHECK }}
 CC: /usr/bin/clang
 CXX: /usr/bin/clang++
 run: |
uname -a
df -h
ulimit -a
which python
python --version
pip install --upgrade pip build
# Set numpy version first, other packages link against it
if [ "${MINIMUM_REQUIREMENTS}" == "1" ]; then
pip install ${CYTHON_MIN} ${NUMPY_MIN}
if [ "${USE_SCIPY}" == "1" ]; then pip install ${SCIPY_MIN}; fi
else
pip install ${PIP_FLAGS} cython numpy
if [ "${USE_SCIPY}" == "1" ]; then pip install ${PIP_FLAGS} scipy; fi
fi
pip install ${PIP_FLAGS} matplotlib pytest
 uname -a
 df -h
 ulimit -a
 which python
 python --version
 pip install --upgrade pip build
 # Set numpy version first, other packages link against it
 if [ "${MINIMUM_REQUIREMENTS}" == "1" ]; then
 pip install ${CYTHON_MIN} ${NUMPY_MIN}
 if [ "${USE_SCIPY}" == "1" ]; then pip install ${SCIPY_MIN}; fi
 else
 pip install ${PIP_FLAGS} cython numpy
 if [ "${USE_SCIPY}" == "1" ]; then pip install ${PIP_FLAGS} scipy; fi
 fi
 pip install ${PIP_FLAGS} matplotlib pytest

 set -o pipefail
 if [ "${USE_SDIST}" == "1" ]; then
Expand All@@ -201,18 +199,18 @@ jobs:

 - name: Run tests
 env:
PIP_FLAGS: ${{ matrix.PIP_FLAGS }}
USE_SDIST: ${{ matrix.USE_SDIST }}
REFGUIDE_CHECK: ${{ matrix.REFGUIDE_CHECK }}
 PIP_FLAGS: ${{ matrix.PIP_FLAGS }}
 USE_SDIST: ${{ matrix.USE_SDIST }}
 REFGUIDE_CHECK: ${{ matrix.REFGUIDE_CHECK }}
 run: |
# Move out of source directory to avoid finding local pywt
pushd demo
if [ "${USE_SDIST}" == "1" ]; then
pytest --pyargs pywt
python ../pywt/tests/test_doc.py
elif [ "${REFGUIDE_CHECK}" == "1" ]; then
python util/refguide_check.py --doctests
else
pytest --pyargs pywt
fi
popd
 # Move out of source directory to avoid finding local pywt
 pushd demo
 if [ "${USE_SDIST}" == "1" ]; then
 pytest --pyargs pywt
 python ../pywt/tests/test_doc.py
 elif [ "${REFGUIDE_CHECK}" == "1" ]; then
 python util/refguide_check.py --doctests
 else
 pytest --pyargs pywt
 fi
 popd
Loading