Uh oh!
There was an error while loading. Please reload this page.
Added some typing throughout api - #1
Merged
Merged
Conversation
Lash-L
marked this pull request as draft
February 20, 2023 21:01
Lash-L
marked this pull request as ready for review
February 20, 2023 21:30
humbertogontijo
approved these changes
Feb 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am trying to get the custom component into a state that would be approved by Home Assistant as a core integration. Part of that process includes adding typing inside the component, it becomes a bit easier if the underlying api has typing as well. there were some parts I wasn't sure about such as the queue items, and what all data types can be returned from the api, so they are just "Any" for now.
As far as preparing the integration to get it to a good enough state for Home Assistant, I'd love to talk to you about that if you're interested. I've gotten a decent bit of work done. and with your help, we could definitely get it up for review in a week or two.